René's URL Explorer Experiment


Title: fix(compiler-cli): handle default imports in defer blocks by crisbeto · Pull Request #53695 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): handle default imports in defer blocks by crisbeto · Pull Request #53695 · angular/angular

X Title: fix(compiler-cli): handle default imports in defer blocks by crisbeto · Pull Request #53695 · angular/angular

Description: Fixes that @defer blocks weren't recognizing default imports and generating the proper code for them. Default symbols need to be accessed through the default property in the import statement, rather than by their name.

Open Graph Description: Fixes that @defer blocks weren't recognizing default imports and generating the proper code for them. Default symbols need to be accessed through the default property in the import statement, r...

X Description: Fixes that @defer blocks weren't recognizing default imports and generating the proper code for them. Default symbols need to be accessed through the default property in the import statemen...

Opengraph URL: https://github.com/angular/angular/pull/53695

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:df274bbe-63c5-1bdd-eeb8-a0f5809e8ca5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD562:19E4BB:1DA4757:25C9900:6B0162D1
html-safe-nonce11027499e00bb54d8b0024818955a271d289a524ef0e22b8e5845f75450c15a6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTYyOjE5RTRCQjoxREE0NzU3OjI1Qzk5MDA6NkIwMTYyRDEiLCJ2aXNpdG9yX2lkIjoiMTE5NzgzNjc5MjYxOTk1MDgwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac621395255487659a0dc14bf2c9ea0e67c24be0bb9abd8f260984b4dc3a79a7fd
hovercard-subject-tagpull_request:1656447436
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/53695/files
twitter:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
og:image:altFixes that @defer blocks weren't recognizing default imports and generating the proper code for them. Default symbols need to be accessed through the default property in the import statement, r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/53695/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F53695%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F53695%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/53695/files
Reloadhttps://github.com/angular/angular/pull/53695/files
Reloadhttps://github.com/angular/angular/pull/53695/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
crisbeto:defer-default-importhttps://github.com/crisbeto/angular/tree/defer-default-import
Conversation 6 https://github.com/angular/angular/pull/53695
Commits 1 https://github.com/angular/angular/pull/53695/commits
Checks 0 https://github.com/angular/angular/pull/53695/checks
Files changed https://github.com/angular/angular/pull/53695/files
Please reload this pagehttps://github.com/angular/angular/pull/53695/files
fix(compiler-cli): handle default imports in defer blocks https://github.com/angular/angular/pull/53695/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/53695/files
b0d55b2 fix(compiler-cli): handle default imports in defer blocks crisbeto Feb 1, 2024 https://github.com/angular/angular/pull/53695/commits/b0d55b234c38d195c75a26ef9f6d2ea72c511a38
Clear filters https://github.com/angular/angular/pull/53695/files
Please reload this pagehttps://github.com/angular/angular/pull/53695/files
Please reload this pagehttps://github.com/angular/angular/pull/53695/files
handler.ts https://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
metadata.ts https://github.com/angular/angular/pull/53695/files#diff-70aeb751e9ce584cc55acdd6e3cf3f886baf2ae81a6e71c2fcf070eab51f8142
typescript.ts https://github.com/angular/angular/pull/53695/files#diff-f64171de3bc6bd3aca1ecb9a6f9711ee7b5e5e87d8c01bb4759aca4831baa71d
ngtsc_spec.ts https://github.com/angular/angular/pull/53695/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
r3_class_metadata_compiler.ts https://github.com/angular/angular/pull/53695/files#diff-10b068026fa00b736f0b072ab780e2d04decf47c8bcd8f2edb7b3435df580c18
api.ts https://github.com/angular/angular/pull/53695/files#diff-73bd90f92ccea688d3ee38be460e3e8c533a0683beff0ecff22cad8d4d3fa885
compiler.ts https://github.com/angular/angular/pull/53695/files#diff-647cc0586b8318c1805d5c42c57358ba468889567f85c7c381e2c635bdcb1fd6
template.ts https://github.com/angular/angular/pull/53695/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
create_defer_deps_fns.ts https://github.com/angular/angular/pull/53695/files#diff-bf174cb0ee3198499689967f0def30e52ad83a28b1ea4386023f566fbbfebfb1
packages/compiler-cli/src/ngtsc/annotations/component/src/handler.tshttps://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
View file https://github.com/crisbeto/angular/blob/b0d55b234c38d195c75a26ef9f6d2ea72c511a38/packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53695/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
https://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
https://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
https://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
https://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
https://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
https://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
https://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
https://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
https://github.com/angular/angular/pull/53695/files#diff-d31c7054eab6f7fd566cfc0dc6df292a9768ccbcb76475fa2da9bb66797df120
packages/compiler-cli/src/ngtsc/annotations/component/src/metadata.tshttps://github.com/angular/angular/pull/53695/files#diff-70aeb751e9ce584cc55acdd6e3cf3f886baf2ae81a6e71c2fcf070eab51f8142
View file https://github.com/crisbeto/angular/blob/b0d55b234c38d195c75a26ef9f6d2ea72c511a38/packages/compiler-cli/src/ngtsc/annotations/component/src/metadata.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53695/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53695/files#diff-70aeb751e9ce584cc55acdd6e3cf3f886baf2ae81a6e71c2fcf070eab51f8142
https://github.com/angular/angular/pull/53695/files#diff-70aeb751e9ce584cc55acdd6e3cf3f886baf2ae81a6e71c2fcf070eab51f8142
packages/compiler-cli/src/ngtsc/reflection/src/typescript.tshttps://github.com/angular/angular/pull/53695/files#diff-f64171de3bc6bd3aca1ecb9a6f9711ee7b5e5e87d8c01bb4759aca4831baa71d
View file https://github.com/crisbeto/angular/blob/b0d55b234c38d195c75a26ef9f6d2ea72c511a38/packages/compiler-cli/src/ngtsc/reflection/src/typescript.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53695/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53695/files#diff-f64171de3bc6bd3aca1ecb9a6f9711ee7b5e5e87d8c01bb4759aca4831baa71d
crisbetohttps://github.com/crisbeto
Dec 25, 2023https://github.com/angular/angular/pull/53695/files#r1436006933
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/53695/files
https://github.com/angular/angular/pull/53695/files#diff-f64171de3bc6bd3aca1ecb9a6f9711ee7b5e5e87d8c01bb4759aca4831baa71d
packages/compiler-cli/test/ngtsc/ngtsc_spec.tshttps://github.com/angular/angular/pull/53695/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
View file https://github.com/crisbeto/angular/blob/b0d55b234c38d195c75a26ef9f6d2ea72c511a38/packages/compiler-cli/test/ngtsc/ngtsc_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53695/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53695/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
https://github.com/angular/angular/pull/53695/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
https://github.com/angular/angular/pull/53695/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
https://github.com/angular/angular/pull/53695/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
packages/compiler/src/render3/r3_class_metadata_compiler.tshttps://github.com/angular/angular/pull/53695/files#diff-10b068026fa00b736f0b072ab780e2d04decf47c8bcd8f2edb7b3435df580c18
View file https://github.com/crisbeto/angular/blob/b0d55b234c38d195c75a26ef9f6d2ea72c511a38/packages/compiler/src/render3/r3_class_metadata_compiler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53695/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53695/files#diff-10b068026fa00b736f0b072ab780e2d04decf47c8bcd8f2edb7b3435df580c18
https://github.com/angular/angular/pull/53695/files#diff-10b068026fa00b736f0b072ab780e2d04decf47c8bcd8f2edb7b3435df580c18
packages/compiler/src/render3/view/api.tshttps://github.com/angular/angular/pull/53695/files#diff-73bd90f92ccea688d3ee38be460e3e8c533a0683beff0ecff22cad8d4d3fa885
View file https://github.com/crisbeto/angular/blob/b0d55b234c38d195c75a26ef9f6d2ea72c511a38/packages/compiler/src/render3/view/api.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53695/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53695/files#diff-73bd90f92ccea688d3ee38be460e3e8c533a0683beff0ecff22cad8d4d3fa885
https://github.com/angular/angular/pull/53695/files#diff-73bd90f92ccea688d3ee38be460e3e8c533a0683beff0ecff22cad8d4d3fa885
https://github.com/angular/angular/pull/53695/files#diff-73bd90f92ccea688d3ee38be460e3e8c533a0683beff0ecff22cad8d4d3fa885
https://github.com/angular/angular/pull/53695/files#diff-73bd90f92ccea688d3ee38be460e3e8c533a0683beff0ecff22cad8d4d3fa885
packages/compiler/src/render3/view/compiler.tshttps://github.com/angular/angular/pull/53695/files#diff-647cc0586b8318c1805d5c42c57358ba468889567f85c7c381e2c635bdcb1fd6
View file https://github.com/crisbeto/angular/blob/b0d55b234c38d195c75a26ef9f6d2ea72c511a38/packages/compiler/src/render3/view/compiler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53695/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53695/files#diff-647cc0586b8318c1805d5c42c57358ba468889567f85c7c381e2c635bdcb1fd6
https://github.com/angular/angular/pull/53695/files#diff-647cc0586b8318c1805d5c42c57358ba468889567f85c7c381e2c635bdcb1fd6
packages/compiler/src/render3/view/template.tshttps://github.com/angular/angular/pull/53695/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
View file https://github.com/crisbeto/angular/blob/b0d55b234c38d195c75a26ef9f6d2ea72c511a38/packages/compiler/src/render3/view/template.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53695/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53695/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
https://github.com/angular/angular/pull/53695/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
packages/compiler/src/template/pipeline/src/phases/create_defer_deps_fns.tshttps://github.com/angular/angular/pull/53695/files#diff-bf174cb0ee3198499689967f0def30e52ad83a28b1ea4386023f566fbbfebfb1
View file https://github.com/crisbeto/angular/blob/b0d55b234c38d195c75a26ef9f6d2ea72c511a38/packages/compiler/src/template/pipeline/src/phases/create_defer_deps_fns.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53695/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53695/files#diff-bf174cb0ee3198499689967f0def30e52ad83a28b1ea4386023f566fbbfebfb1
https://github.com/angular/angular/pull/53695/files#diff-bf174cb0ee3198499689967f0def30e52ad83a28b1ea4386023f566fbbfebfb1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.