René's URL Explorer Experiment


Title: fix(router): Should not freeze original object used for route data by atscott · Pull Request #53635 · angular/angular · GitHub

Open Graph Title: fix(router): Should not freeze original object used for route data by atscott · Pull Request #53635 · angular/angular

X Title: fix(router): Should not freeze original object used for route data by atscott · Pull Request #53635 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This was broken in 3278966 where the new code fails to copy the data object when not inheriting data. fixes #53632

X Description: This was broken in 3278966 where the new code fails to copy the data object when not inheriting data. fixes #53632

Opengraph URL: https://github.com/angular/angular/pull/53635

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7c503c4c-097d-bcf2-03f1-f9793ff6cb95
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84EC:23CF06:12AFCDE:17F2681:6B011072
html-safe-noncebd56936124b4779bf4c93406ea6cd837ec7c40bfca6e581c0e071454d4a4cb97
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEVDOjIzQ0YwNjoxMkFGQ0RFOjE3RjI2ODE6NkIwMTEwNzIiLCJ2aXNpdG9yX2lkIjoiNzE1NzA1MzMwODIyMDI4MDk0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6bdbb40e98f2b1998752c557580c0c29490ad57eadf63ba5259834d64bae8b11
hovercard-subject-tagpull_request:1650700708
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/53635/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3d39946feb347258ca71a779f01499f19cf70043d1c3122b7faecccc844dc5e4/angular/angular/pull/53635
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3d39946feb347258ca71a779f01499f19cf70043d1c3122b7faecccc844dc5e4/angular/angular/pull/53635
og:image:altThis was broken in 3278966 where the new code fails to copy the data object when not inheriting data. fixes #53632
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatscott
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/53635#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F53635
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F53635
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/53635
Reloadhttps://github.com/angular/angular/pull/53635
Reloadhttps://github.com/angular/angular/pull/53635
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:datafreezehttps://github.com/atscott/angular/tree/datafreeze
Conversationhttps://github.com/angular/angular/pull/53635
Commits1 (1)https://github.com/angular/angular/pull/53635/commits
Checkshttps://github.com/angular/angular/pull/53635/checks
Files changedhttps://github.com/angular/angular/pull/53635/files
fix(router): Should not freeze original object used for route datahttps://github.com/angular/angular/pull/53635#top
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:datafreezehttps://github.com/atscott/angular/tree/datafreeze
https://github.com/atscott
atscotthttps://github.com/atscott
Dec 19, 2023https://github.com/angular/angular/pull/53635#issue-2049022829
3278966https://github.com/angular/angular/commit/327896606832bf6fbfc8f23989755123028136a8
#53632https://github.com/angular/angular/issues/53632
Please reload this pagehttps://github.com/angular/angular/pull/53635
https://github.com/atscott
fix(router): Should not freeze original object used for route datahttps://github.com/angular/angular/pull/53635/commits/ab92fa1a9c2d98c0ba84015e922d83b6d8d258ec
ab92fa1https://github.com/angular/angular/pull/53635/commits/ab92fa1a9c2d98c0ba84015e922d83b6d8d258ec
3278966https://github.com/atscott/angular/commit/327896606832bf6fbfc8f23989755123028136a8
angular#53632https://github.com/angular/angular/issues/53632
https://github.com/atscott
atscotthttps://github.com/atscott
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Dec 19, 2023https://github.com/angular/angular/pull/53635#event-11292139622
https://github.com/atscott
atscotthttps://github.com/atscott
AndrewKushnirhttps://github.com/AndrewKushnir
December 19, 2023 16:34https://github.com/angular/angular/pull/53635#event-11292140421
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Dec 19, 2023https://github.com/angular/angular/pull/53635#event-11292140573
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Dec 19, 2023 https://github.com/angular/angular/pull/53635#pullrequestreview-1789293728
View reviewed changes https://github.com/angular/angular/pull/53635/files/ab92fa1a9c2d98c0ba84015e922d83b6d8d258ec
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Dec 19, 2023https://github.com/angular/angular/pull/53635#event-11292198060
https://github.com/atscott
atscotthttps://github.com/atscott
AndrewKushnirhttps://github.com/AndrewKushnir
December 19, 2023 17:19https://github.com/angular/angular/pull/53635#event-11292656426
https://github.com/atscott
atscotthttps://github.com/atscott
Dec 19, 2023https://github.com/angular/angular/pull/53635#issuecomment-1863190205
502f300https://github.com/angular/angular/commit/502f3007575a5445c2876c92548415cb003582b1
Please reload this pagehttps://github.com/angular/angular/pull/53635
https://github.com/atscott
atscotthttps://github.com/atscott
502f300https://github.com/angular/angular/commit/502f3007575a5445c2876c92548415cb003582b1
Dec 19, 2023https://github.com/angular/angular/pull/53635#event-11292668247
atscotthttps://github.com/atscott
Dec 19, 2023 https://github.com/angular/angular/pull/53635#ref-commit-0696ab6
https://github.com/atscott
fix(router): Should not freeze original object used for route data (https://github.com/angular/angular/commit/0696ab6a5bea8acd6dafde488151150bf3332b79
#…https://github.com/angular/angular/pull/53635
0696ab6https://github.com/angular/angular/commit/0696ab6a5bea8acd6dafde488151150bf3332b79
…53635https://github.com/angular/angular/pull/53635
3278966https://github.com/angular/angular/commit/327896606832bf6fbfc8f23989755123028136a8
#53632https://github.com/angular/angular/issues/53632
#53635https://github.com/angular/angular/pull/53635
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 19, 2024https://github.com/angular/angular/pull/53635#issuecomment-1899416022
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/53635
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 19, 2024https://github.com/angular/angular/pull/53635#event-11531328780
ChellappanRajanhttps://github.com/ChellappanRajan
Jan 23, 2024 https://github.com/angular/angular/pull/53635#ref-commit-25e96ab
https://github.com/atscott
https://github.com/ChellappanRajan
fix(router): Should not freeze original object used for route data (https://github.com/ChellappanRajan/angular/commit/25e96ab3e2f7743281dea2133ab942a18b7108ac
a…https://github.com/angular/angular/pull/53635
25e96abhttps://github.com/ChellappanRajan/angular/commit/25e96ab3e2f7743281dea2133ab942a18b7108ac
…ngular#53635https://github.com/angular/angular/pull/53635
3278966https://github.com/ChellappanRajan/angular/commit/327896606832bf6fbfc8f23989755123028136a8
angular#53632https://github.com/angular/angular/issues/53632
angular#53635https://github.com/angular/angular/pull/53635
rlmestrehttps://github.com/rlmestre
Jan 26, 2024 https://github.com/angular/angular/pull/53635#ref-commit-ff029a8
https://github.com/atscott
https://github.com/rlmestre
fix(router): Should not freeze original object used for route data (https://github.com/rlmestre/angular/commit/ff029a8d809c7811f6d0fc5a903976efffa7b13c
a…https://github.com/angular/angular/pull/53635
ff029a8https://github.com/rlmestre/angular/commit/ff029a8d809c7811f6d0fc5a903976efffa7b13c
…ngular#53635https://github.com/angular/angular/pull/53635
3278966https://github.com/rlmestre/angular/commit/327896606832bf6fbfc8f23989755123028136a8
angular#53632https://github.com/angular/angular/issues/53632
angular#53635https://github.com/angular/angular/pull/53635
amilamenhttps://github.com/amilamen
Jan 26, 2024 https://github.com/angular/angular/pull/53635#ref-commit-99f6c9f
https://github.com/atscott
https://github.com/amilamen
fix(router): Should not freeze original object used for route data (https://github.com/amilamen/angular/commit/99f6c9f937a0bf9de03187395929c13c4b5292e7
a…https://github.com/angular/angular/pull/53635
99f6c9fhttps://github.com/amilamen/angular/commit/99f6c9f937a0bf9de03187395929c13c4b5292e7
…ngular#53635https://github.com/angular/angular/pull/53635
3278966https://github.com/amilamen/angular/commit/327896606832bf6fbfc8f23989755123028136a8
angular#53632https://github.com/angular/angular/issues/53632
angular#53635https://github.com/angular/angular/pull/53635
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F53635
https://github.com/crisbeto
crisbeto https://github.com/crisbeto
https://github.com/angular/angular/pull/53635/files/ab92fa1a9c2d98c0ba84015e922d83b6d8d258ec
Please reload this pagehttps://github.com/angular/angular/pull/53635
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Backlog https://github.com/angular/angular/milestone/82
Object set as readonly when passed as a route data https://github.com/angular/angular/issues/53632
Please reload this pagehttps://github.com/angular/angular/pull/53635
https://github.com/atscott
https://github.com/crisbeto
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.