René's URL Explorer Experiment


Title: fix(compiler-cli): add compiler option to disable control flow content projection diagnostic by crisbeto · Pull Request #53311 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): add compiler option to disable control flow content projection diagnostic by crisbeto · Pull Request #53311 · angular/angular

X Title: fix(compiler-cli): add compiler option to disable control flow content projection diagnostic by crisbeto · Pull Request #53311 · angular/angular

Description: These changes add an option to the extendedDiagnostics field that allows the check from #53190 to be disabled. This is a follow-up based on a recent discussion.

Open Graph Description: These changes add an option to the extendedDiagnostics field that allows the check from #53190 to be disabled. This is a follow-up based on a recent discussion.

X Description: These changes add an option to the extendedDiagnostics field that allows the check from #53190 to be disabled. This is a follow-up based on a recent discussion.

Opengraph URL: https://github.com/angular/angular/pull/53311

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:73c658e3-f294-4d7c-9d13-4eccb0ccba39
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB7B0:2AAD2E:1E31561:28404AF:6B017404
html-safe-nonce693ee05ac6b0380f0ed28a8d7f895409b58b3fe7f3462c3695b27e8db8401d30
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0IwOjJBQUQyRToxRTMxNTYxOjI4NDA0QUY6NkIwMTc0MDQiLCJ2aXNpdG9yX2lkIjoiODg3ODY3NTg1NTI4NDI3NTI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4a6a28caab593dab6513ab25a0948b60a577f9225e8987007d6d4d3d84767f43
hovercard-subject-tagpull_request:1625609725
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/53311/files
twitter:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
og:image:altThese changes add an option to the extendedDiagnostics field that allows the check from #53190 to be disabled. This is a follow-up based on a recent discussion.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/53311/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F53311%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F53311%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/53311/files
Reloadhttps://github.com/angular/angular/pull/53311/files
Reloadhttps://github.com/angular/angular/pull/53311/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
crisbeto:disable-control-flow-diaghttps://github.com/crisbeto/angular/tree/disable-control-flow-diag
Conversation 5 https://github.com/angular/angular/pull/53311
Commits 1 https://github.com/angular/angular/pull/53311/commits
Checks 0 https://github.com/angular/angular/pull/53311/checks
Files changed https://github.com/angular/angular/pull/53311/files
Please reload this pagehttps://github.com/angular/angular/pull/53311/files
fix(compiler-cli): add compiler option to disable control flow content projection diagnostic https://github.com/angular/angular/pull/53311/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/53311/files
86b5618 fix(compiler-cli): add compiler option to disable control flow conten… crisbeto Dec 1, 2023 https://github.com/angular/angular/pull/53311/commits/86b561807e779dcdd70ed9eacd0d2186b99879d5
Clear filters https://github.com/angular/angular/pull/53311/files
Please reload this pagehttps://github.com/angular/angular/pull/53311/files
Please reload this pagehttps://github.com/angular/angular/pull/53311/files
extended_template_diagnostic_name.md https://github.com/angular/angular/pull/53311/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
compiler.ts https://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
extended_template_diagnostic_name.ts https://github.com/angular/angular/pull/53311/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
api.ts https://github.com/angular/angular/pull/53311/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc
index.ts https://github.com/angular/angular/pull/53311/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
oob.ts https://github.com/angular/angular/pull/53311/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
type_check_block.ts https://github.com/angular/angular/pull/53311/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
type_check_block_spec.ts https://github.com/angular/angular/pull/53311/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
index.ts https://github.com/angular/angular/pull/53311/files#diff-49fe94d4a7d4e7db381db4e750af7e031e9f33f09b3b89e29ab1f3fe7fa77546
template_typecheck_spec.ts https://github.com/angular/angular/pull/53311/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
goldens/public-api/compiler-cli/extended_template_diagnostic_name.mdhttps://github.com/angular/angular/pull/53311/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
View file https://github.com/crisbeto/angular/blob/86b561807e779dcdd70ed9eacd0d2186b99879d5/goldens/public-api/compiler-cli/extended_template_diagnostic_name.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53311/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
https://github.com/angular/angular/pull/53311/files#diff-a55d694fb92187ba73d0b15e013baa1eb015ff2b629537f5949a6044dfea18a2
packages/compiler-cli/src/ngtsc/core/src/compiler.tshttps://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
View file https://github.com/crisbeto/angular/blob/86b561807e779dcdd70ed9eacd0d2186b99879d5/packages/compiler-cli/src/ngtsc/core/src/compiler.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
https://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
https://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
https://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
https://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
https://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
https://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
https://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
https://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
https://github.com/angular/angular/pull/53311/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.tshttps://github.com/angular/angular/pull/53311/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
View file https://github.com/crisbeto/angular/blob/86b561807e779dcdd70ed9eacd0d2186b99879d5/packages/compiler-cli/src/ngtsc/diagnostics/src/extended_template_diagnostic_name.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53311/files#diff-cacd63f5201299a5f8b8929a4b644ee5a621a63e38c41519a9333a8daf7badce
packages/compiler-cli/src/ngtsc/typecheck/api/api.tshttps://github.com/angular/angular/pull/53311/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc
View file https://github.com/crisbeto/angular/blob/86b561807e779dcdd70ed9eacd0d2186b99879d5/packages/compiler-cli/src/ngtsc/typecheck/api/api.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53311/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc
https://github.com/angular/angular/pull/53311/files#diff-686f1a8f46b295012072acaea9d3f167750e581eed42cafac52d4ef4351d18dc
packages/compiler-cli/src/ngtsc/typecheck/extended/index.tshttps://github.com/angular/angular/pull/53311/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
View file https://github.com/crisbeto/angular/blob/86b561807e779dcdd70ed9eacd0d2186b99879d5/packages/compiler-cli/src/ngtsc/typecheck/extended/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53311/files#diff-72aff941980ce77d2b52e9f84cfbf90bd01e0f62eda953a1a96fc494659135c6
crisbetohttps://github.com/crisbeto
Dec 1, 2023https://github.com/angular/angular/pull/53311/files#r1412052111
Please reload this pagehttps://github.com/angular/angular/pull/53311/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
have a branchhttps://github.com/angular/angular/compare/main...crisbeto:angular:control-flow-diag?expand=1
Please reload this pagehttps://github.com/angular/angular/pull/53311/files
packages/compiler-cli/src/ngtsc/typecheck/src/oob.tshttps://github.com/angular/angular/pull/53311/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
View file https://github.com/crisbeto/angular/blob/86b561807e779dcdd70ed9eacd0d2186b99879d5/packages/compiler-cli/src/ngtsc/typecheck/src/oob.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53311/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
https://github.com/angular/angular/pull/53311/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
https://github.com/angular/angular/pull/53311/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
https://github.com/angular/angular/pull/53311/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
https://github.com/angular/angular/pull/53311/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.tshttps://github.com/angular/angular/pull/53311/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
View file https://github.com/crisbeto/angular/blob/86b561807e779dcdd70ed9eacd0d2186b99879d5/packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53311/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
https://github.com/angular/angular/pull/53311/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
https://github.com/angular/angular/pull/53311/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
https://github.com/angular/angular/pull/53311/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
https://github.com/angular/angular/pull/53311/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
packages/compiler-cli/src/ngtsc/typecheck/test/type_check_block_spec.tshttps://github.com/angular/angular/pull/53311/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
View file https://github.com/crisbeto/angular/blob/86b561807e779dcdd70ed9eacd0d2186b99879d5/packages/compiler-cli/src/ngtsc/typecheck/test/type_check_block_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53311/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
https://github.com/angular/angular/pull/53311/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
packages/compiler-cli/src/ngtsc/typecheck/testing/index.tshttps://github.com/angular/angular/pull/53311/files#diff-49fe94d4a7d4e7db381db4e750af7e031e9f33f09b3b89e29ab1f3fe7fa77546
View file https://github.com/crisbeto/angular/blob/86b561807e779dcdd70ed9eacd0d2186b99879d5/packages/compiler-cli/src/ngtsc/typecheck/testing/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53311/files#diff-49fe94d4a7d4e7db381db4e750af7e031e9f33f09b3b89e29ab1f3fe7fa77546
https://github.com/angular/angular/pull/53311/files#diff-49fe94d4a7d4e7db381db4e750af7e031e9f33f09b3b89e29ab1f3fe7fa77546
https://github.com/angular/angular/pull/53311/files#diff-49fe94d4a7d4e7db381db4e750af7e031e9f33f09b3b89e29ab1f3fe7fa77546
https://github.com/angular/angular/pull/53311/files#diff-49fe94d4a7d4e7db381db4e750af7e031e9f33f09b3b89e29ab1f3fe7fa77546
packages/compiler-cli/test/ngtsc/template_typecheck_spec.tshttps://github.com/angular/angular/pull/53311/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
View file https://github.com/crisbeto/angular/blob/86b561807e779dcdd70ed9eacd0d2186b99879d5/packages/compiler-cli/test/ngtsc/template_typecheck_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/53311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/53311/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.