René's URL Explorer Experiment


Title: fix(core): avoid stale provider info when TestBed.overrideProvider is used by AndrewKushnir · Pull Request #52918 · angular/angular · GitHub

Open Graph Title: fix(core): avoid stale provider info when TestBed.overrideProvider is used by AndrewKushnir · Pull Request #52918 · angular/angular

X Title: fix(core): avoid stale provider info when TestBed.overrideProvider is used by AndrewKushnir · Pull Request #52918 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This commit updates the logic to preserve previous value of cached TView before applying overrides. This helps ensure that the next tests that uses the same component has correct provider info. PR ...

X Description: This commit updates the logic to preserve previous value of cached TView before applying overrides. This helps ensure that the next tests that uses the same component has correct provider info. PR ...

Opengraph URL: https://github.com/angular/angular/pull/52918

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:976a3d4b-d89e-111b-8126-6f4cc3ea91c6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8834:1F2F:184A77C:204AF9E:6B01FB73
html-safe-nonceebfd93c0fd614f0ef2bf73e357ac6c73db7b2397fb8e42a65f0089e880b92a51
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODM0OjFGMkY6MTg0QTc3QzoyMDRBRjlFOjZCMDFGQjczIiwidmlzaXRvcl9pZCI6IjU0MTAyMzE0OTk4MTM0MTk4OTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac605717e03b7c0bd6277baee67b16af623f2cc3d50e16f5c7866145b624eb5098
hovercard-subject-tagpull_request:1601719104
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/52918/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dd8f95e95569b61ee4ad924879341cb37b1b7d114a04d76122daf74f4805cac7/angular/angular/pull/52918
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dd8f95e95569b61ee4ad924879341cb37b1b7d114a04d76122daf74f4805cac7/angular/angular/pull/52918
og:image:altThis commit updates the logic to preserve previous value of cached TView before applying overrides. This helps ensure that the next tests that uses the same component has correct provider info. PR ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndrewKushnir
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/52918#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52918
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52918
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/52918
Reloadhttps://github.com/angular/angular/pull/52918
Reloadhttps://github.com/angular/angular/pull/52918
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
AndrewKushnirhttps://github.com/AndrewKushnir
angular:mainhttps://github.com/angular/angular/tree/main
AndrewKushnir:fix_provider_overrideshttps://github.com/AndrewKushnir/angular/tree/fix_provider_overrides
Conversationhttps://github.com/angular/angular/pull/52918
Commits1 (1)https://github.com/angular/angular/pull/52918/commits
Checkshttps://github.com/angular/angular/pull/52918/checks
Files changedhttps://github.com/angular/angular/pull/52918/files
fix(core): avoid stale provider info when TestBed.overrideProvider is usedhttps://github.com/angular/angular/pull/52918#top
AndrewKushnirhttps://github.com/AndrewKushnir
angular:mainhttps://github.com/angular/angular/tree/main
AndrewKushnir:fix_provider_overrideshttps://github.com/AndrewKushnir/angular/tree/fix_provider_overrides
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 15, 2023https://github.com/angular/angular/pull/52918#issue-1993849272
Please reload this pagehttps://github.com/angular/angular/pull/52918
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
area: testing https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Nov 15, 2023https://github.com/angular/angular/pull/52918#event-10961793818
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
atscotthttps://github.com/atscott
November 15, 2023 01:21https://github.com/angular/angular/pull/52918#event-10961793843
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Nov 15, 2023https://github.com/angular/angular/pull/52918#event-10961794149
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 15, 2023 https://github.com/angular/angular/pull/52918#ref-issue-1988951642
Regression TestBed.overrideComponent in Angular 17 #52817 https://github.com/angular/angular/issues/52817
https://github.com/atscott
atscotthttps://github.com/atscott
Nov 21, 2023 https://github.com/angular/angular/pull/52918#pullrequestreview-1742980262
View reviewed changes https://github.com/angular/angular/pull/52918/files/88d75f552a70fe7850345702515821b476ff927e
https://github.com/AndrewKushnir
fix(core): avoid stale provider info when TestBed.overrideProvider is…https://github.com/angular/angular/pull/52918/commits/88d75f552a70fe7850345702515821b476ff927e
88d75f5https://github.com/angular/angular/pull/52918/commits/88d75f552a70fe7850345702515821b476ff927e
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
force-pushedhttps://github.com/angular/angular/compare/07c04316b8abd115a349f7643332138e0b7699b2..88d75f552a70fe7850345702515821b476ff927e
07c0431https://github.com/angular/angular/commit/07c04316b8abd115a349f7643332138e0b7699b2
88d75f5https://github.com/angular/angular/commit/88d75f552a70fe7850345702515821b476ff927e
Compare https://github.com/angular/angular/compare/07c04316b8abd115a349f7643332138e0b7699b2..88d75f552a70fe7850345702515821b476ff927e
November 28, 2023 01:54https://github.com/angular/angular/pull/52918#event-11077863491
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Nov 28, 2023https://github.com/angular/angular/pull/52918#event-11077868677
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 28, 2023https://github.com/angular/angular/pull/52918#issuecomment-1828938162
Passing TGPhttps://fusion2.corp.google.com/presubmit/582489483/OCL:582489483:BASE:584472540:1700617216210:8df06140
Please reload this pagehttps://github.com/angular/angular/pull/52918
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Nov 28, 2023https://github.com/angular/angular/pull/52918#event-11086625359
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Nov 29, 2023https://github.com/angular/angular/pull/52918#issuecomment-1831463352
58cf389https://github.com/angular/angular/commit/58cf389d8095dd522a998b6b9a7d7b8da1656644
Please reload this pagehttps://github.com/angular/angular/pull/52918
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Nov 29, 2023 https://github.com/angular/angular/pull/52918#ref-commit-6be8804
https://github.com/AndrewKushnir
https://github.com/pkozlowski-opensource
fix(core): avoid stale provider info when TestBed.overrideProvider is…https://github.com/angular/angular/commit/6be88040d134b8c8d7efd2068296f68b8b7efbdd
6be8804https://github.com/angular/angular/commit/6be88040d134b8c8d7efd2068296f68b8b7efbdd
#52918https://github.com/angular/angular/pull/52918
#52918https://github.com/angular/angular/pull/52918
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
58cf389https://github.com/angular/angular/commit/58cf389d8095dd522a998b6b9a7d7b8da1656644
Nov 29, 2023https://github.com/angular/angular/pull/52918#event-11093303483
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 30, 2023https://github.com/angular/angular/pull/52918#issuecomment-1872399221
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/52918
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 30, 2023https://github.com/angular/angular/pull/52918#event-11359059951
ChellappanRajanhttps://github.com/ChellappanRajan
Jan 23, 2024 https://github.com/angular/angular/pull/52918#ref-commit-d9fb645
https://github.com/AndrewKushnir
https://github.com/ChellappanRajan
fix(core): avoid stale provider info when TestBed.overrideProvider is…https://github.com/ChellappanRajan/angular/commit/d9fb64523af9061ed6bce1c6a7db48caf6cc1fcf
d9fb645https://github.com/ChellappanRajan/angular/commit/d9fb64523af9061ed6bce1c6a7db48caf6cc1fcf
angular#52918https://github.com/angular/angular/pull/52918
angular#52918https://github.com/angular/angular/pull/52918
rlmestrehttps://github.com/rlmestre
Jan 26, 2024 https://github.com/angular/angular/pull/52918#ref-commit-9b55efd
https://github.com/AndrewKushnir
https://github.com/rlmestre
fix(core): avoid stale provider info when TestBed.overrideProvider is…https://github.com/rlmestre/angular/commit/9b55efd176c4919ce9d0ec4cdd42dbda94e7eb5d
9b55efdhttps://github.com/rlmestre/angular/commit/9b55efd176c4919ce9d0ec4cdd42dbda94e7eb5d
angular#52918https://github.com/angular/angular/pull/52918
angular#52918https://github.com/angular/angular/pull/52918
amilamenhttps://github.com/amilamen
Jan 26, 2024 https://github.com/angular/angular/pull/52918#ref-commit-2a26b1a
https://github.com/AndrewKushnir
https://github.com/amilamen
fix(core): avoid stale provider info when TestBed.overrideProvider is…https://github.com/amilamen/angular/commit/2a26b1a5cbb9b27d9007b447a1c17fa381b0dbf4
2a26b1ahttps://github.com/amilamen/angular/commit/2a26b1a5cbb9b27d9007b447a1c17fa381b0dbf4
angular#52918https://github.com/angular/angular/pull/52918
angular#52918https://github.com/angular/angular/pull/52918
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52918
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/52918/files/88d75f552a70fe7850345702515821b476ff927e
Please reload this pagehttps://github.com/angular/angular/pull/52918
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
area: testing https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/52918
https://github.com/AndrewKushnir
https://github.com/pkozlowski-opensource
https://github.com/atscott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.