René's URL Explorer Experiment


Title: fix(compiler): ng-template directive invoke twice at the root of control flow by crisbeto · Pull Request #52515 · angular/angular · GitHub

Open Graph Title: fix(compiler): ng-template directive invoke twice at the root of control flow by crisbeto · Pull Request #52515 · angular/angular

X Title: fix(compiler): ng-template directive invoke twice at the root of control flow by crisbeto · Pull Request #52515 · angular/angular

Description: Discovered this while validating #52414 against Angular Material. We were projecting nodes at the root of @if and @for with the ng-template tag name which enables directive matching and applies the directive to the control flow node. These changes fix the issue by never passing along the ng-template tag name.

Open Graph Description: Discovered this while validating #52414 against Angular Material. We were projecting <ng-template> nodes at the root of @if and @for with the ng-template tag name which enables directive matc...

X Description: Discovered this while validating #52414 against Angular Material. We were projecting &lt;ng-template&gt; nodes at the root of @if and @for with the ng-template tag name which enables direct...

Opengraph URL: https://github.com/angular/angular/pull/52515

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:338a42b1-6c42-aed5-c61d-2dd1b1874bb7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9850:240CD1:144A39F:19D1DE2:6B012AE0
html-safe-noncea798128f4b064ee48b8f12320ad55c7dca8b533ee261fc2168bd7b15e5c7d4eb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODUwOjI0MENEMToxNDRBMzlGOjE5RDFERTI6NkIwMTJBRTAiLCJ2aXNpdG9yX2lkIjoiNTcwMjIxMjAyMjM2NDYxMzM0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0b4597c588b1f85c3682fe39d76f869fa4db2fa911c689c57e05ed9a3bb03963
hovercard-subject-tagpull_request:1587344361
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/52515/files
twitter:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
og:image:altDiscovered this while validating #52414 against Angular Material. We were projecting <ng-template> nodes at the root of @if and @for with the ng-template tag name which enables directive matc...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/52515/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52515%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52515%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/52515/files
Reloadhttps://github.com/angular/angular/pull/52515/files
Reloadhttps://github.com/angular/angular/pull/52515/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
crisbeto:control-flow-projection-templatehttps://github.com/crisbeto/angular/tree/control-flow-projection-template
Conversation 3 https://github.com/angular/angular/pull/52515
Commits 1 https://github.com/angular/angular/pull/52515/commits
Checks 0 https://github.com/angular/angular/pull/52515/checks
Files changed https://github.com/angular/angular/pull/52515/files
Please reload this pagehttps://github.com/angular/angular/pull/52515/files
fix(compiler): ng-template directive invoke twice at the root of control flow https://github.com/angular/angular/pull/52515/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/52515/files
d63528f fix(compiler): ng-template directive invoke twice at the root of cont… crisbeto Nov 5, 2023 https://github.com/angular/angular/pull/52515/commits/d63528f86d868276b47eda60a91afcf88187d7a6
Clear filters https://github.com/angular/angular/pull/52515/files
Please reload this pagehttps://github.com/angular/angular/pull/52515/files
Please reload this pagehttps://github.com/angular/angular/pull/52515/files
GOLDEN_PARTIAL.js https://github.com/angular/angular/pull/52515/files#diff-796382fe2cafbd370b695008ffda845878cb671bad5cc8221f2113952e25f332
TEST_CASES.json https://github.com/angular/angular/pull/52515/files#diff-12f2435fdb9ce7d957d8b863f3f4bf182f9c04bf829ea178c54de212463ee12a
for_template_root_node.ts https://github.com/angular/angular/pull/52515/files#diff-f4eb03bccb709addd28de14a747201dcbe2f76e69ea66f985827727ec26d945b
for_template_root_node_template.js https://github.com/angular/angular/pull/52515/files#diff-bd928613ee5ba0e80a4ee40adef5fbbc9e02d6a90111ff0f5daf5c36d986b073
if_template_root_node.ts https://github.com/angular/angular/pull/52515/files#diff-5dc56a850b48b4bfd063096fd99ea746dbbe2581c8591c1c83c641c6ca3225fc
if_template_root_node_template.js https://github.com/angular/angular/pull/52515/files#diff-f1cec2013696a6ad0ac9eff3e61791191e59c75ce18f6dd5fc9e17569991ee8b
template.ts https://github.com/angular/angular/pull/52515/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
ingest.ts https://github.com/angular/angular/pull/52515/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
control_flow_for_spec.ts https://github.com/angular/angular/pull/52515/files#diff-db8880ae6b925a9c0ffc5019fbe3c04672d470273d9d94cd18d12d8e8dc0ab59
control_flow_if_spec.ts https://github.com/angular/angular/pull/52515/files#diff-22fa4e49efd60e312463a320df397a2d58830aa4c59a1da32f1f5b72e0a94c7e
...s/compiler-cli/test/compliance/test_cases/r3_view_compiler_control_flow/GOLDEN_PARTIAL.jshttps://github.com/angular/angular/pull/52515/files#diff-796382fe2cafbd370b695008ffda845878cb671bad5cc8221f2113952e25f332
View file https://github.com/crisbeto/angular/blob/d63528f86d868276b47eda60a91afcf88187d7a6/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_control_flow/GOLDEN_PARTIAL.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52515/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52515/files#diff-796382fe2cafbd370b695008ffda845878cb671bad5cc8221f2113952e25f332
https://github.com/angular/angular/pull/52515/files#diff-796382fe2cafbd370b695008ffda845878cb671bad5cc8221f2113952e25f332
https://github.com/angular/angular/pull/52515/files#diff-796382fe2cafbd370b695008ffda845878cb671bad5cc8221f2113952e25f332
...ges/compiler-cli/test/compliance/test_cases/r3_view_compiler_control_flow/TEST_CASES.jsonhttps://github.com/angular/angular/pull/52515/files#diff-12f2435fdb9ce7d957d8b863f3f4bf182f9c04bf829ea178c54de212463ee12a
View file https://github.com/crisbeto/angular/blob/d63528f86d868276b47eda60a91afcf88187d7a6/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_control_flow/TEST_CASES.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52515/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52515/files#diff-12f2435fdb9ce7d957d8b863f3f4bf182f9c04bf829ea178c54de212463ee12a
https://github.com/angular/angular/pull/52515/files#diff-12f2435fdb9ce7d957d8b863f3f4bf182f9c04bf829ea178c54de212463ee12a
...er-cli/test/compliance/test_cases/r3_view_compiler_control_flow/for_template_root_node.tshttps://github.com/angular/angular/pull/52515/files#diff-f4eb03bccb709addd28de14a747201dcbe2f76e69ea66f985827727ec26d945b
View file https://github.com/crisbeto/angular/blob/d63528f86d868276b47eda60a91afcf88187d7a6/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_control_flow/for_template_root_node.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52515/{{ revealButtonHref }}
...st/compliance/test_cases/r3_view_compiler_control_flow/for_template_root_node_template.jshttps://github.com/angular/angular/pull/52515/files#diff-bd928613ee5ba0e80a4ee40adef5fbbc9e02d6a90111ff0f5daf5c36d986b073
View file https://github.com/crisbeto/angular/blob/d63528f86d868276b47eda60a91afcf88187d7a6/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_control_flow/for_template_root_node_template.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52515/{{ revealButtonHref }}
...ler-cli/test/compliance/test_cases/r3_view_compiler_control_flow/if_template_root_node.tshttps://github.com/angular/angular/pull/52515/files#diff-5dc56a850b48b4bfd063096fd99ea746dbbe2581c8591c1c83c641c6ca3225fc
View file https://github.com/crisbeto/angular/blob/d63528f86d868276b47eda60a91afcf88187d7a6/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_control_flow/if_template_root_node.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52515/{{ revealButtonHref }}
...est/compliance/test_cases/r3_view_compiler_control_flow/if_template_root_node_template.jshttps://github.com/angular/angular/pull/52515/files#diff-f1cec2013696a6ad0ac9eff3e61791191e59c75ce18f6dd5fc9e17569991ee8b
View file https://github.com/crisbeto/angular/blob/d63528f86d868276b47eda60a91afcf88187d7a6/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_control_flow/if_template_root_node_template.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52515/{{ revealButtonHref }}
packages/compiler/src/render3/view/template.tshttps://github.com/angular/angular/pull/52515/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
View file https://github.com/crisbeto/angular/blob/d63528f86d868276b47eda60a91afcf88187d7a6/packages/compiler/src/render3/view/template.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52515/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52515/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
https://github.com/angular/angular/pull/52515/files#diff-0d3035937352a0ed7d0bf6597e98807e6ae6dc132ccf95fd9503dffdad4319cb
packages/compiler/src/template/pipeline/src/ingest.tshttps://github.com/angular/angular/pull/52515/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
View file https://github.com/crisbeto/angular/blob/d63528f86d868276b47eda60a91afcf88187d7a6/packages/compiler/src/template/pipeline/src/ingest.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52515/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52515/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
https://github.com/angular/angular/pull/52515/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
packages/core/test/acceptance/control_flow_for_spec.tshttps://github.com/angular/angular/pull/52515/files#diff-db8880ae6b925a9c0ffc5019fbe3c04672d470273d9d94cd18d12d8e8dc0ab59
View file https://github.com/crisbeto/angular/blob/d63528f86d868276b47eda60a91afcf88187d7a6/packages/core/test/acceptance/control_flow_for_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52515/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52515/files#diff-db8880ae6b925a9c0ffc5019fbe3c04672d470273d9d94cd18d12d8e8dc0ab59
packages/core/test/acceptance/control_flow_if_spec.tshttps://github.com/angular/angular/pull/52515/files#diff-22fa4e49efd60e312463a320df397a2d58830aa4c59a1da32f1f5b72e0a94c7e
View file https://github.com/crisbeto/angular/blob/d63528f86d868276b47eda60a91afcf88187d7a6/packages/core/test/acceptance/control_flow_if_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52515/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52515/files#diff-22fa4e49efd60e312463a320df397a2d58830aa4c59a1da32f1f5b72e0a94c7e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.