René's URL Explorer Experiment


Title: fix(compiler): template type checking not reporting diagnostics for incompatible type comparisons by crisbeto · Pull Request #52322 · angular/angular · GitHub

Open Graph Title: fix(compiler): template type checking not reporting diagnostics for incompatible type comparisons by crisbeto · Pull Request #52322 · angular/angular

X Title: fix(compiler): template type checking not reporting diagnostics for incompatible type comparisons by crisbeto · Pull Request #52322 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: In #52110 the compiler was changed to produce if statements when type checking @switch in order to avoid a bug in the TypeScript compiler. In order to avoid duplicate diagnostics, the main @switch ...

X Description: In #52110 the compiler was changed to produce if statements when type checking @switch in order to avoid a bug in the TypeScript compiler. In order to avoid duplicate diagnostics, the main @switch ...

Opengraph URL: https://github.com/angular/angular/pull/52322

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1bffed98-a718-dd8a-3d4e-fc16643238f1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id81F8:DB09F:D0C01C:10B4CE0:6B01051A
html-safe-nonce4e734b5e37ed52e37035f79a7c48c5f96dc0331634fae1520164875df22e48e7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUY4OkRCMDlGOkQwQzAxQzoxMEI0Q0UwOjZCMDEwNTFBIiwidmlzaXRvcl9pZCI6IjM4NzUzODg1ODM5ODQ1NjM0ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace2f5bce93e76a8365dbb2a0c9190c4d898a322b2ccad434f1152c26174a2f3e3
hovercard-subject-tagpull_request:1568637518
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/52322/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b474f985a50f332501b83b17d4b1e82b55c5fe03ab11eeca1a870a251dc521d9/angular/angular/pull/52322
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b474f985a50f332501b83b17d4b1e82b55c5fe03ab11eeca1a870a251dc521d9/angular/angular/pull/52322
og:image:altIn #52110 the compiler was changed to produce if statements when type checking @switch in order to avoid a bug in the TypeScript compiler. In order to avoid duplicate diagnostics, the main @switch ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecrisbeto
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/52322#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52322
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52322
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/52322
Reloadhttps://github.com/angular/angular/pull/52322
Reloadhttps://github.com/angular/angular/pull/52322
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
crisbeto:52315/switch-incompatible-typeshttps://github.com/crisbeto/angular/tree/52315/switch-incompatible-types
Conversationhttps://github.com/angular/angular/pull/52322
Commits1 (1)https://github.com/angular/angular/pull/52322/commits
Checkshttps://github.com/angular/angular/pull/52322/checks
Files changedhttps://github.com/angular/angular/pull/52322/files
fix(compiler): template type checking not reporting diagnostics for incompatible type comparisonshttps://github.com/angular/angular/pull/52322#top
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
crisbeto:52315/switch-incompatible-typeshttps://github.com/crisbeto/angular/tree/52315/switch-incompatible-types
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Oct 23, 2023https://github.com/angular/angular/pull/52322#issue-1956553379
#52110https://github.com/angular/angular/pull/52110
#52315https://github.com/angular/angular/issues/52315
Please reload this pagehttps://github.com/angular/angular/pull/52322
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
Oct 23, 2023https://github.com/angular/angular/pull/52322#event-10736920044
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
v17-finalhttps://github.com/angular/angular/milestone/126
Oct 23, 2023https://github.com/angular/angular/pull/52322#event-10736920071
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Oct 23, 2023 https://github.com/angular/angular/pull/52322#pullrequestreview-1691899500
View reviewed changes https://github.com/angular/angular/pull/52322/files
packages/compiler-cli/test/ngtsc/template_typecheck_spec.tshttps://github.com/angular/angular/pull/52322/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
crisbetohttps://github.com/crisbeto
Oct 23, 2023https://github.com/angular/angular/pull/52322#discussion_r1368250831
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/52322
https://github.com/crisbeto
fix(compiler): template type checking not reporting diagnostics for i…https://github.com/angular/angular/pull/52322/commits/5f453db182f98dc3988e2ffd12e1e45c3fa43c1e
5f453dbhttps://github.com/angular/angular/pull/52322/commits/5f453db182f98dc3988e2ffd12e1e45c3fa43c1e
angular#52110https://github.com/angular/angular/pull/52110
angular#52315https://github.com/angular/angular/issues/52315
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
force-pushedhttps://github.com/angular/angular/compare/6bd2ee826b5862d69f5897fae8e4fa359cf2d7c1..5f453db182f98dc3988e2ffd12e1e45c3fa43c1e
6bd2ee8https://github.com/angular/angular/commit/6bd2ee826b5862d69f5897fae8e4fa359cf2d7c1
5f453dbhttps://github.com/angular/angular/commit/5f453db182f98dc3988e2ffd12e1e45c3fa43c1e
Compare https://github.com/angular/angular/compare/6bd2ee826b5862d69f5897fae8e4fa359cf2d7c1..5f453db182f98dc3988e2ffd12e1e45c3fa43c1e
October 23, 2023 07:49https://github.com/angular/angular/pull/52322#event-10736980082
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
atscotthttps://github.com/atscott
October 23, 2023 08:13https://github.com/angular/angular/pull/52322#event-10737244574
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
October 23, 2023 08:13https://github.com/angular/angular/pull/52322#event-10737245109
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Oct 23, 2023 https://github.com/angular/angular/pull/52322#pullrequestreview-1692886308
View reviewed changes https://github.com/angular/angular/pull/52322/files/5f453db182f98dc3988e2ffd12e1e45c3fa43c1e
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
atscotthttps://github.com/atscott
October 23, 2023 15:43https://github.com/angular/angular/pull/52322#event-10742806367
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Oct 23, 2023https://github.com/angular/angular/pull/52322#event-10742807067
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
Oct 23, 2023https://github.com/angular/angular/pull/52322#issuecomment-1775568955
dc3f7cbhttps://github.com/angular/angular/commit/dc3f7cb3bfc4f22c1e34abeb5a5311ce1e756c90
Please reload this pagehttps://github.com/angular/angular/pull/52322
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
dc3f7cbhttps://github.com/angular/angular/commit/dc3f7cb3bfc4f22c1e34abeb5a5311ce1e756c90
Oct 23, 2023https://github.com/angular/angular/pull/52322#event-10743317166
dylhunnhttps://github.com/dylhunn
Oct 23, 2023 https://github.com/angular/angular/pull/52322#ref-commit-81c315e
https://github.com/crisbeto
https://github.com/dylhunn
fix(compiler): template type checking not reporting diagnostics for i…https://github.com/angular/angular/commit/81c315ec6ea37c55d951d3b38b6c551226173be5
81c315ehttps://github.com/angular/angular/commit/81c315ec6ea37c55d951d3b38b6c551226173be5
#52322https://github.com/angular/angular/pull/52322
#52110https://github.com/angular/angular/pull/52110
#52315https://github.com/angular/angular/issues/52315
#52322https://github.com/angular/angular/pull/52322
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 23, 2023https://github.com/angular/angular/pull/52322#issuecomment-1823679905
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/52322
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 23, 2023https://github.com/angular/angular/pull/52322#event-11042153368
ChellappanRajanhttps://github.com/ChellappanRajan
Jan 23, 2024 https://github.com/angular/angular/pull/52322#ref-commit-2a8117c
https://github.com/crisbeto
https://github.com/ChellappanRajan
fix(compiler): template type checking not reporting diagnostics for i…https://github.com/ChellappanRajan/angular/commit/2a8117ce79248e8f2d2f8947d70b28d87a519f19
2a8117chttps://github.com/ChellappanRajan/angular/commit/2a8117ce79248e8f2d2f8947d70b28d87a519f19
angular#52322https://github.com/angular/angular/pull/52322
angular#52110https://github.com/angular/angular/pull/52110
angular#52315https://github.com/angular/angular/issues/52315
angular#52322https://github.com/angular/angular/pull/52322
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52322
https://github.com/JoostK
JoostK https://github.com/JoostK
https://github.com/angular/angular/pull/52322/files/5f453db182f98dc3988e2ffd12e1e45c3fa43c1e
Please reload this pagehttps://github.com/angular/angular/pull/52322
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
v17-final https://github.com/angular/angular/milestone/126
@switch does not have type awareness in case statements https://github.com/angular/angular/issues/52315
Please reload this pagehttps://github.com/angular/angular/pull/52322
https://github.com/crisbeto
https://github.com/dylhunn
https://github.com/JoostK
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.