René's URL Explorer Experiment


Title: fix(core): replace assertion with more intentional error by alxhub · Pull Request #52234 · angular/angular · GitHub

Open Graph Title: fix(core): replace assertion with more intentional error by alxhub · Pull Request #52234 · angular/angular

X Title: fix(core): replace assertion with more intentional error by alxhub · Pull Request #52234 · angular/angular

Description: Issue #50320 shows that in some cases, updating a signal that's a dependency of a template during change detection of that template can have several adverse effects. This can happen, for example, if the signal is set during the lifecycle hook of a directive within the same template that reads the signal. This can cause a few things to happen: Straightforwardly, it can cause ExpressionChanged errors. Surprisingly, it can cause an assertion within the ReactiveLViewConsumer to fail. Very surprisingly, it can cause change detection for an OnPush component to stop working. The root cause of these later behaviors is subtle, and is ultimately a desync between the reactive graph and the view tree's notion of "dirty" for a given view. This will be fixed with further work planned for change detection to handle such updates directly. Until then, this commit improves the DX through two changes: The mechanism of "committing" ReactiveLViewConsumers to a view is changed to use the consumerOnSignalRead hook from the reactive graph. This prevents the situation which required the assertion in the first place. A console.warn warning is added when a view is marked dirty via a signal while it's still executing. The warning informs users that they're pushing data against the direction of change detection, risking ExpressionChanged or other issues. It's a warning and not an error because the check is overly broad and captures situations where the application would not actually break as a result, such as if a computed marked the template dirty but still returned the same value.

Open Graph Description: Issue #50320 shows that in some cases, updating a signal that's a dependency of a template during change detection of that template can have several adverse effects. This can happen, for exampl...

X Description: Issue #50320 shows that in some cases, updating a signal that's a dependency of a template during change detection of that template can have several adverse effects. This can happen, for ex...

Opengraph URL: https://github.com/angular/angular/pull/52234

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c806cd50-00dd-0e9d-784d-508771087966
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9C8:34CAB:15EC7F7:1BFD7E7:6B0138EA
html-safe-nonce32d628cdb5a4e7f93ff5bf79224aa4ac2c3a6e962bda2323b38b9f24951fd1a3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUM4OjM0Q0FCOjE1RUM3Rjc6MUJGRDdFNzo2QjAxMzhFQSIsInZpc2l0b3JfaWQiOiI0NjA0OTA0NDU1ODQwODA3MTQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac58d0efbdb29540394615b750cd8d4110965117bfb427bcef8d0b4df66b785610
hovercard-subject-tagpull_request:1559417962
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/52234/files
twitter:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
og:image:altIssue #50320 shows that in some cases, updating a signal that's a dependency of a template during change detection of that template can have several adverse effects. This can happen, for exampl...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/52234/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52234%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52234%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/52234/files
Reloadhttps://github.com/angular/angular/pull/52234/files
Reloadhttps://github.com/angular/angular/pull/52234/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alxhubhttps://github.com/alxhub
angular:mainhttps://github.com/angular/angular/tree/main
alxhub:signals-cd/errorhttps://github.com/alxhub/angular/tree/signals-cd/error
Conversation 12 https://github.com/angular/angular/pull/52234
Commits 1 https://github.com/angular/angular/pull/52234/commits
Checks 0 https://github.com/angular/angular/pull/52234/checks
Files changed https://github.com/angular/angular/pull/52234/files
Please reload this pagehttps://github.com/angular/angular/pull/52234/files
fix(core): replace assertion with more intentional error https://github.com/angular/angular/pull/52234/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/52234/files
eb6d840 fix(core): replace assertion with more intentional error alxhub Oct 16, 2023 https://github.com/angular/angular/pull/52234/commits/eb6d84058da9bf1aa7c24d5a3126ce77c979966b
Clear filters https://github.com/angular/angular/pull/52234/files
Please reload this pagehttps://github.com/angular/angular/pull/52234/files
Please reload this pagehttps://github.com/angular/angular/pull/52234/files
aio-payloads.json https://github.com/angular/angular/pull/52234/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
change_detection.ts https://github.com/angular/angular/pull/52234/files#diff-5a40bc02146e2e6b3af994a675e1bab7d414a66bedb4df9f6eca0321c23cd9aa
shared.ts https://github.com/angular/angular/pull/52234/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
reactive_lview_consumer.ts https://github.com/angular/angular/pull/52234/files#diff-72bf8e0002ca24499882588d6547b9cec7d95e49430e621b213f8db277852fa0
change_detection_signals_in_zones_spec.ts https://github.com/angular/angular/pull/52234/files#diff-376ce155baddd41d9d538ba8164a05f416c22c843ab23328129848ce1831a0dd
bundle.golden_symbols.json https://github.com/angular/angular/pull/52234/files#diff-f2c84d492a8c65b8ff95627bb49ae1700f5ad3afa2e7253c2662921c80e9a0c9
bundle.golden_symbols.json https://github.com/angular/angular/pull/52234/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
bundle.golden_symbols.json https://github.com/angular/angular/pull/52234/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
bundle.golden_symbols.json https://github.com/angular/angular/pull/52234/files#diff-8fc5bf996c8481f2e48e54e8af85f08e8e07e6ab829754ec8fcd5020ee1a0d63
bundle.golden_symbols.json https://github.com/angular/angular/pull/52234/files#diff-a563377da9d556286f0a20e2b5a6e74d72c72f85da56a28685e71cc2ed59e09a
bundle.golden_symbols.json https://github.com/angular/angular/pull/52234/files#diff-67acd054cb217ad104aaf8eec24f62b95d2f8a8c3bf253815f936e5659242be2
bundle.golden_symbols.json https://github.com/angular/angular/pull/52234/files#diff-b45ad5203dc5e93dba1c03c72c197220625be52c2bac940397a5b62179ec49dd
bundle.golden_symbols.json https://github.com/angular/angular/pull/52234/files#diff-bcf46e181be837c02f603b1ee75d0373d48393cacb51bbdf987666f4b294049c
bundle.golden_symbols.json https://github.com/angular/angular/pull/52234/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
bundle.golden_symbols.json https://github.com/angular/angular/pull/52234/files#diff-90fb073da08eb200a8d9bd0ff862812fa7f42e4cdc450a8f3d4ab8338b762e20
bundle.golden_symbols.json https://github.com/angular/angular/pull/52234/files#diff-c8a15946b2828a34229ac187045402b1ea37f0cb736063560a2a20f2744c23fc
goldens/size-tracking/aio-payloads.jsonhttps://github.com/angular/angular/pull/52234/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
View file https://github.com/alxhub/angular/blob/eb6d84058da9bf1aa7c24d5a3126ce77c979966b/goldens/size-tracking/aio-payloads.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52234/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52234/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
https://github.com/angular/angular/pull/52234/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
packages/core/src/render3/instructions/change_detection.tshttps://github.com/angular/angular/pull/52234/files#diff-5a40bc02146e2e6b3af994a675e1bab7d414a66bedb4df9f6eca0321c23cd9aa
View file https://github.com/alxhub/angular/blob/eb6d84058da9bf1aa7c24d5a3126ce77c979966b/packages/core/src/render3/instructions/change_detection.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52234/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52234/files#diff-5a40bc02146e2e6b3af994a675e1bab7d414a66bedb4df9f6eca0321c23cd9aa
https://github.com/angular/angular/pull/52234/files#diff-5a40bc02146e2e6b3af994a675e1bab7d414a66bedb4df9f6eca0321c23cd9aa
https://github.com/angular/angular/pull/52234/files#diff-5a40bc02146e2e6b3af994a675e1bab7d414a66bedb4df9f6eca0321c23cd9aa
https://github.com/angular/angular/pull/52234/files#diff-5a40bc02146e2e6b3af994a675e1bab7d414a66bedb4df9f6eca0321c23cd9aa
packages/core/src/render3/instructions/shared.tshttps://github.com/angular/angular/pull/52234/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
View file https://github.com/alxhub/angular/blob/eb6d84058da9bf1aa7c24d5a3126ce77c979966b/packages/core/src/render3/instructions/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52234/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52234/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/52234/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/52234/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/52234/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/52234/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/52234/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
packages/core/src/render3/reactive_lview_consumer.tshttps://github.com/angular/angular/pull/52234/files#diff-72bf8e0002ca24499882588d6547b9cec7d95e49430e621b213f8db277852fa0
View file https://github.com/alxhub/angular/blob/eb6d84058da9bf1aa7c24d5a3126ce77c979966b/packages/core/src/render3/reactive_lview_consumer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52234/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52234/files#diff-72bf8e0002ca24499882588d6547b9cec7d95e49430e621b213f8db277852fa0
https://github.com/angular/angular/pull/52234/files#diff-72bf8e0002ca24499882588d6547b9cec7d95e49430e621b213f8db277852fa0
JeanMechehttps://github.com/JeanMeche
Oct 16, 2023https://github.com/angular/angular/pull/52234/files#r1361303802
Please reload this pagehttps://github.com/angular/angular/pull/52234/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/52234/files
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 17, 2023https://github.com/angular/angular/pull/52234/files#r1361899243
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/52234/files
JeanMechehttps://github.com/JeanMeche
Oct 17, 2023https://github.com/angular/angular/pull/52234/files#r1361945300
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://next.angular.io/errors/NG0506https://next.angular.io/errors/NG0506
https://next.angular.io/errors/NG0912https://next.angular.io/errors/NG0912
Please reload this pagehttps://github.com/angular/angular/pull/52234/files
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Oct 17, 2023https://github.com/angular/angular/pull/52234/files#r1361990086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/52234/files
alxhubhttps://github.com/alxhub
Oct 26, 2023https://github.com/angular/angular/pull/52234/files#r1373909071
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/52234/files
packages/core/test/acceptance/change_detection_signals_in_zones_spec.tshttps://github.com/angular/angular/pull/52234/files#diff-376ce155baddd41d9d538ba8164a05f416c22c843ab23328129848ce1831a0dd
View file https://github.com/alxhub/angular/blob/eb6d84058da9bf1aa7c24d5a3126ce77c979966b/packages/core/test/acceptance/change_detection_signals_in_zones_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52234/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52234/files#diff-376ce155baddd41d9d538ba8164a05f416c22c843ab23328129848ce1831a0dd
https://github.com/angular/angular/pull/52234/files#diff-376ce155baddd41d9d538ba8164a05f416c22c843ab23328129848ce1831a0dd
https://github.com/angular/angular/pull/52234/files#diff-376ce155baddd41d9d538ba8164a05f416c22c843ab23328129848ce1831a0dd
packages/core/test/bundling/animations-standalone/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/52234/files#diff-f2c84d492a8c65b8ff95627bb49ae1700f5ad3afa2e7253c2662921c80e9a0c9
View file https://github.com/alxhub/angular/blob/eb6d84058da9bf1aa7c24d5a3126ce77c979966b/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52234/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52234/files#diff-f2c84d492a8c65b8ff95627bb49ae1700f5ad3afa2e7253c2662921c80e9a0c9
https://github.com/angular/angular/pull/52234/files#diff-f2c84d492a8c65b8ff95627bb49ae1700f5ad3afa2e7253c2662921c80e9a0c9
https://github.com/angular/angular/pull/52234/files#diff-f2c84d492a8c65b8ff95627bb49ae1700f5ad3afa2e7253c2662921c80e9a0c9
https://github.com/angular/angular/pull/52234/files#diff-f2c84d492a8c65b8ff95627bb49ae1700f5ad3afa2e7253c2662921c80e9a0c9
https://github.com/angular/angular/pull/52234/files#diff-f2c84d492a8c65b8ff95627bb49ae1700f5ad3afa2e7253c2662921c80e9a0c9
https://github.com/angular/angular/pull/52234/files#diff-f2c84d492a8c65b8ff95627bb49ae1700f5ad3afa2e7253c2662921c80e9a0c9
packages/core/test/bundling/animations/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/52234/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
View file https://github.com/alxhub/angular/blob/eb6d84058da9bf1aa7c24d5a3126ce77c979966b/packages/core/test/bundling/animations/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52234/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52234/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
https://github.com/angular/angular/pull/52234/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
https://github.com/angular/angular/pull/52234/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
https://github.com/angular/angular/pull/52234/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
https://github.com/angular/angular/pull/52234/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
https://github.com/angular/angular/pull/52234/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
packages/core/test/bundling/cyclic_import/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/52234/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
View file https://github.com/alxhub/angular/blob/eb6d84058da9bf1aa7c24d5a3126ce77c979966b/packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52234/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52234/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
https://github.com/angular/angular/pull/52234/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
https://github.com/angular/angular/pull/52234/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
https://github.com/angular/angular/pull/52234/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
https://github.com/angular/angular/pull/52234/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
https://github.com/angular/angular/pull/52234/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
packages/core/test/bundling/defer/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/52234/files#diff-8fc5bf996c8481f2e48e54e8af85f08e8e07e6ab829754ec8fcd5020ee1a0d63
View file https://github.com/alxhub/angular/blob/eb6d84058da9bf1aa7c24d5a3126ce77c979966b/packages/core/test/bundling/defer/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/52234/{{ revealButtonHref }}
https://github.com/angular/angular/pull/52234/files#diff-8fc5bf996c8481f2e48e54e8af85f08e8e07e6ab829754ec8fcd5020ee1a0d63
https://github.com/angular/angular/pull/52234/files#diff-8fc5bf996c8481f2e48e54e8af85f08e8e07e6ab829754ec8fcd5020ee1a0d63
https://github.com/angular/angular/pull/52234/files#diff-8fc5bf996c8481f2e48e54e8af85f08e8e07e6ab829754ec8fcd5020ee1a0d63
https://github.com/angular/angular/pull/52234/files#diff-8fc5bf996c8481f2e48e54e8af85f08e8e07e6ab829754ec8fcd5020ee1a0d63
https://github.com/angular/angular/pull/52234/files#diff-8fc5bf996c8481f2e48e54e8af85f08e8e07e6ab829754ec8fcd5020ee1a0d63
https://github.com/angular/angular/pull/52234/files#diff-8fc5bf996c8481f2e48e54e8af85f08e8e07e6ab829754ec8fcd5020ee1a0d63
Please reload this pagehttps://github.com/angular/angular/pull/52234/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.