| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:af7fa43a-7c59-b309-c340-179661780635 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9732:1201C:1064666:15D9F03:6B0110B3 |
| html-safe-nonce | 084b04839a811e076b4d65e39838a97fe6a98922c2150cd1e9cb253f2cf581a9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzMyOjEyMDFDOjEwNjQ2NjY6MTVEOUYwMzo2QjAxMTBCMyIsInZpc2l0b3JfaWQiOiIxNjAxMDEzOTc0NDkyMTYxNzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 84c63ed97ca3256c9d0e5bd5b7a61630fb28de0d40699a1fffba5bc1b8ec7385 |
| hovercard-subject-tag | pull_request:1547412994 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/52110/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6587e04d7e0369716fd580ea5769992f6d8335a2bb91bac0bf2d383a4b30e99a/angular/angular/pull/52110 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6587e04d7e0369716fd580ea5769992f6d8335a2bb91bac0bf2d383a4b30e99a/angular/angular/pull/52110 |
| og:image:alt | We type check @switch blocks by generating identical TS switch statements in the TCB, however TS currently has a bug where parenthesized switch block expressions don't narrow their types. Since... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | crisbeto |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/52110#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52110 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52110 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/52110 |
| Reload | https://github.com/angular/angular/pull/52110 |
| Reload | https://github.com/angular/angular/pull/52110 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| crisbeto | https://github.com/crisbeto |
| angular:main | https://github.com/angular/angular/tree/main |
| crisbeto:switch-if-tcb | https://github.com/crisbeto/angular/tree/switch-if-tcb |
| Conversation | https://github.com/angular/angular/pull/52110 |
| Commits1 (1) | https://github.com/angular/angular/pull/52110/commits |
| Checks | https://github.com/angular/angular/pull/52110/checks |
| Files changed | https://github.com/angular/angular/pull/52110/files |
| fix(compiler): work around TypeScript bug when narrowing switch statements | https://github.com/angular/angular/pull/52110#top |
| crisbeto | https://github.com/crisbeto |
| angular:main | https://github.com/angular/angular/tree/main |
| crisbeto:switch-if-tcb | https://github.com/crisbeto/angular/tree/switch-if-tcb |
|
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#issue-1932567129 |
| #52077 | https://github.com/angular/angular/issues/52077 |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
area: compiler
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22 |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#event-10588246465 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| v17-candidates | https://github.com/angular/angular/milestone/118 |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#event-10588246513 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| JoostK | https://github.com/JoostK |
| atscott | https://github.com/atscott |
| October 9, 2023 09:00 | https://github.com/angular/angular/pull/52110#event-10588469741 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| October 9, 2023 09:00 | https://github.com/angular/angular/pull/52110#event-10588470861 |
| https://github.com/cexbrayat |
| cexbrayat | https://github.com/cexbrayat |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#issuecomment-1752910781 |
| @crisbeto | https://github.com/crisbeto |
| #52107 | https://github.com/angular/angular/issues/52107 |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#issuecomment-1752920144 |
| @crisbeto | https://github.com/crisbeto |
| #52107 | https://github.com/angular/angular/issues/52107 |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
| https://github.com/cexbrayat |
| cexbrayat | https://github.com/cexbrayat |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#issuecomment-1752924601 |
| @JoostK | https://github.com/JoostK |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Oct 9, 2023
| https://github.com/angular/angular/pull/52110#pullrequestreview-1664740558 |
|
View reviewed changes
| https://github.com/angular/angular/pull/52110/files |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#event-10592591823 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#issuecomment-1753201642 |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png |
| https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| force-pushed | https://github.com/angular/angular/compare/c9a6cbb82da9d9bf803c72f2aaabfff55747aa39..b61b0d0ab50793fb98cb543c9524c66702b1a0f8 |
| c9a6cbb | https://github.com/angular/angular/commit/c9a6cbb82da9d9bf803c72f2aaabfff55747aa39 |
| b61b0d0 | https://github.com/angular/angular/commit/b61b0d0ab50793fb98cb543c9524c66702b1a0f8 |
|
Compare
| https://github.com/angular/angular/compare/c9a6cbb82da9d9bf803c72f2aaabfff55747aa39..b61b0d0ab50793fb98cb543c9524c66702b1a0f8 |
| October 9, 2023 15:29 | https://github.com/angular/angular/pull/52110#event-10592807531 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Oct 9, 2023
| https://github.com/angular/angular/pull/52110#pullrequestreview-1664806090 |
|
View reviewed changes
| https://github.com/angular/angular/pull/52110/files |
| packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts | https://github.com/angular/angular/pull/52110/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
| packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts | https://github.com/angular/angular/pull/52110/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#event-10592969905 |
|
| https://github.com/crisbeto |
| fix(compiler): work around TypeScript bug when narrowing switch state… | https://github.com/angular/angular/pull/52110/commits/e47f387aa6df653fd08401566db5b4e2e8080853 |
| e47f387 | https://github.com/angular/angular/pull/52110/commits/e47f387aa6df653fd08401566db5b4e2e8080853 |
| angular#52077 | https://github.com/angular/angular/issues/52077 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| force-pushed | https://github.com/angular/angular/compare/b61b0d0ab50793fb98cb543c9524c66702b1a0f8..e47f387aa6df653fd08401566db5b4e2e8080853 |
| b61b0d0 | https://github.com/angular/angular/commit/b61b0d0ab50793fb98cb543c9524c66702b1a0f8 |
| e47f387 | https://github.com/angular/angular/commit/e47f387aa6df653fd08401566db5b4e2e8080853 |
|
Compare
| https://github.com/angular/angular/compare/b61b0d0ab50793fb98cb543c9524c66702b1a0f8..e47f387aa6df653fd08401566db5b4e2e8080853 |
| October 9, 2023 16:23 | https://github.com/angular/angular/pull/52110#event-10593340056 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#issuecomment-1753312997 |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#event-10593343035 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Oct 9, 2023
| https://github.com/angular/angular/pull/52110#pullrequestreview-1664927776 |
|
View reviewed changes
| https://github.com/angular/angular/pull/52110/files/e47f387aa6df653fd08401566db5b4e2e8080853 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#issuecomment-1753423180 |
| 386e1e9 | https://github.com/angular/angular/commit/386e1e950033ad98661e5077a4f119df0e7b3008 |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| 386e1e9 | https://github.com/angular/angular/commit/386e1e950033ad98661e5077a4f119df0e7b3008 |
| Oct 9, 2023 | https://github.com/angular/angular/pull/52110#event-10594062115 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
|
Oct 23, 2023
| https://github.com/angular/angular/pull/52110#ref-pullrequest-1956553379 |
|
fix(compiler): template type checking not reporting diagnostics for incompatible type comparisons
#52322
| https://github.com/angular/angular/pull/52322 |
| crisbeto | https://github.com/crisbeto |
|
Oct 23, 2023
| https://github.com/angular/angular/pull/52110#ref-commit-5f453db |
|
| https://github.com/crisbeto |
| fix(compiler): template type checking not reporting diagnostics for i… | https://github.com/crisbeto/angular/commit/5f453db182f98dc3988e2ffd12e1e45c3fa43c1e |
| 5f453db | https://github.com/crisbeto/angular/commit/5f453db182f98dc3988e2ffd12e1e45c3fa43c1e |
| angular#52110 | https://github.com/angular/angular/pull/52110 |
| angular#52315 | https://github.com/angular/angular/issues/52315 |
| dylhunn | https://github.com/dylhunn |
|
Oct 23, 2023
| https://github.com/angular/angular/pull/52110#ref-commit-dc3f7cb |
|
| https://github.com/crisbeto |
|
| https://github.com/dylhunn |
| fix(compiler): template type checking not reporting diagnostics for i… | https://github.com/angular/angular/commit/dc3f7cb3bfc4f22c1e34abeb5a5311ce1e756c90 |
| dc3f7cb | https://github.com/angular/angular/commit/dc3f7cb3bfc4f22c1e34abeb5a5311ce1e756c90 |
| #52322 | https://github.com/angular/angular/pull/52322 |
| #52110 | https://github.com/angular/angular/pull/52110 |
| #52315 | https://github.com/angular/angular/issues/52315 |
| #52322 | https://github.com/angular/angular/pull/52322 |
| dylhunn | https://github.com/dylhunn |
|
Oct 23, 2023
| https://github.com/angular/angular/pull/52110#ref-commit-81c315e |
|
| https://github.com/crisbeto |
|
| https://github.com/dylhunn |
| fix(compiler): template type checking not reporting diagnostics for i… | https://github.com/angular/angular/commit/81c315ec6ea37c55d951d3b38b6c551226173be5 |
| 81c315e | https://github.com/angular/angular/commit/81c315ec6ea37c55d951d3b38b6c551226173be5 |
| #52322 | https://github.com/angular/angular/pull/52322 |
| #52110 | https://github.com/angular/angular/pull/52110 |
| #52315 | https://github.com/angular/angular/issues/52315 |
| #52322 | https://github.com/angular/angular/pull/52322 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Nov 9, 2023 | https://github.com/angular/angular/pull/52110#issuecomment-1802941683 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Nov 9, 2023 | https://github.com/angular/angular/pull/52110#event-10907026041 |
| ChellappanRajan | https://github.com/ChellappanRajan |
|
Jan 23, 2024
| https://github.com/angular/angular/pull/52110#ref-commit-86d86ee |
|
| https://github.com/crisbeto |
|
| https://github.com/ChellappanRajan |
| fix(compiler): work around TypeScript bug when narrowing switch state… | https://github.com/ChellappanRajan/angular/commit/86d86ee435a9c962ea3beb33bf564cae300ee10f |
| 86d86ee | https://github.com/ChellappanRajan/angular/commit/86d86ee435a9c962ea3beb33bf564cae300ee10f |
| angular#52110 | https://github.com/angular/angular/pull/52110 |
| angular#52077 | https://github.com/angular/angular/issues/52077 |
| angular#52110 | https://github.com/angular/angular/pull/52110 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52110 |
|
| https://github.com/JoostK |
|
JoostK
| https://github.com/JoostK |
|
| https://github.com/angular/angular/pull/52110/files/e47f387aa6df653fd08401566db5b4e2e8080853 |
|
| https://github.com/atscott |
|
atscott
| https://github.com/atscott |
|
| https://github.com/angular/angular/pull/52110/files/b61b0d0ab50793fb98cb543c9524c66702b1a0f8 |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: compiler
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
v17-candidates
| https://github.com/angular/angular/milestone/118 |
|
@switch type narrowing doesn't work
| https://github.com/angular/angular/issues/52077 |
| Please reload this page | https://github.com/angular/angular/pull/52110 |
|
| https://github.com/crisbeto |
|
| https://github.com/cexbrayat |
|
| https://github.com/JoostK |
|
| https://github.com/atscott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |