René's URL Explorer Experiment


Title: fix(compiler): work around TypeScript bug when narrowing switch statements by crisbeto · Pull Request #52110 · angular/angular · GitHub

Open Graph Title: fix(compiler): work around TypeScript bug when narrowing switch statements by crisbeto · Pull Request #52110 · angular/angular

X Title: fix(compiler): work around TypeScript bug when narrowing switch statements by crisbeto · Pull Request #52110 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: We type check @switch blocks by generating identical TS switch statements in the TCB, however TS currently has a bug where parenthesized switch block expressions don't narrow their types. Since...

X Description: We type check @switch blocks by generating identical TS switch statements in the TCB, however TS currently has a bug where parenthesized switch block expressions don't narrow their types. S...

Opengraph URL: https://github.com/angular/angular/pull/52110

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:af7fa43a-7c59-b309-c340-179661780635
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9732:1201C:1064666:15D9F03:6B0110B3
html-safe-nonce084b04839a811e076b4d65e39838a97fe6a98922c2150cd1e9cb253f2cf581a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzMyOjEyMDFDOjEwNjQ2NjY6MTVEOUYwMzo2QjAxMTBCMyIsInZpc2l0b3JfaWQiOiIxNjAxMDEzOTc0NDkyMTYxNzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac84c63ed97ca3256c9d0e5bd5b7a61630fb28de0d40699a1fffba5bc1b8ec7385
hovercard-subject-tagpull_request:1547412994
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/52110/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6587e04d7e0369716fd580ea5769992f6d8335a2bb91bac0bf2d383a4b30e99a/angular/angular/pull/52110
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6587e04d7e0369716fd580ea5769992f6d8335a2bb91bac0bf2d383a4b30e99a/angular/angular/pull/52110
og:image:altWe type check @switch blocks by generating identical TS switch statements in the TCB, however TS currently has a bug where parenthesized switch block expressions don't narrow their types. Since...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecrisbeto
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/52110#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52110
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52110
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/52110
Reloadhttps://github.com/angular/angular/pull/52110
Reloadhttps://github.com/angular/angular/pull/52110
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
crisbeto:switch-if-tcbhttps://github.com/crisbeto/angular/tree/switch-if-tcb
Conversationhttps://github.com/angular/angular/pull/52110
Commits1 (1)https://github.com/angular/angular/pull/52110/commits
Checkshttps://github.com/angular/angular/pull/52110/checks
Files changedhttps://github.com/angular/angular/pull/52110/files
fix(compiler): work around TypeScript bug when narrowing switch statementshttps://github.com/angular/angular/pull/52110#top
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
crisbeto:switch-if-tcbhttps://github.com/crisbeto/angular/tree/switch-if-tcb
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Oct 9, 2023https://github.com/angular/angular/pull/52110#issue-1932567129
#52077https://github.com/angular/angular/issues/52077
Please reload this pagehttps://github.com/angular/angular/pull/52110
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
Oct 9, 2023https://github.com/angular/angular/pull/52110#event-10588246465
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
v17-candidateshttps://github.com/angular/angular/milestone/118
Oct 9, 2023https://github.com/angular/angular/pull/52110#event-10588246513
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
JoostKhttps://github.com/JoostK
atscotthttps://github.com/atscott
October 9, 2023 09:00https://github.com/angular/angular/pull/52110#event-10588469741
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
October 9, 2023 09:00https://github.com/angular/angular/pull/52110#event-10588470861
https://github.com/cexbrayat
cexbrayathttps://github.com/cexbrayat
Oct 9, 2023https://github.com/angular/angular/pull/52110#issuecomment-1752910781
@crisbetohttps://github.com/crisbeto
#52107https://github.com/angular/angular/issues/52107
Please reload this pagehttps://github.com/angular/angular/pull/52110
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Oct 9, 2023https://github.com/angular/angular/pull/52110#issuecomment-1752920144
@crisbetohttps://github.com/crisbeto
#52107https://github.com/angular/angular/issues/52107
Please reload this pagehttps://github.com/angular/angular/pull/52110
https://github.com/cexbrayat
cexbrayathttps://github.com/cexbrayat
Oct 9, 2023https://github.com/angular/angular/pull/52110#issuecomment-1752924601
@JoostKhttps://github.com/JoostK
Please reload this pagehttps://github.com/angular/angular/pull/52110
https://github.com/atscott
atscotthttps://github.com/atscott
Oct 9, 2023 https://github.com/angular/angular/pull/52110#pullrequestreview-1664740558
View reviewed changes https://github.com/angular/angular/pull/52110/files
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Oct 9, 2023https://github.com/angular/angular/pull/52110#event-10592591823
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Oct 9, 2023https://github.com/angular/angular/pull/52110#issuecomment-1753201642
https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png
https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png
https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png
https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png
Please reload this pagehttps://github.com/angular/angular/pull/52110
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
force-pushedhttps://github.com/angular/angular/compare/c9a6cbb82da9d9bf803c72f2aaabfff55747aa39..b61b0d0ab50793fb98cb543c9524c66702b1a0f8
c9a6cbbhttps://github.com/angular/angular/commit/c9a6cbb82da9d9bf803c72f2aaabfff55747aa39
b61b0d0https://github.com/angular/angular/commit/b61b0d0ab50793fb98cb543c9524c66702b1a0f8
Compare https://github.com/angular/angular/compare/c9a6cbb82da9d9bf803c72f2aaabfff55747aa39..b61b0d0ab50793fb98cb543c9524c66702b1a0f8
October 9, 2023 15:29https://github.com/angular/angular/pull/52110#event-10592807531
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Oct 9, 2023 https://github.com/angular/angular/pull/52110#pullrequestreview-1664806090
View reviewed changes https://github.com/angular/angular/pull/52110/files
packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.tshttps://github.com/angular/angular/pull/52110/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
Please reload this pagehttps://github.com/angular/angular/pull/52110
packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.tshttps://github.com/angular/angular/pull/52110/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
Please reload this pagehttps://github.com/angular/angular/pull/52110
https://github.com/atscott
atscotthttps://github.com/atscott
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Oct 9, 2023https://github.com/angular/angular/pull/52110#event-10592969905
https://github.com/crisbeto
fix(compiler): work around TypeScript bug when narrowing switch state…https://github.com/angular/angular/pull/52110/commits/e47f387aa6df653fd08401566db5b4e2e8080853
e47f387https://github.com/angular/angular/pull/52110/commits/e47f387aa6df653fd08401566db5b4e2e8080853
angular#52077https://github.com/angular/angular/issues/52077
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
force-pushedhttps://github.com/angular/angular/compare/b61b0d0ab50793fb98cb543c9524c66702b1a0f8..e47f387aa6df653fd08401566db5b4e2e8080853
b61b0d0https://github.com/angular/angular/commit/b61b0d0ab50793fb98cb543c9524c66702b1a0f8
e47f387https://github.com/angular/angular/commit/e47f387aa6df653fd08401566db5b4e2e8080853
Compare https://github.com/angular/angular/compare/b61b0d0ab50793fb98cb543c9524c66702b1a0f8..e47f387aa6df653fd08401566db5b4e2e8080853
October 9, 2023 16:23https://github.com/angular/angular/pull/52110#event-10593340056
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Oct 9, 2023https://github.com/angular/angular/pull/52110#issuecomment-1753312997
Please reload this pagehttps://github.com/angular/angular/pull/52110
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Oct 9, 2023https://github.com/angular/angular/pull/52110#event-10593343035
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Oct 9, 2023 https://github.com/angular/angular/pull/52110#pullrequestreview-1664927776
View reviewed changes https://github.com/angular/angular/pull/52110/files/e47f387aa6df653fd08401566db5b4e2e8080853
https://github.com/atscott
atscotthttps://github.com/atscott
Oct 9, 2023https://github.com/angular/angular/pull/52110#issuecomment-1753423180
386e1e9https://github.com/angular/angular/commit/386e1e950033ad98661e5077a4f119df0e7b3008
Please reload this pagehttps://github.com/angular/angular/pull/52110
https://github.com/atscott
atscotthttps://github.com/atscott
386e1e9https://github.com/angular/angular/commit/386e1e950033ad98661e5077a4f119df0e7b3008
Oct 9, 2023https://github.com/angular/angular/pull/52110#event-10594062115
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Oct 23, 2023 https://github.com/angular/angular/pull/52110#ref-pullrequest-1956553379
fix(compiler): template type checking not reporting diagnostics for incompatible type comparisons #52322 https://github.com/angular/angular/pull/52322
crisbetohttps://github.com/crisbeto
Oct 23, 2023 https://github.com/angular/angular/pull/52110#ref-commit-5f453db
https://github.com/crisbeto
fix(compiler): template type checking not reporting diagnostics for i…https://github.com/crisbeto/angular/commit/5f453db182f98dc3988e2ffd12e1e45c3fa43c1e
5f453dbhttps://github.com/crisbeto/angular/commit/5f453db182f98dc3988e2ffd12e1e45c3fa43c1e
angular#52110https://github.com/angular/angular/pull/52110
angular#52315https://github.com/angular/angular/issues/52315
dylhunnhttps://github.com/dylhunn
Oct 23, 2023 https://github.com/angular/angular/pull/52110#ref-commit-dc3f7cb
https://github.com/crisbeto
https://github.com/dylhunn
fix(compiler): template type checking not reporting diagnostics for i…https://github.com/angular/angular/commit/dc3f7cb3bfc4f22c1e34abeb5a5311ce1e756c90
dc3f7cbhttps://github.com/angular/angular/commit/dc3f7cb3bfc4f22c1e34abeb5a5311ce1e756c90
#52322https://github.com/angular/angular/pull/52322
#52110https://github.com/angular/angular/pull/52110
#52315https://github.com/angular/angular/issues/52315
#52322https://github.com/angular/angular/pull/52322
dylhunnhttps://github.com/dylhunn
Oct 23, 2023 https://github.com/angular/angular/pull/52110#ref-commit-81c315e
https://github.com/crisbeto
https://github.com/dylhunn
fix(compiler): template type checking not reporting diagnostics for i…https://github.com/angular/angular/commit/81c315ec6ea37c55d951d3b38b6c551226173be5
81c315ehttps://github.com/angular/angular/commit/81c315ec6ea37c55d951d3b38b6c551226173be5
#52322https://github.com/angular/angular/pull/52322
#52110https://github.com/angular/angular/pull/52110
#52315https://github.com/angular/angular/issues/52315
#52322https://github.com/angular/angular/pull/52322
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 9, 2023https://github.com/angular/angular/pull/52110#issuecomment-1802941683
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/52110
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Nov 9, 2023https://github.com/angular/angular/pull/52110#event-10907026041
ChellappanRajanhttps://github.com/ChellappanRajan
Jan 23, 2024 https://github.com/angular/angular/pull/52110#ref-commit-86d86ee
https://github.com/crisbeto
https://github.com/ChellappanRajan
fix(compiler): work around TypeScript bug when narrowing switch state…https://github.com/ChellappanRajan/angular/commit/86d86ee435a9c962ea3beb33bf564cae300ee10f
86d86eehttps://github.com/ChellappanRajan/angular/commit/86d86ee435a9c962ea3beb33bf564cae300ee10f
angular#52110https://github.com/angular/angular/pull/52110
angular#52077https://github.com/angular/angular/issues/52077
angular#52110https://github.com/angular/angular/pull/52110
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F52110
https://github.com/JoostK
JoostK https://github.com/JoostK
https://github.com/angular/angular/pull/52110/files/e47f387aa6df653fd08401566db5b4e2e8080853
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/52110/files/b61b0d0ab50793fb98cb543c9524c66702b1a0f8
Please reload this pagehttps://github.com/angular/angular/pull/52110
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
v17-candidates https://github.com/angular/angular/milestone/118
@switch type narrowing doesn't work https://github.com/angular/angular/issues/52077
Please reload this pagehttps://github.com/angular/angular/pull/52110
https://github.com/crisbeto
https://github.com/cexbrayat
https://github.com/JoostK
https://github.com/atscott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.