René's URL Explorer Experiment


Title: feat(common): Allow ngSrc to be changed post-init by atcastle · Pull Request #50683 · angular/angular · GitHub

Open Graph Title: feat(common): Allow ngSrc to be changed post-init by atcastle · Pull Request #50683 · angular/angular

X Title: feat(common): Allow ngSrc to be changed post-init by atcastle · Pull Request #50683 · angular/angular

Description: This PR modifies the NgOptimizedImage behavior when ngSrc is modified after component initialization. Previously this would throw an error, but we've received feedback (#47813) that this is impeding people's ability to use the directive for some use cases. This PR starts with just allowing ngSrc to be modified, but could be expanded to allow modifying other inputs as well. I'm concerned that modifying certain inputs, such as height, width and fill would be very likely to cause layout shift, which NgOptimizedImage is specifically designed to prevent. I reviewed the docs and error messages related to this change in functionality, and I don't believe any changes are required. CC: @AndrewKushnir @kara

Open Graph Description: This PR modifies the NgOptimizedImage behavior when ngSrc is modified after component initialization. Previously this would throw an error, but we've received feedback (#47813) that this is imp...

X Description: This PR modifies the NgOptimizedImage behavior when ngSrc is modified after component initialization. Previously this would throw an error, but we've received feedback (#47813) that this is...

Opengraph URL: https://github.com/angular/angular/pull/50683

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b3b5405c-b0f7-d150-d728-2f35a4e587c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8B4:13C1CF:501683:6AAE93:6B017A38
html-safe-noncee34a6cc674ff13c1b4d5a142b5fd963ea5d2a9f7e34be99324311058abf09651
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEI0OjEzQzFDRjo1MDE2ODM6NkFBRTkzOjZCMDE3QTM4IiwidmlzaXRvcl9pZCI6IjMzOTYzODM2NDYxMDQ1MTcxNzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0634b68a807223d22ea43d45379126fcca6919e965ac46dcaee069f14fc55e43
hovercard-subject-tagpull_request:1389067558
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/50683/files
twitter:imagehttps://avatars.githubusercontent.com/u/8526945?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8526945?s=400&v=4
og:image:altThis PR modifies the NgOptimizedImage behavior when ngSrc is modified after component initialization. Previously this would throw an error, but we've received feedback (#47813) that this is imp...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/50683/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50683%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50683%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/50683/files
Reloadhttps://github.com/angular/angular/pull/50683/files
Reloadhttps://github.com/angular/angular/pull/50683/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atcastlehttps://github.com/atcastle
angular:mainhttps://github.com/angular/angular/tree/main
atcastle:allow-changing-ngsrchttps://github.com/atcastle/angular/tree/allow-changing-ngsrc
Conversation 22 https://github.com/angular/angular/pull/50683
Commits 1 https://github.com/angular/angular/pull/50683/commits
Checks 0 https://github.com/angular/angular/pull/50683/checks
Files changed https://github.com/angular/angular/pull/50683/files
Please reload this pagehttps://github.com/angular/angular/pull/50683/files
feat(common): Allow ngSrc to be changed post-init https://github.com/angular/angular/pull/50683/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/50683/files
1ef004f feat(common): Allow ngSrc to be changed post-init atcastle Jun 12, 2023 https://github.com/angular/angular/pull/50683/commits/1ef004ff0ddb2008124da38b6263279c352c2efe
Clear filters https://github.com/angular/angular/pull/50683/files
Please reload this pagehttps://github.com/angular/angular/pull/50683/files
Please reload this pagehttps://github.com/angular/angular/pull/50683/files
errors.md https://github.com/angular/angular/pull/50683/files#diff-0d09f6e92a51749237cde5d441bfdd64a962bab9a25b922861fbaed648351373
lcp_image_observer.ts https://github.com/angular/angular/pull/50683/files#diff-4605789592a14c1fba124f08dbaa8c48f80db8052beb4fc6e5fe136b3643442a
ng_optimized_image.ts https://github.com/angular/angular/pull/50683/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
errors.ts https://github.com/angular/angular/pull/50683/files#diff-b3f127f417ba115081f7791c1ab78f6a143a3287346c90fdfacc22ddf281ebed
ng_optimized_image_spec.ts https://github.com/angular/angular/pull/50683/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
lcp-check.e2e-spec.ts https://github.com/angular/angular/pull/50683/files#diff-9f94113cc38ec8c6320a6cb9659e643be0a9c167e8b42a9c1c2b9f07214065b6
lcp-check.ts https://github.com/angular/angular/pull/50683/files#diff-da6361a16e9ea7e6c7f8775891d8a0b86e20df746f1c0292c6b509ac9f26f08e
goldens/public-api/common/errors.mdhttps://github.com/angular/angular/pull/50683/files#diff-0d09f6e92a51749237cde5d441bfdd64a962bab9a25b922861fbaed648351373
View file https://github.com/atcastle/angular/blob/1ef004ff0ddb2008124da38b6263279c352c2efe/goldens/public-api/common/errors.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50683/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50683/files#diff-0d09f6e92a51749237cde5d441bfdd64a962bab9a25b922861fbaed648351373
https://github.com/angular/angular/pull/50683/files#diff-0d09f6e92a51749237cde5d441bfdd64a962bab9a25b922861fbaed648351373
packages/common/src/directives/ng_optimized_image/lcp_image_observer.tshttps://github.com/angular/angular/pull/50683/files#diff-4605789592a14c1fba124f08dbaa8c48f80db8052beb4fc6e5fe136b3643442a
View file https://github.com/atcastle/angular/blob/1ef004ff0ddb2008124da38b6263279c352c2efe/packages/common/src/directives/ng_optimized_image/lcp_image_observer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50683/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50683/files#diff-4605789592a14c1fba124f08dbaa8c48f80db8052beb4fc6e5fe136b3643442a
https://github.com/angular/angular/pull/50683/files#diff-4605789592a14c1fba124f08dbaa8c48f80db8052beb4fc6e5fe136b3643442a
https://github.com/angular/angular/pull/50683/files#diff-4605789592a14c1fba124f08dbaa8c48f80db8052beb4fc6e5fe136b3643442a
https://github.com/angular/angular/pull/50683/files#diff-4605789592a14c1fba124f08dbaa8c48f80db8052beb4fc6e5fe136b3643442a
https://github.com/angular/angular/pull/50683/files#diff-4605789592a14c1fba124f08dbaa8c48f80db8052beb4fc6e5fe136b3643442a
packages/common/src/directives/ng_optimized_image/ng_optimized_image.tshttps://github.com/angular/angular/pull/50683/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
View file https://github.com/atcastle/angular/blob/1ef004ff0ddb2008124da38b6263279c352c2efe/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50683/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50683/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
https://github.com/angular/angular/pull/50683/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
https://github.com/angular/angular/pull/50683/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
https://github.com/angular/angular/pull/50683/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
https://github.com/angular/angular/pull/50683/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
https://github.com/angular/angular/pull/50683/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
packages/common/src/errors.tshttps://github.com/angular/angular/pull/50683/files#diff-b3f127f417ba115081f7791c1ab78f6a143a3287346c90fdfacc22ddf281ebed
View file https://github.com/atcastle/angular/blob/1ef004ff0ddb2008124da38b6263279c352c2efe/packages/common/src/errors.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50683/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50683/files#diff-b3f127f417ba115081f7791c1ab78f6a143a3287346c90fdfacc22ddf281ebed
packages/common/test/directives/ng_optimized_image_spec.tshttps://github.com/angular/angular/pull/50683/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
View file https://github.com/atcastle/angular/blob/1ef004ff0ddb2008124da38b6263279c352c2efe/packages/common/test/directives/ng_optimized_image_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50683/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50683/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
https://github.com/angular/angular/pull/50683/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
https://github.com/angular/angular/pull/50683/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
https://github.com/angular/angular/pull/50683/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
https://github.com/angular/angular/pull/50683/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
https://github.com/angular/angular/pull/50683/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
packages/core/test/bundling/image-directive/e2e/lcp-check/lcp-check.e2e-spec.tshttps://github.com/angular/angular/pull/50683/files#diff-9f94113cc38ec8c6320a6cb9659e643be0a9c167e8b42a9c1c2b9f07214065b6
View file https://github.com/atcastle/angular/blob/1ef004ff0ddb2008124da38b6263279c352c2efe/packages/core/test/bundling/image-directive/e2e/lcp-check/lcp-check.e2e-spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50683/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50683/files#diff-9f94113cc38ec8c6320a6cb9659e643be0a9c167e8b42a9c1c2b9f07214065b6
packages/core/test/bundling/image-directive/e2e/lcp-check/lcp-check.tshttps://github.com/angular/angular/pull/50683/files#diff-da6361a16e9ea7e6c7f8775891d8a0b86e20df746f1c0292c6b509ac9f26f08e
View file https://github.com/atcastle/angular/blob/1ef004ff0ddb2008124da38b6263279c352c2efe/packages/core/test/bundling/image-directive/e2e/lcp-check/lcp-check.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50683/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50683/files#diff-da6361a16e9ea7e6c7f8775891d8a0b86e20df746f1c0292c6b509ac9f26f08e
https://github.com/angular/angular/pull/50683/files#diff-da6361a16e9ea7e6c7f8775891d8a0b86e20df746f1c0292c6b509ac9f26f08e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.