René's URL Explorer Experiment


Title: fix(platform-server): surface errors during rendering by alan-agius4 · Pull Request #50587 · angular/angular · GitHub

Open Graph Title: fix(platform-server): surface errors during rendering by alan-agius4 · Pull Request #50587 · angular/angular

X Title: fix(platform-server): surface errors during rendering by alan-agius4 · Pull Request #50587 · angular/angular

Description: Prior to this change in some cases errors tht happen during routing were not being surfaced. This is due to the fact that the router has floating promises, and the platform was being destroyed prior to these being settled.

Open Graph Description: Prior to this change in some cases errors tht happen during routing were not being surfaced. This is due to the fact that the router has floating promises, and the platform was being destroyed prio...

X Description: Prior to this change in some cases errors tht happen during routing were not being surfaced. This is due to the fact that the router has floating promises, and the platform was being destroyed prio...

Opengraph URL: https://github.com/angular/angular/pull/50587

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:608429a3-c505-811b-f995-645f3228c801
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD9E2:2C3566:1A1CDD2:2268240:6B0143A8
html-safe-nonce4c0aa8c95e621778abd27bdd3d4f03374fb7719e62b2a8b1fa3e8d7342a74cea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUUyOjJDMzU2NjoxQTFDREQyOjIyNjgyNDA6NkIwMTQzQTgiLCJ2aXNpdG9yX2lkIjoiODE3MDMwNDE2ODU3ODMzNTY1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac34e97a6d1a1e4faaaeabd30ad6e88f1d066d358fab3a7b0efa30c86b6f1f7f77
hovercard-subject-tagpull_request:1380256494
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/50587/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altPrior to this change in some cases errors tht happen during routing were not being surfaced. This is due to the fact that the router has floating promises, and the platform was being destroyed prio...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/50587/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50587%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50587%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/50587/files
Reloadhttps://github.com/angular/angular/pull/50587/files
Reloadhttps://github.com/angular/angular/pull/50587/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular/tree/main
alan-agius4:errors-ssrhttps://github.com/alan-agius4/angular/tree/errors-ssr
Conversation 3 https://github.com/angular/angular/pull/50587
Commits 1 https://github.com/angular/angular/pull/50587/commits
Checks 0 https://github.com/angular/angular/pull/50587/checks
Files changed https://github.com/angular/angular/pull/50587/files
Please reload this pagehttps://github.com/angular/angular/pull/50587/files
fix(platform-server): surface errors during rendering https://github.com/angular/angular/pull/50587/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/50587/files
dab36fc fix(platform-server): surface errors during rendering alan-agius4 Jun 6, 2023 https://github.com/angular/angular/pull/50587/commits/dab36fc60395325fb185433c86b90b289595edd8
Clear filters https://github.com/angular/angular/pull/50587/files
Please reload this pagehttps://github.com/angular/angular/pull/50587/files
Please reload this pagehttps://github.com/angular/angular/pull/50587/files
prerender.ts https://github.com/angular/angular/pull/50587/files#diff-35e3c8c85a519fbcfec8fdc75acfe92b8787dd9cebf3dc618cc68ee36df2366b
server.ts https://github.com/angular/angular/pull/50587/files#diff-d1c9d48f1e826f6aa41694de19842173333e3829be82131e3099a7c1d60b3e7a
app-routing.module.ts https://github.com/angular/angular/pull/50587/files#diff-8235ab973d5b24ab3a23e8b004cbfd4402f7e17b3f04e4ff2ec5ba9d5136c577
prerender.ts https://github.com/angular/angular/pull/50587/files#diff-75652abeda838062cb592f0709583399505d8e1bf1502a1e869271b2ae09830c
server.ts https://github.com/angular/angular/pull/50587/files#diff-0677219992ad5d69f5fdf7d1e312900ed3e69b639f62718216fdda313dbbb544
app-routing.module.ts https://github.com/angular/angular/pull/50587/files#diff-5f1d49385b8f1a45856210ed10c192dc64da10d63240d0a06ee5d942fa320d9f
app.routes.ts https://github.com/angular/angular/pull/50587/files#diff-fb52af8d8b9244df1984b4f42fcf470edf265d26924588fc2e9987efa45c6b96
utils.ts https://github.com/angular/angular/pull/50587/files#diff-123357100da5c09eb9d4e1df15579e76dbb13ecf7abbb33b9e41ff28ff2daeaf
hydration_spec.ts https://github.com/angular/angular/pull/50587/files#diff-af4c8e2af18bf92515f7cb47ed0e7a8be798116a9ca5c1e15f2ba4c3aa7b79b6
integration_spec.ts https://github.com/angular/angular/pull/50587/files#diff-3638ddc0483037fa6db1a6e8d4874358d76e843df722ac5dcb625260d5ff9046
integration/platform-server/projects/ngmodule/prerender.tshttps://github.com/angular/angular/pull/50587/files#diff-35e3c8c85a519fbcfec8fdc75acfe92b8787dd9cebf3dc618cc68ee36df2366b
View file https://github.com/alan-agius4/angular/blob/dab36fc60395325fb185433c86b90b289595edd8/integration/platform-server/projects/ngmodule/prerender.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50587/{{ revealButtonHref }}
integration/platform-server/projects/ngmodule/server.tshttps://github.com/angular/angular/pull/50587/files#diff-d1c9d48f1e826f6aa41694de19842173333e3829be82131e3099a7c1d60b3e7a
View file https://github.com/alan-agius4/angular/blob/dab36fc60395325fb185433c86b90b289595edd8/integration/platform-server/projects/ngmodule/server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50587/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50587/files#diff-d1c9d48f1e826f6aa41694de19842173333e3829be82131e3099a7c1d60b3e7a
https://github.com/angular/angular/pull/50587/files#diff-d1c9d48f1e826f6aa41694de19842173333e3829be82131e3099a7c1d60b3e7a
integration/platform-server/projects/ngmodule/src/app/app-routing.module.tshttps://github.com/angular/angular/pull/50587/files#diff-8235ab973d5b24ab3a23e8b004cbfd4402f7e17b3f04e4ff2ec5ba9d5136c577
View file https://github.com/alan-agius4/angular/blob/dab36fc60395325fb185433c86b90b289595edd8/integration/platform-server/projects/ngmodule/src/app/app-routing.module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50587/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50587/files#diff-8235ab973d5b24ab3a23e8b004cbfd4402f7e17b3f04e4ff2ec5ba9d5136c577
https://github.com/angular/angular/pull/50587/files#diff-8235ab973d5b24ab3a23e8b004cbfd4402f7e17b3f04e4ff2ec5ba9d5136c577
integration/platform-server/projects/standalone/prerender.tshttps://github.com/angular/angular/pull/50587/files#diff-75652abeda838062cb592f0709583399505d8e1bf1502a1e869271b2ae09830c
View file https://github.com/alan-agius4/angular/blob/dab36fc60395325fb185433c86b90b289595edd8/integration/platform-server/projects/standalone/prerender.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50587/{{ revealButtonHref }}
integration/platform-server/projects/standalone/server.tshttps://github.com/angular/angular/pull/50587/files#diff-0677219992ad5d69f5fdf7d1e312900ed3e69b639f62718216fdda313dbbb544
View file https://github.com/alan-agius4/angular/blob/dab36fc60395325fb185433c86b90b289595edd8/integration/platform-server/projects/standalone/server.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50587/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50587/files#diff-0677219992ad5d69f5fdf7d1e312900ed3e69b639f62718216fdda313dbbb544
https://github.com/angular/angular/pull/50587/files#diff-0677219992ad5d69f5fdf7d1e312900ed3e69b639f62718216fdda313dbbb544
integration/platform-server/projects/standalone/src/app/app-routing.module.tshttps://github.com/angular/angular/pull/50587/files#diff-5f1d49385b8f1a45856210ed10c192dc64da10d63240d0a06ee5d942fa320d9f
View file https://github.com/angular/angular/blob/79a706c8476003ce506e61fbd0b14587a99e9257/integration/platform-server/projects/standalone/src/app/app-routing.module.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/angular/angular/pull/50587/files
integration/platform-server/projects/standalone/src/app/app.routes.tshttps://github.com/angular/angular/pull/50587/files#diff-fb52af8d8b9244df1984b4f42fcf470edf265d26924588fc2e9987efa45c6b96
View file https://github.com/alan-agius4/angular/blob/dab36fc60395325fb185433c86b90b289595edd8/integration/platform-server/projects/standalone/src/app/app.routes.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50587/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50587/files#diff-fb52af8d8b9244df1984b4f42fcf470edf265d26924588fc2e9987efa45c6b96
packages/platform-server/src/utils.tshttps://github.com/angular/angular/pull/50587/files#diff-123357100da5c09eb9d4e1df15579e76dbb13ecf7abbb33b9e41ff28ff2daeaf
View file https://github.com/alan-agius4/angular/blob/dab36fc60395325fb185433c86b90b289595edd8/packages/platform-server/src/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50587/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50587/files#diff-123357100da5c09eb9d4e1df15579e76dbb13ecf7abbb33b9e41ff28ff2daeaf
https://github.com/angular/angular/pull/50587/files#diff-123357100da5c09eb9d4e1df15579e76dbb13ecf7abbb33b9e41ff28ff2daeaf
packages/platform-server/test/hydration_spec.tshttps://github.com/angular/angular/pull/50587/files#diff-af4c8e2af18bf92515f7cb47ed0e7a8be798116a9ca5c1e15f2ba4c3aa7b79b6
View file https://github.com/alan-agius4/angular/blob/dab36fc60395325fb185433c86b90b289595edd8/packages/platform-server/test/hydration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50587/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50587/files#diff-af4c8e2af18bf92515f7cb47ed0e7a8be798116a9ca5c1e15f2ba4c3aa7b79b6
https://github.com/angular/angular/pull/50587/files#diff-af4c8e2af18bf92515f7cb47ed0e7a8be798116a9ca5c1e15f2ba4c3aa7b79b6
https://github.com/angular/angular/pull/50587/files#diff-af4c8e2af18bf92515f7cb47ed0e7a8be798116a9ca5c1e15f2ba4c3aa7b79b6
https://github.com/angular/angular/pull/50587/files#diff-af4c8e2af18bf92515f7cb47ed0e7a8be798116a9ca5c1e15f2ba4c3aa7b79b6
https://github.com/angular/angular/pull/50587/files#diff-af4c8e2af18bf92515f7cb47ed0e7a8be798116a9ca5c1e15f2ba4c3aa7b79b6
https://github.com/angular/angular/pull/50587/files#diff-af4c8e2af18bf92515f7cb47ed0e7a8be798116a9ca5c1e15f2ba4c3aa7b79b6
https://github.com/angular/angular/pull/50587/files#diff-af4c8e2af18bf92515f7cb47ed0e7a8be798116a9ca5c1e15f2ba4c3aa7b79b6
https://github.com/angular/angular/pull/50587/files#diff-af4c8e2af18bf92515f7cb47ed0e7a8be798116a9ca5c1e15f2ba4c3aa7b79b6
packages/platform-server/test/integration_spec.tshttps://github.com/angular/angular/pull/50587/files#diff-3638ddc0483037fa6db1a6e8d4874358d76e843df722ac5dcb625260d5ff9046
View file https://github.com/alan-agius4/angular/blob/dab36fc60395325fb185433c86b90b289595edd8/packages/platform-server/test/integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50587/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50587/files#diff-3638ddc0483037fa6db1a6e8d4874358d76e843df722ac5dcb625260d5ff9046
https://github.com/angular/angular/pull/50587/files#diff-3638ddc0483037fa6db1a6e8d4874358d76e843df722ac5dcb625260d5ff9046
https://github.com/angular/angular/pull/50587/files#diff-3638ddc0483037fa6db1a6e8d4874358d76e843df722ac5dcb625260d5ff9046
https://github.com/angular/angular/pull/50587/files#diff-3638ddc0483037fa6db1a6e8d4874358d76e843df722ac5dcb625260d5ff9046
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.