René's URL Explorer Experiment


Title: fix(compiler): do not remove comments in component styles by alan-agius4 · Pull Request #50346 · angular/angular · GitHub

Open Graph Title: fix(compiler): do not remove comments in component styles by alan-agius4 · Pull Request #50346 · angular/angular

X Title: fix(compiler): do not remove comments in component styles by alan-agius4 · Pull Request #50346 · angular/angular

Description: Prior to this commit, comments in CSS were being removed. This caused inline sourcemaps to break to the shift in lines. This caused sourcemaps to break in the ESBuild based builder as this always adds comments at the top of the file with the filename. Example /* src/app/app.component.scss */ * { color: red; background: transparent; } /*# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJzb3VyY2VzIjpbIndlYnBhY2s6Ly8uL3NyYy9hcHAvYXBwLmNvbXBvbmVudC5zY3NzIl0sIm5hbWVzIjpbXSwibWFwcGluZ3MiOiJBQUNBOzs7Ozs7Ozs7Q0FBQTtBQVdBO0VBQ0UsVUFBQTtFQUNBLHVCQUFBO0FBREYiLCJzb3VyY2VzQ29udGVudCI6WyIvL01FRElBIFFVRVJZIE1BTkFHRVJcbi8qXG4gIDAgLSA2MDA6IFBob25lXG4gIDYwMCAtIDkwMDogVGFibGV0IHBvcnRyYWl0XG4gIDkwMCAtIDEyMDA6IFRhYmxldCBsYW5kc2NhcGVcbiAgMTIwMCAtIDE4MDA6IE5vcm1hbCBzdHlsZXNcbiAgMTgwMCsgOiBCaWcgRGVza3RvcFxuICAxZW0gPSAxNnB4XG4gIFRoZSBzbWFsbGVyIGRldmljZSBydWxlcyBhbHdheXMgc2hvdWxkIHdyaXRlIGJlbG93IHRoZSBiaWdnZXIgZGV2aWNlIHJ1bGVzXG4gIEZpeGluZyBPcmRlciA9PiBCYXNlICsgVHlwb2dyYXBoeSA+PiBHZW5lcmFsIExheW91dCArIEdyaWQgPj4gUGFnZSBMYXlvdXQgKyBDb21wb25lbnRcbiovXG5cbioge1xuICBjb2xvcjogcmVkO1xuICBiYWNrZ3JvdW5kOiB0cmFuc3BhcmVudDtcbn1cbiJdLCJzb3VyY2VSb290IjoiIn0= */ Closes #50308

Open Graph Description: Prior to this commit, comments in CSS were being removed. This caused inline sourcemaps to break to the shift in lines. This caused sourcemaps to break in the ESBuild based builder as this always a...

X Description: Prior to this commit, comments in CSS were being removed. This caused inline sourcemaps to break to the shift in lines. This caused sourcemaps to break in the ESBuild based builder as this always a...

Opengraph URL: https://github.com/angular/angular/pull/50346

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1dd6714a-9298-e69b-937d-87cd2feac0a3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD1B4:154D88:FB54D3:13FEA51:6B014E48
html-safe-nonce46caa93e78e2c73b9efbb3ceef9bf16bba1b0af7577ff13413add7ff5e5026d5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUI0OjE1NEQ4ODpGQjU0RDM6MTNGRUE1MTo2QjAxNEU0OCIsInZpc2l0b3JfaWQiOiI0OTQxMDI0MjQwMzA2Mjk0NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac439fd0d63f74664ed68b33df5946bb614a99da36d039a4a57301da06ed23124c
hovercard-subject-tagpull_request:1354168353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/50346/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altPrior to this commit, comments in CSS were being removed. This caused inline sourcemaps to break to the shift in lines. This caused sourcemaps to break in the ESBuild based builder as this always a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/50346/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50346%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50346%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/50346/files
Reloadhttps://github.com/angular/angular/pull/50346/files
Reloadhttps://github.com/angular/angular/pull/50346/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alan-agius4https://github.com/alan-agius4
angular:mainhttps://github.com/angular/angular/tree/main
alan-agius4:comments-in-csshttps://github.com/alan-agius4/angular/tree/comments-in-css
Conversation 4 https://github.com/angular/angular/pull/50346
Commits 1 https://github.com/angular/angular/pull/50346/commits
Checks 0 https://github.com/angular/angular/pull/50346/checks
Files changed https://github.com/angular/angular/pull/50346/files
Please reload this pagehttps://github.com/angular/angular/pull/50346/files
fix(compiler): do not remove comments in component styles https://github.com/angular/angular/pull/50346/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/50346/files
5627c13 fix(compiler): do not remove comments in component styles alan-agius4 May 25, 2023 https://github.com/angular/angular/pull/50346/commits/5627c1312aa7234e404d5f0215059f0a7b087bf4
Clear filters https://github.com/angular/angular/pull/50346/files
Please reload this pagehttps://github.com/angular/angular/pull/50346/files
Please reload this pagehttps://github.com/angular/angular/pull/50346/files
shadow_css.ts https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
shadow_css_spec.ts https://github.com/angular/angular/pull/50346/files#diff-6a1bd485d0a2c5859de1db7ac9f6ea3b905380e7a54a1650ef75ba2ed62a70ea
packages/compiler/src/shadow_css.tshttps://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
View file https://github.com/alan-agius4/angular/blob/5627c1312aa7234e404d5f0215059f0a7b087bf4/packages/compiler/src/shadow_css.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50346/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
https://github.com/angular/angular/pull/50346/files#diff-6051c2c8a3dc4a133880a8344097be738955132464028402155390c38e0ad18a
packages/compiler/test/shadow_css/shadow_css_spec.tshttps://github.com/angular/angular/pull/50346/files#diff-6a1bd485d0a2c5859de1db7ac9f6ea3b905380e7a54a1650ef75ba2ed62a70ea
View file https://github.com/alan-agius4/angular/blob/5627c1312aa7234e404d5f0215059f0a7b087bf4/packages/compiler/test/shadow_css/shadow_css_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50346/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50346/files#diff-6a1bd485d0a2c5859de1db7ac9f6ea3b905380e7a54a1650ef75ba2ed62a70ea
https://github.com/angular/angular/pull/50346/files#diff-6a1bd485d0a2c5859de1db7ac9f6ea3b905380e7a54a1650ef75ba2ed62a70ea
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.