René's URL Explorer Experiment


Title: refactor(forms): remove unnecessary Array.from by garrettld · Pull Request #50314 · angular/angular · GitHub

Open Graph Title: refactor(forms): remove unnecessary Array.from by garrettld · Pull Request #50314 · angular/angular

X Title: refactor(forms): remove unnecessary Array.from by garrettld · Pull Request #50314 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Map.prototype.keys returns an iterator, so the Array.from is unnecessary overhead since all we're doing with it is iterating. What is the new behavior? No more unnecessary array copy. Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

Opengraph URL: https://github.com/angular/angular/pull/50314

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a3418d12-0d1a-3e69-44b9-e3c6d05d505a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA038:B53AF:19AE548:222A98F:6B01518A
html-safe-nonce7905e560de717c136f2d937cd85730490d27ab6c7761995a3b64937cb3e35d0d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDM4OkI1M0FGOjE5QUU1NDg6MjIyQTk4Rjo2QjAxNTE4QSIsInZpc2l0b3JfaWQiOiIzMDg0MDYzMjYyMjQ1OTk4OTg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdf322a48bdd162a13a429b7122cb4e07e4cfbbfbceef2ca2b2a52ca4c9626192
hovercard-subject-tagpull_request:1351415940
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/50314/files
twitter:imagehttps://avatars.githubusercontent.com/u/12160067?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12160067?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/50314/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50314%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50314%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/50314/files
Reloadhttps://github.com/angular/angular/pull/50314/files
Reloadhttps://github.com/angular/angular/pull/50314/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
garrettldhttps://github.com/garrettld
angular:mainhttps://github.com/angular/angular/tree/main
garrettld:unnecessary-array-fromhttps://github.com/garrettld/angular/tree/unnecessary-array-from
Conversation 5 https://github.com/angular/angular/pull/50314
Commits 1 https://github.com/angular/angular/pull/50314/commits
Checks 0 https://github.com/angular/angular/pull/50314/checks
Files changed https://github.com/angular/angular/pull/50314/files
Please reload this pagehttps://github.com/angular/angular/pull/50314/files
refactor(forms): remove unnecessary Array.from https://github.com/angular/angular/pull/50314/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/50314/files
f6da0f2 refactor(forms): remove unnecessary Array.from garrettld May 15, 2023 https://github.com/angular/angular/pull/50314/commits/f6da0f2d0bcb64219ebf16cb57294c3a64d5b6f7
Clear filters https://github.com/angular/angular/pull/50314/files
Please reload this pagehttps://github.com/angular/angular/pull/50314/files
Please reload this pagehttps://github.com/angular/angular/pull/50314/files
select_control_value_accessor.ts https://github.com/angular/angular/pull/50314/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
select_multiple_control_value_accessor.ts https://github.com/angular/angular/pull/50314/files#diff-b4e0fccf9fce3a572ea1fc8e63b2d15f8991513572b4adef7b1ce6d80ce48141
packages/forms/src/directives/select_control_value_accessor.tshttps://github.com/angular/angular/pull/50314/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
View file https://github.com/garrettld/angular/blob/f6da0f2d0bcb64219ebf16cb57294c3a64d5b6f7/packages/forms/src/directives/select_control_value_accessor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50314/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50314/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
https://github.com/angular/angular/pull/50314/files#diff-209cd7288095cb940bbade90e2ff5051d82dfa7b23b1b0d781951e3b71c4dfb9
packages/forms/src/directives/select_multiple_control_value_accessor.tshttps://github.com/angular/angular/pull/50314/files#diff-b4e0fccf9fce3a572ea1fc8e63b2d15f8991513572b4adef7b1ce6d80ce48141
View file https://github.com/garrettld/angular/blob/f6da0f2d0bcb64219ebf16cb57294c3a64d5b6f7/packages/forms/src/directives/select_multiple_control_value_accessor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50314/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50314/files#diff-b4e0fccf9fce3a572ea1fc8e63b2d15f8991513572b4adef7b1ce6d80ce48141
https://github.com/angular/angular/pull/50314/files#diff-b4e0fccf9fce3a572ea1fc8e63b2d15f8991513572b4adef7b1ce6d80ce48141
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.