René's URL Explorer Experiment


Title: refactor(core): avoid using `def.signal` during component id computation by AndrewKushnir · Pull Request #50238 · angular/angular · GitHub

Open Graph Title: refactor(core): avoid using `def.signal` during component id computation by AndrewKushnir · Pull Request #50238 · angular/angular

X Title: refactor(core): avoid using `def.signal` during component id computation by AndrewKushnir · Pull Request #50238 · angular/angular

Description: This commit updates the code in 16.0.x branch to avoid using the def.signals field on a component, while calculating component id. The signal field was introduced later and will be available in 16.1.0. PR Type What kind of change does this PR introduce? Refactoring (no functional changes, no api changes) Does this PR introduce a breaking change? Yes No

Open Graph Description: This commit updates the code in 16.0.x branch to avoid using the def.signals field on a component, while calculating component id. The signal field was introduced later and will be available in 16....

X Description: This commit updates the code in 16.0.x branch to avoid using the def.signals field on a component, while calculating component id. The signal field was introduced later and will be available in 16....

Opengraph URL: https://github.com/angular/angular/pull/50238

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9eff2773-650e-fac9-6ca2-98e7e0a0e3ed
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE920:1D86C4:1D5496C:2537C3E:6B015D5B
html-safe-nonce77f2ba44f1a36a8514d7ec509ce43593d23954306646ba4aeff9edd6f5eececc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTIwOjFEODZDNDoxRDU0OTZDOjI1MzdDM0U6NkIwMTVENUIiLCJ2aXNpdG9yX2lkIjoiMjcxMjUxOTY0NzM1NzM5NDI2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac02c6fa0213918d759d13967b1c9471318b2345d2239d186fda51dc0bed98dbc5
hovercard-subject-tagpull_request:1345808143
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/50238/files
twitter:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
og:image:altThis commit updates the code in 16.0.x branch to avoid using the def.signals field on a component, while calculating component id. The signal field was introduced later and will be available in 16....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/50238/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50238%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50238%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/50238/files
Reloadhttps://github.com/angular/angular/pull/50238/files
Reloadhttps://github.com/angular/angular/pull/50238/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
AndrewKushnirhttps://github.com/AndrewKushnir
angular:16.0.xhttps://github.com/angular/angular/tree/16.0.x
AndrewKushnir:drop_signals_fieldhttps://github.com/AndrewKushnir/angular/tree/drop_signals_field
Conversation 2 https://github.com/angular/angular/pull/50238
Commits 1 https://github.com/angular/angular/pull/50238/commits
Checks 0 https://github.com/angular/angular/pull/50238/checks
Files changed https://github.com/angular/angular/pull/50238/files
Please reload this pagehttps://github.com/angular/angular/pull/50238/files
refactor(core): avoid using def.signal during component id computation https://github.com/angular/angular/pull/50238/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/50238/files
b0d5b25 refactor(core): avoid using `def.signal` during component id computation AndrewKushnir May 10, 2023 https://github.com/angular/angular/pull/50238/commits/b0d5b253ec13fd1fb4ba185ee9b573cab6adfd34
Clear filters https://github.com/angular/angular/pull/50238/files
Please reload this pagehttps://github.com/angular/angular/pull/50238/files
Please reload this pagehttps://github.com/angular/angular/pull/50238/files
packages/core/src/render3/definition.tshttps://github.com/angular/angular/pull/50238/files#diff-4374dd238deae3e4714315fc97bb9983092ada87475d8e0b8d28e191571941de
View file https://github.com/AndrewKushnir/angular/blob/b0d5b253ec13fd1fb4ba185ee9b573cab6adfd34/packages/core/src/render3/definition.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50238/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50238/files#diff-4374dd238deae3e4714315fc97bb9983092ada87475d8e0b8d28e191571941de
https://github.com/angular/angular/pull/50238/files#diff-4374dd238deae3e4714315fc97bb9983092ada87475d8e0b8d28e191571941de
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.