René's URL Explorer Experiment


Title: fix(core): allow onDestroy unregistration while destroying by garrettld · Pull Request #50237 · angular/angular · GitHub

Open Graph Title: fix(core): allow onDestroy unregistration while destroying by garrettld · Pull Request #50237 · angular/angular

X Title: fix(core): allow onDestroy unregistration while destroying by garrettld · Pull Request #50237 · angular/angular

Description: Ensure that all onDestroy callbacks are called by allowing unregistering of onDestroy hooks while destroying. Fixes #50221 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? onDestroy callbacks that unregister themselves when called will cause the next onDestroy callback to be skipped. Issue Number: #50221 What is the new behavior? All onDestroy callbacks that are present when the destroy process starts will be called, regardless of any unregistration that may occur while destroying. Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: Ensure that all onDestroy callbacks are called by allowing unregistering of onDestroy hooks while destroying. Fixes #50221 PR Checklist Please check if your PR fulfills the following requirements: ...

X Description: Ensure that all onDestroy callbacks are called by allowing unregistering of onDestroy hooks while destroying. Fixes #50221 PR Checklist Please check if your PR fulfills the following requirements: ...

Opengraph URL: https://github.com/angular/angular/pull/50237

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ace1fdc7-7ecd-9294-afec-8bd75f1f719f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD932:172B92:191CDBA:217A98D:6B014ED5
html-safe-noncea61a78cea6322b95cfcbc097ecd10d63be1633cfede7de464079984a53e725c7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTMyOjE3MkI5MjoxOTFDREJBOjIxN0E5OEQ6NkIwMTRFRDUiLCJ2aXNpdG9yX2lkIjoiNDA1NDk2NDA5NTc5ODAzODIyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf4abe1dbfecb6f576442fa609dfbc1d63a41cdf5bf127df5708d4440bd871b37
hovercard-subject-tagpull_request:1345750431
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/50237/files
twitter:imagehttps://avatars.githubusercontent.com/u/12160067?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12160067?s=400&v=4
og:image:altEnsure that all onDestroy callbacks are called by allowing unregistering of onDestroy hooks while destroying. Fixes #50221 PR Checklist Please check if your PR fulfills the following requirements: ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/50237/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50237%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50237%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/50237/files
Reloadhttps://github.com/angular/angular/pull/50237/files
Reloadhttps://github.com/angular/angular/pull/50237/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
garrettldhttps://github.com/garrettld
angular:mainhttps://github.com/angular/angular/tree/main
garrettld:on-destroy-hookshttps://github.com/garrettld/angular/tree/on-destroy-hooks
Conversation 13 https://github.com/angular/angular/pull/50237
Commits 4 https://github.com/angular/angular/pull/50237/commits
Checks 0 https://github.com/angular/angular/pull/50237/checks
Files changed https://github.com/angular/angular/pull/50237/files
Please reload this pagehttps://github.com/angular/angular/pull/50237/files
fix(core): allow onDestroy unregistration while destroying https://github.com/angular/angular/pull/50237/files#top
Show all changes 4 commits https://github.com/angular/angular/pull/50237/files
4bb3d66 fix(core): allow onDestroy unregistration while destroying garrettld May 10, 2023 https://github.com/angular/angular/pull/50237/commits/4bb3d668db35f78bf27bcce1ff9d227c53464cf8
2950c8b fixup! fix(core): allow onDestroy unregistration while destroying garrettld May 10, 2023 https://github.com/angular/angular/pull/50237/commits/2950c8ba0f0cc5c59bf2d9b3475304d4d58ffafa
f2753b5 fixup! fix(core): allow onDestroy unregistration while destroying garrettld May 10, 2023 https://github.com/angular/angular/pull/50237/commits/f2753b5ea1780152682a2bd5625826d592694e59
7624701 fixup! fix(core): allow onDestroy unregistration while destroying garrettld May 11, 2023 https://github.com/angular/angular/pull/50237/commits/7624701daca02b60b72ba53f8ce5cab896ec34f5
Clear filters https://github.com/angular/angular/pull/50237/files
Please reload this pagehttps://github.com/angular/angular/pull/50237/files
Please reload this pagehttps://github.com/angular/angular/pull/50237/files
r3_injector.ts https://github.com/angular/angular/pull/50237/files#diff-792b321986ec7f172dec2069c1c68e59e1394ebe04ee8ec15abb8f45fe00ba05
node_manipulation.ts https://github.com/angular/angular/pull/50237/files#diff-79892420ae2137fbd923532484f7415474066714db2d4d342192d4cf3984cf18
destroy_ref_spec.ts https://github.com/angular/angular/pull/50237/files#diff-354255601db72a07c53f4a612171dedb9ae23574dd12851c966da31e0dc2717d
environment_injector_spec.ts https://github.com/angular/angular/pull/50237/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
packages/core/src/di/r3_injector.tshttps://github.com/angular/angular/pull/50237/files#diff-792b321986ec7f172dec2069c1c68e59e1394ebe04ee8ec15abb8f45fe00ba05
View file https://github.com/garrettld/angular/blob/7624701daca02b60b72ba53f8ce5cab896ec34f5/packages/core/src/di/r3_injector.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50237/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50237/files#diff-792b321986ec7f172dec2069c1c68e59e1394ebe04ee8ec15abb8f45fe00ba05
https://github.com/angular/angular/pull/50237/files#diff-792b321986ec7f172dec2069c1c68e59e1394ebe04ee8ec15abb8f45fe00ba05
packages/core/src/render3/node_manipulation.tshttps://github.com/angular/angular/pull/50237/files#diff-79892420ae2137fbd923532484f7415474066714db2d4d342192d4cf3984cf18
View file https://github.com/garrettld/angular/blob/7624701daca02b60b72ba53f8ce5cab896ec34f5/packages/core/src/render3/node_manipulation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50237/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50237/files#diff-79892420ae2137fbd923532484f7415474066714db2d4d342192d4cf3984cf18
https://github.com/angular/angular/pull/50237/files#diff-79892420ae2137fbd923532484f7415474066714db2d4d342192d4cf3984cf18
packages/core/test/acceptance/destroy_ref_spec.tshttps://github.com/angular/angular/pull/50237/files#diff-354255601db72a07c53f4a612171dedb9ae23574dd12851c966da31e0dc2717d
View file https://github.com/garrettld/angular/blob/7624701daca02b60b72ba53f8ce5cab896ec34f5/packages/core/test/acceptance/destroy_ref_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50237/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50237/files#diff-354255601db72a07c53f4a612171dedb9ae23574dd12851c966da31e0dc2717d
packages/core/test/acceptance/environment_injector_spec.tshttps://github.com/angular/angular/pull/50237/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
View file https://github.com/garrettld/angular/blob/7624701daca02b60b72ba53f8ce5cab896ec34f5/packages/core/test/acceptance/environment_injector_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50237/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50237/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
https://github.com/angular/angular/pull/50237/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
https://github.com/angular/angular/pull/50237/files#diff-428abc119407cf383180fe0a6e65b79843960de5445e841bb17ec2e4005d3073
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.