René's URL Explorer Experiment


Title: fix(core): toSignal accepts Subscribable (in addition to Observable) by divdavem · Pull Request #50162 · angular/angular · GitHub

Open Graph Title: fix(core): toSignal accepts Subscribable (in addition to Observable) by divdavem · Pull Request #50162 · angular/angular

X Title: fix(core): toSignal accepts Subscribable (in addition to Observable) by divdavem · Pull Request #50162 · angular/angular

Description: This PR extends toSignal to accept any Subscribable (instead of only Observable) for consistency with AsyncPipe and for broader compatibility with any observable library (that is compatible with the Subscribable interface). This is only a type change as the implementation does not use anything else than the Subscribable interface anyway. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? toSignal only accepts Observable. What is the new behavior? toSignal accepts any Subscribable. Does this PR introduce a breaking change? Yes No Other information This PR is similar to PR 39627 that I had opened for AsyncPipe.

Open Graph Description: This PR extends toSignal to accept any Subscribable (instead of only Observable) for consistency with AsyncPipe and for broader compatibility with any observable library (that is compatible with th...

X Description: This PR extends toSignal to accept any Subscribable (instead of only Observable) for consistency with AsyncPipe and for broader compatibility with any observable library (that is compatible with th...

Opengraph URL: https://github.com/angular/angular/pull/50162

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a0043995-3168-dce7-9fb7-8d9aabb68e2e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB022:27D3AD:1AF8D21:2239E7C:6B014E14
html-safe-nonce6ec31fb145aad7f2f73a85b518faf1f03b6dea4496daacd75e4213c946090afb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDIyOjI3RDNBRDoxQUY4RDIxOjIyMzlFN0M6NkIwMTRFMTQiLCJ2aXNpdG9yX2lkIjoiNjIxODcxMTc1ODQ1MDgwNjI5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac214a2fdec1f2196deea68b2acbabbb5d4ff0bfc54d030c4727f9d1b1bad2598d
hovercard-subject-tagpull_request:1339829566
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/50162/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152706?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152706?s=400&v=4
og:image:altThis PR extends toSignal to accept any Subscribable (instead of only Observable) for consistency with AsyncPipe and for broader compatibility with any observable library (that is compatible with th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/50162/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50162%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50162%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/50162/files
Reloadhttps://github.com/angular/angular/pull/50162/files
Reloadhttps://github.com/angular/angular/pull/50162/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
divdavemhttps://github.com/divdavem
angular:mainhttps://github.com/angular/angular/tree/main
divdavem:toSignalForSubscribablehttps://github.com/divdavem/angular/tree/toSignalForSubscribable
Conversation 13 https://github.com/angular/angular/pull/50162
Commits 1 https://github.com/angular/angular/pull/50162/commits
Checks 0 https://github.com/angular/angular/pull/50162/checks
Files changed https://github.com/angular/angular/pull/50162/files
Please reload this pagehttps://github.com/angular/angular/pull/50162/files
fix(core): toSignal accepts Subscribable (in addition to Observable) https://github.com/angular/angular/pull/50162/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/50162/files
8b6b190 fix(core): extend toSignal to accept any Subscribable divdavem May 5, 2023 https://github.com/angular/angular/pull/50162/commits/8b6b190de9680f34f443903eb99b2899d9c92ad2
Clear filters https://github.com/angular/angular/pull/50162/files
Please reload this pagehttps://github.com/angular/angular/pull/50162/files
Please reload this pagehttps://github.com/angular/angular/pull/50162/files
index.md https://github.com/angular/angular/pull/50162/files#diff-90f149f8132bdfb5ad304aca758b2006175bd63d041475e17e98a705732351a2
to_signal.ts https://github.com/angular/angular/pull/50162/files#diff-d7781989c37f0833d37b7b7ffa296f6558194e9d2ec037e926caea5dc2329ca2
goldens/public-api/core/rxjs-interop/index.mdhttps://github.com/angular/angular/pull/50162/files#diff-90f149f8132bdfb5ad304aca758b2006175bd63d041475e17e98a705732351a2
View file https://github.com/divdavem/angular/blob/8b6b190de9680f34f443903eb99b2899d9c92ad2/goldens/public-api/core/rxjs-interop/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50162/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50162/files#diff-90f149f8132bdfb5ad304aca758b2006175bd63d041475e17e98a705732351a2
https://github.com/angular/angular/pull/50162/files#diff-90f149f8132bdfb5ad304aca758b2006175bd63d041475e17e98a705732351a2
https://github.com/angular/angular/pull/50162/files#diff-90f149f8132bdfb5ad304aca758b2006175bd63d041475e17e98a705732351a2
packages/core/rxjs-interop/src/to_signal.tshttps://github.com/angular/angular/pull/50162/files#diff-d7781989c37f0833d37b7b7ffa296f6558194e9d2ec037e926caea5dc2329ca2
View file https://github.com/divdavem/angular/blob/8b6b190de9680f34f443903eb99b2899d9c92ad2/packages/core/rxjs-interop/src/to_signal.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50162/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50162/files#diff-d7781989c37f0833d37b7b7ffa296f6558194e9d2ec037e926caea5dc2329ca2
https://github.com/angular/angular/pull/50162/files#diff-d7781989c37f0833d37b7b7ffa296f6558194e9d2ec037e926caea5dc2329ca2
https://github.com/angular/angular/pull/50162/files#diff-d7781989c37f0833d37b7b7ffa296f6558194e9d2ec037e926caea5dc2329ca2
JeanMechehttps://github.com/JeanMeche
May 5, 2023https://github.com/angular/angular/pull/50162/files#r1186056018
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/50162/files
divdavemhttps://github.com/divdavem
May 5, 2023https://github.com/angular/angular/pull/50162/files#r1186063572
Please reload this pagehttps://github.com/angular/angular/pull/50162/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
this code in PipeAsynchttps://github.com/angular/angular/blob/80fe08be96633171567e30eb91dd1d23c60a2952/packages/common/src/pipes/async_pipe.ts#LL106C3-L110C71
a bughttps://github.com/microsoft/TypeScript/issues/43643
Please reload this pagehttps://github.com/angular/angular/pull/50162/files
https://github.com/angular/angular/pull/50162/files#diff-d7781989c37f0833d37b7b7ffa296f6558194e9d2ec037e926caea5dc2329ca2
https://github.com/angular/angular/pull/50162/files#diff-d7781989c37f0833d37b7b7ffa296f6558194e9d2ec037e926caea5dc2329ca2
https://github.com/angular/angular/pull/50162/files#diff-d7781989c37f0833d37b7b7ffa296f6558194e9d2ec037e926caea5dc2329ca2
https://github.com/angular/angular/pull/50162/files#diff-d7781989c37f0833d37b7b7ffa296f6558194e9d2ec037e926caea5dc2329ca2
https://github.com/angular/angular/pull/50162/files#diff-d7781989c37f0833d37b7b7ffa296f6558194e9d2ec037e926caea5dc2329ca2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.