René's URL Explorer Experiment


Title: refactor(platform-server): import xhr2 dynamically in the ServerXhr class by AndrewKushnir · Pull Request #50095 · angular/angular · GitHub

Open Graph Title: refactor(platform-server): import xhr2 dynamically in the ServerXhr class by AndrewKushnir · Pull Request #50095 · angular/angular

X Title: refactor(platform-server): import xhr2 dynamically in the ServerXhr class by AndrewKushnir · Pull Request #50095 · angular/angular

Description: This commit updates the @angular/common/http and @angular/platform-server packages to allow dynamic import of the xhr2 dependency. The xhr2 dependency has side-effects that rely on a global scope and as a result in some environments those side-effectful calls fail. With the changes from this PR, the import is delayed until it's actually needed, which gives a chance for the underlying platform to setup global scope (via shims) as needed. PR Type What kind of change does this PR introduce? Feature Does this PR introduce a breaking change? Yes No

Open Graph Description: This commit updates the @angular/common/http and @angular/platform-server packages to allow dynamic import of the xhr2 dependency. The xhr2 dependency has side-effects that rely on a global scope a...

X Description: This commit updates the @angular/common/http and @angular/platform-server packages to allow dynamic import of the xhr2 dependency. The xhr2 dependency has side-effects that rely on a global scope a...

Opengraph URL: https://github.com/angular/angular/pull/50095

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:78fef86a-3c57-f646-33d0-13a9ea5ed776
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9772:2652DC:20B186E:29AEB54:6B015F32
html-safe-nonce81c0360cbe8782d0354acbc519b7e6738bf4afb19d1a3a01f8693f94d18ff2f5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzcyOjI2NTJEQzoyMEIxODZFOjI5QUVCNTQ6NkIwMTVGMzIiLCJ2aXNpdG9yX2lkIjoiNzQ2NzE0NzA5MDgzODI0OTI2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0decf9bdded364500841a08a33a16d2c1a6c243328998ebc5f519c7a5c0e4124
hovercard-subject-tagpull_request:1334375500
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/50095/files
twitter:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
og:image:altThis commit updates the @angular/common/http and @angular/platform-server packages to allow dynamic import of the xhr2 dependency. The xhr2 dependency has side-effects that rely on a global scope a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/50095/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50095%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50095%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/50095/files
Reloadhttps://github.com/angular/angular/pull/50095/files
Reloadhttps://github.com/angular/angular/pull/50095/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
AndrewKushnirhttps://github.com/AndrewKushnir
angular:mainhttps://github.com/angular/angular/tree/main
AndrewKushnir:server-http-shimhttps://github.com/AndrewKushnir/angular/tree/server-http-shim
Conversation 18 https://github.com/angular/angular/pull/50095
Commits 2 https://github.com/angular/angular/pull/50095/commits
Checks 0 https://github.com/angular/angular/pull/50095/checks
Files changed https://github.com/angular/angular/pull/50095/files
Please reload this pagehttps://github.com/angular/angular/pull/50095/files
refactor(platform-server): import xhr2 dynamically in the ServerXhr class https://github.com/angular/angular/pull/50095/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/50095/files
2a2e0f0 refactor(platform-server): import `xhr2` dynamically in the ServerXhr… AndrewKushnir May 1, 2023 https://github.com/angular/angular/pull/50095/commits/2a2e0f09de4bd134b24d37fbe32e772db28df48e
b63245f fixup! refactor(platform-server): import `xhr2` dynamically in the Se… alan-agius4 May 4, 2023 https://github.com/angular/angular/pull/50095/commits/b63245f7acd6592a50bd04f77ca9d58906af1a70
Clear filters https://github.com/angular/angular/pull/50095/files
Please reload this pagehttps://github.com/angular/angular/pull/50095/files
Please reload this pagehttps://github.com/angular/angular/pull/50095/files
angular.json https://github.com/angular/angular/pull/50095/files#diff-4ceebf05eae3b62d595d44d702972c8fce99644ad1dfcb630676a3fbe97f5f9f
xhr.ts https://github.com/angular/angular/pull/50095/files#diff-e7ce3f264bdc649b7239372235037b6583fcd4d06c87c179021aad7778938cc3
http.ts https://github.com/angular/angular/pull/50095/files#diff-59ba639df10e46a77d57c27c6ba99e3f5685534ee951b412f3642ff09947b254
types.d.ts https://github.com/angular/angular/pull/50095/files#diff-721f9aa4592bcaef60d590f3717afcb2c9ae0213ab305ec8be9c256ed4ba0df7
integration/platform-server/angular.jsonhttps://github.com/angular/angular/pull/50095/files#diff-4ceebf05eae3b62d595d44d702972c8fce99644ad1dfcb630676a3fbe97f5f9f
View file https://github.com/AndrewKushnir/angular/blob/b63245f7acd6592a50bd04f77ca9d58906af1a70/integration/platform-server/angular.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50095/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50095/files#diff-4ceebf05eae3b62d595d44d702972c8fce99644ad1dfcb630676a3fbe97f5f9f
https://github.com/angular/angular/pull/50095/files#diff-4ceebf05eae3b62d595d44d702972c8fce99644ad1dfcb630676a3fbe97f5f9f
https://github.com/angular/angular/pull/50095/files#diff-4ceebf05eae3b62d595d44d702972c8fce99644ad1dfcb630676a3fbe97f5f9f
https://github.com/angular/angular/pull/50095/files#diff-4ceebf05eae3b62d595d44d702972c8fce99644ad1dfcb630676a3fbe97f5f9f
Please reload this pagehttps://github.com/angular/angular/pull/50095/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.