René's URL Explorer Experiment


Title: refactor(compiler-cli): add back ngcc as a no-op with a warning by leosvelperez · Pull Request #50045 · angular/angular · GitHub

Open Graph Title: refactor(compiler-cli): add back ngcc as a no-op with a warning by leosvelperez · Pull Request #50045 · angular/angular

X Title: refactor(compiler-cli): add back ngcc as a no-op with a warning by leosvelperez · Pull Request #50045 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A The Angular Compatibility Compiler is removed in Angular 16 and therefore, ngcc is no longer available in users' workspaces. In some setups, ngcc is invoked in the postinstall script of the package.json. When updating Angular, in scenarios where postinstall is run (e.g. Nx migrations), this throws an error before a migration can remove the ngcc invocation. This makes the update process to be more complicated. What is the new behavior? ngcc is available as a no-op operation. When invoked, it will warn, providing details about removing ngcc. It gives some context at the tool level to folks who haven't caught up with news that ngcc was removed. Note: In Angular 17, this will be removed. Does this PR introduce a breaking change? Yes No Other information I chose to inline some slightly modified functionality from chalk for the colors in the console. I did that to avoid adding an extra dependency for this. I'm open to adding the dependency instead or implementing a different way to get colors in the console in a cross-platform way if preferred.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

Opengraph URL: https://github.com/angular/angular/pull/50045

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dee61d7e-c86c-51c7-adb5-8e9d3e70046c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9E4:213839:1C6E101:2458FA6:6B014956
html-safe-nonceacb32267d206c542d86ec886fb638efd64cafa8c17522664fbd1df22a39d68df
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUU0OjIxMzgzOToxQzZFMTAxOjI0NThGQTY6NkIwMTQ5NTYiLCJ2aXNpdG9yX2lkIjoiNjQyMTkxNTc4MzczNTEwMTc4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac04401fc9064821c2cfc0c0147c4b2072ae3c343970e7d16abce71aa1563dad80
hovercard-subject-tagpull_request:1330411857
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/50045/files
twitter:imagehttps://avatars.githubusercontent.com/u/12051310?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12051310?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/50045/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50045%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50045%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/50045/files
Reloadhttps://github.com/angular/angular/pull/50045/files
Reloadhttps://github.com/angular/angular/pull/50045/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
leosvelperezhttps://github.com/leosvelperez
angular:mainhttps://github.com/angular/angular/tree/main
leosvelperez:feature/ngcc-warninghttps://github.com/leosvelperez/angular/tree/feature/ngcc-warning
Conversation 10 https://github.com/angular/angular/pull/50045
Commits 1 https://github.com/angular/angular/pull/50045/commits
Checks 0 https://github.com/angular/angular/pull/50045/checks
Files changed https://github.com/angular/angular/pull/50045/files
Please reload this pagehttps://github.com/angular/angular/pull/50045/files
refactor(compiler-cli): add back ngcc as a no-op with a warning https://github.com/angular/angular/pull/50045/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/50045/files
b3c1cda refactor(compiler-cli): add back ngcc as a no-op with a warning leosvelperez Apr 27, 2023 https://github.com/angular/angular/pull/50045/commits/b3c1cdafe8d7383862e3177b451c76ad8c40bd4c
Clear filters https://github.com/angular/angular/pull/50045/files
Please reload this pagehttps://github.com/angular/angular/pull/50045/files
Please reload this pagehttps://github.com/angular/angular/pull/50045/files
BUILD.bazel https://github.com/angular/angular/pull/50045/files#diff-92a050ad91a15158adb65ab2bc5a2744eab7c6a9e60a60a3b2c44f01ba755e9e
BUILD.bazel https://github.com/angular/angular/pull/50045/files#diff-47cb0156bf8d4a5e6f77b26e302295405a6e7d6ba9520beb32a754e0389d0b8e
index.ts https://github.com/angular/angular/pull/50045/files#diff-cfcbab6ba7d43951c1cfd37201a0e062856321e1c955dfa9ff8576d3db28c69c
package.json https://github.com/angular/angular/pull/50045/files#diff-364608d776f18336d0f25fd0867e8bbc996a4ef1cf1203a1369c1bfde6c8b6a2
packages/compiler-cli/BUILD.bazelhttps://github.com/angular/angular/pull/50045/files#diff-92a050ad91a15158adb65ab2bc5a2744eab7c6a9e60a60a3b2c44f01ba755e9e
View file https://github.com/leosvelperez/angular/blob/b3c1cdafe8d7383862e3177b451c76ad8c40bd4c/packages/compiler-cli/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50045/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50045/files#diff-92a050ad91a15158adb65ab2bc5a2744eab7c6a9e60a60a3b2c44f01ba755e9e
https://github.com/angular/angular/pull/50045/files#diff-92a050ad91a15158adb65ab2bc5a2744eab7c6a9e60a60a3b2c44f01ba755e9e
https://github.com/angular/angular/pull/50045/files#diff-92a050ad91a15158adb65ab2bc5a2744eab7c6a9e60a60a3b2c44f01ba755e9e
packages/compiler-cli/ngcc/BUILD.bazelhttps://github.com/angular/angular/pull/50045/files#diff-47cb0156bf8d4a5e6f77b26e302295405a6e7d6ba9520beb32a754e0389d0b8e
View file https://github.com/leosvelperez/angular/blob/b3c1cdafe8d7383862e3177b451c76ad8c40bd4c/packages/compiler-cli/ngcc/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50045/{{ revealButtonHref }}
packages/compiler-cli/ngcc/index.tshttps://github.com/angular/angular/pull/50045/files#diff-cfcbab6ba7d43951c1cfd37201a0e062856321e1c955dfa9ff8576d3db28c69c
View file https://github.com/leosvelperez/angular/blob/b3c1cdafe8d7383862e3177b451c76ad8c40bd4c/packages/compiler-cli/ngcc/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50045/{{ revealButtonHref }}
packages/compiler-cli/package.jsonhttps://github.com/angular/angular/pull/50045/files#diff-364608d776f18336d0f25fd0867e8bbc996a4ef1cf1203a1369c1bfde6c8b6a2
View file https://github.com/leosvelperez/angular/blob/b3c1cdafe8d7383862e3177b451c76ad8c40bd4c/packages/compiler-cli/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50045/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50045/files#diff-364608d776f18336d0f25fd0867e8bbc996a4ef1cf1203a1369c1bfde6c8b6a2
https://github.com/angular/angular/pull/50045/files#diff-364608d776f18336d0f25fd0867e8bbc996a4ef1cf1203a1369c1bfde6c8b6a2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.