René's URL Explorer Experiment


Title: fix(core): allow passing value of any type to `isSignal` function by markostanimirovic · Pull Request #50035 · angular/angular · GitHub

Open Graph Title: fix(core): allow passing value of any type to `isSignal` function by markostanimirovic · Pull Request #50035 · angular/angular

X Title: fix(core): allow passing value of any type to `isSignal` function by markostanimirovic · Pull Request #50035 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? To check if a value of type unknown is a Signal, we need to add two conditions: import { isSignal } from '@angular/core'; declare const potentialSignal: unknown; const isSig = typeof potentialSignal === 'function' && isSignal(potentialSignal); What is the new behavior? The first condition is not needed anymore, so we can call the isSignal function and pass the argument of type unknown: import { isSignal } from '@angular/core'; declare const potentialSignal: unknown; const isSig = isSignal(potentialSignal); Does this PR introduce a breaking change? Yes No Other information isObservable type guard from the rxjs package accepts value of any type as an input argument.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

Opengraph URL: https://github.com/angular/angular/pull/50035

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:886adfce-897e-1fc2-ed23-0dfefc02c2d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D24:16EED3:1ABF178:22007AE:6B01517E
html-safe-noncec9c09cb5f92789993aa09b732e6479fdf77dbb2ce06cc18a343030eb3c10a9c7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDI0OjE2RUVEMzoxQUJGMTc4OjIyMDA3QUU6NkIwMTUxN0UiLCJ2aXNpdG9yX2lkIjoiMjYwMDE5NzkzNzUxMDMwNjE3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2a539d925a17d8646d3f1d5733d80df7aaddd1e3eb5ccf1b20fa66de18d67aa9
hovercard-subject-tagpull_request:1329337253
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/50035/files
twitter:imagehttps://avatars.githubusercontent.com/u/17877290?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17877290?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/50035/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50035%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50035%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/50035/files
Reloadhttps://github.com/angular/angular/pull/50035/files
Reloadhttps://github.com/angular/angular/pull/50035/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
markostanimirovichttps://github.com/markostanimirovic
angular:mainhttps://github.com/angular/angular/tree/main
markostanimirovic:feat/core/is-signal-any-typehttps://github.com/markostanimirovic/angular/tree/feat/core/is-signal-any-type
Conversation 8 https://github.com/angular/angular/pull/50035
Commits 1 https://github.com/angular/angular/pull/50035/commits
Checks 0 https://github.com/angular/angular/pull/50035/checks
Files changed https://github.com/angular/angular/pull/50035/files
Please reload this pagehttps://github.com/angular/angular/pull/50035/files
fix(core): allow passing value of any type to isSignal function https://github.com/angular/angular/pull/50035/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/50035/files
230f5be fix(core): allow passing value of any type to `isSignal` function markostanimirovic Apr 27, 2023 https://github.com/angular/angular/pull/50035/commits/230f5be56ebf37cbbdfbf2f04f748223cea77a85
Clear filters https://github.com/angular/angular/pull/50035/files
Please reload this pagehttps://github.com/angular/angular/pull/50035/files
Please reload this pagehttps://github.com/angular/angular/pull/50035/files
index.md https://github.com/angular/angular/pull/50035/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
api.ts https://github.com/angular/angular/pull/50035/files#diff-3ca7f49bc600138d3c8574b1afd12afb68ff816cc023ba4bd69fa085339b31d8
is_signal_spec.ts https://github.com/angular/angular/pull/50035/files#diff-c414f4ce43a48c7f5560a6fbaee9b5f65f5239045b665e16996ba7b9a7d63553
goldens/public-api/core/index.mdhttps://github.com/angular/angular/pull/50035/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
View file https://github.com/markostanimirovic/angular/blob/230f5be56ebf37cbbdfbf2f04f748223cea77a85/goldens/public-api/core/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50035/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50035/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
https://github.com/angular/angular/pull/50035/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
packages/core/src/signals/src/api.tshttps://github.com/angular/angular/pull/50035/files#diff-3ca7f49bc600138d3c8574b1afd12afb68ff816cc023ba4bd69fa085339b31d8
View file https://github.com/markostanimirovic/angular/blob/230f5be56ebf37cbbdfbf2f04f748223cea77a85/packages/core/src/signals/src/api.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50035/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50035/files#diff-3ca7f49bc600138d3c8574b1afd12afb68ff816cc023ba4bd69fa085339b31d8
Please reload this pagehttps://github.com/angular/angular/pull/50035/files
https://github.com/angular/angular/pull/50035/files#diff-3ca7f49bc600138d3c8574b1afd12afb68ff816cc023ba4bd69fa085339b31d8
packages/core/test/signals/is_signal_spec.tshttps://github.com/angular/angular/pull/50035/files#diff-c414f4ce43a48c7f5560a6fbaee9b5f65f5239045b665e16996ba7b9a7d63553
View file https://github.com/markostanimirovic/angular/blob/230f5be56ebf37cbbdfbf2f04f748223cea77a85/packages/core/test/signals/is_signal_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50035/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.