| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6fdb1441-7a01-cdd6-e38e-505e1e9edc85 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E38C:1D20B7:E6799C:122FA12:6B014129 |
| html-safe-nonce | f2858e8c26758e8575a59fe7e7fd8d755a2e134cda9f6c6e41a5fff9572d2d7a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzhDOjFEMjBCNzpFNjc5OUM6MTIyRkExMjo2QjAxNDEyOSIsInZpc2l0b3JfaWQiOiI4ODc4MzE4MDI5Njk2NDgzNjI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | bcc4a4964516cd4f36923a60fd5259bd51d2828dd28a135d8fb9abb8f73d6831 |
| hovercard-subject-tag | pull_request:1328052778 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/50008/files |
| twitter:image | https://avatars.githubusercontent.com/u/7135246?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7135246?s=400&v=4 |
| og:image:alt | Implement a couple of missing features in the new template pipeline compiler, to continue bringing it to parity with the old TemplateDefinitionBuilder. This commit series especially fixes issues th... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/50008/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50008%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50008%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/50008/files |
| Reload | https://github.com/angular/angular/pull/50008/files |
| Reload | https://github.com/angular/angular/pull/50008/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| dylhunn | https://github.com/dylhunn |
| angular:main | https://github.com/angular/angular/tree/main |
| dylhunn:template-pipeline-ng-template | https://github.com/dylhunn/angular/tree/template-pipeline-ng-template |
|
Conversation
7
| https://github.com/angular/angular/pull/50008 |
|
Commits
6
| https://github.com/angular/angular/pull/50008/commits |
|
Checks
0
| https://github.com/angular/angular/pull/50008/checks |
|
Files changed
| https://github.com/angular/angular/pull/50008/files |
| Please reload this page | https://github.com/angular/angular/pull/50008/files |
|
Template Pipeline: Various features (ng-container, chains, binary operators, keyed reads, ng-template inputs)
| https://github.com/angular/angular/pull/50008/files#top |
|
Show all changes
6 commits
| https://github.com/angular/angular/pull/50008/files |
|
a768a6f
refactor(compiler): generate ng-container instructions
dylhunn Apr 18, 2023
| https://github.com/angular/angular/pull/50008/commits/a768a6f48507546e38a60266a3484a40707669b8 |
|
2b61810
refactor(compiler): handle binary operators
dylhunn Apr 26, 2023
| https://github.com/angular/angular/pull/50008/commits/2b618106c2c6679fee94fb50e0da45f7ddf161e1 |
|
94a5dc9
refactor(compiler): handle chains in event listeners
dylhunn Apr 26, 2023
| https://github.com/angular/angular/pull/50008/commits/94a5dc94983cc44834dbcaf51a02428707fd3b4d |
|
4a6a6e2
refactor(compiler): generate property instructions for `ng-template` …
dylhunn Apr 26, 2023
| https://github.com/angular/angular/pull/50008/commits/4a6a6e2d60b3ff3a6db4506052216f5568835741 |
|
947f7b0
refactor(compiler): support `KeyedRead` expressions
dylhunn Apr 26, 2023
| https://github.com/angular/angular/pull/50008/commits/947f7b0a30379029db4d1634f09e8472219d4ad0 |
|
a0093d2
refactor(compiler): extract save/restore view logic to separate phase
dylhunn May 1, 2023
| https://github.com/angular/angular/pull/50008/commits/a0093d2917996a03f02c216bc33f0ec42f598d91 |
|
Clear filters
| https://github.com/angular/angular/pull/50008/files |
| Please reload this page | https://github.com/angular/angular/pull/50008/files |
| Please reload this page | https://github.com/angular/angular/pull/50008/files |
|
enums.ts
| https://github.com/angular/angular/pull/50008/files#diff-23abd501679455e95973c3ca41fcff4bc6ceaba55cc2bafd83609b7b2bc751e0 |
|
expression.ts
| https://github.com/angular/angular/pull/50008/files#diff-662861c77899280829024b442c1ef9e5b86892c2b0ba26b27ee6e1490ad919a3 |
|
create.ts
| https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8 |
|
conversion.ts
| https://github.com/angular/angular/pull/50008/files#diff-e9f323fb0271cf0bbfdbb192d0a29449f213ca6538f49c39a3beb59d5c221960 |
|
emit.ts
| https://github.com/angular/angular/pull/50008/files#diff-b370fa3f65f8f789be3d798ea472533917c2bb4bbb09f515a3564b77952f58e6 |
|
ingest.ts
| https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5 |
|
instruction.ts
| https://github.com/angular/angular/pull/50008/files#diff-39d12d1e1bace470f5cb761c0c4b6d1902918fafb3ddc98db8dda15870d74a55 |
|
chaining.ts
| https://github.com/angular/angular/pull/50008/files#diff-ddf44229ba08cf100a5d34ffde6f72cd6cc55361614b3db7d247e4f0091f53b2 |
|
empty_elements.ts
| https://github.com/angular/angular/pull/50008/files#diff-6ef238d9998377620e65b9587217969e46be1f00cba2f3592d3167ecbb51864b |
|
generate_variables.ts
| https://github.com/angular/angular/pull/50008/files#diff-1c6ea5ec7cd83eb22f36e73b08479688b14a6985e6f35d585a12800edccc35e3 |
|
ng_container.ts
| https://github.com/angular/angular/pull/50008/files#diff-885bccf280e6388b1a8174e017a637fa31c80f3287ea50728f9eec290f74dd16 |
|
reify.ts
| https://github.com/angular/angular/pull/50008/files#diff-238fdfcb2b4087f564ff86bf75f9d87aaa7491ac12953eddf0f60d72a9f284c5 |
|
save_restore_view.ts
| https://github.com/angular/angular/pull/50008/files#diff-c816b201afed2919b0fc1388e385394fb0a10f5539d798a8088c4b2b4b8752b1 |
| packages/compiler/src/template/pipeline/ir/src/enums.ts | https://github.com/angular/angular/pull/50008/files#diff-23abd501679455e95973c3ca41fcff4bc6ceaba55cc2bafd83609b7b2bc751e0 |
|
View file
| https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/ir/src/enums.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/50008/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/50008/files#diff-23abd501679455e95973c3ca41fcff4bc6ceaba55cc2bafd83609b7b2bc751e0 |
|
| https://github.com/angular/angular/pull/50008/files#diff-23abd501679455e95973c3ca41fcff4bc6ceaba55cc2bafd83609b7b2bc751e0 |
| packages/compiler/src/template/pipeline/ir/src/expression.ts | https://github.com/angular/angular/pull/50008/files#diff-662861c77899280829024b442c1ef9e5b86892c2b0ba26b27ee6e1490ad919a3 |
|
View file
| https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/ir/src/expression.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/50008/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/50008/files#diff-662861c77899280829024b442c1ef9e5b86892c2b0ba26b27ee6e1490ad919a3 |
|
| https://github.com/angular/angular/pull/50008/files#diff-662861c77899280829024b442c1ef9e5b86892c2b0ba26b27ee6e1490ad919a3 |
|
| https://github.com/angular/angular/pull/50008/files#diff-662861c77899280829024b442c1ef9e5b86892c2b0ba26b27ee6e1490ad919a3 |
| packages/compiler/src/template/pipeline/ir/src/ops/create.ts | https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8 |
|
View file
| https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/ir/src/ops/create.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/50008/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8 |
| packages/compiler/src/template/pipeline/src/conversion.ts | https://github.com/angular/angular/pull/50008/files#diff-e9f323fb0271cf0bbfdbb192d0a29449f213ca6538f49c39a3beb59d5c221960 |
|
View file
| https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/conversion.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/50008/{{ revealButtonHref }} |
| packages/compiler/src/template/pipeline/src/emit.ts | https://github.com/angular/angular/pull/50008/files#diff-b370fa3f65f8f789be3d798ea472533917c2bb4bbb09f515a3564b77952f58e6 |
|
View file
| https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/emit.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/50008/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/50008/files#diff-b370fa3f65f8f789be3d798ea472533917c2bb4bbb09f515a3564b77952f58e6 |
| Please reload this page | https://github.com/angular/angular/pull/50008/files |
|
| https://github.com/angular/angular/pull/50008/files#diff-b370fa3f65f8f789be3d798ea472533917c2bb4bbb09f515a3564b77952f58e6 |
| packages/compiler/src/template/pipeline/src/ingest.ts | https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5 |
|
View file
| https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/ingest.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/50008/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5 |
|
| https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5 |
| packages/compiler/src/template/pipeline/src/instruction.ts | https://github.com/angular/angular/pull/50008/files#diff-39d12d1e1bace470f5cb761c0c4b6d1902918fafb3ddc98db8dda15870d74a55 |
|
View file
| https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/instruction.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/50008/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/50008/files#diff-39d12d1e1bace470f5cb761c0c4b6d1902918fafb3ddc98db8dda15870d74a55 |
|
| https://github.com/angular/angular/pull/50008/files#diff-39d12d1e1bace470f5cb761c0c4b6d1902918fafb3ddc98db8dda15870d74a55 |
|
| https://github.com/angular/angular/pull/50008/files#diff-39d12d1e1bace470f5cb761c0c4b6d1902918fafb3ddc98db8dda15870d74a55 |
| packages/compiler/src/template/pipeline/src/phases/chaining.ts | https://github.com/angular/angular/pull/50008/files#diff-ddf44229ba08cf100a5d34ffde6f72cd6cc55361614b3db7d247e4f0091f53b2 |
|
View file
| https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/phases/chaining.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/50008/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/50008/files#diff-ddf44229ba08cf100a5d34ffde6f72cd6cc55361614b3db7d247e4f0091f53b2 |
|
| https://github.com/angular/angular/pull/50008/files#diff-ddf44229ba08cf100a5d34ffde6f72cd6cc55361614b3db7d247e4f0091f53b2 |
| packages/compiler/src/template/pipeline/src/phases/empty_elements.ts | https://github.com/angular/angular/pull/50008/files#diff-6ef238d9998377620e65b9587217969e46be1f00cba2f3592d3167ecbb51864b |
|
View file
| https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/phases/empty_elements.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/50008/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/50008/files#diff-6ef238d9998377620e65b9587217969e46be1f00cba2f3592d3167ecbb51864b |
|
| https://github.com/angular/angular/pull/50008/files#diff-6ef238d9998377620e65b9587217969e46be1f00cba2f3592d3167ecbb51864b |
| Please reload this page | https://github.com/angular/angular/pull/50008/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |