René's URL Explorer Experiment


Title: Template Pipeline: Various features (`ng-container`, chains, binary operators, keyed reads, `ng-template` inputs) by dylhunn · Pull Request #50008 · angular/angular · GitHub

Open Graph Title: Template Pipeline: Various features (`ng-container`, chains, binary operators, keyed reads, `ng-template` inputs) by dylhunn · Pull Request #50008 · angular/angular

X Title: Template Pipeline: Various features (`ng-container`, chains, binary operators, keyed reads, `ng-template` inputs) by dylhunn · Pull Request #50008 · angular/angular

Description: Implement a couple of missing features in the new template pipeline compiler, to continue bringing it to parity with the old TemplateDefinitionBuilder. This commit series especially fixes issues that came up while working on the ng-template input tests. See individual commits for per-feature info.

Open Graph Description: Implement a couple of missing features in the new template pipeline compiler, to continue bringing it to parity with the old TemplateDefinitionBuilder. This commit series especially fixes issues th...

X Description: Implement a couple of missing features in the new template pipeline compiler, to continue bringing it to parity with the old TemplateDefinitionBuilder. This commit series especially fixes issues th...

Opengraph URL: https://github.com/angular/angular/pull/50008

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6fdb1441-7a01-cdd6-e38e-505e1e9edc85
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE38C:1D20B7:E6799C:122FA12:6B014129
html-safe-noncef2858e8c26758e8575a59fe7e7fd8d755a2e134cda9f6c6e41a5fff9572d2d7a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzhDOjFEMjBCNzpFNjc5OUM6MTIyRkExMjo2QjAxNDEyOSIsInZpc2l0b3JfaWQiOiI4ODc4MzE4MDI5Njk2NDgzNjI2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbcc4a4964516cd4f36923a60fd5259bd51d2828dd28a135d8fb9abb8f73d6831
hovercard-subject-tagpull_request:1328052778
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/50008/files
twitter:imagehttps://avatars.githubusercontent.com/u/7135246?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7135246?s=400&v=4
og:image:altImplement a couple of missing features in the new template pipeline compiler, to continue bringing it to parity with the old TemplateDefinitionBuilder. This commit series especially fixes issues th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/50008/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50008%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F50008%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/50008/files
Reloadhttps://github.com/angular/angular/pull/50008/files
Reloadhttps://github.com/angular/angular/pull/50008/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
dylhunnhttps://github.com/dylhunn
angular:mainhttps://github.com/angular/angular/tree/main
dylhunn:template-pipeline-ng-templatehttps://github.com/dylhunn/angular/tree/template-pipeline-ng-template
Conversation 7 https://github.com/angular/angular/pull/50008
Commits 6 https://github.com/angular/angular/pull/50008/commits
Checks 0 https://github.com/angular/angular/pull/50008/checks
Files changed https://github.com/angular/angular/pull/50008/files
Please reload this pagehttps://github.com/angular/angular/pull/50008/files
Template Pipeline: Various features (ng-container, chains, binary operators, keyed reads, ng-template inputs) https://github.com/angular/angular/pull/50008/files#top
Show all changes 6 commits https://github.com/angular/angular/pull/50008/files
a768a6f refactor(compiler): generate ng-container instructions dylhunn Apr 18, 2023 https://github.com/angular/angular/pull/50008/commits/a768a6f48507546e38a60266a3484a40707669b8
2b61810 refactor(compiler): handle binary operators dylhunn Apr 26, 2023 https://github.com/angular/angular/pull/50008/commits/2b618106c2c6679fee94fb50e0da45f7ddf161e1
94a5dc9 refactor(compiler): handle chains in event listeners dylhunn Apr 26, 2023 https://github.com/angular/angular/pull/50008/commits/94a5dc94983cc44834dbcaf51a02428707fd3b4d
4a6a6e2 refactor(compiler): generate property instructions for `ng-template` … dylhunn Apr 26, 2023 https://github.com/angular/angular/pull/50008/commits/4a6a6e2d60b3ff3a6db4506052216f5568835741
947f7b0 refactor(compiler): support `KeyedRead` expressions dylhunn Apr 26, 2023 https://github.com/angular/angular/pull/50008/commits/947f7b0a30379029db4d1634f09e8472219d4ad0
a0093d2 refactor(compiler): extract save/restore view logic to separate phase dylhunn May 1, 2023 https://github.com/angular/angular/pull/50008/commits/a0093d2917996a03f02c216bc33f0ec42f598d91
Clear filters https://github.com/angular/angular/pull/50008/files
Please reload this pagehttps://github.com/angular/angular/pull/50008/files
Please reload this pagehttps://github.com/angular/angular/pull/50008/files
enums.ts https://github.com/angular/angular/pull/50008/files#diff-23abd501679455e95973c3ca41fcff4bc6ceaba55cc2bafd83609b7b2bc751e0
expression.ts https://github.com/angular/angular/pull/50008/files#diff-662861c77899280829024b442c1ef9e5b86892c2b0ba26b27ee6e1490ad919a3
create.ts https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8
conversion.ts https://github.com/angular/angular/pull/50008/files#diff-e9f323fb0271cf0bbfdbb192d0a29449f213ca6538f49c39a3beb59d5c221960
emit.ts https://github.com/angular/angular/pull/50008/files#diff-b370fa3f65f8f789be3d798ea472533917c2bb4bbb09f515a3564b77952f58e6
ingest.ts https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
instruction.ts https://github.com/angular/angular/pull/50008/files#diff-39d12d1e1bace470f5cb761c0c4b6d1902918fafb3ddc98db8dda15870d74a55
chaining.ts https://github.com/angular/angular/pull/50008/files#diff-ddf44229ba08cf100a5d34ffde6f72cd6cc55361614b3db7d247e4f0091f53b2
empty_elements.ts https://github.com/angular/angular/pull/50008/files#diff-6ef238d9998377620e65b9587217969e46be1f00cba2f3592d3167ecbb51864b
generate_variables.ts https://github.com/angular/angular/pull/50008/files#diff-1c6ea5ec7cd83eb22f36e73b08479688b14a6985e6f35d585a12800edccc35e3
ng_container.ts https://github.com/angular/angular/pull/50008/files#diff-885bccf280e6388b1a8174e017a637fa31c80f3287ea50728f9eec290f74dd16
reify.ts https://github.com/angular/angular/pull/50008/files#diff-238fdfcb2b4087f564ff86bf75f9d87aaa7491ac12953eddf0f60d72a9f284c5
save_restore_view.ts https://github.com/angular/angular/pull/50008/files#diff-c816b201afed2919b0fc1388e385394fb0a10f5539d798a8088c4b2b4b8752b1
packages/compiler/src/template/pipeline/ir/src/enums.tshttps://github.com/angular/angular/pull/50008/files#diff-23abd501679455e95973c3ca41fcff4bc6ceaba55cc2bafd83609b7b2bc751e0
View file https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/ir/src/enums.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50008/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50008/files#diff-23abd501679455e95973c3ca41fcff4bc6ceaba55cc2bafd83609b7b2bc751e0
https://github.com/angular/angular/pull/50008/files#diff-23abd501679455e95973c3ca41fcff4bc6ceaba55cc2bafd83609b7b2bc751e0
packages/compiler/src/template/pipeline/ir/src/expression.tshttps://github.com/angular/angular/pull/50008/files#diff-662861c77899280829024b442c1ef9e5b86892c2b0ba26b27ee6e1490ad919a3
View file https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/ir/src/expression.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50008/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50008/files#diff-662861c77899280829024b442c1ef9e5b86892c2b0ba26b27ee6e1490ad919a3
https://github.com/angular/angular/pull/50008/files#diff-662861c77899280829024b442c1ef9e5b86892c2b0ba26b27ee6e1490ad919a3
https://github.com/angular/angular/pull/50008/files#diff-662861c77899280829024b442c1ef9e5b86892c2b0ba26b27ee6e1490ad919a3
packages/compiler/src/template/pipeline/ir/src/ops/create.tshttps://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8
View file https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/ir/src/ops/create.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50008/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8
https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8
https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8
https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8
https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8
https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8
https://github.com/angular/angular/pull/50008/files#diff-b3a90df91055e79f4c05d5c7f33578b8e36be119448fcbd14a41e987a6ada4a8
packages/compiler/src/template/pipeline/src/conversion.tshttps://github.com/angular/angular/pull/50008/files#diff-e9f323fb0271cf0bbfdbb192d0a29449f213ca6538f49c39a3beb59d5c221960
View file https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/conversion.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50008/{{ revealButtonHref }}
packages/compiler/src/template/pipeline/src/emit.tshttps://github.com/angular/angular/pull/50008/files#diff-b370fa3f65f8f789be3d798ea472533917c2bb4bbb09f515a3564b77952f58e6
View file https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/emit.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50008/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50008/files#diff-b370fa3f65f8f789be3d798ea472533917c2bb4bbb09f515a3564b77952f58e6
Please reload this pagehttps://github.com/angular/angular/pull/50008/files
https://github.com/angular/angular/pull/50008/files#diff-b370fa3f65f8f789be3d798ea472533917c2bb4bbb09f515a3564b77952f58e6
packages/compiler/src/template/pipeline/src/ingest.tshttps://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
View file https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/ingest.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50008/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
https://github.com/angular/angular/pull/50008/files#diff-b1e4c95e3f14b52160cbf995deb6a31f915584b15e5be61ba1ef5dbf7c0fdea5
packages/compiler/src/template/pipeline/src/instruction.tshttps://github.com/angular/angular/pull/50008/files#diff-39d12d1e1bace470f5cb761c0c4b6d1902918fafb3ddc98db8dda15870d74a55
View file https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/instruction.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50008/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50008/files#diff-39d12d1e1bace470f5cb761c0c4b6d1902918fafb3ddc98db8dda15870d74a55
https://github.com/angular/angular/pull/50008/files#diff-39d12d1e1bace470f5cb761c0c4b6d1902918fafb3ddc98db8dda15870d74a55
https://github.com/angular/angular/pull/50008/files#diff-39d12d1e1bace470f5cb761c0c4b6d1902918fafb3ddc98db8dda15870d74a55
packages/compiler/src/template/pipeline/src/phases/chaining.tshttps://github.com/angular/angular/pull/50008/files#diff-ddf44229ba08cf100a5d34ffde6f72cd6cc55361614b3db7d247e4f0091f53b2
View file https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/phases/chaining.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50008/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50008/files#diff-ddf44229ba08cf100a5d34ffde6f72cd6cc55361614b3db7d247e4f0091f53b2
https://github.com/angular/angular/pull/50008/files#diff-ddf44229ba08cf100a5d34ffde6f72cd6cc55361614b3db7d247e4f0091f53b2
packages/compiler/src/template/pipeline/src/phases/empty_elements.tshttps://github.com/angular/angular/pull/50008/files#diff-6ef238d9998377620e65b9587217969e46be1f00cba2f3592d3167ecbb51864b
View file https://github.com/dylhunn/angular/blob/a0093d2917996a03f02c216bc33f0ec42f598d91/packages/compiler/src/template/pipeline/src/phases/empty_elements.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/50008/{{ revealButtonHref }}
https://github.com/angular/angular/pull/50008/files#diff-6ef238d9998377620e65b9587217969e46be1f00cba2f3592d3167ecbb51864b
https://github.com/angular/angular/pull/50008/files#diff-6ef238d9998377620e65b9587217969e46be1f00cba2f3592d3167ecbb51864b
Please reload this pagehttps://github.com/angular/angular/pull/50008/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.