René's URL Explorer Experiment


Title: fix(router): create correct URL relative to path with empty child by atscott · Pull Request #49691 · angular/angular · GitHub

Open Graph Title: fix(router): create correct URL relative to path with empty child by atscott · Pull Request #49691 · angular/angular

X Title: fix(router): create correct URL relative to path with empty child by atscott · Pull Request #49691 · angular/angular

Description: The previous fix for squashing empty children didn't quite work when the existing route had segments. The result would be that the segments from the existing route were dropped from the final URL. This bug was discovered in #48508 (comment)

Open Graph Description: The previous fix for squashing empty children didn't quite work when the existing route had segments. The result would be that the segments from the existing route were dropped from the final U...

X Description: The previous fix for squashing empty children didn't quite work when the existing route had segments. The result would be that the segments from the existing route were dropped from the fin...

Opengraph URL: https://github.com/angular/angular/pull/49691

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:14582aa4-e855-5dc5-a406-7cd2617ef8f8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8410:229B2E:E5D555:1306630:6B00FEC8
html-safe-noncec74edc2eb296ee868d0a8add6030782f412438de93d44c7fb32c0452467d407f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDEwOjIyOUIyRTpFNUQ1NTU6MTMwNjYzMDo2QjAwRkVDOCIsInZpc2l0b3JfaWQiOiI2MzI1Mzc1NjM0ODY0NDA2MjE3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb70c4e4ff197c1af4205eceed9be32fa53ca601c0c9abdc6654557dcbf04d42f
hovercard-subject-tagpull_request:1300675965
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/49691/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altThe previous fix for squashing empty children didn't quite work when the existing route had segments. The result would be that the segments from the existing route were dropped from the final U...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/49691/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49691%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49691%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/49691/files
Reloadhttps://github.com/angular/angular/pull/49691/files
Reloadhttps://github.com/angular/angular/pull/49691/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:fixemptypathsagainhttps://github.com/atscott/angular/tree/fixemptypathsagain
Conversation 3 https://github.com/angular/angular/pull/49691
Commits 1 https://github.com/angular/angular/pull/49691/commits
Checks 0 https://github.com/angular/angular/pull/49691/checks
Files changed https://github.com/angular/angular/pull/49691/files
Please reload this pagehttps://github.com/angular/angular/pull/49691/files
fix(router): create correct URL relative to path with empty child https://github.com/angular/angular/pull/49691/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/49691/files
296c786 fix(router): create correct URL relative to path with empty child atscott Apr 3, 2023 https://github.com/angular/angular/pull/49691/commits/296c786782c3bbd65911c5fe89c09bf419205931
Clear filters https://github.com/angular/angular/pull/49691/files
Please reload this pagehttps://github.com/angular/angular/pull/49691/files
Please reload this pagehttps://github.com/angular/angular/pull/49691/files
create_url_tree.ts https://github.com/angular/angular/pull/49691/files#diff-6c05064cfb81fe461655c0b26f32cdd961bb73ce7220e2e6ad1eb523b071831f
create_url_tree.spec.ts https://github.com/angular/angular/pull/49691/files#diff-9783a36747e843ca62b247ecaba8cc35b6e649c5eed9903a8e637087d04ff5f6
packages/router/src/create_url_tree.tshttps://github.com/angular/angular/pull/49691/files#diff-6c05064cfb81fe461655c0b26f32cdd961bb73ce7220e2e6ad1eb523b071831f
View file https://github.com/atscott/angular/blob/296c786782c3bbd65911c5fe89c09bf419205931/packages/router/src/create_url_tree.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49691/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49691/files#diff-6c05064cfb81fe461655c0b26f32cdd961bb73ce7220e2e6ad1eb523b071831f
https://github.com/angular/angular/pull/49691/files#diff-6c05064cfb81fe461655c0b26f32cdd961bb73ce7220e2e6ad1eb523b071831f
https://github.com/angular/angular/pull/49691/files#diff-6c05064cfb81fe461655c0b26f32cdd961bb73ce7220e2e6ad1eb523b071831f
packages/router/test/create_url_tree.spec.tshttps://github.com/angular/angular/pull/49691/files#diff-9783a36747e843ca62b247ecaba8cc35b6e649c5eed9903a8e637087d04ff5f6
View file https://github.com/atscott/angular/blob/296c786782c3bbd65911c5fe89c09bf419205931/packages/router/test/create_url_tree.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49691/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49691/files#diff-9783a36747e843ca62b247ecaba8cc35b6e649c5eed9903a8e637087d04ff5f6
https://github.com/angular/angular/pull/49691/files#diff-9783a36747e843ca62b247ecaba8cc35b6e649c5eed9903a8e637087d04ff5f6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.