René's URL Explorer Experiment


Title: feat(core): change the URL sanitization to only block javascript: URLs by neuracr · Pull Request #49659 · angular/angular · GitHub

Open Graph Title: feat(core): change the URL sanitization to only block javascript: URLs by neuracr · Pull Request #49659 · angular/angular

X Title: feat(core): change the URL sanitization to only block javascript: URLs by neuracr · Pull Request #49659 · angular/angular

Description: In modern browsers, the 'javascript:' URL scheme is the only scheme that can execute JavaScript when passed in a navigation URL context (e.g. a.href value). Validate URL shemes to only contain characters allowed in the URL specification ([a-zA-Z-+.]), and that are not javascript (case insensitive). This is not a breaking change. The URL sanitization is loosen. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features). The documentation is already explaining the javascript: URLs are sanitized. This is still the case, and is the only scheme being sanitized. PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: Security change. What is the current behavior? The navigation URL sanitization in Angular is currently allowlist based. It allows implicit shemes, or explicit scheme oneof https?|mailto|data|ftp|tel|file|sms that are known to be always safe wrt. XSS. Issue Number: N/A What is the new behavior? The new sanitization algorithm validates the scheme has characters allowed by the URL specification. It is also blocklist based and blocks the javascript scheme (non case sensitive). Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: In modern browsers, the 'javascript:' URL scheme is the only scheme that can execute JavaScript when passed in a navigation URL context (e.g. a.href value). Validate URL shemes to only cont...

X Description: In modern browsers, the 'javascript:' URL scheme is the only scheme that can execute JavaScript when passed in a navigation URL context (e.g. a.href value). Validate URL shemes to o...

Opengraph URL: https://github.com/angular/angular/pull/49659

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3b1f1905-109b-a88f-3748-9b6cc3716bb7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB48:EDA7A:CA3F63:101E500:6B010044
html-safe-noncea0965b0e719591cd41f71558cc0a44b64988cdbd43d4b6d84ed2f36912fd44bf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjQ4OkVEQTdBOkNBM0Y2MzoxMDFFNTAwOjZCMDEwMDQ0IiwidmlzaXRvcl9pZCI6IjY2MjY0NzgzMTE0NzAwNzE4NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5efb9908ba24f76c8b7a3e5b4d055e1b5cf7444cd637455193c5ecc3239579f5
hovercard-subject-tagpull_request:1297637766
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/49659/files
twitter:imagehttps://avatars.githubusercontent.com/u/26376659?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/26376659?s=400&v=4
og:image:altIn modern browsers, the 'javascript:' URL scheme is the only scheme that can execute JavaScript when passed in a navigation URL context (e.g. a.href value). Validate URL shemes to only cont...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/49659/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49659%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49659%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/49659/files
Reloadhttps://github.com/angular/angular/pull/49659/files
Reloadhttps://github.com/angular/angular/pull/49659/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
neuracrhttps://github.com/neuracr
angular:mainhttps://github.com/angular/angular/tree/main
neuracr:javascript-url-sanitizerhttps://github.com/neuracr/angular/tree/javascript-url-sanitizer
Conversation 8 https://github.com/angular/angular/pull/49659
Commits 1 https://github.com/angular/angular/pull/49659/commits
Checks 0 https://github.com/angular/angular/pull/49659/checks
Files changed https://github.com/angular/angular/pull/49659/files
Please reload this pagehttps://github.com/angular/angular/pull/49659/files
feat(core): change the URL sanitization to only block javascript: URLs https://github.com/angular/angular/pull/49659/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/49659/files
bb41366 feat(core): change the URL sanitization to only block javascript: URLs neuracr Mar 31, 2023 https://github.com/angular/angular/pull/49659/commits/bb41366600f394bd2daf219c5fc01cfafcfe6a95
Clear filters https://github.com/angular/angular/pull/49659/files
Please reload this pagehttps://github.com/angular/angular/pull/49659/files
Please reload this pagehttps://github.com/angular/angular/pull/49659/files
url_sanitizer.ts https://github.com/angular/angular/pull/49659/files#diff-416e72fb8d691a1f1787d5d63b8d0b3d982de4b61df2dd8c99b61c058e4f4d2d
url_sanitizer_spec.ts https://github.com/angular/angular/pull/49659/files#diff-12d234b0713d30ff713160f9e60605ff8deea33f592cb246cb358e1c3341126c
packages/core/src/sanitization/url_sanitizer.tshttps://github.com/angular/angular/pull/49659/files#diff-416e72fb8d691a1f1787d5d63b8d0b3d982de4b61df2dd8c99b61c058e4f4d2d
View file https://github.com/neuracr/angular/blob/bb41366600f394bd2daf219c5fc01cfafcfe6a95/packages/core/src/sanitization/url_sanitizer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49659/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49659/files#diff-416e72fb8d691a1f1787d5d63b8d0b3d982de4b61df2dd8c99b61c058e4f4d2d
https://github.com/angular/angular/pull/49659/files#diff-416e72fb8d691a1f1787d5d63b8d0b3d982de4b61df2dd8c99b61c058e4f4d2d
https://github.com/angular/angular/pull/49659/files#diff-416e72fb8d691a1f1787d5d63b8d0b3d982de4b61df2dd8c99b61c058e4f4d2d
packages/core/test/sanitization/url_sanitizer_spec.tshttps://github.com/angular/angular/pull/49659/files#diff-12d234b0713d30ff713160f9e60605ff8deea33f592cb246cb358e1c3341126c
View file https://github.com/neuracr/angular/blob/bb41366600f394bd2daf219c5fc01cfafcfe6a95/packages/core/test/sanitization/url_sanitizer_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49659/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49659/files#diff-12d234b0713d30ff713160f9e60605ff8deea33f592cb246cb358e1c3341126c
https://github.com/angular/angular/pull/49659/files#diff-12d234b0713d30ff713160f9e60605ff8deea33f592cb246cb358e1c3341126c
https://github.com/angular/angular/pull/49659/files#diff-12d234b0713d30ff713160f9e60605ff8deea33f592cb246cb358e1c3341126c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.