René's URL Explorer Experiment


Title: fix(zone.js): fix several behavior diffs when Promise reject unhandled by JiaLiPassion · Pull Request #49589 · angular/angular · GitHub

Open Graph Title: fix(zone.js): fix several behavior diffs when Promise reject unhandled by JiaLiPassion · Pull Request #49589 · angular/angular

X Title: fix(zone.js): fix several behavior diffs when Promise reject unhandled by JiaLiPassion · Pull Request #49589 · angular/angular

Description: Close #47562 There are several behavior differences between ZoneAwarePromise and Native Promise. Such as. Promise.reject(new Error("test error")).finally(() => console.log("finally")); Native Promise, will console log finally and throw a Promise unhandled error also process exit with code 1. ZoneAwarePromise, will console log finally but will not output any uncaught error also process exit with code 0. This PR fix the issue and make Promise rejection behave the same with the native one.

Open Graph Description: Close #47562 There are several behavior differences between ZoneAwarePromise and Native Promise. Such as. Promise.reject(new Error("test error")).finally(() => console.log("finall...

X Description: Close #47562 There are several behavior differences between ZoneAwarePromise and Native Promise. Such as. Promise.reject(new Error("test error")).finally(() => console.log(...

Opengraph URL: https://github.com/angular/angular/pull/49589

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ac9f802a-a781-a264-cff5-8ce02e037bc5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC700:22DB35:217AA0E:2AB48C2:6B016518
html-safe-nonceae45cca0c92f327b628f4897d818eb1317b2292bc308bdd5bdae701669900540
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNzAwOjIyREIzNToyMTdBQTBFOjJBQjQ4QzI6NkIwMTY1MTgiLCJ2aXNpdG9yX2lkIjoiMjQ0NDk2NzM5OTg0MjIxMTA5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc89475571c63f0038d887490f4fbb289f25be1b83c97c93bd35ce30e18fcc8cd
hovercard-subject-tagpull_request:1289882585
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/49589/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altClose #47562 There are several behavior differences between ZoneAwarePromise and Native Promise. Such as. Promise.reject(new Error("test error")).finally(() => console.log("finall...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/49589/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49589%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49589%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/49589/files
Reloadhttps://github.com/angular/angular/pull/49589/files
Reloadhttps://github.com/angular/angular/pull/49589/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JiaLiPassionhttps://github.com/JiaLiPassion
angular:mainhttps://github.com/angular/angular/tree/main
JiaLiPassion:promise-rejecthttps://github.com/JiaLiPassion/angular/tree/promise-reject
Conversation 7 https://github.com/angular/angular/pull/49589
Commits 1 https://github.com/angular/angular/pull/49589/commits
Checks 0 https://github.com/angular/angular/pull/49589/checks
Files changed https://github.com/angular/angular/pull/49589/files
Please reload this pagehttps://github.com/angular/angular/pull/49589/files
fix(zone.js): fix several behavior diffs when Promise reject unhandled https://github.com/angular/angular/pull/49589/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/49589/files
3035927 fix(zone.js): fix several behavior diffs when Promise reject unhandled JiaLiPassion Mar 25, 2023 https://github.com/angular/angular/pull/49589/commits/3035927c423993ce8a61b43f0989c2491a6bd776
Clear filters https://github.com/angular/angular/pull/49589/files
Please reload this pagehttps://github.com/angular/angular/pull/49589/files
Please reload this pagehttps://github.com/angular/angular/pull/49589/files
browser.ts https://github.com/angular/angular/pull/49589/files#diff-bd0d958d3e90a48a24c35daff80d489804c21f97acae2dc6a693b5f744f690e2
promise.ts https://github.com/angular/angular/pull/49589/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
node.ts https://github.com/angular/angular/pull/49589/files#diff-c1ec9f48b439868e8eeb50f3c17bfa379bab2acd12612270ec6284a9ed104eb1
Promise.spec.ts https://github.com/angular/angular/pull/49589/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
process.spec.ts https://github.com/angular/angular/pull/49589/files#diff-6e87ec002654d3394912b766b39d2450bcf95b5dbd25d00dd5b44f35ad018839
long-stack-trace-zone.spec.ts https://github.com/angular/angular/pull/49589/files#diff-e852eb04ded42e102c9c7453d882d9fc07ed6aeaa5f9ab54b64128af1313cd6b
packages/zone.js/lib/browser/browser.tshttps://github.com/angular/angular/pull/49589/files#diff-bd0d958d3e90a48a24c35daff80d489804c21f97acae2dc6a693b5f744f690e2
View file https://github.com/JiaLiPassion/angular/blob/3035927c423993ce8a61b43f0989c2491a6bd776/packages/zone.js/lib/browser/browser.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49589/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49589/files#diff-bd0d958d3e90a48a24c35daff80d489804c21f97acae2dc6a693b5f744f690e2
https://github.com/angular/angular/pull/49589/files#diff-bd0d958d3e90a48a24c35daff80d489804c21f97acae2dc6a693b5f744f690e2
packages/zone.js/lib/common/promise.tshttps://github.com/angular/angular/pull/49589/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
View file https://github.com/JiaLiPassion/angular/blob/3035927c423993ce8a61b43f0989c2491a6bd776/packages/zone.js/lib/common/promise.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49589/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49589/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/49589/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/49589/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/49589/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/49589/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/49589/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/49589/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/49589/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
packages/zone.js/lib/node/node.tshttps://github.com/angular/angular/pull/49589/files#diff-c1ec9f48b439868e8eeb50f3c17bfa379bab2acd12612270ec6284a9ed104eb1
View file https://github.com/JiaLiPassion/angular/blob/3035927c423993ce8a61b43f0989c2491a6bd776/packages/zone.js/lib/node/node.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49589/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49589/files#diff-c1ec9f48b439868e8eeb50f3c17bfa379bab2acd12612270ec6284a9ed104eb1
https://github.com/angular/angular/pull/49589/files#diff-c1ec9f48b439868e8eeb50f3c17bfa379bab2acd12612270ec6284a9ed104eb1
packages/zone.js/test/common/Promise.spec.tshttps://github.com/angular/angular/pull/49589/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
View file https://github.com/JiaLiPassion/angular/blob/3035927c423993ce8a61b43f0989c2491a6bd776/packages/zone.js/test/common/Promise.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49589/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49589/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
https://github.com/angular/angular/pull/49589/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
https://github.com/angular/angular/pull/49589/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
https://github.com/angular/angular/pull/49589/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
https://github.com/angular/angular/pull/49589/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42
packages/zone.js/test/node/process.spec.tshttps://github.com/angular/angular/pull/49589/files#diff-6e87ec002654d3394912b766b39d2450bcf95b5dbd25d00dd5b44f35ad018839
View file https://github.com/JiaLiPassion/angular/blob/3035927c423993ce8a61b43f0989c2491a6bd776/packages/zone.js/test/node/process.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49589/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49589/files#diff-6e87ec002654d3394912b766b39d2450bcf95b5dbd25d00dd5b44f35ad018839
https://github.com/angular/angular/pull/49589/files#diff-6e87ec002654d3394912b766b39d2450bcf95b5dbd25d00dd5b44f35ad018839
https://github.com/angular/angular/pull/49589/files#diff-6e87ec002654d3394912b766b39d2450bcf95b5dbd25d00dd5b44f35ad018839
https://github.com/angular/angular/pull/49589/files#diff-6e87ec002654d3394912b766b39d2450bcf95b5dbd25d00dd5b44f35ad018839
packages/zone.js/test/zone-spec/long-stack-trace-zone.spec.tshttps://github.com/angular/angular/pull/49589/files#diff-e852eb04ded42e102c9c7453d882d9fc07ed6aeaa5f9ab54b64128af1313cd6b
View file https://github.com/JiaLiPassion/angular/blob/3035927c423993ce8a61b43f0989c2491a6bd776/packages/zone.js/test/zone-spec/long-stack-trace-zone.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49589/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49589/files#diff-e852eb04ded42e102c9c7453d882d9fc07ed6aeaa5f9ab54b64128af1313cd6b
https://github.com/angular/angular/pull/49589/files#diff-e852eb04ded42e102c9c7453d882d9fc07ed6aeaa5f9ab54b64128af1313cd6b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.