René's URL Explorer Experiment


Title: fix(router): Ensure initial navigation clears current navigation when… by atscott · Pull Request #49572 · angular/angular · GitHub

Open Graph Title: fix(router): Ensure initial navigation clears current navigation when… by atscott · Pull Request #49572 · angular/angular

X Title: fix(router): Ensure initial navigation clears current navigation when… by atscott · Pull Request #49572 · angular/angular

Description: … blocking The navigation transition clears the current navigation in the finalize operator of the current navigation Observer. This commit both completes the bootstrapDone observable and updates the transition to only take 1 emit from the completed navigation. Either of these changes on their own would fix the issue. The latter is a preventative measure in case a mistake like the former is made again. fixes #49567

Open Graph Description: … blocking The navigation transition clears the current navigation in the finalize operator of the current navigation Observer. This commit both completes the bootstrapDone observable and updates t...

X Description: … blocking The navigation transition clears the current navigation in the finalize operator of the current navigation Observer. This commit both completes the bootstrapDone observable and updates t...

Opengraph URL: https://github.com/angular/angular/pull/49572

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:982489a1-02f5-e21a-3635-11a76e04de58
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id999A:95C88:E61DBC:1313965:6B010002
html-safe-noncedce355f71a0fe5b1495405967e83a0dae40a8c1954c72095db2810190179ea96
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTlBOjk1Qzg4OkU2MURCQzoxMzEzOTY1OjZCMDEwMDAyIiwidmlzaXRvcl9pZCI6Ijg0MjE5MjAyNzA2NTQxNzcyODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7c0a94faff2a34aa4ffb57ac84abde739ee3564b79b7b176289064affbf55fc6
hovercard-subject-tagpull_request:1287893853
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/49572/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:alt… blocking The navigation transition clears the current navigation in the finalize operator of the current navigation Observer. This commit both completes the bootstrapDone observable and updates t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/49572/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49572%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49572%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/49572/files
Reloadhttps://github.com/angular/angular/pull/49572/files
Reloadhttps://github.com/angular/angular/pull/49572/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:completethenavigationhttps://github.com/atscott/angular/tree/completethenavigation
Conversation 6 https://github.com/angular/angular/pull/49572
Commits 1 https://github.com/angular/angular/pull/49572/commits
Checks 0 https://github.com/angular/angular/pull/49572/checks
Files changed https://github.com/angular/angular/pull/49572/files
Please reload this pagehttps://github.com/angular/angular/pull/49572/files
fix(router): Ensure initial navigation clears current navigation when… https://github.com/angular/angular/pull/49572/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/49572/files
dc7ead4 fix(router): Ensure initial navigation clears current navigation when… atscott Mar 23, 2023 https://github.com/angular/angular/pull/49572/commits/dc7ead4160900874ea5a81b46a5f49b584beb72a
Clear filters https://github.com/angular/angular/pull/49572/files
Please reload this pagehttps://github.com/angular/angular/pull/49572/files
Please reload this pagehttps://github.com/angular/angular/pull/49572/files
navigation_transition.ts https://github.com/angular/angular/pull/49572/files#diff-c4c1d7a8c2c72273b72db39318a243007232433efad02fb75564006e40b286ee
provide_router.ts https://github.com/angular/angular/pull/49572/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
bootstrap.spec.ts https://github.com/angular/angular/pull/49572/files#diff-f809521defda82427d4635083824cac7e7d083fc5bcfd5dedf3e24be89d936d2
packages/router/src/navigation_transition.tshttps://github.com/angular/angular/pull/49572/files#diff-c4c1d7a8c2c72273b72db39318a243007232433efad02fb75564006e40b286ee
View file https://github.com/atscott/angular/blob/dc7ead4160900874ea5a81b46a5f49b584beb72a/packages/router/src/navigation_transition.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49572/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49572/files#diff-c4c1d7a8c2c72273b72db39318a243007232433efad02fb75564006e40b286ee
https://github.com/angular/angular/pull/49572/files#diff-c4c1d7a8c2c72273b72db39318a243007232433efad02fb75564006e40b286ee
packages/router/src/provide_router.tshttps://github.com/angular/angular/pull/49572/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
View file https://github.com/atscott/angular/blob/dc7ead4160900874ea5a81b46a5f49b584beb72a/packages/router/src/provide_router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49572/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49572/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
https://github.com/angular/angular/pull/49572/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
packages/router/test/bootstrap.spec.tshttps://github.com/angular/angular/pull/49572/files#diff-f809521defda82427d4635083824cac7e7d083fc5bcfd5dedf3e24be89d936d2
View file https://github.com/atscott/angular/blob/dc7ead4160900874ea5a81b46a5f49b584beb72a/packages/router/test/bootstrap.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49572/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49572/files#diff-f809521defda82427d4635083824cac7e7d083fc5bcfd5dedf3e24be89d936d2
https://github.com/angular/angular/pull/49572/files#diff-f809521defda82427d4635083824cac7e7d083fc5bcfd5dedf3e24be89d936d2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.