René's URL Explorer Experiment


Title: build(docs-infra): fix example e2e tests not failing properly in some situations by devversion · Pull Request #49293 · angular/angular · GitHub

Open Graph Title: build(docs-infra): fix example e2e tests not failing properly in some situations by devversion · Pull Request #49293 · angular/angular

X Title: build(docs-infra): fix example e2e tests not failing properly in some situations by devversion · Pull Request #49293 · angular/angular

Description: The run-example-e2e script does not properly fail if configured tests of examples are failing. This happens when a CLI example configures multiple tests in the example-config. Due to incorrect usage of promises in combination with reduce, only the last test command had an effect on the overall test conclusion. A similar issue seems to occur with SystemJS Protractor tests. This commit fixes the problem and also cleans up the code a little by switching it to async/await. Additionally we fix the following two things: Examples that were already broken but just didn't fail.. Local AIO tests had significant failures where incorrect transitive local dependencies were resolved..

Open Graph Description: The run-example-e2e script does not properly fail if configured tests of examples are failing. This happens when a CLI example configures multiple tests in the example-config. Due to incorrect usag...

X Description: The run-example-e2e script does not properly fail if configured tests of examples are failing. This happens when a CLI example configures multiple tests in the example-config. Due to incorrect usag...

Opengraph URL: https://github.com/angular/angular/pull/49293

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6e83fa49-ed24-1135-76d7-0bc9a6a675e9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0BC:10531B:1E0D4B2:2670119:6B01A941
html-safe-nonce03dba30def02d8c82f283aea462d24ed8bb859786f866b5d928b2cee510e5aae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMEJDOjEwNTMxQjoxRTBENEIyOjI2NzAxMTk6NkIwMUE5NDEiLCJ2aXNpdG9yX2lkIjoiNTUwMDI0NzYyMzQyNjIyMjQwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6f3a79ec3c900f51665363c2af1a06e9fc860530d30f82e344c7a3ac45cbc31e
hovercard-subject-tagpull_request:1260789331
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/49293/files
twitter:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
og:image:altThe run-example-e2e script does not properly fail if configured tests of examples are failing. This happens when a CLI example configures multiple tests in the example-config. Due to incorrect usag...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/49293/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49293%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49293%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/49293/files
Reloadhttps://github.com/angular/angular/pull/49293/files
Reloadhttps://github.com/angular/angular/pull/49293/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests143 (143)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
devversionhttps://github.com/devversion
angular:mainhttps://github.com/angular/angular/tree/main
devversion:fix-e2e-example-testinghttps://github.com/devversion/angular/tree/fix-e2e-example-testing
Conversation 3 https://github.com/angular/angular/pull/49293
Commits 7 https://github.com/angular/angular/pull/49293/commits
Checks 0 https://github.com/angular/angular/pull/49293/checks
Files changed https://github.com/angular/angular/pull/49293/files
Please reload this pagehttps://github.com/angular/angular/pull/49293/files
build(docs-infra): fix example e2e tests not failing properly in some situations https://github.com/angular/angular/pull/49293/files#top
Show all changes 7 commits https://github.com/angular/angular/pull/49293/files
5caa3c7 build: format `run-example-e2e.mjs` with prettier devversion Mar 2, 2023 https://github.com/angular/angular/pull/49293/commits/5caa3c7a6e033523b7eb4bceccf7023e567d8a41
3c4f752 build(docs-infra): fix example e2e tests not failing properly in some… devversion Mar 2, 2023 https://github.com/angular/angular/pull/49293/commits/3c4f75279cb64f684ed7ea768ec8a52dbf0ddd0f
92dde7f test: fix node and dom types conflict in `practical-observable-usage`… devversion Mar 3, 2023 https://github.com/angular/angular/pull/49293/commits/92dde7f181792bd62381cafa97ce145df45baab4
56a38dd build: fix AIO local e2e examples picking up incorrect dependencies devversion Mar 3, 2023 https://github.com/angular/angular/pull/49293/commits/56a38dd44c1738b51284431541163d11d73315f1
639e5bc build: ensure chromium is not using sandbox within Bazel sandbox for … devversion Mar 3, 2023 https://github.com/angular/angular/pull/49293/commits/639e5bcb01d08bdb59272592b62efdf91938ec7d
7f7afb7 build: always preserve symlinks when executing e2e test commands devversion Mar 3, 2023 https://github.com/angular/angular/pull/49293/commits/7f7afb74373f666f248be81c1b50be927f72c002
08dacb4 test: fix router testing example breaking due to non-existent stub devversion Mar 3, 2023 https://github.com/angular/angular/pull/49293/commits/08dacb4a948bca931f7024bb10f6d86f28414a34
Clear filters https://github.com/angular/angular/pull/49293/files
Please reload this pagehttps://github.com/angular/angular/pull/49293/files
Please reload this pagehttps://github.com/angular/angular/pull/49293/files
example-config.json https://github.com/angular/angular/pull/49293/files#diff-c5ae56c77220fb86e71fbbbe2eac223a2c6c6a302c72b5b4bf085a76bb1d1bfe
example-config.json https://github.com/angular/angular/pull/49293/files#diff-37a934d668e1cd0abd7b1a56d2b0f192eb0f7a69bd94e21f6f777884d0b4dfa7
typeahead.spec.ts https://github.com/angular/angular/pull/49293/files#diff-df6cc20c32f45135d4b4e64d86d41ba843cf3270cbc63fb1a111048da2654088
example-config.json https://github.com/angular/angular/pull/49293/files#diff-28ffabdd00567fd152a0b3bb7d24f522fa9e8974d014264de8528c1e46b1a324
example-config.json https://github.com/angular/angular/pull/49293/files#diff-bc8b017d30e7af7e085f77fffdeb3d8bbac58500828479bc6df431f433cdd14f
hero-detail.component.no-testbed.spec.ts https://github.com/angular/angular/pull/49293/files#diff-37c96537c9861bad9760f54c088ebbc33c3c9eb3150132ce3d2e945e2ef68ae5
example-config.json https://github.com/angular/angular/pull/49293/files#diff-c5857c4c85dd28701a784f88feb95ca43487e76efd9808549aced151b161199a
example-sandbox.mjs https://github.com/angular/angular/pull/49293/files#diff-ec2d41093be79b189af2eca6429df50b51f2c07e0dd55ad19b374618e885348d
run-example-e2e.mjs https://github.com/angular/angular/pull/49293/files#diff-2bb203c749eb393e1596af31197ef437a63f87fd6ac87dc6222b89f70fee37cf
protractor-bazel.conf.js https://github.com/angular/angular/pull/49293/files#diff-5b862e5c937525d97f7cae7761e31c0f78db8287e668d9990940e5ebca087565
aio/content/examples/forms-overview/example-config.jsonhttps://github.com/angular/angular/pull/49293/files#diff-c5ae56c77220fb86e71fbbbe2eac223a2c6c6a302c72b5b4bf085a76bb1d1bfe
View file https://github.com/devversion/angular/blob/08dacb4a948bca931f7024bb10f6d86f28414a34/aio/content/examples/forms-overview/example-config.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49293/{{ revealButtonHref }}
aio/content/examples/http/example-config.jsonhttps://github.com/angular/angular/pull/49293/files#diff-37a934d668e1cd0abd7b1a56d2b0f192eb0f7a69bd94e21f6f777884d0b4dfa7
View file https://github.com/devversion/angular/blob/08dacb4a948bca931f7024bb10f6d86f28414a34/aio/content/examples/http/example-config.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49293/{{ revealButtonHref }}
aio/content/examples/practical-observable-usage/src/typeahead.spec.tshttps://github.com/angular/angular/pull/49293/files#diff-df6cc20c32f45135d4b4e64d86d41ba843cf3270cbc63fb1a111048da2654088
View file https://github.com/devversion/angular/blob/08dacb4a948bca931f7024bb10f6d86f28414a34/aio/content/examples/practical-observable-usage/src/typeahead.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49293/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49293/files#diff-df6cc20c32f45135d4b4e64d86d41ba843cf3270cbc63fb1a111048da2654088
https://github.com/angular/angular/pull/49293/files#diff-df6cc20c32f45135d4b4e64d86d41ba843cf3270cbc63fb1a111048da2654088
https://github.com/angular/angular/pull/49293/files#diff-df6cc20c32f45135d4b4e64d86d41ba843cf3270cbc63fb1a111048da2654088
https://github.com/angular/angular/pull/49293/files#diff-df6cc20c32f45135d4b4e64d86d41ba843cf3270cbc63fb1a111048da2654088
aio/content/examples/setup/example-config.jsonhttps://github.com/angular/angular/pull/49293/files#diff-28ffabdd00567fd152a0b3bb7d24f522fa9e8974d014264de8528c1e46b1a324
View file https://github.com/devversion/angular/blob/08dacb4a948bca931f7024bb10f6d86f28414a34/aio/content/examples/setup/example-config.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49293/{{ revealButtonHref }}
aio/content/examples/testing/example-config.jsonhttps://github.com/angular/angular/pull/49293/files#diff-bc8b017d30e7af7e085f77fffdeb3d8bbac58500828479bc6df431f433cdd14f
View file https://github.com/devversion/angular/blob/08dacb4a948bca931f7024bb10f6d86f28414a34/aio/content/examples/testing/example-config.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49293/{{ revealButtonHref }}
aio/content/examples/testing/src/app/hero/hero-detail.component.no-testbed.spec.tshttps://github.com/angular/angular/pull/49293/files#diff-37c96537c9861bad9760f54c088ebbc33c3c9eb3150132ce3d2e945e2ef68ae5
View file https://github.com/angular/angular/blob/51d7cfbac69c810018e5b3c1fb1ae2abdadb8262/aio/content/examples/testing/src/app/hero/hero-detail.component.no-testbed.spec.ts
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/angular/angular/pull/49293/files
aio/content/examples/toh-pt6/example-config.jsonhttps://github.com/angular/angular/pull/49293/files#diff-c5857c4c85dd28701a784f88feb95ca43487e76efd9808549aced151b161199a
View file https://github.com/devversion/angular/blob/08dacb4a948bca931f7024bb10f6d86f28414a34/aio/content/examples/toh-pt6/example-config.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49293/{{ revealButtonHref }}
aio/tools/examples/example-sandbox.mjshttps://github.com/angular/angular/pull/49293/files#diff-ec2d41093be79b189af2eca6429df50b51f2c07e0dd55ad19b374618e885348d
View file https://github.com/devversion/angular/blob/08dacb4a948bca931f7024bb10f6d86f28414a34/aio/tools/examples/example-sandbox.mjs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/49293/{{ revealButtonHref }}
https://github.com/angular/angular/pull/49293/files#diff-ec2d41093be79b189af2eca6429df50b51f2c07e0dd55ad19b374618e885348d
https://github.com/angular/angular/pull/49293/files#diff-ec2d41093be79b189af2eca6429df50b51f2c07e0dd55ad19b374618e885348d
https://github.com/angular/angular/pull/49293/files#diff-ec2d41093be79b189af2eca6429df50b51f2c07e0dd55ad19b374618e885348d
https://github.com/angular/angular/pull/49293/files#diff-ec2d41093be79b189af2eca6429df50b51f2c07e0dd55ad19b374618e885348d
https://github.com/angular/angular/pull/49293/files#diff-ec2d41093be79b189af2eca6429df50b51f2c07e0dd55ad19b374618e885348d
Please reload this pagehttps://github.com/angular/angular/pull/49293/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.