| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4342ef2f-4bd3-3aa4-cfd8-1621d329909e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AB42:215B92:E8FFEE:136FC4E:6B01096C |
| html-safe-nonce | bbe05bc57c52ef562656ec8798f2c0dee4e5e99154fad3cc7e9178a263edec6f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjQyOjIxNUI5MjpFOEZGRUU6MTM2RkM0RTo2QjAxMDk2QyIsInZpc2l0b3JfaWQiOiI2MDQzNTc0ODMxNDgzMjQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 96f61cff1c325191ccfa5bba5da40e3e91c410897202eea537c9b085f026dc10 |
| hovercard-subject-tag | pull_request:1254637163 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/49221/files |
| twitter:image | https://avatars.githubusercontent.com/u/1300985?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1300985?s=400&v=4 |
| og:image:alt | This commit removes the remaining TODO(issue/24571) in core code base.
In the core code base most TODOs were on spec files where it is acceptable to have non-null assertions.
See also the PRs about... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/49221/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49221%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49221%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/49221/files |
| Reload | https://github.com/angular/angular/pull/49221/files |
| Reload | https://github.com/angular/angular/pull/49221/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| JeanMeche | https://github.com/JeanMeche |
| angular:main | https://github.com/angular/angular/tree/main |
| JeanMeche:chore/coore-24571 | https://github.com/JeanMeche/angular/tree/chore/coore-24571 |
|
Conversation
26
| https://github.com/angular/angular/pull/49221 |
|
Commits
1
| https://github.com/angular/angular/pull/49221/commits |
|
Checks
0
| https://github.com/angular/angular/pull/49221/checks |
|
Files changed
| https://github.com/angular/angular/pull/49221/files |
| Please reload this page | https://github.com/angular/angular/pull/49221/files |
|
refactor(core): handle #24571 todos.
| https://github.com/angular/angular/pull/49221/files#top |
|
Show all changes
1 commit
| https://github.com/angular/angular/pull/49221/files |
|
9a770e6
refactor(core): handle #24571 todos.
JeanMeche Feb 26, 2023
| https://github.com/angular/angular/pull/49221/commits/9a770e687c00ad5c93ebf8b0d80670cca735775b |
|
Clear filters
| https://github.com/angular/angular/pull/49221/files |
| Please reload this page | https://github.com/angular/angular/pull/49221/files |
| Please reload this page | https://github.com/angular/angular/pull/49221/files |
|
default_iterable_differ.ts
| https://github.com/angular/angular/pull/49221/files#diff-67b1eb63c852b68b307e68c8a786231f822d5c657c4d7494466f71836e1c98c6 |
|
api.ts
| https://github.com/angular/angular/pull/49221/files#diff-27d607ed41e9c29ab0b7613e43c3bd0e00da2b7da742b5c371329530f14bcbcc |
|
i18n_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-70005ce05bc2036b8ed97ea6f0097d87e0c223186c513e308e6cdabab47ef924 |
|
animation_integration_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
animation_query_integration_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-aaf1bf1c70eaa94277253fbd9c7c196f233121d892c0b884c08f8feed49e1445 |
|
animations_with_web_animations_integration_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-9b996953316ac04cb64b448614b2e188ad042a171a2a08d3c72536e14fd957df |
|
application_ref_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-afa1cbf5d6f53fbdb7d6024f388412fc4e0f805606492ebd36d5edf98c5a0b4f |
|
index.ts
| https://github.com/angular/angular/pull/49221/files#diff-732552566461d63a66b083390ea8fa4672d652d4ecfadd84e2fa9e66c975f96a |
|
debug_node_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-b58ddaf793e92367cae39049d6bf5c7fa938d125bdcd0cd4a10a7c6a7611953c |
|
forward_ref_integration_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-a0758e9252ce17d1f62538d8d025a78593f9afd9304b77c9987db7da57477fdf |
|
change_detection_integration_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-27b3dbc8c869a842685bc9126f8b1b0c12dba63f46eaadc9dd599853bb4aa5e7 |
|
integration_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-6c4b76ffae8d7951899be9c4be6c3d7ed2147cca8d29c71a31f31fda563f4fc3 |
|
ng_container_integration_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-0b49cce2c09702cb217753ef037c02b535f1abea9564395ee66bcb89c89fe9ad |
|
ng_module_integration_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-f522598682a2140c3b088137a50ab95eb919f2b0ce0d17a65d03b3037dce02f8 |
|
query_integration_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-4e06604fb325539d0d573671ffc7f8d740137f081f37426011fedc6c25a4a8c8 |
|
regression_integration_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-545ef95585c6050f8a03a7b13a64d7ca35322644a12e41c0675649bcd18fe811 |
|
resource_loader_mock.ts
| https://github.com/angular/angular/pull/49221/files#diff-eae2a32f9113c0fdd60fa9b46bb079891ac12751d7ba011f519ae6eff14986ed |
|
security_integration_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-c600fb729e6d592bd1e1578516c56a1d878422664b4fde5aa975c26c8f8ebf76 |
|
di_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-beb2d4b722e20a01591534829b6929adb4186092c26a7a269ce15797986887c7 |
|
instructions_spec.ts
| https://github.com/angular/angular/pull/49221/files#diff-d1f3b8b7b6243d70135b58dae246b22df046dde8ec08e217a8cc4537f990c531 |
| packages/core/src/change_detection/differs/default_iterable_differ.ts | https://github.com/angular/angular/pull/49221/files#diff-67b1eb63c852b68b307e68c8a786231f822d5c657c4d7494466f71836e1c98c6 |
|
View file
| https://github.com/JeanMeche/angular/blob/9a770e687c00ad5c93ebf8b0d80670cca735775b/packages/core/src/change_detection/differs/default_iterable_differ.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/49221/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/49221/files#diff-67b1eb63c852b68b307e68c8a786231f822d5c657c4d7494466f71836e1c98c6 |
| JeanMeche | https://github.com/JeanMeche |
| Feb 26, 2023 | https://github.com/angular/angular/pull/49221/files#r1118175520 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/49221/files |
|
| https://github.com/angular/angular/pull/49221/files#diff-67b1eb63c852b68b307e68c8a786231f822d5c657c4d7494466f71836e1c98c6 |
|
| https://github.com/angular/angular/pull/49221/files#diff-67b1eb63c852b68b307e68c8a786231f822d5c657c4d7494466f71836e1c98c6 |
| JeanMeche | https://github.com/JeanMeche |
| Feb 26, 2023 | https://github.com/angular/angular/pull/49221/files#r1118172926 |
| Please reload this page | https://github.com/angular/angular/pull/49221/files |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/49221/files |
| JeanMeche | https://github.com/JeanMeche |
| Jun 6, 2023 | https://github.com/angular/angular/pull/49221/files#r1220116671 |
| Please reload this page | https://github.com/angular/angular/pull/49221/files |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #49754 | https://github.com/angular/angular/pull/49754 |
| Please reload this page | https://github.com/angular/angular/pull/49221/files |
|
| https://github.com/angular/angular/pull/49221/files#diff-67b1eb63c852b68b307e68c8a786231f822d5c657c4d7494466f71836e1c98c6 |
| packages/core/src/render/api.ts | https://github.com/angular/angular/pull/49221/files#diff-27d607ed41e9c29ab0b7613e43c3bd0e00da2b7da742b5c371329530f14bcbcc |
|
View file
| https://github.com/JeanMeche/angular/blob/9a770e687c00ad5c93ebf8b0d80670cca735775b/packages/core/src/render/api.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/49221/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/49221/files#diff-27d607ed41e9c29ab0b7613e43c3bd0e00da2b7da742b5c371329530f14bcbcc |
|
| https://github.com/angular/angular/pull/49221/files#diff-27d607ed41e9c29ab0b7613e43c3bd0e00da2b7da742b5c371329530f14bcbcc |
| packages/core/test/acceptance/i18n_spec.ts | https://github.com/angular/angular/pull/49221/files#diff-70005ce05bc2036b8ed97ea6f0097d87e0c223186c513e308e6cdabab47ef924 |
|
View file
| https://github.com/JeanMeche/angular/blob/9a770e687c00ad5c93ebf8b0d80670cca735775b/packages/core/test/acceptance/i18n_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/49221/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/49221/files#diff-70005ce05bc2036b8ed97ea6f0097d87e0c223186c513e308e6cdabab47ef924 |
|
| https://github.com/angular/angular/pull/49221/files#diff-70005ce05bc2036b8ed97ea6f0097d87e0c223186c513e308e6cdabab47ef924 |
|
| https://github.com/angular/angular/pull/49221/files#diff-70005ce05bc2036b8ed97ea6f0097d87e0c223186c513e308e6cdabab47ef924 |
|
| https://github.com/angular/angular/pull/49221/files#diff-70005ce05bc2036b8ed97ea6f0097d87e0c223186c513e308e6cdabab47ef924 |
| packages/core/test/animation/animation_integration_spec.ts | https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
View file
| https://github.com/JeanMeche/angular/blob/9a770e687c00ad5c93ebf8b0d80670cca735775b/packages/core/test/animation/animation_integration_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/49221/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
|
| https://github.com/angular/angular/pull/49221/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039 |
| Please reload this page | https://github.com/angular/angular/pull/49221/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |