| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f9b01b04-ed98-bb61-5560-190f92d35856 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E4C4:2463BD:121F62A:1746623:6B010E35 |
| html-safe-nonce | d334156dbcf6e6b4e405a2b01b3fca471389057dc157013e0003a6fbd72ea9e6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEM0OjI0NjNCRDoxMjFGNjJBOjE3NDY2MjM6NkIwMTBFMzUiLCJ2aXNpdG9yX2lkIjoiNTc1OTM0NDQ4NDc4OTg0OTY1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6a5c8900b533089235c24309a8cb66e8dfb9f8af15cd8c95eef39c2e0159231e |
| hovercard-subject-tag | pull_request:1254626176 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/49220/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/558b7d335cf9c620b5521650d2a5782861ad9c0a7270f5f4c08347100d262554/angular/angular/pull/49220 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/558b7d335cf9c620b5521650d2a5782861ad9c0a7270f5f4c08347100d262554/angular/angular/pull/49220 |
| og:image:alt | I looking to tackle the ~200ish TODOs related to #24571 to finally close it.
This commit removes the remaining ones in compiler code base
Does this PR introduce a breaking change?
No
See also th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JeanMeche |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/49220#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49220 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49220 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/49220 |
| Reload | https://github.com/angular/angular/pull/49220 |
| Reload | https://github.com/angular/angular/pull/49220 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| JeanMeche | https://github.com/JeanMeche |
| angular:main | https://github.com/angular/angular/tree/main |
| JeanMeche:compiler-24571 | https://github.com/JeanMeche/angular/tree/compiler-24571 |
| Conversation | https://github.com/angular/angular/pull/49220 |
| Commits1 (1) | https://github.com/angular/angular/pull/49220/commits |
| Checks | https://github.com/angular/angular/pull/49220/checks |
| Files changed | https://github.com/angular/angular/pull/49220/files |
| refactor(compiler): handle #24571 todos. | https://github.com/angular/angular/pull/49220#top |
| JeanMeche | https://github.com/JeanMeche |
| angular:main | https://github.com/angular/angular/tree/main |
| JeanMeche:compiler-24571 | https://github.com/JeanMeche/angular/tree/compiler-24571 |
|
| https://github.com/JeanMeche |
| JeanMeche | https://github.com/JeanMeche |
| Feb 26, 2023 | https://github.com/angular/angular/pull/49220#issue-1600228763 |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| #24571 | https://github.com/angular/angular/issues/24571 |
| #24571 | https://github.com/angular/angular/issues/24571 |
| refactor(core): handle #24571 todos. #49221 | https://github.com/angular/angular/pull/49221 |
| refactor(animations): handle #24571 todos #49231 | https://github.com/angular/angular/pull/49231 |
| refactor(platform-browser): handle #24571 todos #49232 | https://github.com/angular/angular/pull/49232 |
| refactor: handle #24571 todos for examples/platform-server/elements #49233 | https://github.com/angular/angular/pull/49233 |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| atscott | https://github.com/atscott |
| dgp1130 | https://github.com/dgp1130 |
| February 26, 2023 22:39 | https://github.com/angular/angular/pull/49220#event-8610315243 |
| https://github.com/JeanMeche |
| JeanMeche | https://github.com/JeanMeche |
|
Feb 26, 2023
| https://github.com/angular/angular/pull/49220#pullrequestreview-1314742543 |
|
View reviewed changes
| https://github.com/angular/angular/pull/49220/files |
| packages/compiler/test/integration_spec.ts | https://github.com/angular/angular/pull/49220/files#diff-404146409d7e9864739f86a1719f585da266f50168dd96836cf54bc4f7482ca9 |
| JeanMeche | https://github.com/JeanMeche |
| Feb 26, 2023 | https://github.com/angular/angular/pull/49220#discussion_r1118165550 |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| https://github.com/JeanMeche |
| JeanMeche | https://github.com/JeanMeche |
|
Feb 26, 2023
| https://github.com/angular/angular/pull/49220#ref-pullrequest-1600241912 |
|
refactor(core): handle #24571 todos.
#49221
| https://github.com/angular/angular/pull/49221 |
| https://github.com/JeanMeche |
| JeanMeche | https://github.com/JeanMeche |
| force-pushed | https://github.com/angular/angular/compare/56e276c599247fdc2712346a895ed6f211cd0721..7c19308f3573a584b44756c6037d3c4615d6f4af |
| 56e276c | https://github.com/angular/angular/commit/56e276c599247fdc2712346a895ed6f211cd0721 |
| 7c19308 | https://github.com/angular/angular/commit/7c19308f3573a584b44756c6037d3c4615d6f4af |
|
Compare
| https://github.com/angular/angular/compare/56e276c599247fdc2712346a895ed6f211cd0721..7c19308f3573a584b44756c6037d3c4615d6f4af |
| February 26, 2023 23:26 | https://github.com/angular/angular/pull/49220#event-8610387122 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Feb 27, 2023
| https://github.com/angular/angular/pull/49220#pullrequestreview-1316133595 |
|
View reviewed changes
| https://github.com/angular/angular/pull/49220/files |
| packages/compiler/src/constant_pool.ts | https://github.com/angular/angular/pull/49220/files#diff-5055e3ac4d274484b17b4c8d7a25daf73521e072a8e9ff787c1fbecebe403225 |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| packages/compiler/src/i18n/serializers/xliff2.ts | https://github.com/angular/angular/pull/49220/files#diff-31f7749e84042beda6319672802302eab21804598a437701be501794a53dbdcf |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| packages/compiler/src/i18n/serializers/xliff2.ts | https://github.com/angular/angular/pull/49220/files#diff-31f7749e84042beda6319672802302eab21804598a437701be501794a53dbdcf |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| https://github.com/JeanMeche |
| JeanMeche | https://github.com/JeanMeche |
| force-pushed | https://github.com/angular/angular/compare/7c19308f3573a584b44756c6037d3c4615d6f4af..6c40c131e67302cc5291a8d1e35f3f9378f696cd |
| 7c19308 | https://github.com/angular/angular/commit/7c19308f3573a584b44756c6037d3c4615d6f4af |
| 6c40c13 | https://github.com/angular/angular/commit/6c40c131e67302cc5291a8d1e35f3f9378f696cd |
|
Compare
| https://github.com/angular/angular/compare/7c19308f3573a584b44756c6037d3c4615d6f4af..6c40c131e67302cc5291a8d1e35f3f9378f696cd |
| February 27, 2023 18:19 | https://github.com/angular/angular/pull/49220#event-8618893047 |
| https://github.com/JeanMeche |
| JeanMeche | https://github.com/JeanMeche |
| atscott | https://github.com/atscott |
| dgp1130 | https://github.com/dgp1130 |
| February 27, 2023 18:20 | https://github.com/angular/angular/pull/49220#event-8618894261 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| dgp1130 | https://github.com/dgp1130 |
| February 27, 2023 18:20 | https://github.com/angular/angular/pull/49220#event-8618896176 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Feb 27, 2023
| https://github.com/angular/angular/pull/49220#pullrequestreview-1316203072 |
|
View reviewed changes
| https://github.com/angular/angular/pull/49220/files |
|
refactor(animations): handle #24571 todos
#49231
| https://github.com/angular/angular/pull/49231 |
|
refactor(platform-browser): handle #24571 todos
#49232
| https://github.com/angular/angular/pull/49232 |
|
refactor: handle #24571 todos for examples/platform-server/elements
#49233
| https://github.com/angular/angular/pull/49233 |
|
Remove non-null assertions on common/http
#48241
| https://github.com/angular/angular/pull/48241 |
| https://github.com/jessicajaniuk |
| jessicajaniuk | https://github.com/jessicajaniuk |
|
area: compiler
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22 |
| Mar 2, 2023 | https://github.com/angular/angular/pull/49220#event-8651796168 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Backlog | https://github.com/angular/angular/milestone/82 |
| Mar 2, 2023 | https://github.com/angular/angular/pull/49220#event-8651796737 |
| https://github.com/JeanMeche |
| JeanMeche | https://github.com/JeanMeche |
| Apr 15, 2023 | https://github.com/angular/angular/pull/49220#issuecomment-1509993366 |
| @dgp1130 | https://github.com/dgp1130 |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| https://github.com/dgp1130 |
| dgp1130 | https://github.com/dgp1130 |
| AndrewKushnir | https://github.com/AndrewKushnir |
| dgp1130 | https://github.com/dgp1130 |
| April 17, 2023 20:12 | https://github.com/angular/angular/pull/49220#event-9028764268 |
| https://github.com/dgp1130 |
| dgp1130 | https://github.com/dgp1130 |
| Apr 17, 2023 | https://github.com/angular/angular/pull/49220#issuecomment-1512019770 |
| @AndrewKushnir | https://github.com/AndrewKushnir |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Apr 18, 2023
| https://github.com/angular/angular/pull/49220#pullrequestreview-1389114061 |
|
View reviewed changes
| https://github.com/angular/angular/pull/49220/files |
|
| https://github.com/JeanMeche |
|
| https://github.com/AndrewKushnir |
| refactor(compiler): handle | https://github.com/angular/angular/pull/49220/commits/d29b87bb5eff35f0da0e175ae46c73d18fe0380b |
| angular#24571 | https://github.com/angular/angular/issues/24571 |
| todos. | https://github.com/angular/angular/pull/49220/commits/d29b87bb5eff35f0da0e175ae46c73d18fe0380b |
| d29b87b | https://github.com/angular/angular/pull/49220/commits/d29b87bb5eff35f0da0e175ae46c73d18fe0380b |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| force-pushed | https://github.com/angular/angular/compare/6c40c131e67302cc5291a8d1e35f3f9378f696cd..d29b87bb5eff35f0da0e175ae46c73d18fe0380b |
| 6c40c13 | https://github.com/angular/angular/commit/6c40c131e67302cc5291a8d1e35f3f9378f696cd |
| d29b87b | https://github.com/angular/angular/commit/d29b87bb5eff35f0da0e175ae46c73d18fe0380b |
|
Compare
| https://github.com/angular/angular/compare/6c40c131e67302cc5291a8d1e35f3f9378f696cd..d29b87bb5eff35f0da0e175ae46c73d18fe0380b |
| April 18, 2023 00:43 | https://github.com/angular/angular/pull/49220#event-9030259988 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
|
target: rc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22 |
| Apr 18, 2023 | https://github.com/angular/angular/pull/49220#event-9030265924 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Apr 18, 2023 | https://github.com/angular/angular/pull/49220#issuecomment-1512283533 |
| Presubmit | http://test/OCL:524997685:BASE:524997707:1681778732713:f2e2a14a |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| https://github.com/jessicajaniuk |
| jessicajaniuk | https://github.com/jessicajaniuk |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Apr 18, 2023 | https://github.com/angular/angular/pull/49220#event-9037473030 |
| https://github.com/jessicajaniuk |
| jessicajaniuk | https://github.com/jessicajaniuk |
| Apr 18, 2023 | https://github.com/angular/angular/pull/49220#issuecomment-1513470287 |
| d4ef207 | https://github.com/angular/angular/commit/d4ef20736fe31d729444857346cbd8bda8fff0c2 |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| https://github.com/jessicajaniuk |
| jessicajaniuk | https://github.com/jessicajaniuk |
| d4ef207 | https://github.com/angular/angular/commit/d4ef20736fe31d729444857346cbd8bda8fff0c2 |
| Apr 18, 2023 | https://github.com/angular/angular/pull/49220#event-9038029036 |
| jessicajaniuk | https://github.com/jessicajaniuk |
|
Apr 18, 2023
| https://github.com/angular/angular/pull/49220#ref-commit-27c624e |
|
| https://github.com/JeanMeche |
|
| https://github.com/thePunderWoman |
| refactor(compiler): handle | https://github.com/angular/angular/commit/27c624e8e7c085cce22fb850bd726e9e68ac3343 |
| #24571 | https://github.com/angular/angular/issues/24571 |
| todos. ( | https://github.com/angular/angular/commit/27c624e8e7c085cce22fb850bd726e9e68ac3343 |
| #49220 | https://github.com/angular/angular/pull/49220 |
| ) | https://github.com/angular/angular/commit/27c624e8e7c085cce22fb850bd726e9e68ac3343 |
| 27c624e | https://github.com/angular/angular/commit/27c624e8e7c085cce22fb850bd726e9e68ac3343 |
| #49220 | https://github.com/angular/angular/pull/49220 |
| https://github.com/JeanMeche |
| JeanMeche | https://github.com/JeanMeche |
| April 18, 2023 19:22 | https://github.com/angular/angular/pull/49220#event-9039424563 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| May 19, 2023 | https://github.com/angular/angular/pull/49220#issuecomment-1553824092 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| May 19, 2023 | https://github.com/angular/angular/pull/49220#event-9284649029 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F49220 |
|
| https://github.com/atscott |
|
atscott
| https://github.com/atscott |
|
| https://github.com/angular/angular/pull/49220/files/6c40c131e67302cc5291a8d1e35f3f9378f696cd |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
|
| https://github.com/angular/angular/pull/49220/files/6c40c131e67302cc5291a8d1e35f3f9378f696cd |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: compiler
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22 |
|
target: rc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22 |
|
Backlog
| https://github.com/angular/angular/milestone/82 |
| Please reload this page | https://github.com/angular/angular/pull/49220 |
|
| https://github.com/JeanMeche |
|
| https://github.com/dgp1130 |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/jessicajaniuk |
|
| https://github.com/atscott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |