René's URL Explorer Experiment


Title: fix(forms): Make radio buttons respect `[attr.disabled]` by dylhunn · Pull Request #48864 · angular/angular · GitHub

Open Graph Title: fix(forms): Make radio buttons respect `[attr.disabled]` by dylhunn · Pull Request #48864 · angular/angular

X Title: fix(forms): Make radio buttons respect `[attr.disabled]` by dylhunn · Pull Request #48864 · angular/angular

Description: setDisabledState is supposed to be called whenever the disabled state of a control changes, including upon control creation. However, a longstanding bug caused the method to not fire when an enabled control was attached. This bug was fixed in v15. This had a side effect: previously, it was possible to instantiate a reactive form control with [attr.disabled]=true, even though the the corresponding control was enabled in the model. (Note that the similar-looking property binding version [disabled]=true was always rejected, though.) This resulted in a mismatch between the model and the DOM. Now, because setDisabledState is always called, the value in the DOM will be immediately overwritten with the "correct" enabled value. Users should instead disable the control directly in their model. (There are many ways to do this, such as using the {value: 'foo', disabled: true} constructor format, or immediately calling FooControl.disable() in ngOnInit.) If this incompatibility is too breaking, you may also opt out using FormsModule.withConfig or ReactiveFormsModule.withConfig at the time you import it, via the callSetDisabledState option. However, there is an exceptional case: radio buttons. Because Reactive Forms models the entire group of radio buttons as a single FormControl, there is no way to control the disabled state for individual radios, so they can no longer be configured as disabled. In this PR, we have special cased radio buttons to ignore their first call to setDisabledState when in callSetDisabledState: 'always' mode. This preserves the old behavior. Related to #48350.

Open Graph Description: setDisabledState is supposed to be called whenever the disabled state of a control changes, including upon control creation. However, a longstanding bug caused the method to not fire when an enable...

X Description: setDisabledState is supposed to be called whenever the disabled state of a control changes, including upon control creation. However, a longstanding bug caused the method to not fire when an enable...

Opengraph URL: https://github.com/angular/angular/pull/48864

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0cf1d9bd-0c24-74be-aff1-b622e3d2a364
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id87EC:240CD1:20B9C15:2992F6A:6B017309
html-safe-nonce3a9906f338912f010bf48c9f72f8eeef30600d3bf7f5807a46a5da0c92f1ff82
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0VDOjI0MENEMToyMEI5QzE1OjI5OTJGNkE6NkIwMTczMDkiLCJ2aXNpdG9yX2lkIjoiMzA1NDYyMjkzMjE3NDIwNTcwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8cd6b9850b4c0ea781aa7e8218f2424360fe4ca087b55f6d03e72141627225de
hovercard-subject-tagpull_request:1218659878
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/48864/files
twitter:imagehttps://avatars.githubusercontent.com/u/7135246?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7135246?s=400&v=4
og:image:altsetDisabledState is supposed to be called whenever the disabled state of a control changes, including upon control creation. However, a longstanding bug caused the method to not fire when an enable...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/48864/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F48864%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F48864%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/48864/files
Reloadhttps://github.com/angular/angular/pull/48864/files
Reloadhttps://github.com/angular/angular/pull/48864/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
dylhunnhttps://github.com/dylhunn
angular:mainhttps://github.com/angular/angular/tree/main
dylhunn:sds-radiohttps://github.com/dylhunn/angular/tree/sds-radio
Conversation 21 https://github.com/angular/angular/pull/48864
Commits 1 https://github.com/angular/angular/pull/48864/commits
Checks 0 https://github.com/angular/angular/pull/48864/checks
Files changed https://github.com/angular/angular/pull/48864/files
Please reload this pagehttps://github.com/angular/angular/pull/48864/files
fix(forms): Make radio buttons respect [attr.disabled] https://github.com/angular/angular/pull/48864/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/48864/files
483a50f fix(forms): Make radio buttons respect `[attr.disabled]` dylhunn Jan 27, 2023 https://github.com/angular/angular/pull/48864/commits/483a50fd88783b6481a14fc75590fccea34d520d
Clear filters https://github.com/angular/angular/pull/48864/files
Please reload this pagehttps://github.com/angular/angular/pull/48864/files
Please reload this pagehttps://github.com/angular/angular/pull/48864/files
index.md https://github.com/angular/angular/pull/48864/files#diff-8882a0e878aaf15ecb861d74345ae52f1cdd646d3de282a1cd6a4f2bef998d05
radio_control_value_accessor.ts https://github.com/angular/angular/pull/48864/files#diff-0297262a676681d384b8da647cd7f139a7d94057730b32e16fddd3ee36776bd0
reactive_integration_spec.ts https://github.com/angular/angular/pull/48864/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
goldens/public-api/forms/index.mdhttps://github.com/angular/angular/pull/48864/files#diff-8882a0e878aaf15ecb861d74345ae52f1cdd646d3de282a1cd6a4f2bef998d05
View file https://github.com/dylhunn/angular/blob/483a50fd88783b6481a14fc75590fccea34d520d/goldens/public-api/forms/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/48864/{{ revealButtonHref }}
https://github.com/angular/angular/pull/48864/files#diff-8882a0e878aaf15ecb861d74345ae52f1cdd646d3de282a1cd6a4f2bef998d05
https://github.com/angular/angular/pull/48864/files#diff-8882a0e878aaf15ecb861d74345ae52f1cdd646d3de282a1cd6a4f2bef998d05
packages/forms/src/directives/radio_control_value_accessor.tshttps://github.com/angular/angular/pull/48864/files#diff-0297262a676681d384b8da647cd7f139a7d94057730b32e16fddd3ee36776bd0
View file https://github.com/dylhunn/angular/blob/483a50fd88783b6481a14fc75590fccea34d520d/packages/forms/src/directives/radio_control_value_accessor.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/48864/{{ revealButtonHref }}
https://github.com/angular/angular/pull/48864/files#diff-0297262a676681d384b8da647cd7f139a7d94057730b32e16fddd3ee36776bd0
https://github.com/angular/angular/pull/48864/files#diff-0297262a676681d384b8da647cd7f139a7d94057730b32e16fddd3ee36776bd0
https://github.com/angular/angular/pull/48864/files#diff-0297262a676681d384b8da647cd7f139a7d94057730b32e16fddd3ee36776bd0
https://github.com/angular/angular/pull/48864/files#diff-0297262a676681d384b8da647cd7f139a7d94057730b32e16fddd3ee36776bd0
https://github.com/angular/angular/pull/48864/files#diff-0297262a676681d384b8da647cd7f139a7d94057730b32e16fddd3ee36776bd0
https://github.com/angular/angular/pull/48864/files#diff-0297262a676681d384b8da647cd7f139a7d94057730b32e16fddd3ee36776bd0
https://github.com/angular/angular/pull/48864/files#diff-0297262a676681d384b8da647cd7f139a7d94057730b32e16fddd3ee36776bd0
Please reload this pagehttps://github.com/angular/angular/pull/48864/files
https://github.com/angular/angular/pull/48864/files#diff-0297262a676681d384b8da647cd7f139a7d94057730b32e16fddd3ee36776bd0
packages/forms/test/reactive_integration_spec.tshttps://github.com/angular/angular/pull/48864/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
View file https://github.com/dylhunn/angular/blob/483a50fd88783b6481a14fc75590fccea34d520d/packages/forms/test/reactive_integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/48864/{{ revealButtonHref }}
https://github.com/angular/angular/pull/48864/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
Please reload this pagehttps://github.com/angular/angular/pull/48864/files
Please reload this pagehttps://github.com/angular/angular/pull/48864/files
https://github.com/angular/angular/pull/48864/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
https://github.com/angular/angular/pull/48864/files#diff-9d49b87bd9f813d36f5da177bfee5465c78e2e266129c989bd2035307f364e9d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.