Title: fix(compiler-cli): update `@babel/core` dependency and lock version by devversion · Pull Request #48634 · angular/angular · GitHub
Open Graph Title: fix(compiler-cli): update `@babel/core` dependency and lock version by devversion · Pull Request #48634 · angular/angular
X Title: fix(compiler-cli): update `@babel/core` dependency and lock version by devversion · Pull Request #48634 · angular/angular
Description: Similar to how the @babel/core dependency is managed for the localize NPM package, the version should be locked. Also the version should correspond to the version we install for building & testing. Currently the Babel version allowed by the compiler-cli may not work given the ESM -> CJS interop. causing errors like: import { types as t } from "@babel/core"; ^^^^^ SyntaxError: Named export 'types' not found. The requested module '@babel/core' is a CommonJS module, which may not support all module.exports as named exports. CommonJS modules can always be imported via the default export, for example using: import pkg from '@babel/core'; const { types: t } = pkg; We can only be confident about the interop if we know the version installed- is the one we test. The error above does not surface in integration tests because the Angular CLI brings a more recent Babel version. In components this failed because we had an older version of Babel that breaks the NodeJS CJS/ESM interop. Notes: It previously worked because we had a "hacky" file to make the @babel/core import work (back when the repo also executed the linker code as CommonJS). See: https://github.com/angular/angular/blob/61e69c87e6b577f1c5a71fb5c39c3bd6125c4b91/packages/localize/tools/src/babel_core.ts We cannot simply use the default import for e.g. @babel/template because the types are incorrect. This is a separate issue, but long-term it would be ideal to use the default import always, or have Babel ship an ESM distribution. The latter is in-progress, see babel/babel#15269
Open Graph Description: Similar to how the @babel/core dependency is managed for the localize NPM package, the version should be locked. Also the version should correspond to the version we install for building & test...
X Description: Similar to how the @babel/core dependency is managed for the localize NPM package, the version should be locked. Also the version should correspond to the version we install for building & ...
Opengraph URL: https://github.com/angular/angular/pull/48634
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:854dba1a-7a2f-c738-603f-3081f5553635 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AFD2:311640:6894D8:868247:6B00E135 |
| html-safe-nonce | 8e9a22c4fc1960bcf13ced161f0af445baf23417d2247439eccf02f5ff7fe48e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkQyOjMxMTY0MDo2ODk0RDg6ODY4MjQ3OjZCMDBFMTM1IiwidmlzaXRvcl9pZCI6IjU2MzU1OTgxMTg5ODU3MjAxMTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c71e8f8bd02365e4eb6c0686a1249eb947e97e9cb029936ca9101125dcc6627f |
| hovercard-subject-tag | pull_request:1183682268 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/48634/files |
| twitter:image | https://avatars.githubusercontent.com/u/4987015?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4987015?s=400&v=4 |
| og:image:alt | Similar to how the @babel/core dependency is managed for the localize NPM package, the version should be locked. Also the version should correspond to the version we install for building & test... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width