René's URL Explorer Experiment


Title: fix(compiler-cli): update `@babel/core` dependency and lock version by devversion · Pull Request #48634 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): update `@babel/core` dependency and lock version by devversion · Pull Request #48634 · angular/angular

X Title: fix(compiler-cli): update `@babel/core` dependency and lock version by devversion · Pull Request #48634 · angular/angular

Description: Similar to how the @babel/core dependency is managed for the localize NPM package, the version should be locked. Also the version should correspond to the version we install for building & testing. Currently the Babel version allowed by the compiler-cli may not work given the ESM -> CJS interop. causing errors like: import { types as t } from "@babel/core"; ^^^^^ SyntaxError: Named export 'types' not found. The requested module '@babel/core' is a CommonJS module, which may not support all module.exports as named exports. CommonJS modules can always be imported via the default export, for example using: import pkg from '@babel/core'; const { types: t } = pkg; We can only be confident about the interop if we know the version installed- is the one we test. The error above does not surface in integration tests because the Angular CLI brings a more recent Babel version. In components this failed because we had an older version of Babel that breaks the NodeJS CJS/ESM interop. Notes: It previously worked because we had a "hacky" file to make the @babel/core import work (back when the repo also executed the linker code as CommonJS). See: https://github.com/angular/angular/blob/61e69c87e6b577f1c5a71fb5c39c3bd6125c4b91/packages/localize/tools/src/babel_core.ts We cannot simply use the default import for e.g. @babel/template because the types are incorrect. This is a separate issue, but long-term it would be ideal to use the default import always, or have Babel ship an ESM distribution. The latter is in-progress, see babel/babel#15269

Open Graph Description: Similar to how the @babel/core dependency is managed for the localize NPM package, the version should be locked. Also the version should correspond to the version we install for building & test...

X Description: Similar to how the @babel/core dependency is managed for the localize NPM package, the version should be locked. Also the version should correspond to the version we install for building & ...

Opengraph URL: https://github.com/angular/angular/pull/48634

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:854dba1a-7a2f-c738-603f-3081f5553635
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAFD2:311640:6894D8:868247:6B00E135
html-safe-nonce8e9a22c4fc1960bcf13ced161f0af445baf23417d2247439eccf02f5ff7fe48e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkQyOjMxMTY0MDo2ODk0RDg6ODY4MjQ3OjZCMDBFMTM1IiwidmlzaXRvcl9pZCI6IjU2MzU1OTgxMTg5ODU3MjAxMTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc71e8f8bd02365e4eb6c0686a1249eb947e97e9cb029936ca9101125dcc6627f
hovercard-subject-tagpull_request:1183682268
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/48634/files
twitter:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
og:image:altSimilar to how the @babel/core dependency is managed for the localize NPM package, the version should be locked. Also the version should correspond to the version we install for building & test...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/48634/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F48634%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F48634%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/48634/files
Reloadhttps://github.com/angular/angular/pull/48634/files
Reloadhttps://github.com/angular/angular/pull/48634/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
devversionhttps://github.com/devversion
angular:mainhttps://github.com/angular/angular/tree/main
devversion:update-babel-dephttps://github.com/devversion/angular/tree/update-babel-dep
Conversation 2 https://github.com/angular/angular/pull/48634
Commits 1 https://github.com/angular/angular/pull/48634/commits
Checks 0 https://github.com/angular/angular/pull/48634/checks
Files changed https://github.com/angular/angular/pull/48634/files
Please reload this pagehttps://github.com/angular/angular/pull/48634/files
fix(compiler-cli): update @babel/core dependency and lock version https://github.com/angular/angular/pull/48634/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/48634/files
591997d fix(compiler-cli): update `@babel/core` dependency and lock version devversion Jan 3, 2023 https://github.com/angular/angular/pull/48634/commits/591997d7ac9117eb31c5c391f61e1711eeb14ed6
Clear filters https://github.com/angular/angular/pull/48634/files
Please reload this pagehttps://github.com/angular/angular/pull/48634/files
Please reload this pagehttps://github.com/angular/angular/pull/48634/files
packages/compiler-cli/package.jsonhttps://github.com/angular/angular/pull/48634/files#diff-364608d776f18336d0f25fd0867e8bbc996a4ef1cf1203a1369c1bfde6c8b6a2
View file https://github.com/devversion/angular/blob/591997d7ac9117eb31c5c391f61e1711eeb14ed6/packages/compiler-cli/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/48634/{{ revealButtonHref }}
https://github.com/angular/angular/pull/48634/files#diff-364608d776f18336d0f25fd0867e8bbc996a4ef1cf1203a1369c1bfde6c8b6a2
https://github.com/angular/angular/pull/48634/files#diff-364608d776f18336d0f25fd0867e8bbc996a4ef1cf1203a1369c1bfde6c8b6a2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.