René's URL Explorer Experiment


Title: fix(router): Router.createUrlTree should work with any ActivatedRoute by atscott · Pull Request #48508 · angular/angular · GitHub

Open Graph Title: fix(router): Router.createUrlTree should work with any ActivatedRoute by atscott · Pull Request #48508 · angular/angular

X Title: fix(router): Router.createUrlTree should work with any ActivatedRoute by atscott · Pull Request #48508 · angular/angular

Description: This change makes the createUrlTreeFromSnapshot added in #45877 the default and only behavior in the Router. This now addreses #42191, #38276, #22763, and #48472 without needing to create custom handling to call createUrlTreeFromSnapshot (since it's now called by Router.createUrlTree). BREAKING CHANGE: Tests which mock ActivatedRoute instances may need to be adjusted because Router.createUrlTree now does the right thing in more scenarios. This means that tests with invalid/incomplete ActivatedRoute mocks may behave differently than before. Additionally, tests may now navigate to a real URL where before they would navigate to the root. Ensure that tests provide expected routes to match. There is rarely production impact, but it has been found that relative navigations when using an ActivatedRoute that does not appear in the current router state were effectively ignored in the past. By creating the correct URLs, this sometimes resulted in different navigation behavior in the application. Most often, this happens when attempting to create a navigation that only updates query params using an empty command array, for example router.navigate([], {relativeTo: route, queryParams: newQueryParams}). In this case, the relativeTo property should be removed.

Open Graph Description: This change makes the createUrlTreeFromSnapshot added in #45877 the default and only behavior in the Router. This now addreses #42191, #38276, #22763, and #48472 without needing to create custom ha...

X Description: This change makes the createUrlTreeFromSnapshot added in #45877 the default and only behavior in the Router. This now addreses #42191, #38276, #22763, and #48472 without needing to create custom ha...

Opengraph URL: https://github.com/angular/angular/pull/48508

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:65125b96-2bbd-dca6-0adb-2a4e949c3df8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE46:2454CC:FA85A9:13EB9CE:6B0111DA
html-safe-nonce0cc417e8f2d4f513e6f39f789028c7bd0421ee958057918af85bd04a9f7dddd3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTQ2OjI0NTRDQzpGQTg1QTk6MTNFQjlDRTo2QjAxMTFEQSIsInZpc2l0b3JfaWQiOiIxMjQyMTk4OTQyODg0NjMxMDAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbc85e41c982ccc2a8b3603a7767545c6d82220852262a3920b31e2a32464e731
hovercard-subject-tagpull_request:1167188009
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/48508/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altThis change makes the createUrlTreeFromSnapshot added in #45877 the default and only behavior in the Router. This now addreses #42191, #38276, #22763, and #48472 without needing to create custom ha...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/48508/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F48508%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F48508%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/48508/files
Reloadhttps://github.com/angular/angular/pull/48508/files
Reloadhttps://github.com/angular/angular/pull/48508/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:createUrlTreeFromSnapshotByDefaulthttps://github.com/atscott/angular/tree/createUrlTreeFromSnapshotByDefault
Conversation 14 https://github.com/angular/angular/pull/48508
Commits 1 https://github.com/angular/angular/pull/48508/commits
Checks 0 https://github.com/angular/angular/pull/48508/checks
Files changed https://github.com/angular/angular/pull/48508/files
Please reload this pagehttps://github.com/angular/angular/pull/48508/files
fix(router): Router.createUrlTree should work with any ActivatedRoute https://github.com/angular/angular/pull/48508/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/48508/files
8d2e92f fix(router): Router.createUrlTree should work with any ActivatedRoute atscott Dec 15, 2022 https://github.com/angular/angular/pull/48508/commits/8d2e92f02cdddd41ab1730bd354845055b287e3b
Clear filters https://github.com/angular/angular/pull/48508/files
Please reload this pagehttps://github.com/angular/angular/pull/48508/files
Please reload this pagehttps://github.com/angular/angular/pull/48508/files
bundle.golden_symbols.json https://github.com/angular/angular/pull/48508/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
create_url_tree_strategy.ts https://github.com/angular/angular/pull/48508/files#diff-6668646456861923fb76cc3e8641137a17a942f644da106dcb9bc0cf32361cfb
packages/core/test/bundling/router/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/48508/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
View file https://github.com/atscott/angular/blob/8d2e92f02cdddd41ab1730bd354845055b287e3b/packages/core/test/bundling/router/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/48508/{{ revealButtonHref }}
https://github.com/angular/angular/pull/48508/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/48508/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/48508/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/48508/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/48508/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/48508/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
packages/router/src/create_url_tree_strategy.tshttps://github.com/angular/angular/pull/48508/files#diff-6668646456861923fb76cc3e8641137a17a942f644da106dcb9bc0cf32361cfb
View file https://github.com/atscott/angular/blob/8d2e92f02cdddd41ab1730bd354845055b287e3b/packages/router/src/create_url_tree_strategy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/48508/{{ revealButtonHref }}
https://github.com/angular/angular/pull/48508/files#diff-6668646456861923fb76cc3e8641137a17a942f644da106dcb9bc0cf32361cfb
https://github.com/angular/angular/pull/48508/files#diff-6668646456861923fb76cc3e8641137a17a942f644da106dcb9bc0cf32361cfb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.