René's URL Explorer Experiment


Title: feat(router): Add feature provider for enabling hash navigation by atscott · Pull Request #48301 · angular/angular · GitHub

Open Graph Title: feat(router): Add feature provider for enabling hash navigation by atscott · Pull Request #48301 · angular/angular

X Title: feat(router): Add feature provider for enabling hash navigation by atscott · Pull Request #48301 · angular/angular

Description: The argument against this feature: This isn't a navigation strategy that's very commonly desired. Secondly, the hash strategy is a location configuration in @angular/common and you can use it outside of the Router or with any custom router implementations. So while the net effect of using the router is that it updates the URL which is controlled by the strategy, this feature provider doesn't necessarily need to exist in the Router. The location strategy is an application-wide configuration and affects anything that imports Location. Of course, the Router does this in a few places but plenty of other things might as well. The argument for this feature: Discoverability. While LocationStrategy is technically in @angular/common, the most common use-case is when using it with the Router. Precedence in the RouterModule.forRoot([], {useHash: true}) Precedence in other routing libraries (createWebHashHistory in VueJS and HashRouter in React, for example) The implementation of withHashLocation is much more clear than useHash was. You can look at the function and see that all it's doing is adding the HashLocationStrategy to the providers list. resolves #48295 / #47986

Open Graph Description: The argument against this feature: This isn't a navigation strategy that's very commonly desired. Secondly, the hash strategy is a location configuration in @angular/common and you can use ...

X Description: The argument against this feature: This isn't a navigation strategy that's very commonly desired. Secondly, the hash strategy is a location configuration in @angular/common and you ...

Opengraph URL: https://github.com/angular/angular/pull/48301

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:48b0d557-9e99-4a64-161e-05eb181f355c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3C4:14700E:6BB0A2:8A9272:6B00E11C
html-safe-noncef6293b4a914762513c0f3aee6efa3fb0f072b360448a6541821f78f7b0a53e4d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0M0OjE0NzAwRTo2QkIwQTI6OEE5MjcyOjZCMDBFMTFDIiwidmlzaXRvcl9pZCI6IjI3ODI3NzQ2NTIyMTEwOTM3ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7f00f04e8ec08a8183bbb10a4cd49957d46a62451bb8470a675a1bc349159f9a
hovercard-subject-tagpull_request:1140728163
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/48301/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altThe argument against this feature: This isn't a navigation strategy that's very commonly desired. Secondly, the hash strategy is a location configuration in @angular/common and you can use ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/48301/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F48301%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F48301%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/48301/files
Reloadhttps://github.com/angular/angular/pull/48301/files
Reloadhttps://github.com/angular/angular/pull/48301/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:withHashLocationhttps://github.com/atscott/angular/tree/withHashLocation
Conversation 5 https://github.com/angular/angular/pull/48301
Commits 1 https://github.com/angular/angular/pull/48301/commits
Checks 0 https://github.com/angular/angular/pull/48301/checks
Files changed https://github.com/angular/angular/pull/48301/files
Please reload this pagehttps://github.com/angular/angular/pull/48301/files
feat(router): Add feature provider for enabling hash navigation https://github.com/angular/angular/pull/48301/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/48301/files
c34208d feat(router): Add feature provider for enabling hash navigation atscott Nov 30, 2022 https://github.com/angular/angular/pull/48301/commits/c34208dedc2a855711a967840144359c0a8a3d0f
Clear filters https://github.com/angular/angular/pull/48301/files
Please reload this pagehttps://github.com/angular/angular/pull/48301/files
Please reload this pagehttps://github.com/angular/angular/pull/48301/files
index.md https://github.com/angular/angular/pull/48301/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
index.ts https://github.com/angular/angular/pull/48301/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
provide_router.ts https://github.com/angular/angular/pull/48301/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
goldens/public-api/router/index.mdhttps://github.com/angular/angular/pull/48301/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
View file https://github.com/atscott/angular/blob/c34208dedc2a855711a967840144359c0a8a3d0f/goldens/public-api/router/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/48301/{{ revealButtonHref }}
https://github.com/angular/angular/pull/48301/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/48301/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/48301/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/48301/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
packages/router/src/index.tshttps://github.com/angular/angular/pull/48301/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
View file https://github.com/atscott/angular/blob/c34208dedc2a855711a967840144359c0a8a3d0f/packages/router/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/48301/{{ revealButtonHref }}
https://github.com/angular/angular/pull/48301/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
https://github.com/angular/angular/pull/48301/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
packages/router/src/provide_router.tshttps://github.com/angular/angular/pull/48301/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
View file https://github.com/atscott/angular/blob/c34208dedc2a855711a967840144359c0a8a3d0f/packages/router/src/provide_router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/48301/{{ revealButtonHref }}
https://github.com/angular/angular/pull/48301/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
https://github.com/angular/angular/pull/48301/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
https://github.com/angular/angular/pull/48301/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
https://github.com/angular/angular/pull/48301/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.