René's URL Explorer Experiment


Title: refactor(router): Remove unnecessary logic in enabledBlocking option by atscott · Pull Request #48064 · angular/angular · GitHub

Open Graph Title: refactor(router): Remove unnecessary logic in enabledBlocking option by atscott · Pull Request #48064 · angular/angular

X Title: refactor(router): Remove unnecessary logic in enabledBlocking option by atscott · Pull Request #48064 · angular/angular

Description: The initNavigated flag is not necessary. The way enabledBlocking works is by blocking any navigations from finishing until the application has bootstrapped. The bootstrap is unblocked as soon as we hit the afterPreactivation step. After that point, afterPreactivation is always unblocked because the bootstrapDone Subject is completed/stopped. There is no need for an additional variable to track this information.

Open Graph Description: The initNavigated flag is not necessary. The way enabledBlocking works is by blocking any navigations from finishing until the application has bootstrapped. The bootstrap is unblocked as soon as we...

X Description: The initNavigated flag is not necessary. The way enabledBlocking works is by blocking any navigations from finishing until the application has bootstrapped. The bootstrap is unblocked as soon as we...

Opengraph URL: https://github.com/angular/angular/pull/48064

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:319dfcbf-aacc-96f8-4abb-a1cfc6da2d11
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C6C:24ACB9:18A927D:20612C2:6B013686
html-safe-nonced98bf33bc6da9e534a1303836245c15f84d2a4ab8c539c897f67685e9eef9f23
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzZDOjI0QUNCOToxOEE5MjdEOjIwNjEyQzI6NkIwMTM2ODYiLCJ2aXNpdG9yX2lkIjoiNTYwNzMzMDUyMTE0NDE3ODMxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacebd6e7c31090a17666730e4ace789ad970b988d77f177ae203996fc8b23ba2ed
hovercard-subject-tagpull_request:1123160883
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/48064/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altThe initNavigated flag is not necessary. The way enabledBlocking works is by blocking any navigations from finishing until the application has bootstrapped. The bootstrap is unblocked as soon as we...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/48064/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F48064%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F48064%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/48064/files
Reloadhttps://github.com/angular/angular/pull/48064/files
Reloadhttps://github.com/angular/angular/pull/48064/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:initnavigatedvarhttps://github.com/atscott/angular/tree/initnavigatedvar
Conversation 4 https://github.com/angular/angular/pull/48064
Commits 2 https://github.com/angular/angular/pull/48064/commits
Checks 0 https://github.com/angular/angular/pull/48064/checks
Files changed https://github.com/angular/angular/pull/48064/files
Please reload this pagehttps://github.com/angular/angular/pull/48064/files
refactor(router): Remove unnecessary logic in enabledBlocking option https://github.com/angular/angular/pull/48064/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/48064/files
982b9e4 refactor(router): Remove unnecessary logic in enabledBlocking option atscott Nov 15, 2022 https://github.com/angular/angular/pull/48064/commits/982b9e438f0533dd2579b09753f3de3109a644aa
dac9acb fixup! refactor(router): Remove unnecessary logic in enabledBlocking … atscott Nov 17, 2022 https://github.com/angular/angular/pull/48064/commits/dac9acb241221c0395fa8580f49e37af66d3226b
Clear filters https://github.com/angular/angular/pull/48064/files
Please reload this pagehttps://github.com/angular/angular/pull/48064/files
Please reload this pagehttps://github.com/angular/angular/pull/48064/files
provide_router.ts https://github.com/angular/angular/pull/48064/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
bootstrap.spec.ts https://github.com/angular/angular/pull/48064/files#diff-f809521defda82427d4635083824cac7e7d083fc5bcfd5dedf3e24be89d936d2
packages/router/src/provide_router.tshttps://github.com/angular/angular/pull/48064/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
View file https://github.com/atscott/angular/blob/dac9acb241221c0395fa8580f49e37af66d3226b/packages/router/src/provide_router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/48064/{{ revealButtonHref }}
https://github.com/angular/angular/pull/48064/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
https://github.com/angular/angular/pull/48064/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
https://github.com/angular/angular/pull/48064/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
https://github.com/angular/angular/pull/48064/files#diff-b60f579b6666c0ed6d78acd8ef5c55cfc7b599c9011d5a34fbb2d5dd291da819
packages/router/test/bootstrap.spec.tshttps://github.com/angular/angular/pull/48064/files#diff-f809521defda82427d4635083824cac7e7d083fc5bcfd5dedf3e24be89d936d2
View file https://github.com/atscott/angular/blob/dac9acb241221c0395fa8580f49e37af66d3226b/packages/router/test/bootstrap.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/48064/{{ revealButtonHref }}
https://github.com/angular/angular/pull/48064/files#diff-f809521defda82427d4635083824cac7e7d083fc5bcfd5dedf3e24be89d936d2
https://github.com/angular/angular/pull/48064/files#diff-f809521defda82427d4635083824cac7e7d083fc5bcfd5dedf3e24be89d936d2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.