René's URL Explorer Experiment


Title: fix(language-service): Prevent crashes on unemitable references by dylhunn · Pull Request #47938 · angular/angular · GitHub

Open Graph Title: fix(language-service): Prevent crashes on unemitable references by dylhunn · Pull Request #47938 · angular/angular

X Title: fix(language-service): Prevent crashes on unemitable references by dylhunn · Pull Request #47938 · angular/angular

Description: Currently, when generating an import of a selector, the language service might crash if the compiler cannot emit a reference to the new symbol's file from the target component's file. (This might happen because the two are the same file.) We should handle that case by reusing the existing identifier if possible, or otherwise failing gracefully.

Open Graph Description: Currently, when generating an import of a selector, the language service might crash if the compiler cannot emit a reference to the new symbol's file from the target component's file. (This...

X Description: Currently, when generating an import of a selector, the language service might crash if the compiler cannot emit a reference to the new symbol's file from the target component's fil...

Opengraph URL: https://github.com/angular/angular/pull/47938

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b08d8808-3ac9-84e9-426f-b0452327b21d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BDE:842EC:7B9793:A6E5DC:6B00DF5A
html-safe-nonce2231d5defed24a2d9c9b4f5d767d8b7a7251073997bfc99ae92bb2be3c7aa0d3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkRFOjg0MkVDOjdCOTc5MzpBNkU1REM6NkIwMERGNUEiLCJ2aXNpdG9yX2lkIjoiODUyMTk5NDU1OTEzNDE2Mjc3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3df7dd514f67db27004cfb5289172eb93b2df6b6ba5a8bc9b446d4741b96709b
hovercard-subject-tagpull_request:1107612222
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/47938/files
twitter:imagehttps://avatars.githubusercontent.com/u/7135246?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7135246?s=400&v=4
og:image:altCurrently, when generating an import of a selector, the language service might crash if the compiler cannot emit a reference to the new symbol's file from the target component's file. (This...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/47938/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47938%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47938%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/47938/files
Reloadhttps://github.com/angular/angular/pull/47938/files
Reloadhttps://github.com/angular/angular/pull/47938/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
dylhunnhttps://github.com/dylhunn
angular:mainhttps://github.com/angular/angular/tree/main
dylhunn:same-file-importshttps://github.com/dylhunn/angular/tree/same-file-imports
Conversation 5 https://github.com/angular/angular/pull/47938
Commits 1 https://github.com/angular/angular/pull/47938/commits
Checks 0 https://github.com/angular/angular/pull/47938/checks
Files changed https://github.com/angular/angular/pull/47938/files
Please reload this pagehttps://github.com/angular/angular/pull/47938/files
fix(language-service): Prevent crashes on unemitable references https://github.com/angular/angular/pull/47938/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/47938/files
3620fff fix(language-service): Prevent crashes on unemitable references dylhunn Nov 2, 2022 https://github.com/angular/angular/pull/47938/commits/3620fff43a910afd419ebad17b8fa296b6c6a1b6
Clear filters https://github.com/angular/angular/pull/47938/files
Please reload this pagehttps://github.com/angular/angular/pull/47938/files
Please reload this pagehttps://github.com/angular/angular/pull/47938/files
scope.ts https://github.com/angular/angular/pull/47938/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7
checker.ts https://github.com/angular/angular/pull/47938/files#diff-a0ed0852ff66702fe4085465e0f735265c83782c4afe7fab466b53d87a564580
fix_missing_import.ts https://github.com/angular/angular/pull/47938/files#diff-d021b88eac12fad2e929f49cbf44b66f2dff7edc1056c56885386aff87d0fbaf
packages/compiler-cli/src/ngtsc/typecheck/api/scope.tshttps://github.com/angular/angular/pull/47938/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7
View file https://github.com/dylhunn/angular/blob/3620fff43a910afd419ebad17b8fa296b6c6a1b6/packages/compiler-cli/src/ngtsc/typecheck/api/scope.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47938/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47938/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7
https://github.com/angular/angular/pull/47938/files#diff-0ca5f23353fc254f00e96234a28908dc6a9b21c7fda3972f8cd7f8e18e7f0bf7
packages/compiler-cli/src/ngtsc/typecheck/src/checker.tshttps://github.com/angular/angular/pull/47938/files#diff-a0ed0852ff66702fe4085465e0f735265c83782c4afe7fab466b53d87a564580
View file https://github.com/dylhunn/angular/blob/3620fff43a910afd419ebad17b8fa296b6c6a1b6/packages/compiler-cli/src/ngtsc/typecheck/src/checker.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47938/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47938/files#diff-a0ed0852ff66702fe4085465e0f735265c83782c4afe7fab466b53d87a564580
https://github.com/angular/angular/pull/47938/files#diff-a0ed0852ff66702fe4085465e0f735265c83782c4afe7fab466b53d87a564580
https://github.com/angular/angular/pull/47938/files#diff-a0ed0852ff66702fe4085465e0f735265c83782c4afe7fab466b53d87a564580
https://github.com/angular/angular/pull/47938/files#diff-a0ed0852ff66702fe4085465e0f735265c83782c4afe7fab466b53d87a564580
https://github.com/angular/angular/pull/47938/files#diff-a0ed0852ff66702fe4085465e0f735265c83782c4afe7fab466b53d87a564580
packages/language-service/src/codefixes/fix_missing_import.tshttps://github.com/angular/angular/pull/47938/files#diff-d021b88eac12fad2e929f49cbf44b66f2dff7edc1056c56885386aff87d0fbaf
View file https://github.com/dylhunn/angular/blob/3620fff43a910afd419ebad17b8fa296b6c6a1b6/packages/language-service/src/codefixes/fix_missing_import.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47938/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47938/files#diff-d021b88eac12fad2e929f49cbf44b66f2dff7edc1056c56885386aff87d0fbaf
https://github.com/angular/angular/pull/47938/files#diff-d021b88eac12fad2e929f49cbf44b66f2dff7edc1056c56885386aff87d0fbaf
https://github.com/angular/angular/pull/47938/files#diff-d021b88eac12fad2e929f49cbf44b66f2dff7edc1056c56885386aff87d0fbaf
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.