René's URL Explorer Experiment


Title: fix(language-service): Prevent crashes on unemitable references by dylhunn · Pull Request #47938 · angular/angular · GitHub

Open Graph Title: fix(language-service): Prevent crashes on unemitable references by dylhunn · Pull Request #47938 · angular/angular

X Title: fix(language-service): Prevent crashes on unemitable references by dylhunn · Pull Request #47938 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Currently, when generating an import of a selector, the language service might crash if the compiler cannot emit a reference to the new symbol's file from the target component's file. (This...

X Description: Currently, when generating an import of a selector, the language service might crash if the compiler cannot emit a reference to the new symbol's file from the target component's fil...

Opengraph URL: https://github.com/angular/angular/pull/47938

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:374bf188-c03f-3b59-e29f-f468f437427e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC9FC:14700E:5630F8:6F3634:6B00DAD1
html-safe-nonce5732d53aeea9cfcf334db5102dd5f374a6b1904f685c9df729abc847b24fbbb2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUZDOjE0NzAwRTo1NjMwRjg6NkYzNjM0OjZCMDBEQUQxIiwidmlzaXRvcl9pZCI6IjQ2Nzg3NjU3NjQzNDQzMzkxNTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9aab3bc9e9f7b1e01d082e4bf21a931a3400a44b6719765960fd88de76a1f841
hovercard-subject-tagpull_request:1107612222
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/47938/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/19ad9295f3cd1ec1a528c6a6e7ccfc65433ff37a7c5e4e40149ebb4d32b1d36c/angular/angular/pull/47938
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/19ad9295f3cd1ec1a528c6a6e7ccfc65433ff37a7c5e4e40149ebb4d32b1d36c/angular/angular/pull/47938
og:image:altCurrently, when generating an import of a selector, the language service might crash if the compiler cannot emit a reference to the new symbol's file from the target component's file. (This...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedylhunn
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/47938#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47938
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47938
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/47938
Reloadhttps://github.com/angular/angular/pull/47938
Reloadhttps://github.com/angular/angular/pull/47938
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests139 (139)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
dylhunnhttps://github.com/dylhunn
angular:mainhttps://github.com/angular/angular/tree/main
dylhunn:same-file-importshttps://github.com/dylhunn/angular/tree/same-file-imports
Conversationhttps://github.com/angular/angular/pull/47938
Commits1 (1)https://github.com/angular/angular/pull/47938/commits
Checkshttps://github.com/angular/angular/pull/47938/checks
Files changedhttps://github.com/angular/angular/pull/47938/files
fix(language-service): Prevent crashes on unemitable referenceshttps://github.com/angular/angular/pull/47938#top
dylhunnhttps://github.com/dylhunn
angular:mainhttps://github.com/angular/angular/tree/main
dylhunn:same-file-importshttps://github.com/dylhunn/angular/tree/same-file-imports
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
Nov 2, 2022https://github.com/angular/angular/pull/47938#issue-1432415285
Please reload this pagehttps://github.com/angular/angular/pull/47938
Please reload this pagehttps://github.com/angular/angular/pull/47938
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: language-service https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20language-service%22
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
Nov 2, 2022https://github.com/angular/angular/pull/47938#event-7718970082
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
atscotthttps://github.com/atscott
November 2, 2022 03:19https://github.com/angular/angular/pull/47938#event-7718970094
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Nov 2, 2022https://github.com/angular/angular/pull/47938#event-7718970304
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
force-pushedhttps://github.com/angular/angular/compare/7b29605837ec727774dd0b6a9d1712538bce01fd..57ab0b634059bf4d1c42c1c2f11790d20283d456
7b29605https://github.com/angular/angular/commit/7b29605837ec727774dd0b6a9d1712538bce01fd
57ab0b6https://github.com/angular/angular/commit/57ab0b634059bf4d1c42c1c2f11790d20283d456
Compare https://github.com/angular/angular/compare/7b29605837ec727774dd0b6a9d1712538bce01fd..57ab0b634059bf4d1c42c1c2f11790d20283d456
November 2, 2022 03:24https://github.com/angular/angular/pull/47938#event-7718994459
https://github.com/dylhunn
fix(language-service): Prevent crashes on unemitable referenceshttps://github.com/angular/angular/pull/47938/commits/3620fff43a910afd419ebad17b8fa296b6c6a1b6
3620fffhttps://github.com/angular/angular/pull/47938/commits/3620fff43a910afd419ebad17b8fa296b6c6a1b6
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
force-pushedhttps://github.com/angular/angular/compare/57ab0b634059bf4d1c42c1c2f11790d20283d456..3620fff43a910afd419ebad17b8fa296b6c6a1b6
57ab0b6https://github.com/angular/angular/commit/57ab0b634059bf4d1c42c1c2f11790d20283d456
3620fffhttps://github.com/angular/angular/commit/3620fff43a910afd419ebad17b8fa296b6c6a1b6
Compare https://github.com/angular/angular/compare/57ab0b634059bf4d1c42c1c2f11790d20283d456..3620fff43a910afd419ebad17b8fa296b6c6a1b6
November 2, 2022 03:26https://github.com/angular/angular/pull/47938#event-7719001891
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
Nov 2, 2022 https://github.com/angular/angular/pull/47938#ref-issue-1405195348
Language Service: Automatic Import Improvements #47737 https://github.com/angular/angular/issues/47737
https://github.com/atscott
atscotthttps://github.com/atscott
Nov 2, 2022 https://github.com/angular/angular/pull/47938#pullrequestreview-1165265009
View reviewed changes https://github.com/angular/angular/pull/47938/files/3620fff43a910afd419ebad17b8fa296b6c6a1b6
https://github.com/atscott
atscotthttps://github.com/atscott
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
Nov 2, 2022https://github.com/angular/angular/pull/47938#event-7723484421
https://github.com/atscott
atscotthttps://github.com/atscott
Nov 2, 2022https://github.com/angular/angular/pull/47938#issuecomment-1300420768
@dylhunnhttps://github.com/dylhunn
Please reload this pagehttps://github.com/angular/angular/pull/47938
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
Nov 2, 2022https://github.com/angular/angular/pull/47938#issuecomment-1301215861
Please reload this pagehttps://github.com/angular/angular/pull/47938
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Nov 2, 2022https://github.com/angular/angular/pull/47938#event-7727132889
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
Nov 4, 2022https://github.com/angular/angular/pull/47938#event-7736787368
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 4, 2022https://github.com/angular/angular/pull/47938#issuecomment-1302831051
ce8160ehttps://github.com/angular/angular/commit/ce8160ecb28d6765d438eb65035835984eb956ec
Please reload this pagehttps://github.com/angular/angular/pull/47938
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
ce8160ehttps://github.com/angular/angular/commit/ce8160ecb28d6765d438eb65035835984eb956ec
Nov 4, 2022https://github.com/angular/angular/pull/47938#event-7736788960
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 4, 2022https://github.com/angular/angular/pull/47938#issuecomment-1302831336
@dylhunnhttps://github.com/dylhunn
Please reload this pagehttps://github.com/angular/angular/pull/47938
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
November 30, 2022 20:12https://github.com/angular/angular/pull/47938#event-7925381333
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 31, 2022https://github.com/angular/angular/pull/47938#issuecomment-1368246490
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/47938
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 31, 2022https://github.com/angular/angular/pull/47938#event-8132839057
trekladyonehttps://github.com/trekladyone
Feb 1, 2023 https://github.com/angular/angular/pull/47938#ref-commit-df8a48e
https://github.com/dylhunn
https://github.com/trekladyone
fix(language-service): Prevent crashes on unemitable references (https://github.com/trekladyone/angular/commit/df8a48efff79264f104444be3c13b4ca209a8faa
angu…https://github.com/angular/angular/pull/47938
df8a48ehttps://github.com/trekladyone/angular/commit/df8a48efff79264f104444be3c13b4ca209a8faa
…lar#47938https://github.com/angular/angular/pull/47938
angular#47938https://github.com/angular/angular/pull/47938
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47938
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/47938/files/3620fff43a910afd419ebad17b8fa296b6c6a1b6
Please reload this pagehttps://github.com/angular/angular/pull/47938
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: language-service https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20language-service%22
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/47938
https://github.com/dylhunn
https://github.com/atscott
https://github.com/AndrewKushnir
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.