René's URL Explorer Experiment


Title: fix(service-worker): include headers in requests for assets by gkalpak · Pull Request #47260 · angular/angular · GitHub

Open Graph Title: fix(service-worker): include headers in requests for assets by gkalpak · Pull Request #47260 · angular/angular

X Title: fix(service-worker): include headers in requests for assets by gkalpak · Pull Request #47260 · angular/angular

Description: Previously, when requesting non-cached asset resources from the network, the ServiceWorker would strip off all request metadata (including headers). This was done in order to avoid issues with opaque responses, but it turned out to be overly aggressive, breaking/worsening legit usecases (such as requesting compressed data). This commit fixes this by preserving the headers of such requests. For reference, Workbox passes the original request as is. (See for example the NetworkFirst strategy). Note Data requests (i.e. requests for URLs that belong to a data-group) are not affected by this. They already use the original resource as is. Fixes #24227

Open Graph Description: Previously, when requesting non-cached asset resources from the network, the ServiceWorker would strip off all request metadata (including headers). This was done in order to avoid issues with opaq...

X Description: Previously, when requesting non-cached asset resources from the network, the ServiceWorker would strip off all request metadata (including headers). This was done in order to avoid issues with opaq...

Opengraph URL: https://github.com/angular/angular/pull/47260

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:912514b6-b404-3e6c-4693-06255ca77828
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD3A4:1F2F:5E21E7:7D71F0:6B018781
html-safe-nonce6fc2d6eede776ac7465824f7431781791d1d037e71bd39b11307595156bbd5e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0E0OjFGMkY6NUUyMUU3OjdENzFGMDo2QjAxODc4MSIsInZpc2l0b3JfaWQiOiI3MzAyNzQzNTU5NTg3ODU4MzA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0b85efd6051f21597024ab6a54d036b674e2983cea9297c75d5df3a7788109c1
hovercard-subject-tagpull_request:1037103268
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/47260/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPreviously, when requesting non-cached asset resources from the network, the ServiceWorker would strip off all request metadata (including headers). This was done in order to avoid issues with opaq...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/47260/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47260%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47260%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/47260/files
Reloadhttps://github.com/angular/angular/pull/47260/files
Reloadhttps://github.com/angular/angular/pull/47260/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:mainhttps://github.com/angular/angular/tree/main
gkalpak:fix-sw-asset-headershttps://github.com/gkalpak/angular/tree/fix-sw-asset-headers
Conversation 4 https://github.com/angular/angular/pull/47260
Commits 3 https://github.com/angular/angular/pull/47260/commits
Checks 0 https://github.com/angular/angular/pull/47260/checks
Files changed https://github.com/angular/angular/pull/47260/files
Please reload this pagehttps://github.com/angular/angular/pull/47260/files
fix(service-worker): include headers in requests for assets https://github.com/angular/angular/pull/47260/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/47260/files
44d76e8 test(service-worker): fix default value of `Request#credentials` (`om… gkalpak Aug 25, 2022 https://github.com/angular/angular/pull/47260/commits/44d76e89bb708ca479105830184eebbbc80efc2d
36351b3 test(service-worker): simplify how redirects are defined in `MockServ… gkalpak Aug 25, 2022 https://github.com/angular/angular/pull/47260/commits/36351b3d28900476b867e77aaaaca23dbc602350
281e3b3 fix(service-worker): include headers in requests for assets gkalpak Aug 25, 2022 https://github.com/angular/angular/pull/47260/commits/281e3b3545a6a0e9bf706ee5a43eebd19db7b691
Clear filters https://github.com/angular/angular/pull/47260/files
Please reload this pagehttps://github.com/angular/angular/pull/47260/files
Please reload this pagehttps://github.com/angular/angular/pull/47260/files
app-version.ts https://github.com/angular/angular/pull/47260/files#diff-be8e562dd282b385d6cde346dfafdb741d040155720cfd28fb431ac7f42340ac
assets.ts https://github.com/angular/angular/pull/47260/files#diff-cdc1a59661d2c930cef49c4b4cde312883018c2c1777511fc50b32e8397fe81a
happy_spec.ts https://github.com/angular/angular/pull/47260/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
fetch.ts https://github.com/angular/angular/pull/47260/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9
mock.ts https://github.com/angular/angular/pull/47260/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
packages/service-worker/worker/src/app-version.tshttps://github.com/angular/angular/pull/47260/files#diff-be8e562dd282b385d6cde346dfafdb741d040155720cfd28fb431ac7f42340ac
View file https://github.com/gkalpak/angular/blob/281e3b3545a6a0e9bf706ee5a43eebd19db7b691/packages/service-worker/worker/src/app-version.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47260/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47260/files#diff-be8e562dd282b385d6cde346dfafdb741d040155720cfd28fb431ac7f42340ac
https://github.com/angular/angular/pull/47260/files#diff-be8e562dd282b385d6cde346dfafdb741d040155720cfd28fb431ac7f42340ac
packages/service-worker/worker/src/assets.tshttps://github.com/angular/angular/pull/47260/files#diff-cdc1a59661d2c930cef49c4b4cde312883018c2c1777511fc50b32e8397fe81a
View file https://github.com/gkalpak/angular/blob/281e3b3545a6a0e9bf706ee5a43eebd19db7b691/packages/service-worker/worker/src/assets.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47260/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47260/files#diff-cdc1a59661d2c930cef49c4b4cde312883018c2c1777511fc50b32e8397fe81a
https://github.com/angular/angular/pull/47260/files#diff-cdc1a59661d2c930cef49c4b4cde312883018c2c1777511fc50b32e8397fe81a
https://github.com/angular/angular/pull/47260/files#diff-cdc1a59661d2c930cef49c4b4cde312883018c2c1777511fc50b32e8397fe81a
https://github.com/angular/angular/pull/47260/files#diff-cdc1a59661d2c930cef49c4b4cde312883018c2c1777511fc50b32e8397fe81a
https://github.com/angular/angular/pull/47260/files#diff-cdc1a59661d2c930cef49c4b4cde312883018c2c1777511fc50b32e8397fe81a
https://github.com/angular/angular/pull/47260/files#diff-cdc1a59661d2c930cef49c4b4cde312883018c2c1777511fc50b32e8397fe81a
https://github.com/angular/angular/pull/47260/files#diff-cdc1a59661d2c930cef49c4b4cde312883018c2c1777511fc50b32e8397fe81a
https://github.com/angular/angular/pull/47260/files#diff-cdc1a59661d2c930cef49c4b4cde312883018c2c1777511fc50b32e8397fe81a
packages/service-worker/worker/test/happy_spec.tshttps://github.com/angular/angular/pull/47260/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
View file https://github.com/gkalpak/angular/blob/281e3b3545a6a0e9bf706ee5a43eebd19db7b691/packages/service-worker/worker/test/happy_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47260/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47260/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/47260/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/47260/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/47260/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/47260/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/47260/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/47260/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/47260/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
https://github.com/angular/angular/pull/47260/files#diff-1868a67565c7b5733ec2e925a421c8cbc0daba78547c45306f987a037904426d
packages/service-worker/worker/testing/fetch.tshttps://github.com/angular/angular/pull/47260/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9
View file https://github.com/gkalpak/angular/blob/281e3b3545a6a0e9bf706ee5a43eebd19db7b691/packages/service-worker/worker/testing/fetch.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47260/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47260/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9
https://github.com/angular/angular/pull/47260/files#diff-a6e4cded06ab6c68c6b760f02896bc7f122b263e79faf3acd4d97547294ef9b9
packages/service-worker/worker/testing/mock.tshttps://github.com/angular/angular/pull/47260/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
View file https://github.com/gkalpak/angular/blob/281e3b3545a6a0e9bf706ee5a43eebd19db7b691/packages/service-worker/worker/testing/mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47260/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47260/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
https://github.com/angular/angular/pull/47260/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
https://github.com/angular/angular/pull/47260/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
https://github.com/angular/angular/pull/47260/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
https://github.com/angular/angular/pull/47260/files#diff-3e1e3c4c77d2bf0964465d5b1e9f84a764acc1886990c3ca64bd166518fd2181
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.