René's URL Explorer Experiment


Title: fix(common): consider density descriptors with multiple digits as valid by pkozlowski-opensource · Pull Request #47230 · angular/angular · GitHub

Open Graph Title: fix(common): consider density descriptors with multiple digits as valid by pkozlowski-opensource · Pull Request #47230 · angular/angular

X Title: fix(common): consider density descriptors with multiple digits as valid by pkozlowski-opensource · Pull Request #47230 · angular/angular

Description: Valid density descriptors used in the NgOptimizedImage can contain multiple digits (ex. 1.25x, 25x). This change fixes the issue where density descriptors with multiple digits (ex. 25x) where considered invalid. Please note that a valid density descriptor might still be rejected by the directive's validation logic if the supplied value is too big. Based on this review

Open Graph Description: Valid density descriptors used in the NgOptimizedImage can contain multiple digits (ex. 1.25x, 25x). This change fixes the issue where density descriptors with multiple digits (ex. 25x) where consi...

X Description: Valid density descriptors used in the NgOptimizedImage can contain multiple digits (ex. 1.25x, 25x). This change fixes the issue where density descriptors with multiple digits (ex. 25x) where consi...

Opengraph URL: https://github.com/angular/angular/pull/47230

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:409acb58-a5a5-59d4-f567-425ff87f4683
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA53C:2652DC:FAEAB4:142CFBA:6B00FF17
html-safe-nonce80cd7b1cd1dcdcce3195ae45d04a8664aa78c180acd3e73ef719b457475e9807
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTNDOjI2NTJEQzpGQUVBQjQ6MTQyQ0ZCQTo2QjAwRkYxNyIsInZpc2l0b3JfaWQiOiI2NDE0NTYzMzc5NTQ0OTE1NzM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac47c98d7b11fd6fc8dc4ac37f813be17d05bc621d3fe00458e14e4dd37eb7770a
hovercard-subject-tagpull_request:1034114972
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/47230/files
twitter:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
og:image:altValid density descriptors used in the NgOptimizedImage can contain multiple digits (ex. 1.25x, 25x). This change fixes the issue where density descriptors with multiple digits (ex. 25x) where consi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/47230/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47230%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47230%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/47230/files
Reloadhttps://github.com/angular/angular/pull/47230/files
Reloadhttps://github.com/angular/angular/pull/47230/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:mainhttps://github.com/angular/angular/tree/main
pkozlowski-opensource:image_directive_density_deescriptorhttps://github.com/pkozlowski-opensource/angular/tree/image_directive_density_deescriptor
Conversation 3 https://github.com/angular/angular/pull/47230
Commits 1 https://github.com/angular/angular/pull/47230/commits
Checks 0 https://github.com/angular/angular/pull/47230/checks
Files changed https://github.com/angular/angular/pull/47230/files
Please reload this pagehttps://github.com/angular/angular/pull/47230/files
fix(common): consider density descriptors with multiple digits as valid https://github.com/angular/angular/pull/47230/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/47230/files
278fc40 fix(common): consider density descriptors with multiple digits as valid pkozlowski-opensource Aug 23, 2022 https://github.com/angular/angular/pull/47230/commits/278fc40c97805cf0d555cfe8b0d69ab39166fbe8
Clear filters https://github.com/angular/angular/pull/47230/files
Please reload this pagehttps://github.com/angular/angular/pull/47230/files
Please reload this pagehttps://github.com/angular/angular/pull/47230/files
ng_optimized_image.ts https://github.com/angular/angular/pull/47230/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
ng_optimized_image_spec.ts https://github.com/angular/angular/pull/47230/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
packages/common/src/directives/ng_optimized_image/ng_optimized_image.tshttps://github.com/angular/angular/pull/47230/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
View file https://github.com/pkozlowski-opensource/angular/blob/278fc40c97805cf0d555cfe8b0d69ab39166fbe8/packages/common/src/directives/ng_optimized_image/ng_optimized_image.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47230/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47230/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
https://github.com/angular/angular/pull/47230/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
https://github.com/angular/angular/pull/47230/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
https://github.com/angular/angular/pull/47230/files#diff-73d1dd876731fb822abdc319c5b2ca14f93ee2c1709787204ce5717b9dc6e919
packages/common/test/directives/ng_optimized_image_spec.tshttps://github.com/angular/angular/pull/47230/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
View file https://github.com/pkozlowski-opensource/angular/blob/278fc40c97805cf0d555cfe8b0d69ab39166fbe8/packages/common/test/directives/ng_optimized_image_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47230/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47230/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
https://github.com/angular/angular/pull/47230/files#diff-0c1437cd01db709944186184ee657f72c863920aa691fa013610aec48ca712f4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.