René's URL Explorer Experiment


Title: fix(animations): fix stagger timing not handling params by dario-piotrowicz · Pull Request #47208 · angular/angular · GitHub

Open Graph Title: fix(animations): fix stagger timing not handling params by dario-piotrowicz · Pull Request #47208 · angular/angular

X Title: fix(animations): fix stagger timing not handling params by dario-piotrowicz · Pull Request #47208 · angular/angular

Description: prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change makes it so that during ast building a timing ast is built instead and that ast is used dynammically to build animations which can handle params correctly resolves #19786 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? trying to use a parameters inside a stagger timings' argument (such as for example stagger('{{myParam}}', [...) results in an error being displayed in the console and the animation not running Issue Number: #19786 What is the new behavior? params used inside a stagger timing's argument are correctly handled Does this PR introduce a breaking change? Yes No

Open Graph Description: prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change ma...

X Description: prior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change ma...

Opengraph URL: https://github.com/angular/angular/pull/47208

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:05ab9a2c-cdd7-20cf-2f5b-49cfad9c94a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97D2:6DC60:301B26:3C3C93:6B010236
html-safe-nonce99a98f2e3236d2eae979f1917335b53a63bb27d7f544b15205919d0aa9b88bac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0QyOjZEQzYwOjMwMUIyNjozQzNDOTM6NkIwMTAyMzYiLCJ2aXNpdG9yX2lkIjoiNTI5Mzg2NTg4OTI3ODUyNjAwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbda51020bf6b0cfe582b5c396be8f1530a5194e90b1bdb8c20334fef979cf4db
hovercard-subject-tagpull_request:1032107534
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/47208/files
twitter:imagehttps://avatars.githubusercontent.com/u/61631103?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/61631103?s=400&v=4
og:image:altprior to this change the stagger timing was being built during the ast building instead of dynamically when visiting the stagger animation, thus it could not handle params correctly, this change ma...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/47208/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47208%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47208%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/47208/files
Reloadhttps://github.com/angular/angular/pull/47208/files
Reloadhttps://github.com/angular/angular/pull/47208/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
dario-piotrowiczhttps://github.com/dario-piotrowicz
angular:mainhttps://github.com/angular/angular/tree/main
dario-piotrowicz:stagger-timining-params-fixhttps://github.com/dario-piotrowicz/angular/tree/stagger-timining-params-fix
Conversation 5 https://github.com/angular/angular/pull/47208
Commits 1 https://github.com/angular/angular/pull/47208/commits
Checks 0 https://github.com/angular/angular/pull/47208/checks
Files changed https://github.com/angular/angular/pull/47208/files
Please reload this pagehttps://github.com/angular/angular/pull/47208/files
fix(animations): fix stagger timing not handling params https://github.com/angular/angular/pull/47208/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/47208/files
c2bb768 fix(animations): fix stagger timing not handling params dario-piotrowicz Aug 21, 2022 https://github.com/angular/angular/pull/47208/commits/c2bb768b5f92a490aed56b211430c7785d8a7a80
Clear filters https://github.com/angular/angular/pull/47208/files
Please reload this pagehttps://github.com/angular/angular/pull/47208/files
Please reload this pagehttps://github.com/angular/angular/pull/47208/files
animation_ast_builder.ts https://github.com/angular/angular/pull/47208/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
animation_timeline_builder.ts https://github.com/angular/angular/pull/47208/files#diff-e40b103808b78174213187c96d8bdb6259e1651bdcdbb95c1af0673ba01c49d0
animation_query_integration_spec.ts https://github.com/angular/angular/pull/47208/files#diff-aaf1bf1c70eaa94277253fbd9c7c196f233121d892c0b884c08f8feed49e1445
bundle.golden_symbols.json https://github.com/angular/angular/pull/47208/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
packages/animations/browser/src/dsl/animation_ast_builder.tshttps://github.com/angular/angular/pull/47208/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
View file https://github.com/dario-piotrowicz/angular/blob/c2bb768b5f92a490aed56b211430c7785d8a7a80/packages/animations/browser/src/dsl/animation_ast_builder.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47208/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47208/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
https://github.com/angular/angular/pull/47208/files#diff-2aadfb992cfa9fe7790cd968078bcde851fcd111e88e65a417de3d11d6943982
packages/animations/browser/src/dsl/animation_timeline_builder.tshttps://github.com/angular/angular/pull/47208/files#diff-e40b103808b78174213187c96d8bdb6259e1651bdcdbb95c1af0673ba01c49d0
View file https://github.com/dario-piotrowicz/angular/blob/c2bb768b5f92a490aed56b211430c7785d8a7a80/packages/animations/browser/src/dsl/animation_timeline_builder.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47208/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47208/files#diff-e40b103808b78174213187c96d8bdb6259e1651bdcdbb95c1af0673ba01c49d0
https://github.com/angular/angular/pull/47208/files#diff-e40b103808b78174213187c96d8bdb6259e1651bdcdbb95c1af0673ba01c49d0
https://github.com/angular/angular/pull/47208/files#diff-e40b103808b78174213187c96d8bdb6259e1651bdcdbb95c1af0673ba01c49d0
https://github.com/angular/angular/pull/47208/files#diff-e40b103808b78174213187c96d8bdb6259e1651bdcdbb95c1af0673ba01c49d0
packages/core/test/animation/animation_query_integration_spec.tshttps://github.com/angular/angular/pull/47208/files#diff-aaf1bf1c70eaa94277253fbd9c7c196f233121d892c0b884c08f8feed49e1445
View file https://github.com/dario-piotrowicz/angular/blob/c2bb768b5f92a490aed56b211430c7785d8a7a80/packages/core/test/animation/animation_query_integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47208/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47208/files#diff-aaf1bf1c70eaa94277253fbd9c7c196f233121d892c0b884c08f8feed49e1445
jessicajaniukhttps://github.com/jessicajaniuk
Aug 22, 2022https://github.com/angular/angular/pull/47208/files#r951656949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/47208/files
dario-piotrowiczhttps://github.com/dario-piotrowicz
Aug 22, 2022https://github.com/angular/angular/pull/47208/files#r951816064
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/47208/files
https://github.com/angular/angular/pull/47208/files#diff-aaf1bf1c70eaa94277253fbd9c7c196f233121d892c0b884c08f8feed49e1445
packages/core/test/bundling/animations/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/47208/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
View file https://github.com/dario-piotrowicz/angular/blob/c2bb768b5f92a490aed56b211430c7785d8a7a80/packages/core/test/bundling/animations/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47208/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47208/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
https://github.com/angular/angular/pull/47208/files#diff-55b700f90ffe0ca99dfbda0537aad672bf475c13ec8e7a8a6a23eb9b3c48816a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.