René's URL Explorer Experiment


Title: refactor(common): post-review image directive cleanup by pkozlowski-opensource · Pull Request #47170 · angular/angular · GitHub

Open Graph Title: refactor(common): post-review image directive cleanup by pkozlowski-opensource · Pull Request #47170 · angular/angular

X Title: refactor(common): post-review image directive cleanup by pkozlowski-opensource · Pull Request #47170 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Minor cleanups based on the review comments that were not addressed after the initial review. Based on #47082 (review)

X Description: Minor cleanups based on the review comments that were not addressed after the initial review. Based on #47082 (review)

Opengraph URL: https://github.com/angular/angular/pull/47170

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:58db1269-0502-566d-c739-458c525e171c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB23E:B53AF:C53DC7:10786F5:6B00F9A5
html-safe-nonce8aab4152c8082de3ecb3c0c7889771a1ac3a57be1cf2b720bdfa1186a5f3a069
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjNFOkI1M0FGOkM1M0RDNzoxMDc4NkY1OjZCMDBGOUE1IiwidmlzaXRvcl9pZCI6Ijg2MTUyOTkzOTkzMzUwODI0MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0e420cccda4d550a70daf8877bc113d8ca523da98c8fa9d85f704975d37fc2cc
hovercard-subject-tagpull_request:1028639589
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/47170/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/88110ab2994578af10a52535dd4209159b3887bcd7eb16951fef6b40bee0c73d/angular/angular/pull/47170
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/88110ab2994578af10a52535dd4209159b3887bcd7eb16951fef6b40bee0c73d/angular/angular/pull/47170
og:image:altMinor cleanups based on the review comments that were not addressed after the initial review. Based on #47082 (review)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkozlowski-opensource
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/47170#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47170
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47170
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/47170
Reloadhttps://github.com/angular/angular/pull/47170
Reloadhttps://github.com/angular/angular/pull/47170
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:mainhttps://github.com/angular/angular/tree/main
pkozlowski-opensource:image_post_merge_reviewhttps://github.com/pkozlowski-opensource/angular/tree/image_post_merge_review
Conversationhttps://github.com/angular/angular/pull/47170
Commits1 (1)https://github.com/angular/angular/pull/47170/commits
Checkshttps://github.com/angular/angular/pull/47170/checks
Files changedhttps://github.com/angular/angular/pull/47170/files
refactor(common): post-review image directive cleanuphttps://github.com/angular/angular/pull/47170#top
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:mainhttps://github.com/angular/angular/tree/main
pkozlowski-opensource:image_post_merge_reviewhttps://github.com/pkozlowski-opensource/angular/tree/image_post_merge_review
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Aug 17, 2022https://github.com/angular/angular/pull/47170#issue-1341538579
#47082 (review)https://github.com/angular/angular/pull/47082#pullrequestreview-1074480563
Please reload this pagehttps://github.com/angular/angular/pull/47170
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
karahttps://github.com/kara
August 17, 2022 10:21https://github.com/angular/angular/pull/47170#event-7204512943
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: common https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
Aug 17, 2022https://github.com/angular/angular/pull/47170#event-7204518062
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Aug 17, 2022https://github.com/angular/angular/pull/47170#event-7204518267
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Aug 17, 2022 https://github.com/angular/angular/pull/47170#pullrequestreview-1075667918
View reviewed changes https://github.com/angular/angular/pull/47170/files
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/47170#pullrequestreview-1075667918
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#47082 (review)https://github.com/angular/angular/pull/47082#pullrequestreview-1075647565
Please reload this pagehttps://github.com/angular/angular/pull/47170
packages/common/src/directives/ng_optimized_image/url.tshttps://github.com/angular/angular/pull/47170/files#diff-14df7806a1064f4f1cf67b75aec1b605988769859d02a95a32f15f9f241b6585
Please reload this pagehttps://github.com/angular/angular/pull/47170
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
August 17, 2022 12:58https://github.com/angular/angular/pull/47170#event-7205800525
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Aug 17, 2022https://github.com/angular/angular/pull/47170#issuecomment-1217977629
@gkalpakhttps://github.com/gkalpak
Please reload this pagehttps://github.com/angular/angular/pull/47170
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Aug 19, 2022 https://github.com/angular/angular/pull/47170#ref-pullrequest-1343680015
fix(common): remove duplicate deepForEach #47189 https://github.com/angular/angular/pull/47189
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Backloghttps://github.com/angular/angular/milestone/82
v14.2-candidateshttps://github.com/angular/angular/milestone/114
Aug 19, 2022https://github.com/angular/angular/pull/47170#event-7221322700
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/7516bebcd0ffeba45cc14c8e306b988bc71b62be..15eaeae58d626a17e39e5a8a208ce62e0907d2ea
7516bebhttps://github.com/angular/angular/commit/7516bebcd0ffeba45cc14c8e306b988bc71b62be
15eaeaehttps://github.com/angular/angular/commit/15eaeae58d626a17e39e5a8a208ce62e0907d2ea
Compare https://github.com/angular/angular/compare/7516bebcd0ffeba45cc14c8e306b988bc71b62be..15eaeae58d626a17e39e5a8a208ce62e0907d2ea
August 19, 2022 11:15https://github.com/angular/angular/pull/47170#event-7221420012
https://github.com/pkozlowski-opensource
refactor(common): post-review image directive cleanuphttps://github.com/angular/angular/pull/47170/commits/278e6b33d41f69a12a36663e19d6c006180ec153
278e6b3https://github.com/angular/angular/pull/47170/commits/278e6b33d41f69a12a36663e19d6c006180ec153
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/15eaeae58d626a17e39e5a8a208ce62e0907d2ea..278e6b33d41f69a12a36663e19d6c006180ec153
15eaeaehttps://github.com/angular/angular/commit/15eaeae58d626a17e39e5a8a208ce62e0907d2ea
278e6b3https://github.com/angular/angular/commit/278e6b33d41f69a12a36663e19d6c006180ec153
Compare https://github.com/angular/angular/compare/15eaeae58d626a17e39e5a8a208ce62e0907d2ea..278e6b33d41f69a12a36663e19d6c006180ec153
August 19, 2022 12:03https://github.com/angular/angular/pull/47170#event-7221699590
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
August 19, 2022 12:12https://github.com/angular/angular/pull/47170#event-7221752960
https://github.com/kara
karahttps://github.com/kara
Aug 19, 2022 https://github.com/angular/angular/pull/47170#pullrequestreview-1079190076
View reviewed changes https://github.com/angular/angular/pull/47170/files/278e6b33d41f69a12a36663e19d6c006180ec153
karahttps://github.com/kara
https://github.com/angular/angular/pull/47170#pullrequestreview-1079190076
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/47170
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Aug 22, 2022 https://github.com/angular/angular/pull/47170#pullrequestreview-1080021114
View reviewed changes https://github.com/angular/angular/pull/47170/files/278e6b33d41f69a12a36663e19d6c006180ec153
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Aug 22, 2022https://github.com/angular/angular/pull/47170#event-7230635684
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Aug 22, 2022https://github.com/angular/angular/pull/47170#issuecomment-1222712157
634e6c7https://github.com/angular/angular/commit/634e6c7f1ad9492f7ed6cec7aae2dfc132a704a1
Please reload this pagehttps://github.com/angular/angular/pull/47170
https://github.com/alxhub
alxhubhttps://github.com/alxhub
634e6c7https://github.com/angular/angular/commit/634e6c7f1ad9492f7ed6cec7aae2dfc132a704a1
Aug 22, 2022https://github.com/angular/angular/pull/47170#event-7235000446
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Aug 23, 2022 https://github.com/angular/angular/pull/47170#ref-commit-1d23881
https://github.com/pkozlowski-opensource
refactor(common): post-review image directive cleanup (https://github.com/pkozlowski-opensource/angular/commit/1d238812b9d6f22c753311988306138e334ce252
angular#47170https://github.com/angular/angular/pull/47170
)https://github.com/pkozlowski-opensource/angular/commit/1d238812b9d6f22c753311988306138e334ce252
1d23881https://github.com/pkozlowski-opensource/angular/commit/1d238812b9d6f22c753311988306138e334ce252
angular#47170https://github.com/angular/angular/pull/47170
alxhubhttps://github.com/alxhub
Aug 23, 2022 https://github.com/angular/angular/pull/47170#ref-commit-6790d3c
https://github.com/pkozlowski-opensource
https://github.com/alxhub
refactor(common): post-review image directive cleanup (https://github.com/angular/angular/commit/6790d3ceb12dd16856776a6367045450dfcd5806
#47170https://github.com/angular/angular/pull/47170
) (https://github.com/angular/angular/commit/6790d3ceb12dd16856776a6367045450dfcd5806
#47232https://github.com/angular/angular/pull/47232
)https://github.com/angular/angular/commit/6790d3ceb12dd16856776a6367045450dfcd5806
6790d3chttps://github.com/angular/angular/commit/6790d3ceb12dd16856776a6367045450dfcd5806
#47170https://github.com/angular/angular/pull/47170
#47232https://github.com/angular/angular/pull/47232
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 22, 2022https://github.com/angular/angular/pull/47170#issuecomment-1255243078
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/47170
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 22, 2022https://github.com/angular/angular/pull/47170#event-7441065261
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47170
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/47170/files/278e6b33d41f69a12a36663e19d6c006180ec153
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/47170/files/278e6b33d41f69a12a36663e19d6c006180ec153
Please reload this pagehttps://github.com/angular/angular/pull/47170
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: common https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
v14.2-candidates https://github.com/angular/angular/milestone/114
Please reload this pagehttps://github.com/angular/angular/pull/47170
https://github.com/pkozlowski-opensource
https://github.com/alxhub
https://github.com/kara
https://github.com/gkalpak
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.