| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c557173a-6aa5-7a54-e6d7-42cefa9cda81 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DD66:A99C2:1074F15:151D220:6B0101C9 |
| html-safe-nonce | f06f229fc243e673cb52f801598ed7245cf1eb16a3f9a2d31ae129e60276af1d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDY2OkE5OUMyOjEwNzRGMTU6MTUxRDIyMDo2QjAxMDFDOSIsInZpc2l0b3JfaWQiOiI5MTg1MTI1OTQ3NTg0NjEwNzYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4a8c760a244a2e904be1a80410962cf663aa12953189eaf845eabe31652f90aa |
| hovercard-subject-tag | pull_request:1021805097 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/47098/files |
| twitter:image | https://avatars.githubusercontent.com/u/479713?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/479713?s=400&v=4 |
| og:image:alt | Some versions of rxjs cause the algorithm used in the Router to not recognize Route configs correctly.
This commit updates the algorithm to be compatible in the same way as other code locations int... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/47098/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47098%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47098%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/47098/files |
| Reload | https://github.com/angular/angular/pull/47098/files |
| Reload | https://github.com/angular/angular/pull/47098/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| atscott | https://github.com/atscott |
| angular:main | https://github.com/angular/angular/tree/main |
| atscott:emptyerror | https://github.com/atscott/angular/tree/emptyerror |
|
Conversation
5
| https://github.com/angular/angular/pull/47098 |
|
Commits
2
| https://github.com/angular/angular/pull/47098/commits |
|
Checks
0
| https://github.com/angular/angular/pull/47098/checks |
|
Files changed
| https://github.com/angular/angular/pull/47098/files |
| Please reload this page | https://github.com/angular/angular/pull/47098/files |
|
fix(router): Fix route recognition behavior with some versions of rxjs
| https://github.com/angular/angular/pull/47098/files#top |
|
Show all changes
2 commits
| https://github.com/angular/angular/pull/47098/files |
|
c48f99e
fix(router): Fix route recognition behavior with some versions of rxjs
atscott Aug 9, 2022
| https://github.com/angular/angular/pull/47098/commits/c48f99e7e63ff17172a2709641946006593313bc |
|
31f580a
fixup! fix(router): Fix route recognition behavior with some versions…
atscott Aug 9, 2022
| https://github.com/angular/angular/pull/47098/commits/31f580a2a4f5487dff512a8469a6e808a3ff5d8f |
|
Clear filters
| https://github.com/angular/angular/pull/47098/files |
| Please reload this page | https://github.com/angular/angular/pull/47098/files |
| Please reload this page | https://github.com/angular/angular/pull/47098/files |
|
bundle.golden_symbols.json
| https://github.com/angular/angular/pull/47098/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
apply_redirects.ts
| https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
|
resolve_data.ts
| https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d |
|
recognize.ts
| https://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1 |
|
type_guards.ts
| https://github.com/angular/angular/pull/47098/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2 |
| packages/core/test/bundling/router/bundle.golden_symbols.json | https://github.com/angular/angular/pull/47098/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
View file
| https://github.com/atscott/angular/blob/31f580a2a4f5487dff512a8469a6e808a3ff5d8f/packages/core/test/bundling/router/bundle.golden_symbols.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/47098/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/47098/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
| https://github.com/angular/angular/pull/47098/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
| packages/router/src/apply_redirects.ts | https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
|
View file
| https://github.com/atscott/angular/blob/31f580a2a4f5487dff512a8469a6e808a3ff5d8f/packages/router/src/apply_redirects.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/47098/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
|
| https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
|
| https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
|
| https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
|
| https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
| packages/router/src/operators/resolve_data.ts | https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d |
|
View file
| https://github.com/atscott/angular/blob/31f580a2a4f5487dff512a8469a6e808a3ff5d8f/packages/router/src/operators/resolve_data.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/47098/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d |
|
| https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d |
|
| https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d |
|
| https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d |
|
| https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d |
| packages/router/src/recognize.ts | https://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1 |
|
View file
| https://github.com/atscott/angular/blob/31f580a2a4f5487dff512a8469a6e808a3ff5d8f/packages/router/src/recognize.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/47098/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1 |
|
| https://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1 |
|
| https://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1 |
|
| https://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1 |
| packages/router/src/utils/type_guards.ts | https://github.com/angular/angular/pull/47098/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2 |
|
View file
| https://github.com/atscott/angular/blob/31f580a2a4f5487dff512a8469a6e808a3ff5d8f/packages/router/src/utils/type_guards.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/47098/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/47098/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2 |
|
| https://github.com/angular/angular/pull/47098/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2 |
|
| https://github.com/angular/angular/pull/47098/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |