René's URL Explorer Experiment


Title: fix(router): Fix route recognition behavior with some versions of rxjs by atscott · Pull Request #47098 · angular/angular · GitHub

Open Graph Title: fix(router): Fix route recognition behavior with some versions of rxjs by atscott · Pull Request #47098 · angular/angular

X Title: fix(router): Fix route recognition behavior with some versions of rxjs by atscott · Pull Request #47098 · angular/angular

Description: Some versions of rxjs cause the algorithm used in the Router to not recognize Route configs correctly. This commit updates the algorithm to be compatible in the same way as other code locations internally. Context: 1160b81 fixes #47089 Note: This does not have a test because I was unable to identify the version of rxjs that would cause a failure here.

Open Graph Description: Some versions of rxjs cause the algorithm used in the Router to not recognize Route configs correctly. This commit updates the algorithm to be compatible in the same way as other code locations int...

X Description: Some versions of rxjs cause the algorithm used in the Router to not recognize Route configs correctly. This commit updates the algorithm to be compatible in the same way as other code locations int...

Opengraph URL: https://github.com/angular/angular/pull/47098

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c557173a-6aa5-7a54-e6d7-42cefa9cda81
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD66:A99C2:1074F15:151D220:6B0101C9
html-safe-noncef06f229fc243e673cb52f801598ed7245cf1eb16a3f9a2d31ae129e60276af1d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDY2OkE5OUMyOjEwNzRGMTU6MTUxRDIyMDo2QjAxMDFDOSIsInZpc2l0b3JfaWQiOiI5MTg1MTI1OTQ3NTg0NjEwNzYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4a8c760a244a2e904be1a80410962cf663aa12953189eaf845eabe31652f90aa
hovercard-subject-tagpull_request:1021805097
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/47098/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altSome versions of rxjs cause the algorithm used in the Router to not recognize Route configs correctly. This commit updates the algorithm to be compatible in the same way as other code locations int...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/47098/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47098%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47098%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/47098/files
Reloadhttps://github.com/angular/angular/pull/47098/files
Reloadhttps://github.com/angular/angular/pull/47098/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:emptyerrorhttps://github.com/atscott/angular/tree/emptyerror
Conversation 5 https://github.com/angular/angular/pull/47098
Commits 2 https://github.com/angular/angular/pull/47098/commits
Checks 0 https://github.com/angular/angular/pull/47098/checks
Files changed https://github.com/angular/angular/pull/47098/files
Please reload this pagehttps://github.com/angular/angular/pull/47098/files
fix(router): Fix route recognition behavior with some versions of rxjs https://github.com/angular/angular/pull/47098/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/47098/files
c48f99e fix(router): Fix route recognition behavior with some versions of rxjs atscott Aug 9, 2022 https://github.com/angular/angular/pull/47098/commits/c48f99e7e63ff17172a2709641946006593313bc
31f580a fixup! fix(router): Fix route recognition behavior with some versions… atscott Aug 9, 2022 https://github.com/angular/angular/pull/47098/commits/31f580a2a4f5487dff512a8469a6e808a3ff5d8f
Clear filters https://github.com/angular/angular/pull/47098/files
Please reload this pagehttps://github.com/angular/angular/pull/47098/files
Please reload this pagehttps://github.com/angular/angular/pull/47098/files
bundle.golden_symbols.json https://github.com/angular/angular/pull/47098/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
apply_redirects.ts https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
resolve_data.ts https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d
recognize.ts https://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
type_guards.ts https://github.com/angular/angular/pull/47098/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2
packages/core/test/bundling/router/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/47098/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
View file https://github.com/atscott/angular/blob/31f580a2a4f5487dff512a8469a6e808a3ff5d8f/packages/core/test/bundling/router/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47098/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47098/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/47098/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
packages/router/src/apply_redirects.tshttps://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
View file https://github.com/atscott/angular/blob/31f580a2a4f5487dff512a8469a6e808a3ff5d8f/packages/router/src/apply_redirects.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47098/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/47098/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
packages/router/src/operators/resolve_data.tshttps://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d
View file https://github.com/atscott/angular/blob/31f580a2a4f5487dff512a8469a6e808a3ff5d8f/packages/router/src/operators/resolve_data.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47098/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d
https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d
https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d
https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d
https://github.com/angular/angular/pull/47098/files#diff-fcb2cfa4f8768f15aa076c8e7fa930b9c9173883badc599053673675a5a0078d
packages/router/src/recognize.tshttps://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
View file https://github.com/atscott/angular/blob/31f580a2a4f5487dff512a8469a6e808a3ff5d8f/packages/router/src/recognize.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47098/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
https://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
https://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
https://github.com/angular/angular/pull/47098/files#diff-44c1b65f761a41afe66b151124a4be3714cad25e122360a783d81d6c8d37b4b1
packages/router/src/utils/type_guards.tshttps://github.com/angular/angular/pull/47098/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2
View file https://github.com/atscott/angular/blob/31f580a2a4f5487dff512a8469a6e808a3ff5d8f/packages/router/src/utils/type_guards.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/47098/{{ revealButtonHref }}
https://github.com/angular/angular/pull/47098/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2
https://github.com/angular/angular/pull/47098/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2
https://github.com/angular/angular/pull/47098/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.