René's URL Explorer Experiment


Title: fix(router): Do not call preload method when not necessary by atscott · Pull Request #47007 · angular/angular · GitHub

Open Graph Title: fix(router): Do not call preload method when not necessary by atscott · Pull Request #47007 · angular/angular

X Title: fix(router): Do not call preload method when not necessary by atscott · Pull Request #47007 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: In Angular 14, we introduced the loadComponent API for a Route to allow lazy loading of a routed component in addition to the existing loadChildren which allows lazy loading of child routes. As a r...

X Description: In Angular 14, we introduced the loadComponent API for a Route to allow lazy loading of a routed component in addition to the existing loadChildren which allows lazy loading of child routes. As a r...

Opengraph URL: https://github.com/angular/angular/pull/47007

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/*id(.:format)
route-controllerpull_requests
route-actionshow
fetch-noncev2:069076d2-41d3-67b7-0849-3253358a0935
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB858:23CF06:E80CF1:12B0D05:6B00FA0B
html-safe-nonce697411bcae0829bd869a834813849085170dfc5b311006a8abfd9e22a8436395
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODU4OjIzQ0YwNjpFODBDRjE6MTJCMEQwNTo2QjAwRkEwQiIsInZpc2l0b3JfaWQiOiIzMTU4NjM5Nzc3MjkzNTk3MTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf2f15842626674cd3b1aebfae0a5cf9c0f3ca00ff875beea287fdd955ec01ec2
hovercard-subject-tagpull_request:1014093243
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/47007
twitter:imagehttps://opengraph.githubassets.com/5a0158175219b91e955e25fc45384a37e316186dfbfd2bb4741d43476202b7fe/angular/angular/pull/47007
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5a0158175219b91e955e25fc45384a37e316186dfbfd2bb4741d43476202b7fe/angular/angular/pull/47007
og:image:altIn Angular 14, we introduced the loadComponent API for a Route to allow lazy loading of a routed component in addition to the existing loadChildren which allows lazy loading of child routes. As a r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatscott
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/47007#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47007
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47007
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/47007
Reloadhttps://github.com/angular/angular/pull/47007
Reloadhttps://github.com/angular/angular/pull/47007
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:preloadCanloadhttps://github.com/atscott/angular/tree/preloadCanload
Conversationhttps://github.com/angular/angular/pull/47007
Commits1 (1)https://github.com/angular/angular/pull/47007/commits
Checkshttps://github.com/angular/angular/pull/47007/checks
Files changedhttps://github.com/angular/angular/pull/47007/files
fix(router): Do not call preload method when not necessaryhttps://github.com/angular/angular/pull/47007#top
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:preloadCanloadhttps://github.com/atscott/angular/tree/preloadCanload
https://github.com/atscott
atscotthttps://github.com/atscott
Aug 1, 2022https://github.com/angular/angular/pull/47007#issue-1324681583
#47003https://github.com/angular/angular/issues/47003
Please reload this pagehttps://github.com/angular/angular/pull/47007
https://github.com/atscott
atscotthttps://github.com/atscott
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Aug 1, 2022https://github.com/angular/angular/pull/47007#event-7103135293
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Aug 1, 2022https://github.com/angular/angular/pull/47007#event-7103135466
https://github.com/atscott
atscotthttps://github.com/atscott
AndrewKushnirhttps://github.com/AndrewKushnir
August 1, 2022 16:31https://github.com/angular/angular/pull/47007#event-7103135811
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Aug 1, 2022 https://github.com/angular/angular/pull/47007#pullrequestreview-1057632150
View reviewed changes https://github.com/angular/angular/pull/47007/files
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/47007#pullrequestreview-1057632150
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/47007
packages/router/src/router_preloader.tshttps://github.com/angular/angular/pull/47007/files#diff-7e01bb0f7817b5e6799f8f1a2c145e5b489c6bc7428be8a36841a4e43944aba5
Please reload this pagehttps://github.com/angular/angular/pull/47007
https://github.com/atscott
fix(router): Do not call preload method when not necessaryhttps://github.com/angular/angular/pull/47007/commits/ea03bd3c5d9192c718995eb7158b98c99cf397ae
ea03bd3https://github.com/angular/angular/pull/47007/commits/ea03bd3c5d9192c718995eb7158b98c99cf397ae
angular#47003https://github.com/angular/angular/issues/47003
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/d6c2e355e566e4889a1c0de611b6a3eaa0d2e332..ea03bd3c5d9192c718995eb7158b98c99cf397ae
d6c2e35https://github.com/angular/angular/commit/d6c2e355e566e4889a1c0de611b6a3eaa0d2e332
ea03bd3https://github.com/angular/angular/commit/ea03bd3c5d9192c718995eb7158b98c99cf397ae
Compare https://github.com/angular/angular/compare/d6c2e355e566e4889a1c0de611b6a3eaa0d2e332..ea03bd3c5d9192c718995eb7158b98c99cf397ae
August 1, 2022 17:45https://github.com/angular/angular/pull/47007#event-7103599072
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Aug 1, 2022https://github.com/angular/angular/pull/47007#event-7105339943
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Aug 1, 2022https://github.com/angular/angular/pull/47007#issuecomment-1201801003
https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png
Please reload this pagehttps://github.com/angular/angular/pull/47007
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Aug 2, 2022https://github.com/angular/angular/pull/47007#issuecomment-1202969201
d8cf78bhttps://github.com/angular/angular/commit/d8cf78ba5e6e5bf48e6c3f2b5f2b590fa4598bb3
Please reload this pagehttps://github.com/angular/angular/pull/47007
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
d8cf78bhttps://github.com/angular/angular/commit/d8cf78ba5e6e5bf48e6c3f2b5f2b590fa4598bb3
Aug 2, 2022https://github.com/angular/angular/pull/47007#event-7111585325
AndrewKushnirhttps://github.com/AndrewKushnir
Aug 2, 2022 https://github.com/angular/angular/pull/47007#ref-commit-79825d3
https://github.com/atscott
https://github.com/AndrewKushnir
fix(router): Do not call preload method when not necessary (https://github.com/angular/angular/commit/79825d3f1078c9b91eeb5e4699718ccde6c458b5
#47007https://github.com/angular/angular/pull/47007
)https://github.com/angular/angular/commit/79825d3f1078c9b91eeb5e4699718ccde6c458b5
79825d3https://github.com/angular/angular/commit/79825d3f1078c9b91eeb5e4699718ccde6c458b5
#47003https://github.com/angular/angular/issues/47003
#47007https://github.com/angular/angular/pull/47007
crapStonehttps://github.com/crapStone
Aug 9, 2022 https://github.com/angular/angular/pull/47007#ref-commit-6058bb1
Update angular monorepo to v14.1.1 (#1490)https://github.com/Calciumdibromid/CaBr2/commit/6058bb1c8bd33cd05e7ce6c193c67051511aba7c
6058bb1https://github.com/Calciumdibromid/CaBr2/commit/6058bb1c8bd33cd05e7ce6c193c67051511aba7c
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fanimations/14.1.0/14.1.1https://renovatebot.com/diffs/npm/@angular%2fanimations/14.1.0/14.1.1
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fcommon/14.1.0/14.1.1https://renovatebot.com/diffs/npm/@angular%2fcommon/14.1.0/14.1.1
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.1.0/14.1.1https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.1.0/14.1.1
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.1.0/14.1.1https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.1.0/14.1.1
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fcore/14.1.0/14.1.1https://renovatebot.com/diffs/npm/@angular%2fcore/14.1.0/14.1.1
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fforms/14.1.0/14.1.1https://renovatebot.com/diffs/npm/@angular%2fforms/14.1.0/14.1.1
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.1.0/14.1.1https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.1.0/14.1.1
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.1.0/14.1.1https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.1.0/14.1.1
https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1411-2022-08-03https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1411-2022-08-03
angular/angular@14.1.0...14.1.1https://github.com/angular/angular/compare/14.1.0...14.1.1
angular/angular@3606917https://github.com/angular/angular/commit/3606917732e5ad887426c1cbccf6e375eff905d6
angular/angular#46903https://github.com/angular/angular/pull/46903
angular/angular@79825d3https://github.com/angular/angular/commit/79825d3f1078c9b91eeb5e4699718ccde6c458b5
angular/angular#47007https://github.com/angular/angular/pull/47007
angular/angular@05f3f74https://github.com/angular/angular/commit/05f3f7445a0bbe3c7ffed3aec308ca8888e77d99
angular/angular#46941https://github.com/angular/angular/pull/46941
https://github.com/renovatebot/renovatehttps://github.com/renovatebot/renovate
https://codeberg.org/Calciumdibromid/CaBr2/pulls/1490https://codeberg.org/Calciumdibromid/CaBr2/pulls/1490
build: bump @angular/language-service from 12.2.4 to 14.1.1 numbersprotocol/capture-cam#1931 https://github.com/numbersprotocol/capture-cam/pull/1931
build: bump @angular/compiler from 12.2.4 to 14.1.1 numbersprotocol/capture-cam#1929 https://github.com/numbersprotocol/capture-cam/pull/1929
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 2, 2022https://github.com/angular/angular/pull/47007#issuecomment-1235673867
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/47007
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 2, 2022https://github.com/angular/angular/pull/47007#event-7314404700
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F47007
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/47007/files/d6c2e355e566e4889a1c0de611b6a3eaa0d2e332
Please reload this pagehttps://github.com/angular/angular/pull/47007
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Backlog https://github.com/angular/angular/milestone/82
Breaking undocumented change from Angular 13 to 14 in custom PreloadingStrategy. "preload"-method is called despite a set canLoad-guard. https://github.com/angular/angular/issues/47003
Please reload this pagehttps://github.com/angular/angular/pull/47007
https://github.com/atscott
https://github.com/AndrewKushnir
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.