René's URL Explorer Experiment


Title: fix(core): check if transplanted views are attached to change detector by edusperoni · Pull Request #46974 · angular/angular · GitHub

Open Graph Title: fix(core): check if transplanted views are attached to change detector by edusperoni · Pull Request #46974 · angular/angular

X Title: fix(core): check if transplanted views are attached to change detector by edusperoni · Pull Request #46974 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

Opengraph URL: https://github.com/angular/angular/pull/46974

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:21191da8-8da2-eb70-15be-956f7d287f2b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1D6:38E318:1C160B:2340C2:6B00FC15
html-safe-noncee924814916334d9dc8cc342748cf3b6681d94cf73f95865ec78b94ffb4f94825
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUQ2OjM4RTMxODoxQzE2MEI6MjM0MEMyOjZCMDBGQzE1IiwidmlzaXRvcl9pZCI6IjcwMjk1NDc0NTQ0NjI3NTM4MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc0ec483355430843c98d64cc7f3e64cf53472ddf083281118266d52e6ea816a6
hovercard-subject-tagpull_request:1009020373
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/46974/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c37ceb47c0cd647a5b934af793c5bb7d7cb9bc1bdcf5f7e453ced8dea4fe8eed/angular/angular/pull/46974
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c37ceb47c0cd647a5b934af793c5bb7d7cb9bc1bdcf5f7e453ced8dea4fe8eed/angular/angular/pull/46974
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameedusperoni
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/46974#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46974
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46974
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46974
Reloadhttps://github.com/angular/angular/pull/46974
Reloadhttps://github.com/angular/angular/pull/46974
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
edusperonihttps://github.com/edusperoni
angular:mainhttps://github.com/angular/angular/tree/main
edusperoni:fix/transplated-viewshttps://github.com/edusperoni/angular/tree/fix/transplated-views
Conversationhttps://github.com/angular/angular/pull/46974
Commits1 (1)https://github.com/angular/angular/pull/46974/commits
Checkshttps://github.com/angular/angular/pull/46974/checks
Files changedhttps://github.com/angular/angular/pull/46974/files
fix(core): check if transplanted views are attached to change detectorhttps://github.com/angular/angular/pull/46974#top
edusperonihttps://github.com/edusperoni
angular:mainhttps://github.com/angular/angular/tree/main
edusperoni:fix/transplated-viewshttps://github.com/edusperoni/angular/tree/fix/transplated-views
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
Jul 26, 2022https://github.com/angular/angular/pull/46974#issue-1318817556
https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
#46973https://github.com/angular/angular/issues/46973
Please reload this pagehttps://github.com/angular/angular/pull/46974
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
AndrewKushnirhttps://github.com/AndrewKushnir
July 26, 2022 22:37https://github.com/angular/angular/pull/46974#event-7068525081
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
force-pushedhttps://github.com/angular/angular/compare/7e6b7a4dbc56827dbe78e947d71bc5e1d164d085..e36b8ff4bf8ce3d8c9289e4b73a7f03f293e8c91
7e6b7a4https://github.com/angular/angular/commit/7e6b7a4dbc56827dbe78e947d71bc5e1d164d085
e36b8ffhttps://github.com/angular/angular/commit/e36b8ff4bf8ce3d8c9289e4b73a7f03f293e8c91
Compare https://github.com/angular/angular/compare/7e6b7a4dbc56827dbe78e947d71bc5e1d164d085..e36b8ff4bf8ce3d8c9289e4b73a7f03f293e8c91
July 26, 2022 23:58https://github.com/angular/angular/pull/46974#event-7068797879
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
atscotthttps://github.com/atscott
AndrewKushnirhttps://github.com/AndrewKushnir
July 27, 2022 05:24https://github.com/angular/angular/pull/46974#event-7069813649
https://github.com/atscott
atscotthttps://github.com/atscott
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
action: global presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20global%20presubmit%22
Aug 1, 2022https://github.com/angular/angular/pull/46974#event-7103368966
https://github.com/atscott
atscotthttps://github.com/atscott
Aug 1, 2022 https://github.com/angular/angular/pull/46974#pullrequestreview-1057616851
View reviewed changes https://github.com/angular/angular/pull/46974/files
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/46974#pullrequestreview-1057616851
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/46974
packages/core/test/acceptance/change_detection_transplanted_view_spec.tshttps://github.com/angular/angular/pull/46974/files#diff-dd202e7c7b81c4f3486687ac3794d5bdbfe136c51abaf446c47b295ce4c69bcf
Please reload this pagehttps://github.com/angular/angular/pull/46974
packages/core/test/acceptance/change_detection_transplanted_view_spec.tshttps://github.com/angular/angular/pull/46974/files#diff-dd202e7c7b81c4f3486687ac3794d5bdbfe136c51abaf446c47b295ce4c69bcf
Please reload this pagehttps://github.com/angular/angular/pull/46974
https://github.com/atscott
atscotthttps://github.com/atscott
Aug 1, 2022https://github.com/angular/angular/pull/46974#issuecomment-1201835793
TGPhttps://fusion2.corp.google.com/presubmit/tap/464574397/OCL:464574397:BASE:464543952:1659392273198:10643d5/targets
Please reload this pagehttps://github.com/angular/angular/pull/46974
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
force-pushedhttps://github.com/angular/angular/compare/e36b8ff4bf8ce3d8c9289e4b73a7f03f293e8c91..382ad057e9a43ebcf3cca53bbb3162756afadace
e36b8ffhttps://github.com/angular/angular/commit/e36b8ff4bf8ce3d8c9289e4b73a7f03f293e8c91
382ad05https://github.com/angular/angular/commit/382ad057e9a43ebcf3cca53bbb3162756afadace
Compare https://github.com/angular/angular/compare/e36b8ff4bf8ce3d8c9289e4b73a7f03f293e8c91..382ad057e9a43ebcf3cca53bbb3162756afadace
August 4, 2022 18:46https://github.com/angular/angular/pull/46974#event-7130681664
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
Aug 4, 2022https://github.com/angular/angular/pull/46974#issuecomment-1205647082
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/46974
https://github.com/edusperoni
fix(core): check if transplanted views are attached to change detectorhttps://github.com/angular/angular/pull/46974/commits/d947b43b208219f571825fefc63ecaf36d552677
d947b43https://github.com/angular/angular/pull/46974/commits/d947b43b208219f571825fefc63ecaf36d552677
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
force-pushedhttps://github.com/angular/angular/compare/382ad057e9a43ebcf3cca53bbb3162756afadace..d947b43b208219f571825fefc63ecaf36d552677
382ad05https://github.com/angular/angular/commit/382ad057e9a43ebcf3cca53bbb3162756afadace
d947b43https://github.com/angular/angular/commit/d947b43b208219f571825fefc63ecaf36d552677
Compare https://github.com/angular/angular/compare/382ad057e9a43ebcf3cca53bbb3162756afadace..d947b43b208219f571825fefc63ecaf36d552677
August 4, 2022 18:50https://github.com/angular/angular/pull/46974#event-7130715423
https://github.com/edusperoni
edusperonihttps://github.com/edusperoni
atscotthttps://github.com/atscott
August 4, 2022 18:51https://github.com/angular/angular/pull/46974#event-7130721142
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
Aug 4, 2022https://github.com/angular/angular/pull/46974#event-7131158466
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Aug 4, 2022https://github.com/angular/angular/pull/46974#event-7131158628
https://github.com/atscott
atscotthttps://github.com/atscott
Aug 5, 2022 https://github.com/angular/angular/pull/46974#pullrequestreview-1063717372
View reviewed changes https://github.com/angular/angular/pull/46974/files/d947b43b208219f571825fefc63ecaf36d552677
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/46974#pullrequestreview-1063717372
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/46974
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: global presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20global%20presubmit%22
Aug 5, 2022https://github.com/angular/angular/pull/46974#event-7137768128
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Aug 5, 2022https://github.com/angular/angular/pull/46974#issuecomment-1206725760
https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png
https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png
Please reload this pagehttps://github.com/angular/angular/pull/46974
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
Aug 8, 2022https://github.com/angular/angular/pull/46974#issuecomment-1208468745
dbed2cfhttps://github.com/angular/angular/commit/dbed2cf079c52825ce0aa67fc2a46bc3d38f408f
Please reload this pagehttps://github.com/angular/angular/pull/46974
https://github.com/dylhunn
dylhunnhttps://github.com/dylhunn
dbed2cfhttps://github.com/angular/angular/commit/dbed2cf079c52825ce0aa67fc2a46bc3d38f408f
Aug 8, 2022https://github.com/angular/angular/pull/46974#event-7149400719
dylhunnhttps://github.com/dylhunn
Aug 8, 2022 https://github.com/angular/angular/pull/46974#ref-commit-5ff715c
https://github.com/edusperoni
https://github.com/dylhunn
fix(core): check if transplanted views are attached to change detector (https://github.com/angular/angular/commit/5ff715c5497fcbcbb33eb93770470fff5a816cd5
5ff715chttps://github.com/angular/angular/commit/5ff715c5497fcbcbb33eb93770470fff5a816cd5
#46974https://github.com/angular/angular/pull/46974
#46974https://github.com/angular/angular/pull/46974
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Aug 9, 2022 https://github.com/angular/angular/pull/46974#ref-issue-1318812140
Transplanted views are change detected regardless if they're detached from CD when inside OnPush components #46973 https://github.com/angular/angular/issues/46973
crapStonehttps://github.com/crapStone
Aug 12, 2022 https://github.com/angular/angular/pull/46974#ref-commit-be22a54
Update angular monorepo to v14.1.2 (#1501)https://github.com/Calciumdibromid/CaBr2/commit/be22a54a1f0a6894afc11aa9180096e75ba53f5c
be22a54https://github.com/Calciumdibromid/CaBr2/commit/be22a54a1f0a6894afc11aa9180096e75ba53f5c
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fanimations/14.1.1/14.1.2https://renovatebot.com/diffs/npm/@angular%2fanimations/14.1.1/14.1.2
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fcommon/14.1.1/14.1.2https://renovatebot.com/diffs/npm/@angular%2fcommon/14.1.1/14.1.2
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.1.1/14.1.2https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.1.1/14.1.2
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.1.1/14.1.2https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.1.1/14.1.2
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fcore/14.1.1/14.1.2https://renovatebot.com/diffs/npm/@angular%2fcore/14.1.1/14.1.2
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fforms/14.1.1/14.1.2https://renovatebot.com/diffs/npm/@angular%2fforms/14.1.1/14.1.2
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.1.1/14.1.2https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.1.1/14.1.2
https://github.com/angular/angularhttps://github.com/angular/angular
https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.1.1/14.1.2https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.1.1/14.1.2
https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1412-2022-08-10https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1412-2022-08-10
angular/angular@14.1.1...14.1.2https://github.com/angular/angular/compare/14.1.1...14.1.2
angular/angular@5ff715chttps://github.com/angular/angular/commit/5ff715c5497fcbcbb33eb93770470fff5a816cd5
angular/angular#46974https://github.com/angular/angular/pull/46974
angular/angular@439d77ehttps://github.com/angular/angular/commit/439d77e852c2e08d384c420a2c3a962a804c60f1
angular/angular#47098https://github.com/angular/angular/pull/47098
angular/angular#47112https://github.com/angular/angular/pull/47112
https://github.com/renovatebot/renovatehttps://github.com/renovatebot/renovate
https://codeberg.org/Calciumdibromid/CaBr2/pulls/1501https://codeberg.org/Calciumdibromid/CaBr2/pulls/1501
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 8, 2022https://github.com/angular/angular/pull/46974#issuecomment-1240923503
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/46974
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 8, 2022https://github.com/angular/angular/pull/46974#event-7349303797
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46974
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/46974/files/d947b43b208219f571825fefc63ecaf36d552677
Please reload this pagehttps://github.com/angular/angular/pull/46974
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/46974
https://github.com/edusperoni
https://github.com/atscott
https://github.com/dylhunn
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.