René's URL Explorer Experiment


Title: fix(router): Use correct return type for provideRoutes function by atscott · Pull Request #46941 · angular/angular · GitHub

Open Graph Title: fix(router): Use correct return type for provideRoutes function by atscott · Pull Request #46941 · angular/angular

X Title: fix(router): Use correct return type for provideRoutes function by atscott · Pull Request #46941 · angular/angular

Description: The provideRoutes function of the Router returns a Provider array and should not be typed as 'any' Note: need to run global presubmit to determine if this needs to be considered a breaking change. Generally these type changes are, but due to the nature of how this is likely to be used, it's possible it won't need to be. TGP came back green for this change so it should be safe to land in patch (or minor if we want to be more conservative).

Open Graph Description: The provideRoutes function of the Router returns a Provider array and should not be typed as 'any' Note: need to run global presubmit to determine if this needs to be considered a breaking ...

X Description: The provideRoutes function of the Router returns a Provider array and should not be typed as 'any' Note: need to run global presubmit to determine if this needs to be considered a b...

Opengraph URL: https://github.com/angular/angular/pull/46941

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6d73fd78-7577-4071-ca2d-3f320f9ea85b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE40A:785A9:D20C09:10B1E9B:6B0101F8
html-safe-nonce605d331721daac7647366a3d996d86470daa21d628d388394b8c6b8bb3fc66a3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDBBOjc4NUE5OkQyMEMwOToxMEIxRTlCOjZCMDEwMUY4IiwidmlzaXRvcl9pZCI6IjkxNTcwMzg2NDgxNzUxNjU5NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac92c4a70cfaea5baad7bb7b7c4559c1bba583c0f03b10e60f74fe6d249574f88c
hovercard-subject-tagpull_request:1005949081
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46941/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altThe provideRoutes function of the Router returns a Provider array and should not be typed as 'any' Note: need to run global presubmit to determine if this needs to be considered a breaking ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46941/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46941%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46941%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46941/files
Reloadhttps://github.com/angular/angular/pull/46941/files
Reloadhttps://github.com/angular/angular/pull/46941/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:provideroutereturntypehttps://github.com/atscott/angular/tree/provideroutereturntype
Conversation 5 https://github.com/angular/angular/pull/46941
Commits 1 https://github.com/angular/angular/pull/46941/commits
Checks 0 https://github.com/angular/angular/pull/46941/checks
Files changed https://github.com/angular/angular/pull/46941/files
Please reload this pagehttps://github.com/angular/angular/pull/46941/files
fix(router): Use correct return type for provideRoutes function https://github.com/angular/angular/pull/46941/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/46941/files
aa8c23a fix(router): Use correct return type for provideRoutes function atscott Jul 8, 2022 https://github.com/angular/angular/pull/46941/commits/aa8c23a352fd47094763c0cf4b3c6e4c99d379c1
Clear filters https://github.com/angular/angular/pull/46941/files
Please reload this pagehttps://github.com/angular/angular/pull/46941/files
Please reload this pagehttps://github.com/angular/angular/pull/46941/files
index.md https://github.com/angular/angular/pull/46941/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
router_module.ts https://github.com/angular/angular/pull/46941/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
goldens/public-api/router/index.mdhttps://github.com/angular/angular/pull/46941/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
View file https://github.com/atscott/angular/blob/aa8c23a352fd47094763c0cf4b3c6e4c99d379c1/goldens/public-api/router/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46941/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46941/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
https://github.com/angular/angular/pull/46941/files#diff-b66b8d89f0c8effbe51128387af21d4705a974d132a64ac6c73090cc73ff2905
packages/router/src/router_module.tshttps://github.com/angular/angular/pull/46941/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
View file https://github.com/atscott/angular/blob/aa8c23a352fd47094763c0cf4b3c6e4c99d379c1/packages/router/src/router_module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46941/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46941/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com/angular/angular/pull/46941/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com/angular/angular/pull/46941/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com/angular/angular/pull/46941/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.