René's URL Explorer Experiment


Title: fix(common): allow null/undefined to be passed to ngClass input (#39280) by imirkin · Pull Request #46906 · angular/angular · GitHub

Open Graph Title: fix(common): allow null/undefined to be passed to ngClass input (#39280) by imirkin · Pull Request #46906 · angular/angular

X Title: fix(common): allow null/undefined to be passed to ngClass input (#39280) by imirkin · Pull Request #46906 · angular/angular

Description: With strict template type checking, a null/undefined value will raise an error. However the implementation is completely fine with it, and it would be pointless to "fix" it at the callsite and convert to e.g. an empty string. Allow all of the "supported types" to be passed in directly to ngClass. Fixes #39280 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #39280 Currently bindings to [ngClass] that may return null or undefined are rejected by typescript as a result of enabling strictTemplates (e.g. map.get('foo') or anything else whose type includes undefined) What is the new behavior? undefined/null are allowed by the @Input type and thus strictTemplate-enabled builds Does this PR introduce a breaking change? Yes No Wasn't sure how to add a test for this specifically, since one has to enable strictTemplates for the source issue to occur. Suggestions welcome.

Open Graph Description: With strict template type checking, a null/undefined value will raise an error. However the implementation is completely fine with it, and it would be pointless to "fix" it at the callsit...

X Description: With strict template type checking, a null/undefined value will raise an error. However the implementation is completely fine with it, and it would be pointless to "fix" it at the...

Opengraph URL: https://github.com/angular/angular/pull/46906

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c5ae3e6b-4d8a-6721-237f-8828d4a81f63
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CD6:311640:CD1E61:1058E24:6B0101AF
html-safe-noncedda2b41da6d891ef1dfdc2ca21ff813eb7c1cb0249bc479ab970e0ceafd05bbe
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0Q2OjMxMTY0MDpDRDFFNjE6MTA1OEUyNDo2QjAxMDFBRiIsInZpc2l0b3JfaWQiOiI0MzIyNTY4MDM3NTM5NTc4Mjg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac30ed79dced87def89b9f29b1bd1a31c5b861cdebd9902806bee6080dfbf280c2
hovercard-subject-tagpull_request:1002498006
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46906/files
twitter:imagehttps://avatars.githubusercontent.com/u/817874?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/817874?s=400&v=4
og:image:altWith strict template type checking, a null/undefined value will raise an error. However the implementation is completely fine with it, and it would be pointless to "fix" it at the callsit...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46906/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46906%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46906%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46906/files
Reloadhttps://github.com/angular/angular/pull/46906/files
Reloadhttps://github.com/angular/angular/pull/46906/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
imirkinhttps://github.com/imirkin
angular:mainhttps://github.com/angular/angular/tree/main
imirkin:masterhttps://github.com/imirkin/angular/tree/master
Conversation 20 https://github.com/angular/angular/pull/46906
Commits 1 https://github.com/angular/angular/pull/46906/commits
Checks 0 https://github.com/angular/angular/pull/46906/checks
Files changed https://github.com/angular/angular/pull/46906/files
Please reload this pagehttps://github.com/angular/angular/pull/46906/files
fix(common): allow null/undefined to be passed to ngClass input (#39280) https://github.com/angular/angular/pull/46906/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/46906/files
20a4d92 fix(common): allow null/undefined to be passed to ngClass input (#39280) imirkin Jul 20, 2022 https://github.com/angular/angular/pull/46906/commits/20a4d9246825597191408a91c2b7cc8cc6b5d7cd
Clear filters https://github.com/angular/angular/pull/46906/files
Please reload this pagehttps://github.com/angular/angular/pull/46906/files
Please reload this pagehttps://github.com/angular/angular/pull/46906/files
index.md https://github.com/angular/angular/pull/46906/files#diff-a471ad9864447ce5eb1c8205c226634af3549c109f10a34b22e2e6b6e0dc0864
ng_class.ts https://github.com/angular/angular/pull/46906/files#diff-32f40c0c973dd88c08491227bd183ee034cf4e4a303d04574456e58c7cca576f
ng_class_spec.ts https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
goldens/public-api/common/index.mdhttps://github.com/angular/angular/pull/46906/files#diff-a471ad9864447ce5eb1c8205c226634af3549c109f10a34b22e2e6b6e0dc0864
View file https://github.com/imirkin/angular/blob/20a4d9246825597191408a91c2b7cc8cc6b5d7cd/goldens/public-api/common/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46906/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46906/files#diff-a471ad9864447ce5eb1c8205c226634af3549c109f10a34b22e2e6b6e0dc0864
https://github.com/angular/angular/pull/46906/files#diff-a471ad9864447ce5eb1c8205c226634af3549c109f10a34b22e2e6b6e0dc0864
packages/common/src/directives/ng_class.tshttps://github.com/angular/angular/pull/46906/files#diff-32f40c0c973dd88c08491227bd183ee034cf4e4a303d04574456e58c7cca576f
View file https://github.com/imirkin/angular/blob/20a4d9246825597191408a91c2b7cc8cc6b5d7cd/packages/common/src/directives/ng_class.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46906/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46906/files#diff-32f40c0c973dd88c08491227bd183ee034cf4e4a303d04574456e58c7cca576f
https://github.com/angular/angular/pull/46906/files#diff-32f40c0c973dd88c08491227bd183ee034cf4e4a303d04574456e58c7cca576f
packages/common/test/directives/ng_class_spec.tshttps://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
View file https://github.com/imirkin/angular/blob/20a4d9246825597191408a91c2b7cc8cc6b5d7cd/packages/common/test/directives/ng_class_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46906/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com/angular/angular/pull/46906/files#diff-aedb1cf270c70e0ea1399210acac5d5a00c7edc7a1aff7ed05067b451833ae52
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.