René's URL Explorer Experiment


Title: fix(core): improve the missing control flow directive message by cexbrayat · Pull Request #46903 · angular/angular · GitHub

Open Graph Title: fix(core): improve the missing control flow directive message by cexbrayat · Pull Request #46903 · angular/angular

X Title: fix(core): improve the missing control flow directive message by cexbrayat · Pull Request #46903 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Similarly to what has been done in #46846 for the extended diagnostics about missing control flow directive that was only mentioning that the CommonModule should be imported, this commit improves the validation done by the JiT compiler. What is the new behavior? Now that the control flow directives are available as standalone, the message mentions that directive itself can be imported. The message now also mentions which import should be used for the directive (as it can be tricky to figure out that NgForOf is the directive corresponding to *ngFor). Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

Opengraph URL: https://github.com/angular/angular/pull/46903

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3b68ac5e-f5cc-bb1d-057b-c6b316d68226
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB970:23CF06:DE2BF6:11E6593:6B00F69F
html-safe-nonce0485e88da7142689de2e5aee5b7915ff7a6b44015dac148546885a734d19f446
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTcwOjIzQ0YwNjpERTJCRjY6MTFFNjU5Mzo2QjAwRjY5RiIsInZpc2l0b3JfaWQiOiI2NjgxODA2MDgwMTc3MTQxNDA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac13c7607e75d55f0228b2a88483ccc0fd336f056d97fca5eb73b2f26ca7debd79
hovercard-subject-tagpull_request:1002319110
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46903/files
twitter:imagehttps://avatars.githubusercontent.com/u/411874?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/411874?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46903/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46903%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46903%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46903/files
Reloadhttps://github.com/angular/angular/pull/46903/files
Reloadhttps://github.com/angular/angular/pull/46903/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
cexbrayathttps://github.com/cexbrayat
angular:mainhttps://github.com/angular/angular/tree/main
cexbrayat:fix/missing-control-flow-directive-message-in-corehttps://github.com/cexbrayat/angular/tree/fix/missing-control-flow-directive-message-in-core
Conversation 3 https://github.com/angular/angular/pull/46903
Commits 1 https://github.com/angular/angular/pull/46903/commits
Checks 0 https://github.com/angular/angular/pull/46903/checks
Files changed https://github.com/angular/angular/pull/46903/files
Please reload this pagehttps://github.com/angular/angular/pull/46903/files
fix(core): improve the missing control flow directive message https://github.com/angular/angular/pull/46903/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/46903/files
08219e0 fix(core): improve the missing control flow directive message cexbrayat Jul 15, 2022 https://github.com/angular/angular/pull/46903/commits/08219e0cdbc8370ff7213f5857b8fd7a1b976e03
Clear filters https://github.com/angular/angular/pull/46903/files
Please reload this pagehttps://github.com/angular/angular/pull/46903/files
Please reload this pagehttps://github.com/angular/angular/pull/46903/files
element_validation.ts https://github.com/angular/angular/pull/46903/files#diff-f596ff1f2ddb3c5bc2e25dac80bc42e87ab5250ae0c28786b82b53fec6cd61d3
ng_module_spec.ts https://github.com/angular/angular/pull/46903/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
packages/core/src/render3/instructions/element_validation.tshttps://github.com/angular/angular/pull/46903/files#diff-f596ff1f2ddb3c5bc2e25dac80bc42e87ab5250ae0c28786b82b53fec6cd61d3
View file https://github.com/cexbrayat/angular/blob/08219e0cdbc8370ff7213f5857b8fd7a1b976e03/packages/core/src/render3/instructions/element_validation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46903/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46903/files#diff-f596ff1f2ddb3c5bc2e25dac80bc42e87ab5250ae0c28786b82b53fec6cd61d3
https://github.com/angular/angular/pull/46903/files#diff-f596ff1f2ddb3c5bc2e25dac80bc42e87ab5250ae0c28786b82b53fec6cd61d3
https://github.com/angular/angular/pull/46903/files#diff-f596ff1f2ddb3c5bc2e25dac80bc42e87ab5250ae0c28786b82b53fec6cd61d3
https://github.com/angular/angular/pull/46903/files#diff-f596ff1f2ddb3c5bc2e25dac80bc42e87ab5250ae0c28786b82b53fec6cd61d3
packages/core/test/acceptance/ng_module_spec.tshttps://github.com/angular/angular/pull/46903/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
View file https://github.com/cexbrayat/angular/blob/08219e0cdbc8370ff7213f5857b8fd7a1b976e03/packages/core/test/acceptance/ng_module_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46903/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46903/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
https://github.com/angular/angular/pull/46903/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
https://github.com/angular/angular/pull/46903/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
https://github.com/angular/angular/pull/46903/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
https://github.com/angular/angular/pull/46903/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.