René's URL Explorer Experiment


Title: refactor(core): `NgModuleRef` should not implement `EnvironmentInjector` interface by AndrewKushnir · Pull Request #46896 · angular/angular · GitHub

Open Graph Title: refactor(core): `NgModuleRef` should not implement `EnvironmentInjector` interface by AndrewKushnir · Pull Request #46896 · angular/angular

X Title: refactor(core): `NgModuleRef` should not implement `EnvironmentInjector` interface by AndrewKushnir · Pull Request #46896 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This commit refactors the NgModuleRef implementation to drop functions required by the EnvironmentInjector interface. Previously the idea was that the NgModuleRef can act as an Injector to facilita...

X Description: This commit refactors the NgModuleRef implementation to drop functions required by the EnvironmentInjector interface. Previously the idea was that the NgModuleRef can act as an Injector to facilita...

Opengraph URL: https://github.com/angular/angular/pull/46896

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3ae639c6-fe5f-51f5-1426-e97051506a00
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BC8:364B55:C6D244:101E826:6B00EE9C
html-safe-nonce8bf49ce2e0b006d6e9ef293c201e14376f4e1a1cbbfd79b54c4ef0fce41b846b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkM4OjM2NEI1NTpDNkQyNDQ6MTAxRTgyNjo2QjAwRUU5QyIsInZpc2l0b3JfaWQiOiIyMTgyNzA4Nzg5NzEzNjI4ODI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd772c0d0daa86ee0c0dc0600bdeb33dd480eaaa8c8ad9fe624e10c2c1bf0aff2
hovercard-subject-tagpull_request:1001263654
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/46896/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bbd291cab8b699f48e27966fc30e2205dffa8c481a61ea83537efe52b5412420/angular/angular/pull/46896
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bbd291cab8b699f48e27966fc30e2205dffa8c481a61ea83537efe52b5412420/angular/angular/pull/46896
og:image:altThis commit refactors the NgModuleRef implementation to drop functions required by the EnvironmentInjector interface. Previously the idea was that the NgModuleRef can act as an Injector to facilita...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndrewKushnir
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/46896#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46896
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46896
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46896
Reloadhttps://github.com/angular/angular/pull/46896
Reloadhttps://github.com/angular/angular/pull/46896
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
AndrewKushnirhttps://github.com/AndrewKushnir
angular:mainhttps://github.com/angular/angular/tree/main
AndrewKushnir:ng_module_ref_cleanuphttps://github.com/AndrewKushnir/angular/tree/ng_module_ref_cleanup
Conversationhttps://github.com/angular/angular/pull/46896
Commits2 (2)https://github.com/angular/angular/pull/46896/commits
Checkshttps://github.com/angular/angular/pull/46896/checks
Files changedhttps://github.com/angular/angular/pull/46896/files
refactor(core): NgModuleRef should not implement EnvironmentInjector interfacehttps://github.com/angular/angular/pull/46896#top
AndrewKushnirhttps://github.com/AndrewKushnir
angular:mainhttps://github.com/angular/angular/tree/main
AndrewKushnir:ng_module_ref_cleanuphttps://github.com/AndrewKushnir/angular/tree/ng_module_ref_cleanup
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 19, 2022https://github.com/angular/angular/pull/46896#issue-1310069010
Please reload this pagehttps://github.com/angular/angular/pull/46896
https://github.com/atscott
https://github.com/AndrewKushnir
Revert "fix(core): Fixhttps://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5
runInContexthttps://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5
forhttps://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5
NgModuleRefhttps://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5
injector (https://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5
ang…https://github.com/angular/angular/pull/46877
abbdf2fhttps://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5
…ular#46877https://github.com/angular/angular/pull/46877
14081dchttps://github.com/AndrewKushnir/angular/commit/14081dc48dfc9adbeac1c761ad9658b21f0ae775
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
Jul 19, 2022https://github.com/angular/angular/pull/46896#event-7024085231
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
alxhubhttps://github.com/alxhub
atscotthttps://github.com/atscott
July 19, 2022 21:34https://github.com/angular/angular/pull/46896#event-7024085246
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Jul 19, 2022https://github.com/angular/angular/pull/46896#event-7024085400
https://github.com/AndrewKushnir
refactor(core): NgModuleRef should not implement EnvironmentInjector …https://github.com/angular/angular/pull/46896/commits/fca66f5fd11d81091278ed5eaa9c5cfdac2c0404
fca66f5https://github.com/angular/angular/pull/46896/commits/fca66f5fd11d81091278ed5eaa9c5cfdac2c0404
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
force-pushedhttps://github.com/angular/angular/compare/1dad92c722435a8b5ecd0ac15cd927aa5b2a005e..fca66f5fd11d81091278ed5eaa9c5cfdac2c0404
1dad92chttps://github.com/angular/angular/commit/1dad92c722435a8b5ecd0ac15cd927aa5b2a005e
fca66f5https://github.com/angular/angular/commit/fca66f5fd11d81091278ed5eaa9c5cfdac2c0404
Compare https://github.com/angular/angular/compare/1dad92c722435a8b5ecd0ac15cd927aa5b2a005e..fca66f5fd11d81091278ed5eaa9c5cfdac2c0404
July 19, 2022 22:02https://github.com/angular/angular/pull/46896#event-7024209375
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 19, 2022https://github.com/angular/angular/pull/46896#issuecomment-1189612417
Presubmithttp://test/OCL:461989910:BASE:461989945:1658269614345:fb2a1bfd
Please reload this pagehttps://github.com/angular/angular/pull/46896
https://github.com/atscott
atscotthttps://github.com/atscott
Jul 19, 2022 https://github.com/angular/angular/pull/46896#pullrequestreview-1044151824
View reviewed changes https://github.com/angular/angular/pull/46896/files/fca66f5fd11d81091278ed5eaa9c5cfdac2c0404
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 20, 2022https://github.com/angular/angular/pull/46896#issuecomment-1189721812
Global Presubmithttps://test.corp.google.com/OCL:461989910:BASE:462028214:1658282572443:77c9445
Please reload this pagehttps://github.com/angular/angular/pull/46896
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: global presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20global%20presubmit%22
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
action: global presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20global%20presubmit%22
Jul 20, 2022https://github.com/angular/angular/pull/46896#event-7025358669
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
alxhubhttps://github.com/alxhub
July 20, 2022 15:36https://github.com/angular/angular/pull/46896#event-7030591745
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 20, 2022https://github.com/angular/angular/pull/46896#issuecomment-1190453313
7a6509bhttps://github.com/angular/angular/commit/7a6509bdc1b12e4375c5727c2afc8269550dfabb
Please reload this pagehttps://github.com/angular/angular/pull/46896
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
422f06dhttps://github.com/angular/angular/commit/422f06d1cd34914fb9ada0252942859aee7a1331
Jul 20, 2022https://github.com/angular/angular/pull/46896#event-7030701836
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 20, 2022 https://github.com/angular/angular/pull/46896#ref-commit-7a6509b
https://github.com/AndrewKushnir
refactor(core): NgModuleRef should not implement EnvironmentInjector …https://github.com/angular/angular/commit/7a6509bdc1b12e4375c5727c2afc8269550dfabb
7a6509bhttps://github.com/angular/angular/commit/7a6509bdc1b12e4375c5727c2afc8269550dfabb
#46896https://github.com/angular/angular/pull/46896
#46896https://github.com/angular/angular/pull/46896
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 20, 2022 https://github.com/angular/angular/pull/46896#ref-commit-9b8ea9b
https://github.com/atscott
https://github.com/AndrewKushnir
Revert "fix(core): Fixhttps://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb
runInContexthttps://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb
forhttps://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb
NgModuleRefhttps://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb
injector (https://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb
#46877https://github.com/angular/angular/pull/46877
9b8ea9bhttps://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb
https://github.com/angular/angular/pull/46877
#46896https://github.com/angular/angular/pull/46896
14081dchttps://github.com/angular/angular/commit/14081dc48dfc9adbeac1c761ad9658b21f0ae775
#46896https://github.com/angular/angular/pull/46896
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 20, 2022 https://github.com/angular/angular/pull/46896#ref-commit-2e5bd88
https://github.com/AndrewKushnir
refactor(core): NgModuleRef should not implement EnvironmentInjector …https://github.com/angular/angular/commit/2e5bd88ebf6de18ebb4b9758595d75fcf5306f9e
2e5bd88https://github.com/angular/angular/commit/2e5bd88ebf6de18ebb4b9758595d75fcf5306f9e
#46896https://github.com/angular/angular/pull/46896
#46896https://github.com/angular/angular/pull/46896
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Aug 20, 2022https://github.com/angular/angular/pull/46896#issuecomment-1221356246
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/46896
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Aug 20, 2022https://github.com/angular/angular/pull/46896#event-7226474282
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46896
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/46896/files/fca66f5fd11d81091278ed5eaa9c5cfdac2c0404
Please reload this pagehttps://github.com/angular/angular/pull/46896
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/46896
https://github.com/AndrewKushnir
https://github.com/atscott
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.