| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3ae639c6-fe5f-51f5-1426-e97051506a00 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9BC8:364B55:C6D244:101E826:6B00EE9C |
| html-safe-nonce | 8bf49ce2e0b006d6e9ef293c201e14376f4e1a1cbbfd79b54c4ef0fce41b846b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkM4OjM2NEI1NTpDNkQyNDQ6MTAxRTgyNjo2QjAwRUU5QyIsInZpc2l0b3JfaWQiOiIyMTgyNzA4Nzg5NzEzNjI4ODI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d772c0d0daa86ee0c0dc0600bdeb33dd480eaaa8c8ad9fe624e10c2c1bf0aff2 |
| hovercard-subject-tag | pull_request:1001263654 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/46896/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bbd291cab8b699f48e27966fc30e2205dffa8c481a61ea83537efe52b5412420/angular/angular/pull/46896 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bbd291cab8b699f48e27966fc30e2205dffa8c481a61ea83537efe52b5412420/angular/angular/pull/46896 |
| og:image:alt | This commit refactors the NgModuleRef implementation to drop functions required by the EnvironmentInjector interface. Previously the idea was that the NgModuleRef can act as an Injector to facilita... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AndrewKushnir |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/46896#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46896 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46896 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/46896 |
| Reload | https://github.com/angular/angular/pull/46896 |
| Reload | https://github.com/angular/angular/pull/46896 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests140 (140) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| AndrewKushnir | https://github.com/AndrewKushnir |
| angular:main | https://github.com/angular/angular/tree/main |
| AndrewKushnir:ng_module_ref_cleanup | https://github.com/AndrewKushnir/angular/tree/ng_module_ref_cleanup |
| Conversation | https://github.com/angular/angular/pull/46896 |
| Commits2 (2) | https://github.com/angular/angular/pull/46896/commits |
| Checks | https://github.com/angular/angular/pull/46896/checks |
| Files changed | https://github.com/angular/angular/pull/46896/files |
| refactor(core): NgModuleRef should not implement EnvironmentInjector interface | https://github.com/angular/angular/pull/46896#top |
| AndrewKushnir | https://github.com/AndrewKushnir |
| angular:main | https://github.com/angular/angular/tree/main |
| AndrewKushnir:ng_module_ref_cleanup | https://github.com/AndrewKushnir/angular/tree/ng_module_ref_cleanup |
|
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jul 19, 2022 | https://github.com/angular/angular/pull/46896#issue-1310069010 |
| Please reload this page | https://github.com/angular/angular/pull/46896 |
|
| https://github.com/atscott |
|
| https://github.com/AndrewKushnir |
| Revert "fix(core): Fix | https://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5 |
| runInContext | https://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5 |
| for | https://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5 |
| NgModuleRef | https://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5 |
| injector ( | https://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5 |
| ang… | https://github.com/angular/angular/pull/46877 |
| abbdf2f | https://github.com/angular/angular/pull/46896/commits/abbdf2f7af72c655bdf6307f5cb910254ca846d5 |
| …ular#46877 | https://github.com/angular/angular/pull/46877 |
| 14081dc | https://github.com/AndrewKushnir/angular/commit/14081dc48dfc9adbeac1c761ad9658b21f0ae775 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
target: rc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22 |
| Jul 19, 2022 | https://github.com/angular/angular/pull/46896#event-7024085231 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| alxhub | https://github.com/alxhub |
| atscott | https://github.com/atscott |
| July 19, 2022 21:34 | https://github.com/angular/angular/pull/46896#event-7024085246 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| Backlog | https://github.com/angular/angular/milestone/82 |
| Jul 19, 2022 | https://github.com/angular/angular/pull/46896#event-7024085400 |
|
| https://github.com/AndrewKushnir |
| refactor(core): NgModuleRef should not implement EnvironmentInjector … | https://github.com/angular/angular/pull/46896/commits/fca66f5fd11d81091278ed5eaa9c5cfdac2c0404 |
| fca66f5 | https://github.com/angular/angular/pull/46896/commits/fca66f5fd11d81091278ed5eaa9c5cfdac2c0404 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| force-pushed | https://github.com/angular/angular/compare/1dad92c722435a8b5ecd0ac15cd927aa5b2a005e..fca66f5fd11d81091278ed5eaa9c5cfdac2c0404 |
| 1dad92c | https://github.com/angular/angular/commit/1dad92c722435a8b5ecd0ac15cd927aa5b2a005e |
| fca66f5 | https://github.com/angular/angular/commit/fca66f5fd11d81091278ed5eaa9c5cfdac2c0404 |
|
Compare
| https://github.com/angular/angular/compare/1dad92c722435a8b5ecd0ac15cd927aa5b2a005e..fca66f5fd11d81091278ed5eaa9c5cfdac2c0404 |
| July 19, 2022 22:02 | https://github.com/angular/angular/pull/46896#event-7024209375 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jul 19, 2022 | https://github.com/angular/angular/pull/46896#issuecomment-1189612417 |
| Presubmit | http://test/OCL:461989910:BASE:461989945:1658269614345:fb2a1bfd |
| Please reload this page | https://github.com/angular/angular/pull/46896 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Jul 19, 2022
| https://github.com/angular/angular/pull/46896#pullrequestreview-1044151824 |
|
View reviewed changes
| https://github.com/angular/angular/pull/46896/files/fca66f5fd11d81091278ed5eaa9c5cfdac2c0404 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jul 20, 2022 | https://github.com/angular/angular/pull/46896#issuecomment-1189721812 |
| Global Presubmit | https://test.corp.google.com/OCL:461989910:BASE:462028214:1658282572443:77c9445 |
| Please reload this page | https://github.com/angular/angular/pull/46896 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: global presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20global%20presubmit%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
action: global presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20global%20presubmit%22 |
| Jul 20, 2022 | https://github.com/angular/angular/pull/46896#event-7025358669 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| alxhub | https://github.com/alxhub |
| July 20, 2022 15:36 | https://github.com/angular/angular/pull/46896#event-7030591745 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jul 20, 2022 | https://github.com/angular/angular/pull/46896#issuecomment-1190453313 |
| 7a6509b | https://github.com/angular/angular/commit/7a6509bdc1b12e4375c5727c2afc8269550dfabb |
| Please reload this page | https://github.com/angular/angular/pull/46896 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| 422f06d | https://github.com/angular/angular/commit/422f06d1cd34914fb9ada0252942859aee7a1331 |
| Jul 20, 2022 | https://github.com/angular/angular/pull/46896#event-7030701836 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jul 20, 2022
| https://github.com/angular/angular/pull/46896#ref-commit-7a6509b |
|
| https://github.com/AndrewKushnir |
| refactor(core): NgModuleRef should not implement EnvironmentInjector … | https://github.com/angular/angular/commit/7a6509bdc1b12e4375c5727c2afc8269550dfabb |
| 7a6509b | https://github.com/angular/angular/commit/7a6509bdc1b12e4375c5727c2afc8269550dfabb |
| #46896 | https://github.com/angular/angular/pull/46896 |
| #46896 | https://github.com/angular/angular/pull/46896 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jul 20, 2022
| https://github.com/angular/angular/pull/46896#ref-commit-9b8ea9b |
|
| https://github.com/atscott |
|
| https://github.com/AndrewKushnir |
| Revert "fix(core): Fix | https://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb |
| runInContext | https://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb |
| for | https://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb |
| NgModuleRef | https://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb |
| injector ( | https://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb |
| #46877 | https://github.com/angular/angular/pull/46877 |
| 9b8ea9b | https://github.com/angular/angular/commit/9b8ea9b5cae4390a458478dcc8d13b9c066730eb |
| https://github.com/angular/angular/pull/46877 |
| #46896 | https://github.com/angular/angular/pull/46896 |
| 14081dc | https://github.com/angular/angular/commit/14081dc48dfc9adbeac1c761ad9658b21f0ae775 |
| #46896 | https://github.com/angular/angular/pull/46896 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jul 20, 2022
| https://github.com/angular/angular/pull/46896#ref-commit-2e5bd88 |
|
| https://github.com/AndrewKushnir |
| refactor(core): NgModuleRef should not implement EnvironmentInjector … | https://github.com/angular/angular/commit/2e5bd88ebf6de18ebb4b9758595d75fcf5306f9e |
| 2e5bd88 | https://github.com/angular/angular/commit/2e5bd88ebf6de18ebb4b9758595d75fcf5306f9e |
| #46896 | https://github.com/angular/angular/pull/46896 |
| #46896 | https://github.com/angular/angular/pull/46896 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Aug 20, 2022 | https://github.com/angular/angular/pull/46896#issuecomment-1221356246 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/46896 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Aug 20, 2022 | https://github.com/angular/angular/pull/46896#event-7226474282 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46896 |
|
| https://github.com/atscott |
|
atscott
| https://github.com/atscott |
|
| https://github.com/angular/angular/pull/46896/files/fca66f5fd11d81091278ed5eaa9c5cfdac2c0404 |
| Please reload this page | https://github.com/angular/angular/pull/46896 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
target: rc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22 |
|
Backlog
| https://github.com/angular/angular/milestone/82 |
| Please reload this page | https://github.com/angular/angular/pull/46896 |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/atscott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |