René's URL Explorer Experiment


Title: fix(animations): make sure falsy values are added to _globalTimelineStyles by dario-piotrowicz · Pull Request #46863 · angular/angular · GitHub

Open Graph Title: fix(animations): make sure falsy values are added to _globalTimelineStyles by dario-piotrowicz · Pull Request #46863 · angular/angular

X Title: fix(animations): make sure falsy values are added to _globalTimelineStyles by dario-piotrowicz · Pull Request #46863 · angular/angular

Description: style values get added to the _globalTimelineStyles map in order to keep them so that they can be used across different timelines _globalTimelineStyles was previously a plain object but has been refactored to a map in #44482, as part of the update a check has been changed from a ternary operation to an or, causing falsy values not to be added to the map anymore, re-apply a ternary operation check so that the original behavior is restored also since this aspect was clearly not covered by tests, add a new test to ensure that such regression doesn't happen in the future resolves #46833 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #46833 Falsy values are lost when defined in different timelines, as you can see from the new test failing with the old code: (basically the issue is that opacity: 0 is lost and replaced with opacity: *) What is the new behavior? Falsy values no longer get lost between timelines (as it was previously in v13) (also the new test with the new code obviously passes) Does this PR introduce a breaking change? Yes No Other information @jessicajaniuk 🙂👍

Open Graph Description: style values get added to the _globalTimelineStyles map in order to keep them so that they can be used across different timelines _globalTimelineStyles was previously a plain object but has been re...

X Description: style values get added to the _globalTimelineStyles map in order to keep them so that they can be used across different timelines _globalTimelineStyles was previously a plain object but has been re...

Opengraph URL: https://github.com/angular/angular/pull/46863

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:aeb01a82-64f1-ca65-31a8-97c4c71a16f5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE106:2F9718:AB8039:E733C1:6B00F519
html-safe-noncedc92a687afc1937b35d816381273286f620350d2587c30b55d7a518cced14ea5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTA2OjJGOTcxODpBQjgwMzk6RTczM0MxOjZCMDBGNTE5IiwidmlzaXRvcl9pZCI6IjMzNjAzMjgxMzQzODg5MzgwMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacab4d7423c08047fb8a8627c65be20ba159edaaa22b0a8c97442a4ed36794f3b6
hovercard-subject-tagpull_request:998659794
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46863/files
twitter:imagehttps://avatars.githubusercontent.com/u/61631103?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/61631103?s=400&v=4
og:image:altstyle values get added to the _globalTimelineStyles map in order to keep them so that they can be used across different timelines _globalTimelineStyles was previously a plain object but has been re...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46863/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46863%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46863%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46863/files
Reloadhttps://github.com/angular/angular/pull/46863/files
Reloadhttps://github.com/angular/angular/pull/46863/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
dario-piotrowiczhttps://github.com/dario-piotrowicz
angular:mainhttps://github.com/angular/angular/tree/main
dario-piotrowicz:fix-falsy-values-not-in-globalTimelineStyleshttps://github.com/dario-piotrowicz/angular/tree/fix-falsy-values-not-in-globalTimelineStyles
Conversation 12 https://github.com/angular/angular/pull/46863
Commits 1 https://github.com/angular/angular/pull/46863/commits
Checks 0 https://github.com/angular/angular/pull/46863/checks
Files changed https://github.com/angular/angular/pull/46863/files
Please reload this pagehttps://github.com/angular/angular/pull/46863/files
fix(animations): make sure falsy values are added to _globalTimelineStyles https://github.com/angular/angular/pull/46863/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/46863/files
fb3be88 fix(animations): make sure falsy values are added to _globalTimelineS… dario-piotrowicz Jul 17, 2022 https://github.com/angular/angular/pull/46863/commits/fb3be88529b1b9f065f606dafbbec71a3f18e0d3
Clear filters https://github.com/angular/angular/pull/46863/files
Please reload this pagehttps://github.com/angular/angular/pull/46863/files
Please reload this pagehttps://github.com/angular/angular/pull/46863/files
animation_timeline_builder.ts https://github.com/angular/angular/pull/46863/files#diff-e40b103808b78174213187c96d8bdb6259e1651bdcdbb95c1af0673ba01c49d0
animation_integration_spec.ts https://github.com/angular/angular/pull/46863/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039
packages/animations/browser/src/dsl/animation_timeline_builder.tshttps://github.com/angular/angular/pull/46863/files#diff-e40b103808b78174213187c96d8bdb6259e1651bdcdbb95c1af0673ba01c49d0
View file https://github.com/dario-piotrowicz/angular/blob/fb3be88529b1b9f065f606dafbbec71a3f18e0d3/packages/animations/browser/src/dsl/animation_timeline_builder.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46863/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46863/files#diff-e40b103808b78174213187c96d8bdb6259e1651bdcdbb95c1af0673ba01c49d0
https://github.com/angular/angular/pull/46863/files#diff-e40b103808b78174213187c96d8bdb6259e1651bdcdbb95c1af0673ba01c49d0
packages/core/test/animation/animation_integration_spec.tshttps://github.com/angular/angular/pull/46863/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039
View file https://github.com/dario-piotrowicz/angular/blob/fb3be88529b1b9f065f606dafbbec71a3f18e0d3/packages/core/test/animation/animation_integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46863/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46863/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039
https://github.com/angular/angular/pull/46863/files#diff-799a01e97a3245d15771359f3dff304a7ef74c43d610ec9cfeda2625cb19a039
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.