Title: fix(animations): make sure falsy values are added to _globalTimelineStyles by dario-piotrowicz · Pull Request #46863 · angular/angular · GitHub
Open Graph Title: fix(animations): make sure falsy values are added to _globalTimelineStyles by dario-piotrowicz · Pull Request #46863 · angular/angular
X Title: fix(animations): make sure falsy values are added to _globalTimelineStyles by dario-piotrowicz · Pull Request #46863 · angular/angular
Description: style values get added to the _globalTimelineStyles map in order to keep them so that they can be used across different timelines _globalTimelineStyles was previously a plain object but has been refactored to a map in #44482, as part of the update a check has been changed from a ternary operation to an or, causing falsy values not to be added to the map anymore, re-apply a ternary operation check so that the original behavior is restored also since this aspect was clearly not covered by tests, add a new test to ensure that such regression doesn't happen in the future resolves #46833 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #46833 Falsy values are lost when defined in different timelines, as you can see from the new test failing with the old code: (basically the issue is that opacity: 0 is lost and replaced with opacity: *) What is the new behavior? Falsy values no longer get lost between timelines (as it was previously in v13) (also the new test with the new code obviously passes) Does this PR introduce a breaking change? Yes No Other information @jessicajaniuk 🙂👍
Open Graph Description: style values get added to the _globalTimelineStyles map in order to keep them so that they can be used across different timelines _globalTimelineStyles was previously a plain object but has been re...
X Description: style values get added to the _globalTimelineStyles map in order to keep them so that they can be used across different timelines _globalTimelineStyles was previously a plain object but has been re...
Opengraph URL: https://github.com/angular/angular/pull/46863
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:aeb01a82-64f1-ca65-31a8-97c4c71a16f5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E106:2F9718:AB8039:E733C1:6B00F519 |
| html-safe-nonce | dc92a687afc1937b35d816381273286f620350d2587c30b55d7a518cced14ea5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTA2OjJGOTcxODpBQjgwMzk6RTczM0MxOjZCMDBGNTE5IiwidmlzaXRvcl9pZCI6IjMzNjAzMjgxMzQzODg5MzgwMDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ab4d7423c08047fb8a8627c65be20ba159edaaa22b0a8c97442a4ed36794f3b6 |
| hovercard-subject-tag | pull_request:998659794 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/46863/files |
| twitter:image | https://avatars.githubusercontent.com/u/61631103?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/61631103?s=400&v=4 |
| og:image:alt | style values get added to the _globalTimelineStyles map in order to keep them so that they can be used across different timelines _globalTimelineStyles was previously a plain object but has been re... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width