René's URL Explorer Experiment


Title: fix(compiler-cli): improve the missingControlFlowDirective message by cexbrayat · Pull Request #46846 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): improve the missingControlFlowDirective message by cexbrayat · Pull Request #46846 · angular/angular

X Title: fix(compiler-cli): improve the missingControlFlowDirective message by cexbrayat · Pull Request #46846 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? The extended diagnostics about missing control flow directive was only mentioning that the CommonModule should be imported. error NG8103: The `*ngFor` directive was used in the template, but the `CommonModule` was not imported. Please make sure that the `CommonModule` is included into the `@Component.imports` array of this component. What is the new behavior? Now that the control flow directives are available as standalone, the message mentions that directive itself can be imported. It also refers to the import that should be used, which can be tricky to figure out for ngFor: error NG8103: The `*ngFor` directive was used in the template, but the `NgForOf` directive or the `CommonModule` were not imported. Please make sure that the `NgForOf` directive or the `CommonModule` are included in the `@Component.imports` array of this component. Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...

Opengraph URL: https://github.com/angular/angular/pull/46846

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:99d87b4c-c085-53bf-f7fd-3efbee205545
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9430:882E2:D9AD44:120637D:6B00F809
html-safe-nonce254d388489b40f70006364c024c42fc808b78dc561dacc9736688676b94bacb3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDMwOjg4MkUyOkQ5QUQ0NDoxMjA2MzdEOjZCMDBGODA5IiwidmlzaXRvcl9pZCI6IjgxNzQzMTcyNDQyODU3Nzc5MjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbb6a44e5c93e2a63f5158018fc7de204e4176e4e9df93779dcb8e022a6456172
hovercard-subject-tagpull_request:997460245
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46846/files
twitter:imagehttps://avatars.githubusercontent.com/u/411874?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/411874?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit Tests for...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46846/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46846%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46846%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46846/files
Reloadhttps://github.com/angular/angular/pull/46846/files
Reloadhttps://github.com/angular/angular/pull/46846/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
cexbrayathttps://github.com/cexbrayat
angular:mainhttps://github.com/angular/angular/tree/main
cexbrayat:fix/missing-control-flow-directive-messagehttps://github.com/cexbrayat/angular/tree/fix/missing-control-flow-directive-message
Conversation 12 https://github.com/angular/angular/pull/46846
Commits 1 https://github.com/angular/angular/pull/46846/commits
Checks 0 https://github.com/angular/angular/pull/46846/checks
Files changed https://github.com/angular/angular/pull/46846/files
Please reload this pagehttps://github.com/angular/angular/pull/46846/files
fix(compiler-cli): improve the missingControlFlowDirective message https://github.com/angular/angular/pull/46846/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/46846/files
3004e2a fix(compiler-cli): improve the missingControlFlowDirective message cexbrayat Jul 15, 2022 https://github.com/angular/angular/pull/46846/commits/3004e2ad3a267eeae79d91ee487cfd33efbf9fb0
Clear filters https://github.com/angular/angular/pull/46846/files
Please reload this pagehttps://github.com/angular/angular/pull/46846/files
Please reload this pagehttps://github.com/angular/angular/pull/46846/files
index.ts https://github.com/angular/angular/pull/46846/files#diff-8dca7371ba941e649fe73086e291397254764341ce12b5354fd2fdd7e1b7b9a2
missing_control_flow_directive_spec.ts https://github.com/angular/angular/pull/46846/files#diff-a1d1bad706f6bc2b3fa5c29f0aa38af5ab38b1995dd89bc781a37d56bbbc3122
.../compiler-cli/src/ngtsc/typecheck/extended/checks/missing_control_flow_directive/index.tshttps://github.com/angular/angular/pull/46846/files#diff-8dca7371ba941e649fe73086e291397254764341ce12b5354fd2fdd7e1b7b9a2
View file https://github.com/cexbrayat/angular/blob/3004e2ad3a267eeae79d91ee487cfd33efbf9fb0/packages/compiler-cli/src/ngtsc/typecheck/extended/checks/missing_control_flow_directive/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46846/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46846/files#diff-8dca7371ba941e649fe73086e291397254764341ce12b5354fd2fdd7e1b7b9a2
https://github.com/angular/angular/pull/46846/files#diff-8dca7371ba941e649fe73086e291397254764341ce12b5354fd2fdd7e1b7b9a2
https://github.com/angular/angular/pull/46846/files#diff-8dca7371ba941e649fe73086e291397254764341ce12b5354fd2fdd7e1b7b9a2
https://github.com/angular/angular/pull/46846/files#diff-8dca7371ba941e649fe73086e291397254764341ce12b5354fd2fdd7e1b7b9a2
...xtended/test/checks/missing_control_flow_directive/missing_control_flow_directive_spec.tshttps://github.com/angular/angular/pull/46846/files#diff-a1d1bad706f6bc2b3fa5c29f0aa38af5ab38b1995dd89bc781a37d56bbbc3122
View file https://github.com/cexbrayat/angular/blob/3004e2ad3a267eeae79d91ee487cfd33efbf9fb0/packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks/missing_control_flow_directive/missing_control_flow_directive_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46846/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46846/files#diff-a1d1bad706f6bc2b3fa5c29f0aa38af5ab38b1995dd89bc781a37d56bbbc3122
https://github.com/angular/angular/pull/46846/files#diff-a1d1bad706f6bc2b3fa5c29f0aa38af5ab38b1995dd89bc781a37d56bbbc3122
https://github.com/angular/angular/pull/46846/files#diff-a1d1bad706f6bc2b3fa5c29f0aa38af5ab38b1995dd89bc781a37d56bbbc3122
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.