René's URL Explorer Experiment


Title: refactor(router): Update Router to be providedIn: 'root' by atscott · Pull Request #46824 · angular/angular · GitHub

Open Graph Title: refactor(router): Update Router to be providedIn: 'root' by atscott · Pull Request #46824 · angular/angular

X Title: refactor(router): Update Router to be providedIn: 'root' by atscott · Pull Request #46824 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This commit updates the Router itself to be providedIn: 'root' with a factory function rather than provided in the RouterModule. Note: includes commit from #46758 which should be submitted ...

X Description: This commit updates the Router itself to be providedIn: 'root' with a factory function rather than provided in the RouterModule. Note: includes commit from #46758 which should be su...

Opengraph URL: https://github.com/angular/angular/pull/46824

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d9879616-83b0-3084-2a21-5a5b3f1f4d02
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE12:2270F4:CDA587:112B60C:6B00FC17
html-safe-noncea8b65a8d5a3281946be032adec57de85df150da80c419411ebfed10f2da020da
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTEyOjIyNzBGNDpDREE1ODc6MTEyQjYwQzo2QjAwRkMxNyIsInZpc2l0b3JfaWQiOiIxMjIwOTY4OTQ5NjA1MjY4NTA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0bf5d11eeb12bcc554c811aa1e21654080bd9c5dde0047ffab591f81fbe71002
hovercard-subject-tagpull_request:995745069
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/46824/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/913c5671293ce7d11f860a77830dacb084ab1054ddddda83d3d64a98918d5bbe/angular/angular/pull/46824
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/913c5671293ce7d11f860a77830dacb084ab1054ddddda83d3d64a98918d5bbe/angular/angular/pull/46824
og:image:altThis commit updates the Router itself to be providedIn: 'root' with a factory function rather than provided in the RouterModule. Note: includes commit from #46758 which should be submitted ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatscott
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/46824#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46824
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46824
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46824
Reloadhttps://github.com/angular/angular/pull/46824
Reloadhttps://github.com/angular/angular/pull/46824
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:routerForRoothttps://github.com/atscott/angular/tree/routerForRoot
Conversationhttps://github.com/angular/angular/pull/46824
Commits1 (1)https://github.com/angular/angular/pull/46824/commits
Checkshttps://github.com/angular/angular/pull/46824/checks
Files changedhttps://github.com/angular/angular/pull/46824/files
refactor(router): Update Router to be providedIn: 'root'https://github.com/angular/angular/pull/46824#top
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:routerForRoothttps://github.com/atscott/angular/tree/routerForRoot
https://github.com/atscott
atscotthttps://github.com/atscott
Jul 13, 2022https://github.com/angular/angular/pull/46824#issue-1303713253
#46758https://github.com/angular/angular/pull/46758
Please reload this pagehttps://github.com/angular/angular/pull/46824
https://github.com/atscott
atscotthttps://github.com/atscott
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
Jul 13, 2022https://github.com/angular/angular/pull/46824#event-6987754309
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/c2beccf3686603d468a3969b9986ab2f047e28cb..f67ce9b6462cdcf790cf527a64651685f1701e90
c2beccfhttps://github.com/angular/angular/commit/c2beccf3686603d468a3969b9986ab2f047e28cb
f67ce9bhttps://github.com/angular/angular/commit/f67ce9b6462cdcf790cf527a64651685f1701e90
Compare https://github.com/angular/angular/compare/c2beccf3686603d468a3969b9986ab2f047e28cb..f67ce9b6462cdcf790cf527a64651685f1701e90
July 13, 2022 17:07https://github.com/angular/angular/pull/46824#event-6987773411
https://github.com/jessicajaniuk
jessicajaniukhttps://github.com/jessicajaniuk
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
Jul 13, 2022https://github.com/angular/angular/pull/46824#event-6987833202
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
Jul 13, 2022https://github.com/angular/angular/pull/46824#event-6987833386
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/235faaf183c330dabcfa7479ee92cf6bb014728d..4161b06c85071935e9b5f4b57a97637e97061e6f
235faafhttps://github.com/angular/angular/commit/235faaf183c330dabcfa7479ee92cf6bb014728d
4161b06https://github.com/angular/angular/commit/4161b06c85071935e9b5f4b57a97637e97061e6f
Compare https://github.com/angular/angular/compare/235faaf183c330dabcfa7479ee92cf6bb014728d..4161b06c85071935e9b5f4b57a97637e97061e6f
July 19, 2022 16:12https://github.com/angular/angular/pull/46824#event-7022144929
https://github.com/atscott
atscotthttps://github.com/atscott
Jul 19, 2022https://github.com/angular/angular/pull/46824#issuecomment-1189273016
Green TGPhttps://fusion2.corp.google.com/presubmit/tap/461208564/OCL:461208564:BASE:461736853:1658206411706:b205b26c/targets
Please reload this pagehttps://github.com/angular/angular/pull/46824
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/4161b06c85071935e9b5f4b57a97637e97061e6f..5779054a568be6f9870b31222cd00a97ee581021
4161b06https://github.com/angular/angular/commit/4161b06c85071935e9b5f4b57a97637e97061e6f
5779054https://github.com/angular/angular/commit/5779054a568be6f9870b31222cd00a97ee581021
Compare https://github.com/angular/angular/compare/4161b06c85071935e9b5f4b57a97637e97061e6f..5779054a568be6f9870b31222cd00a97ee581021
July 19, 2022 16:16https://github.com/angular/angular/pull/46824#event-7022173439
https://github.com/atscott
atscotthttps://github.com/atscott
July 19, 2022 16:20https://github.com/angular/angular/pull/46824#event-7022203881
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
alxhubhttps://github.com/alxhub
dylhunnhttps://github.com/dylhunn
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
July 19, 2022 16:21https://github.com/angular/angular/pull/46824#event-7022205033
https://github.com/atscott
atscotthttps://github.com/atscott
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
Jul 19, 2022https://github.com/angular/angular/pull/46824#event-7022205489
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/5779054a568be6f9870b31222cd00a97ee581021..bfc87b8f863e2bd513a1a2ed37a6669c02f2ba20
5779054https://github.com/angular/angular/commit/5779054a568be6f9870b31222cd00a97ee581021
bfc87b8https://github.com/angular/angular/commit/bfc87b8f863e2bd513a1a2ed37a6669c02f2ba20
Compare https://github.com/angular/angular/compare/5779054a568be6f9870b31222cd00a97ee581021..bfc87b8f863e2bd513a1a2ed37a6669c02f2ba20
July 19, 2022 16:25https://github.com/angular/angular/pull/46824#event-7022233697
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Jul 19, 2022 https://github.com/angular/angular/pull/46824#pullrequestreview-1043798017
View reviewed changes https://github.com/angular/angular/pull/46824/files
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
https://github.com/angular/angular/pull/46824#pullrequestreview-1043798017
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/46824
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
AndrewKushnirhttps://github.com/AndrewKushnir
July 19, 2022 16:59https://github.com/angular/angular/pull/46824#event-7022460466
https://github.com/atscott
atscotthttps://github.com/atscott
Jul 19, 2022 https://github.com/angular/angular/pull/46824#ref-pullrequest-1309815777
refactor(router): Move scroller and preloader initializers to be with… #46892 https://github.com/angular/angular/pull/46892
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 20, 2022 https://github.com/angular/angular/pull/46824#pullrequestreview-1044231932
View reviewed changes https://github.com/angular/angular/pull/46824/files
packages/router/src/router_config.tshttps://github.com/angular/angular/pull/46824/files#diff-48bb9d926af008072c5af8f1e374ee542a713cdc0e6d2521a21c7ce71d8cdef8
Please reload this pagehttps://github.com/angular/angular/pull/46824
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
AndrewKushnirhttps://github.com/AndrewKushnir
July 20, 2022 00:03https://github.com/angular/angular/pull/46824#event-7024944283
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 20, 2022 https://github.com/angular/angular/pull/46824#pullrequestreview-1044232278
View reviewed changes https://github.com/angular/angular/pull/46824/files
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/46824#pullrequestreview-1044232278
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/46824
https://github.com/atscott
refactor(router): Update Router to be providedIn: 'root'https://github.com/angular/angular/pull/46824/commits/71ea3f3173c9be629e94c25989a31008db6961ba
71ea3f3https://github.com/angular/angular/pull/46824/commits/71ea3f3173c9be629e94c25989a31008db6961ba
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/bfc87b8f863e2bd513a1a2ed37a6669c02f2ba20..71ea3f3173c9be629e94c25989a31008db6961ba
bfc87b8https://github.com/angular/angular/commit/bfc87b8f863e2bd513a1a2ed37a6669c02f2ba20
71ea3f3https://github.com/angular/angular/commit/71ea3f3173c9be629e94c25989a31008db6961ba
Compare https://github.com/angular/angular/compare/bfc87b8f863e2bd513a1a2ed37a6669c02f2ba20..71ea3f3173c9be629e94c25989a31008db6961ba
July 20, 2022 00:40https://github.com/angular/angular/pull/46824#event-7025068986
https://github.com/atscott
atscotthttps://github.com/atscott
target: rc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20rc%22
Jul 20, 2022https://github.com/angular/angular/pull/46824#event-7031898665
https://github.com/atscott
atscotthttps://github.com/atscott
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Jul 20, 2022https://github.com/angular/angular/pull/46824#event-7031898670
https://github.com/atscott
atscotthttps://github.com/atscott
alxhubhttps://github.com/alxhub
dylhunnhttps://github.com/dylhunn
July 20, 2022 18:30https://github.com/angular/angular/pull/46824#event-7031900989
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Jul 20, 2022https://github.com/angular/angular/pull/46824#event-7031943724
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 20, 2022https://github.com/angular/angular/pull/46824#issuecomment-1190623067
d583f85https://github.com/angular/angular/commit/d583f85701b0424496e263bf1cbc2c619869437e
Please reload this pagehttps://github.com/angular/angular/pull/46824
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
d583f85https://github.com/angular/angular/commit/d583f85701b0424496e263bf1cbc2c619869437e
Jul 20, 2022https://github.com/angular/angular/pull/46824#event-7031948857
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jul 20, 2022https://github.com/angular/angular/pull/46824#issuecomment-1190623598
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/46824
https://github.com/atscott
atscotthttps://github.com/atscott
Jul 20, 2022 https://github.com/angular/angular/pull/46824#ref-pullrequest-1311710487
refactor(router): Update Router to be providedIn: 'root' #46914 https://github.com/angular/angular/pull/46914
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Aug 20, 2022https://github.com/angular/angular/pull/46824#issuecomment-1221356301
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/46824
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Aug 20, 2022https://github.com/angular/angular/pull/46824#event-7226474555
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46824
https://github.com/pkozlowski-opensource
pkozlowski-opensource https://github.com/pkozlowski-opensource
https://github.com/angular/angular/pull/46824/files/bfc87b8f863e2bd513a1a2ed37a6669c02f2ba20
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/46824/files/bfc87b8f863e2bd513a1a2ed37a6669c02f2ba20
Please reload this pagehttps://github.com/angular/angular/pull/46824
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
target: minor https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20minor%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/46824
https://github.com/atscott
https://github.com/AndrewKushnir
https://github.com/pkozlowski-opensource
https://github.com/jessicajaniuk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.