René's URL Explorer Experiment


Title: fix(compiler): inputs/outputs incorrectly parsed in jit mode by crisbeto · Pull Request #46813 · angular/angular · GitHub

Open Graph Title: fix(compiler): inputs/outputs incorrectly parsed in jit mode by crisbeto · Pull Request #46813 · angular/angular

X Title: fix(compiler): inputs/outputs incorrectly parsed in jit mode by crisbeto · Pull Request #46813 · angular/angular

Description: The Directive and Component decorators support inputs and outputs fields which accept an array in the format of "someInput" or "someInput: someAlias", however the parsing during JIT compilation was splitting on commas, not on colons, which resulted in incorrect parsing. E.g. inputs: ["someInput: someAlias"] was being parsed into {"someInput: someAlias": "someInput: someAlias"} instead of {someInput: "someAlias"}. The feature was working by accident, because there's some logic further down in the compiler pipeline that was splitting the strings again.

Open Graph Description: The Directive and Component decorators support inputs and outputs fields which accept an array in the format of "someInput" or "someInput: someAlias", however the parsing during...

X Description: The Directive and Component decorators support inputs and outputs fields which accept an array in the format of "someInput" or "someInput: someAlias", however th...

Opengraph URL: https://github.com/angular/angular/pull/46813

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:73336648-10b9-e88d-84b7-4ba5322ec770
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDFFC:1CFBF7:4C58C:603E8:6B00F1A4
html-safe-nonce8e1176d7fa292f5df4e4a0a074b290023ee0385ec68ea26156d0d725a6151f40
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkZDOjFDRkJGNzo0QzU4Qzo2MDNFODo2QjAwRjFBNCIsInZpc2l0b3JfaWQiOiIzOTA4NzY5MjIwMTMyOTI1ODYwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd3016b1d061335a91f20ecf4ac2f0eefa2823c02612cd526caed1954f3f7f780
hovercard-subject-tagpull_request:995113804
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46813/files
twitter:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4450522?s=400&v=4
og:image:altThe Directive and Component decorators support inputs and outputs fields which accept an array in the format of "someInput" or "someInput: someAlias", however the parsing during...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46813/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46813%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46813%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46813/files
Reloadhttps://github.com/angular/angular/pull/46813/files
Reloadhttps://github.com/angular/angular/pull/46813/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
crisbetohttps://github.com/crisbeto
angular:mainhttps://github.com/angular/angular/tree/main
crisbeto:jit-parsing-incorrect-inputshttps://github.com/crisbeto/angular/tree/jit-parsing-incorrect-inputs
Conversation 7 https://github.com/angular/angular/pull/46813
Commits 1 https://github.com/angular/angular/pull/46813/commits
Checks 0 https://github.com/angular/angular/pull/46813/checks
Files changed https://github.com/angular/angular/pull/46813/files
Please reload this pagehttps://github.com/angular/angular/pull/46813/files
fix(compiler): inputs/outputs incorrectly parsed in jit mode https://github.com/angular/angular/pull/46813/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/46813/files
c721182 fix(compiler): inputs/outputs incorrectly parsed in jit mode crisbeto Jul 13, 2022 https://github.com/angular/angular/pull/46813/commits/c7211824e1698fb6bb6327619a0904dc3c3131b5
Clear filters https://github.com/angular/angular/pull/46813/files
Please reload this pagehttps://github.com/angular/angular/pull/46813/files
Please reload this pagehttps://github.com/angular/angular/pull/46813/files
jit_compiler_facade.ts https://github.com/angular/angular/pull/46813/files#diff-01d6d00c4d4bc32fd756511329b51832d5992d909f137cd0f29a85448b05207d
util.ts https://github.com/angular/angular/pull/46813/files#diff-b1981b82aa935a63c95195b74d7646408abcc97a88211fbb99b83c9840678564
upgrade_ng1_adapter.ts https://github.com/angular/angular/pull/46813/files#diff-df1f48666ec4e9310d7fb3d2c66e2a3473e26ee3154e50dfb9c01e826f593e4a
packages/compiler/src/jit_compiler_facade.tshttps://github.com/angular/angular/pull/46813/files#diff-01d6d00c4d4bc32fd756511329b51832d5992d909f137cd0f29a85448b05207d
View file https://github.com/crisbeto/angular/blob/c7211824e1698fb6bb6327619a0904dc3c3131b5/packages/compiler/src/jit_compiler_facade.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46813/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46813/files#diff-01d6d00c4d4bc32fd756511329b51832d5992d909f137cd0f29a85448b05207d
https://github.com/angular/angular/pull/46813/files#diff-01d6d00c4d4bc32fd756511329b51832d5992d909f137cd0f29a85448b05207d
packages/compiler/src/render3/view/util.tshttps://github.com/angular/angular/pull/46813/files#diff-b1981b82aa935a63c95195b74d7646408abcc97a88211fbb99b83c9840678564
View file https://github.com/crisbeto/angular/blob/c7211824e1698fb6bb6327619a0904dc3c3131b5/packages/compiler/src/render3/view/util.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46813/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46813/files#diff-b1981b82aa935a63c95195b74d7646408abcc97a88211fbb99b83c9840678564
https://github.com/angular/angular/pull/46813/files#diff-b1981b82aa935a63c95195b74d7646408abcc97a88211fbb99b83c9840678564
Please reload this pagehttps://github.com/angular/angular/pull/46813/files
https://github.com/angular/angular/pull/46813/files#diff-b1981b82aa935a63c95195b74d7646408abcc97a88211fbb99b83c9840678564
packages/upgrade/src/dynamic/src/upgrade_ng1_adapter.tshttps://github.com/angular/angular/pull/46813/files#diff-df1f48666ec4e9310d7fb3d2c66e2a3473e26ee3154e50dfb9c01e826f593e4a
View file https://github.com/crisbeto/angular/blob/c7211824e1698fb6bb6327619a0904dc3c3131b5/packages/upgrade/src/dynamic/src/upgrade_ng1_adapter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46813/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46813/files#diff-df1f48666ec4e9310d7fb3d2c66e2a3473e26ee3154e50dfb9c01e826f593e4a
https://github.com/angular/angular/pull/46813/files#diff-df1f48666ec4e9310d7fb3d2c66e2a3473e26ee3154e50dfb9c01e826f593e4a
https://github.com/angular/angular/pull/46813/files#diff-df1f48666ec4e9310d7fb3d2c66e2a3473e26ee3154e50dfb9c01e826f593e4a
https://github.com/angular/angular/pull/46813/files#diff-df1f48666ec4e9310d7fb3d2c66e2a3473e26ee3154e50dfb9c01e826f593e4a
https://github.com/angular/angular/pull/46813/files#diff-df1f48666ec4e9310d7fb3d2c66e2a3473e26ee3154e50dfb9c01e826f593e4a
https://github.com/angular/angular/pull/46813/files#diff-df1f48666ec4e9310d7fb3d2c66e2a3473e26ee3154e50dfb9c01e826f593e4a
https://github.com/angular/angular/pull/46813/files#diff-df1f48666ec4e9310d7fb3d2c66e2a3473e26ee3154e50dfb9c01e826f593e4a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.