| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:18911639-409a-f188-4aaf-9fd3068b61c5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9A68:3F4253:CC0E09:1109E5A:6B00FE2D |
| html-safe-nonce | 698142b9badc531331d5ffbeb3439cce44feffd67f0c4a7c07b1c98df6b273c0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTY4OjNGNDI1MzpDQzBFMDk6MTEwOUU1QTo2QjAwRkUyRCIsInZpc2l0b3JfaWQiOiI2NTcwNTcxNzY1ODU1MDkyMjY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4c0a0b4fe23fa2fb7e864349be78512a56b3982bc48fb1cf1047502e913e535f |
| hovercard-subject-tag | pull_request:991824731 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/46752/files |
| twitter:image | https://avatars.githubusercontent.com/u/479713?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/479713?s=400&v=4 |
| og:image:alt | Before this commit, the NavigationCancellationCode would always be set
to Redirect when encountering a "navigationcancelingError". However,
this error can also be thrown when CanLoad guar... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/46752/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46752%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46752%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/46752/files |
| Reload | https://github.com/angular/angular/pull/46752/files |
| Reload | https://github.com/angular/angular/pull/46752/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| atscott | https://github.com/atscott |
| angular:main | https://github.com/angular/angular/tree/main |
| atscott:fixCancellationCode | https://github.com/atscott/angular/tree/fixCancellationCode |
|
Conversation
10
| https://github.com/angular/angular/pull/46752 |
|
Commits
2
| https://github.com/angular/angular/pull/46752/commits |
|
Checks
0
| https://github.com/angular/angular/pull/46752/checks |
|
Files changed
| https://github.com/angular/angular/pull/46752/files |
| Please reload this page | https://github.com/angular/angular/pull/46752/files |
|
fix(router): Fix cancellation code for canLoad rejections
| https://github.com/angular/angular/pull/46752/files#top |
|
Show all changes
2 commits
| https://github.com/angular/angular/pull/46752/files |
|
d04505a
fix(router): Fix cancellation code for canLoad rejections
atscott Jul 8, 2022
| https://github.com/angular/angular/pull/46752/commits/d04505a97cc7a8494d53462c5dee8ed8909144df |
|
e87563c
refactor(router): move around some code to eliminate circular deps
atscott Feb 9, 2022
| https://github.com/angular/angular/pull/46752/commits/e87563c855551c394d77decbd27dc61eefa71940 |
|
Clear filters
| https://github.com/angular/angular/pull/46752/files |
| Please reload this page | https://github.com/angular/angular/pull/46752/files |
| Please reload this page | https://github.com/angular/angular/pull/46752/files |
|
bundle.golden_symbols.json
| https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
apply_redirects.ts
| https://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
|
index.ts
| https://github.com/angular/angular/pull/46752/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1 |
|
models.ts
| https://github.com/angular/angular/pull/46752/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814 |
|
navigation_canceling_error.ts
| https://github.com/angular/angular/pull/46752/files#diff-86eb942294a6e08478e57eede94a488ec6c5270a9a747500a13bcb33f5c3bea0 |
|
check_guards.ts
| https://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec |
|
prioritized_guard_value.ts
| https://github.com/angular/angular/pull/46752/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf |
|
router.ts
| https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
|
shared.ts
| https://github.com/angular/angular/pull/46752/files#diff-c2ba50534a1fa1afc7288fb298b1793e2d26254c27ec7ca9bbbcd87ce18f220f |
|
url_tree.ts
| https://github.com/angular/angular/pull/46752/files#diff-816e3805aa88d3ac994854f77df6f18c8bda5fd7e00f52434aa7e91a005738d9 |
|
type_guards.ts
| https://github.com/angular/angular/pull/46752/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2 |
|
computed_state_restoration.spec.ts
| https://github.com/angular/angular/pull/46752/files#diff-83d65fa1ccc4f05b6a704bc1ddeb3603d0463c3cd3fe455142986e0fda354941 |
|
integration.spec.ts
| https://github.com/angular/angular/pull/46752/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e |
| packages/core/test/bundling/router/bundle.golden_symbols.json | https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
View file
| https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/core/test/bundling/router/bundle.golden_symbols.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46752/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
| https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
| https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
| https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
|
| https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d |
| packages/router/src/apply_redirects.ts | https://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
|
View file
| https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/apply_redirects.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46752/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
|
| https://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
|
| https://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
|
| https://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb |
| packages/router/src/index.ts | https://github.com/angular/angular/pull/46752/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1 |
|
View file
| https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/index.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46752/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46752/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1 |
|
| https://github.com/angular/angular/pull/46752/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1 |
| packages/router/src/models.ts | https://github.com/angular/angular/pull/46752/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814 |
|
View file
| https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/models.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46752/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46752/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814 |
| Please reload this page | https://github.com/angular/angular/pull/46752/files |
| packages/router/src/navigation_canceling_error.ts | https://github.com/angular/angular/pull/46752/files#diff-86eb942294a6e08478e57eede94a488ec6c5270a9a747500a13bcb33f5c3bea0 |
|
View file
| https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/navigation_canceling_error.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46752/{{ revealButtonHref }} |
| packages/router/src/operators/check_guards.ts | https://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec |
|
View file
| https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/operators/check_guards.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46752/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec |
|
| https://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec |
|
| https://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec |
|
| https://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec |
| packages/router/src/operators/prioritized_guard_value.ts | https://github.com/angular/angular/pull/46752/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf |
|
View file
| https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/operators/prioritized_guard_value.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46752/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46752/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf |
|
| https://github.com/angular/angular/pull/46752/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
|
View file
| https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/router.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46752/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
|
| https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
|
| https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
|
| https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
|
| https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
|
| https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
|
| https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
|
| https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
|
| https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
|
| https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| packages/router/src/shared.ts | https://github.com/angular/angular/pull/46752/files#diff-c2ba50534a1fa1afc7288fb298b1793e2d26254c27ec7ca9bbbcd87ce18f220f |
|
View file
| https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/shared.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46752/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46752/files#diff-c2ba50534a1fa1afc7288fb298b1793e2d26254c27ec7ca9bbbcd87ce18f220f |
|
| https://github.com/angular/angular/pull/46752/files#diff-c2ba50534a1fa1afc7288fb298b1793e2d26254c27ec7ca9bbbcd87ce18f220f |
| packages/router/src/url_tree.ts | https://github.com/angular/angular/pull/46752/files#diff-816e3805aa88d3ac994854f77df6f18c8bda5fd7e00f52434aa7e91a005738d9 |
|
View file
| https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/url_tree.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/46752/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/46752/files#diff-816e3805aa88d3ac994854f77df6f18c8bda5fd7e00f52434aa7e91a005738d9 |
| Please reload this page | https://github.com/angular/angular/pull/46752/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |