René's URL Explorer Experiment


Title: fix(router): Fix cancellation code for canLoad rejections by atscott · Pull Request #46752 · angular/angular · GitHub

Open Graph Title: fix(router): Fix cancellation code for canLoad rejections by atscott · Pull Request #46752 · angular/angular

X Title: fix(router): Fix cancellation code for canLoad rejections by atscott · Pull Request #46752 · angular/angular

Description: Before this commit, the NavigationCancellationCode would always be set to Redirect when encountering a "navigationcancelingError". However, this error can also be thrown when CanLoad guars reject. This commit ensures these cancellation errors have a code as well so this mistake cannot be made again.

Open Graph Description: Before this commit, the NavigationCancellationCode would always be set to Redirect when encountering a "navigationcancelingError". However, this error can also be thrown when CanLoad guar...

X Description: Before this commit, the NavigationCancellationCode would always be set to Redirect when encountering a "navigationcancelingError". However, this error can also be thrown when CanL...

Opengraph URL: https://github.com/angular/angular/pull/46752

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:18911639-409a-f188-4aaf-9fd3068b61c5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A68:3F4253:CC0E09:1109E5A:6B00FE2D
html-safe-nonce698142b9badc531331d5ffbeb3439cce44feffd67f0c4a7c07b1c98df6b273c0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTY4OjNGNDI1MzpDQzBFMDk6MTEwOUU1QTo2QjAwRkUyRCIsInZpc2l0b3JfaWQiOiI2NTcwNTcxNzY1ODU1MDkyMjY5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4c0a0b4fe23fa2fb7e864349be78512a56b3982bc48fb1cf1047502e913e535f
hovercard-subject-tagpull_request:991824731
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46752/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altBefore this commit, the NavigationCancellationCode would always be set to Redirect when encountering a "navigationcancelingError". However, this error can also be thrown when CanLoad guar...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46752/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46752%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46752%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46752/files
Reloadhttps://github.com/angular/angular/pull/46752/files
Reloadhttps://github.com/angular/angular/pull/46752/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:mainhttps://github.com/angular/angular/tree/main
atscott:fixCancellationCodehttps://github.com/atscott/angular/tree/fixCancellationCode
Conversation 10 https://github.com/angular/angular/pull/46752
Commits 2 https://github.com/angular/angular/pull/46752/commits
Checks 0 https://github.com/angular/angular/pull/46752/checks
Files changed https://github.com/angular/angular/pull/46752/files
Please reload this pagehttps://github.com/angular/angular/pull/46752/files
fix(router): Fix cancellation code for canLoad rejections https://github.com/angular/angular/pull/46752/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/46752/files
d04505a fix(router): Fix cancellation code for canLoad rejections atscott Jul 8, 2022 https://github.com/angular/angular/pull/46752/commits/d04505a97cc7a8494d53462c5dee8ed8909144df
e87563c refactor(router): move around some code to eliminate circular deps atscott Feb 9, 2022 https://github.com/angular/angular/pull/46752/commits/e87563c855551c394d77decbd27dc61eefa71940
Clear filters https://github.com/angular/angular/pull/46752/files
Please reload this pagehttps://github.com/angular/angular/pull/46752/files
Please reload this pagehttps://github.com/angular/angular/pull/46752/files
bundle.golden_symbols.json https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
apply_redirects.ts https://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
index.ts https://github.com/angular/angular/pull/46752/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
models.ts https://github.com/angular/angular/pull/46752/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
navigation_canceling_error.ts https://github.com/angular/angular/pull/46752/files#diff-86eb942294a6e08478e57eede94a488ec6c5270a9a747500a13bcb33f5c3bea0
check_guards.ts https://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
prioritized_guard_value.ts https://github.com/angular/angular/pull/46752/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf
router.ts https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
shared.ts https://github.com/angular/angular/pull/46752/files#diff-c2ba50534a1fa1afc7288fb298b1793e2d26254c27ec7ca9bbbcd87ce18f220f
url_tree.ts https://github.com/angular/angular/pull/46752/files#diff-816e3805aa88d3ac994854f77df6f18c8bda5fd7e00f52434aa7e91a005738d9
type_guards.ts https://github.com/angular/angular/pull/46752/files#diff-97b8a510ff6a090c39e3d90c8b90fe17d0d147ebb2ed843dae582f62e66b5fc2
computed_state_restoration.spec.ts https://github.com/angular/angular/pull/46752/files#diff-83d65fa1ccc4f05b6a704bc1ddeb3603d0463c3cd3fe455142986e0fda354941
integration.spec.ts https://github.com/angular/angular/pull/46752/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
packages/core/test/bundling/router/bundle.golden_symbols.jsonhttps://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
View file https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/core/test/bundling/router/bundle.golden_symbols.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
https://github.com/angular/angular/pull/46752/files#diff-0ea07045c567fb07c48994161c0a3bfa5bd1a676bc484d0fd8d3f9c5c2bc5d8d
packages/router/src/apply_redirects.tshttps://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
View file https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/apply_redirects.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
https://github.com/angular/angular/pull/46752/files#diff-c4958945d247eb3842b4117e948efc54b776ad843626c0adca169e5d416582fb
packages/router/src/index.tshttps://github.com/angular/angular/pull/46752/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
View file https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46752/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
https://github.com/angular/angular/pull/46752/files#diff-60f7c2fcb5faf15b8cf44d1cadc6c78e266a83e6addf94bdf3f4b5fee82549a1
packages/router/src/models.tshttps://github.com/angular/angular/pull/46752/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
View file https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/models.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46752/files#diff-b8e9749ad4562cf0925fd464daee97ba96d82e28fd9f7b45bd1bf0e0342fa814
Please reload this pagehttps://github.com/angular/angular/pull/46752/files
packages/router/src/navigation_canceling_error.tshttps://github.com/angular/angular/pull/46752/files#diff-86eb942294a6e08478e57eede94a488ec6c5270a9a747500a13bcb33f5c3bea0
View file https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/navigation_canceling_error.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46752/{{ revealButtonHref }}
packages/router/src/operators/check_guards.tshttps://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
View file https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/operators/check_guards.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
https://github.com/angular/angular/pull/46752/files#diff-1706bbbdd4dda445171e80023d67b54f1aa77a457d6b81b6815239113fd34dec
packages/router/src/operators/prioritized_guard_value.tshttps://github.com/angular/angular/pull/46752/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf
View file https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/operators/prioritized_guard_value.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46752/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf
https://github.com/angular/angular/pull/46752/files#diff-8251d2c537fabc454b33a5696339bcc90de0f5d87a5374ec4a0b613669a8e9bf
packages/router/src/router.tshttps://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
View file https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/router.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
https://github.com/angular/angular/pull/46752/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
packages/router/src/shared.tshttps://github.com/angular/angular/pull/46752/files#diff-c2ba50534a1fa1afc7288fb298b1793e2d26254c27ec7ca9bbbcd87ce18f220f
View file https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46752/files#diff-c2ba50534a1fa1afc7288fb298b1793e2d26254c27ec7ca9bbbcd87ce18f220f
https://github.com/angular/angular/pull/46752/files#diff-c2ba50534a1fa1afc7288fb298b1793e2d26254c27ec7ca9bbbcd87ce18f220f
packages/router/src/url_tree.tshttps://github.com/angular/angular/pull/46752/files#diff-816e3805aa88d3ac994854f77df6f18c8bda5fd7e00f52434aa7e91a005738d9
View file https://github.com/atscott/angular/blob/e87563c855551c394d77decbd27dc61eefa71940/packages/router/src/url_tree.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46752/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46752/files#diff-816e3805aa88d3ac994854f77df6f18c8bda5fd7e00f52434aa7e91a005738d9
Please reload this pagehttps://github.com/angular/angular/pull/46752/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.