René's URL Explorer Experiment


Title: fix(core): remove `@internal` annotation from `ApplicationRef.injector` by arturovt · Pull Request #46727 · angular/angular · GitHub

Open Graph Title: fix(core): remove `@internal` annotation from `ApplicationRef.injector` by arturovt · Pull Request #46727 · angular/angular

X Title: fix(core): remove `@internal` annotation from `ApplicationRef.injector` by arturovt · Pull Request #46727 · angular/angular

Description: The injector getter is annotated with @internal and is removed from declarations. This commit removes the annotation thus it's possible to access the injector on the ApplicationRef, e.g., after calling bootstrapApplication. Currently, it requires casting ApplicationRef to { injector: Injector } after calling the bootstrapApplication, e.g.: bootstrapApplication(...).then((appRef) => { const injector = (appRef as unknown as { injector: Injector }).injector; const router = injector.get(Router); ... }); NgModuleRef prior to ApplicationRef has a public injector property which allows the above behavior: platformBrowserDynamic() .bootstrapModule(...) .then((ngModuleRef) => { const router = ngModuleRef.injector.get(Router); ... }); This change also allows a more straightforward setup for micro-frontend adapters (e.g., single-spa-angular). The micro-frontend bootstrap function can resolve to ApplicationRef | NgModuleRef; they both have the destroy method now, and having injector on both types doesn't require type cast for ApplicationRef.

Open Graph Description: The injector getter is annotated with @internal and is removed from declarations. This commit removes the annotation thus it's possible to access the injector on the ApplicationRef, e.g., after...

X Description: The injector getter is annotated with @internal and is removed from declarations. This commit removes the annotation thus it's possible to access the injector on the ApplicationRef, e.g., a...

Opengraph URL: https://github.com/angular/angular/pull/46727

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:078084b0-eaff-a819-2da9-5537491b4991
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85D2:1F44:7CD756:A3A4A1:6B010221
html-safe-noncef67f861169f4ae45a1651a95ecd8846b03baaf2cfbe502fb3078866834c8e3d1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUQyOjFGNDQ6N0NENzU2OkEzQTRBMTo2QjAxMDIyMSIsInZpc2l0b3JfaWQiOiIyODQ0NTE0ODQ1NzQ1ODA3OTA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac655383be2dd3d7b2b06eaf703ad4c2f5f32a4e8dbce21064acc5b39748670977
hovercard-subject-tagpull_request:989070586
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/46727/files
twitter:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7337691?s=400&v=4
og:image:altThe injector getter is annotated with @internal and is removed from declarations. This commit removes the annotation thus it's possible to access the injector on the ApplicationRef, e.g., after...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/46727/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46727%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F46727%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/46727/files
Reloadhttps://github.com/angular/angular/pull/46727/files
Reloadhttps://github.com/angular/angular/pull/46727/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
arturovthttps://github.com/arturovt
angular:mainhttps://github.com/angular/angular/tree/main
arturovt:fix/core-injector-internalhttps://github.com/arturovt/angular/tree/fix/core-injector-internal
Conversation 2 https://github.com/angular/angular/pull/46727
Commits 1 https://github.com/angular/angular/pull/46727/commits
Checks 0 https://github.com/angular/angular/pull/46727/checks
Files changed https://github.com/angular/angular/pull/46727/files
Please reload this pagehttps://github.com/angular/angular/pull/46727/files
fix(core): remove @internal annotation from ApplicationRef.injector https://github.com/angular/angular/pull/46727/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/46727/files
6c6465c fix(core): remove `@internal` annotation from `ApplicationRef.injector` arturovt Jul 6, 2022 https://github.com/angular/angular/pull/46727/commits/6c6465c3f0035005340d91d0cf51adc648940baa
Clear filters https://github.com/angular/angular/pull/46727/files
Please reload this pagehttps://github.com/angular/angular/pull/46727/files
Please reload this pagehttps://github.com/angular/angular/pull/46727/files
index.md https://github.com/angular/angular/pull/46727/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
application_ref.ts https://github.com/angular/angular/pull/46727/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897
goldens/public-api/core/index.mdhttps://github.com/angular/angular/pull/46727/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
View file https://github.com/arturovt/angular/blob/6c6465c3f0035005340d91d0cf51adc648940baa/goldens/public-api/core/index.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46727/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46727/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
https://github.com/angular/angular/pull/46727/files#diff-3395003fb035cfc47bf17a421174501f2bf7a3ed164cd3d0fbc4d91f50475f2b
packages/core/src/application_ref.tshttps://github.com/angular/angular/pull/46727/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897
View file https://github.com/arturovt/angular/blob/6c6465c3f0035005340d91d0cf51adc648940baa/packages/core/src/application_ref.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/46727/{{ revealButtonHref }}
https://github.com/angular/angular/pull/46727/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897
https://github.com/angular/angular/pull/46727/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.